> On Jun 7, 2022, at 9:21 PM, Alexander Matveev
> wrote:
>
> Hi Michael,
>
> Yes, this is correct. It is a three step process as you outlined it below.
>
Alexander,
Could you post an example of the three invocations, without needing to include
any post-processing, to 1) create app-image
On 07/06/22 9:39 am, Stuart Marks wrote:
Hi Jai,
The error
java.lang.OutOfMemoryError: Java heap space
indicates that the VM really has run out of memory. Presumably if you
increased the heap size, it would actually be able to allocate that
memory. You might have to add the /othervm te
Can I please get a review of this change which addresses
https://bugs.openjdk.java.net/browse/JDK-8285405?
I've added the test for `LinkedHashMap.newLinkedHashMap(int)` in the existing
`test/jdk/java/util/LinkedHashMap/Basic.java` since that test has tests for
various APIs of this class.
For `
On Fri, 27 May 2022 22:59:47 GMT, Raffaello Giulietti
wrote:
>> BigDecimal(String) currently fails to accept some strings produced by
>> BigDecimal.toString(). This PR removes this limitation.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since
On Wed, 8 Jun 2022 02:40:15 GMT, Tim Prinzing wrote:
>> The Class::forName behavior change to match JNI FindClass is a compatible
>> change and seems pretty attractive as it would be expected that
>> Class::forName would give the same behavior as FindClass which uses the
>> system classloader.
On Tue, 26 Apr 2022 15:04:15 GMT, Thiago Henrique Hüpner
wrote:
> 8287353: Use snippet tag instead of pre tag in Javadoc of InterruptedException
This pull request has now been integrated.
Changeset: 7df48f97
Author:Thiago Henrique Hüpner
Committer: Jaikiran Pai
URL:
https://git.op
> The Class::forName behavior change to match JNI FindClass is a compatible
> change and seems pretty attractive as it would be expected that
> Class::forName would give the same behavior as FindClass which uses the
> system classloader. The test for 8281006 was enhanced to test for this
> cha
Hi Michael,
Yes, this is correct. It is a three step process as you outlined it below.
Thanks,
Alexander
On Jun 7, 2022, at 12:00 AM, Michael Hall
mailto:mik3h...@gmail.com>> wrote:
Alexander,
I had an existing local GitHub repo for the jdk I updated that appeared to
accept the parameters yo
On Tue, 24 May 2022 12:58:45 GMT, Raffaello Giulietti
wrote:
>> Extend the range of Random.doubles(double, double) and similar methods.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8202449: overflow handling in R
Vote: yes
-Joe
Vote: yes
On 6/7/22 10:43 AM, Stuart Marks wrote:
I hereby nominate Roger Riggs [1] to membership in the Core Libraries Group [2].
Roger has been a member of the Oracle Core Libraries team since 2014. He has made
significant contributions in the areas of java.time, Legacy Serialization and
Se
Vote: yes
On 6/6/22 5:52 PM, Stuart Marks wrote:
I hereby nominate Naoto Sato [1] to membership in the Core Libraries Group [2].
Naoto Sato has been on the Core Libraries team for over a decade and has contributed
hundreds of changes to the JDK project [3]. His most significant recent contribu
On Tue, 7 Jun 2022 21:19:02 GMT, Brent Christian wrote:
> > The commented out printf/println's should be removed before committing.
>
> Do you mean the pre-existing `println`s in LdapSearchEnumeration.java?
Usually, I would mean any that were added for this issue.
The changes in indentation (as
> Please review this change to replace the finalizer in
> `AbstractLdapNamingEnumeration` with a Cleaner.
>
> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
> res`, and `LdapClient enumClnt`) are moved to a static inner class . From
> there, the change is fairly mechan
On Tue, 7 Jun 2022 18:45:17 GMT, Roger Riggs wrote:
> The commented out printf/println's should be removed before committing.
Do you mean the pre-existing `println`s in LdapSearchEnumeration.java?
-
PR: https://git.openjdk.java.net/jdk/pull/8311
On Fri, 3 Jun 2022 18:17:55 GMT, Joe Wang wrote:
> Adjust how XPath operators are counted to improve accuracy. This change does
> not affect how XPath works.
>
> Test:
> Tier2 passed;
> JCK XML tests passed.
This pull request has now been integrated.
Changeset: 8e078391
Author:
Vote: yes
Mandy
On Fri, 3 Jun 2022 23:56:31 GMT, Joe Wang wrote:
>> Adjust how XPath operators are counted to improve accuracy. This change does
>> not affect how XPath works.
>>
>> Test:
>> Tier2 passed;
>> JCK XML tests passed.
>
> Joe Wang has updated the pull request incrementally with one add
Vote: yes
Iris
Vote: yes
On Mon, 6 Jun 2022 21:59:56 GMT, Brent Christian wrote:
>> Please review this change to replace the finalizer in
>> `AbstractLdapNamingEnumeration` with a Cleaner.
>>
>> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
>> res`, and `LdapClient enumClnt`) are moved to a
> This is a follow up update per comments in [JDK-8287384
> PR](https://github.com/openjdk/jdk/pull/8907). The tier1 and tier2 test in
> open part looks good to me. Please help to run Mach5 just case the closed
> test cases are impacted.
Xue-Lei Andrew Fan has updated the pull request with a
On Tue, 7 Jun 2022 17:14:18 GMT, Quan Anh Mai wrote:
> Hi,
>
> This patch implements intrinsics for `Integer/Long::compareUnsigned` using
> the same approach as the JVM does for long and floating-point comparisons.
> This allows efficient and reliable usage of unsigned comparison in Java,
> w
I hereby nominate Roger Riggs [1] to membership in the Core Libraries Group [2].
Roger has been a member of the Oracle Core Libraries team since 2014. He has made
significant contributions in the areas of java.time, Legacy Serialization and
Serialization Filtering, Processes, and many others. H
Hi,
This patch implements intrinsics for `Integer/Long::compareUnsigned` using the
same approach as the JVM does for long and floating-point comparisons. This
allows efficient and reliable usage of unsigned comparison in Java, which is a
basic operation and is important for range checks such as
Hi,
the aim of this PR was firstly to have a correct implementation of the
spec. Speed improvement was a secondary goal, which was intentionally
pursued with conventional Java arithmetic and just a few calls to simple
methods in the standard library.
Whether the Vector API (which is still in
Vote: yes
Mandy
On Mon, 9 May 2022 12:50:31 GMT, Raffaello Giulietti
wrote:
>> Marked as reviewed by limck...@github.com (no known OpenJDK username).
>
> @limck599
> While we at OpenJDK appreciate constructive reviews from GitHub users not
> registered in the [census](https://openjdk.java.net/census), only off
On Wed, 25 May 2022 00:19:41 GMT, Joe Darcy wrote:
> Generally add apiNote's to map from Java library methods to particular IEEE
> 754 operations. For now, I only added such notes to java.lang.Math and not
> java.lang.StrictMath.
This pull request has now been integrated.
Changeset: 5d4ea9b9
> Generally add apiNote's to map from Java library methods to particular IEEE
> 754 operations. For now, I only added such notes to java.lang.Math and not
> java.lang.StrictMath.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Correct
On Mon, 6 Jun 2022 15:50:39 GMT, Naoto Sato wrote:
>> The code path calls `String.getBytesNoRepl()`, but it blindly replaces
>> unmappable characters with replacements if the encoder is an `ArrayEncoder`.
>> Changed only to do so if `doReplace` is `true` in
>> `String.encodeWithEncoder()`.
>
>
Vote: Yes
On 6/6/22 8:52 PM, Stuart Marks wrote:
I hereby nominate Naoto Sato [1] to membership in the Core Libraries
Group [2].
On Tue, 7 Jun 2022 14:11:57 GMT, Gaurav Chaudhari wrote:
>> Gaurav Chaudhari has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - 8285838: Cleanup of trailing whitespace
>> - 8285838: Corrected month comparison check for TZ DST
>
> Appreci
On Wed, 1 Jun 2022 13:32:36 GMT, Gaurav Chaudhari wrote:
>> This fix ensures that when a lookup for a custom TZ code fails, and an
>> attempt is made to find the GMT offset in order to get the current time,
>> Daylight savings rules are applied correctly.
>
> Gaurav Chaudhari has updated the pu
> This fix ensures that when a lookup for a custom TZ code fails, and an
> attempt is made to find the GMT offset in order to get the current time,
> Daylight savings rules are applied correctly.
Gaurav Chaudhari has updated the pull request incrementally with one additional
commit since the la
Instead of `Executable.getParameterTypes()` we could use
`Executable.getSharedParameterTypes()` in trusted code. Same is applicable for
`Executable.getExceptionTypes()`.
-
Commit messages:
- 8287908: Use non-cloning reflection methods where acceptable
Changes: https://git.openjdk.
On Tue, 7 Jun 2022 12:34:25 GMT, Claes Redestad wrote:
> - Reduce runtime by running fewer forks, fewer iterations, less warmup. All
> micros tested in this group appear to stabilize very quickly.
> - Refactor BigIntegers to avoid re-running some (most) micros over and over
> with parameter val
On Tue, 17 May 2022 12:47:25 GMT, Adam Sotona wrote:
> ### Problem description
> Minimal jdk image created by jlink with the only jdk.compiler module and its
> dependencies
> fails to run java source launcher correctly (for example when --source N is
> specified).
> Failing source launcher is o
On Wed, 18 May 2022 06:30:34 GMT, Adam Sotona wrote:
>> ### Problem description
>> Minimal jdk image created by jlink with the only jdk.compiler module and its
>> dependencies
>> fails to run java source launcher correctly (for example when --source N is
>> specified).
>> Failing source launche
On Tue, 7 Jun 2022 13:30:50 GMT, Thiago Henrique Hüpner
wrote:
>> 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved
>> flags is used
>
> Thiago Henrique Hüpner has refreshed the contents of this pull request, and
> previous commits have been removed. The incremental v
> 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved
> flags is used
Thiago Henrique Hüpner has refreshed the contents of this pull request, and
previous commits have been removed. The incremental views will show differences
compared to the previous content of the PR. T
> 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved
> flags is used
Thiago Henrique Hüpner has updated the pull request incrementally with one
additional commit since the last revision:
Fix copyright year
-
Changes:
- all: https://git.openjdk.java.net
> This is a cleanup of the memory session implementation. The main new concept
> is that `MemorySessionImpl` is split into two parts: there is an
> implementation of memory session and then there is a state abstraction
> (`MemorySessionImpl.State`). This allows to share the state across multiple
- Reduce runtime by running fewer forks, fewer iterations, less warmup. All
micros tested in this group appear to stabilize very quickly.
- Refactor BigIntegers to avoid re-running some (most) micros over and over
with parameter values that don't affect them.
Expected runtime down from 14 hours
> Please review this cleanup change in the cgroup subsystem which used to use
> hard-coded stack allocated
> buffers for concatenating strings in memory. We can use `stringStream`
> instead which doesn't have the issue
> of hard-coding maximum lengths (and related checks) and makes the code, thus
The test
`test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTest.java`
verifies different failure modes of resource bundles. One of the failures is
that the runner class, `MissingResourceCauseTestRun.java`, creates a file
`UnreadableRB`, and runs `chmod 000` on it, to make it unrea
On Tue, 7 Jun 2022 10:14:47 GMT, Magnus Ihse Bursie wrote:
> The test `test/jdk/java/util/Currency/PropertiesTest.sh` fails on msys2,
> since it does not properly detect this environment.
This pull request has now been integrated.
Changeset: f1dd559e
Author:Magnus Ihse Bursie
URL:
On Mon, 6 Jun 2022 12:58:39 GMT, Сергей Цыпанов wrote:
> - cached hash code of `Locale` and `Locale$LanguageRange` shouldn't be
> volatile, even in case of race in the worst case it is recalculated at most
> once per thread
> - `defaultLocale` field is read multiple times in `initDefault()`
> -
On Tue, 7 Jun 2022 10:14:47 GMT, Magnus Ihse Bursie wrote:
> The test `test/jdk/java/util/Currency/PropertiesTest.sh` fails on msys2,
> since it does not properly detect this environment.
Looks good. Thanks for the change.
-
Marked as reviewed by naoto (Reviewer).
PR: https://git
On Wed, 25 May 2022 00:35:24 GMT, Joe Darcy wrote:
>> This is an early review of changes to better model JVM access flags, that is
>> "modifiers" like public, protected, etc. but explicitly at a VM level.
>>
>> Language level modifiers and JVM level access flags are closely related, but
>> dis
The test `test/jdk/java/util/Currency/PropertiesTest.sh` fails on msys2, since
it does not properly detect this environment.
-
Commit messages:
- 8287896: PropertiesTest.sh fail on msys2
Changes: https://git.openjdk.java.net/jdk/pull/9057/files
Webrev: https://webrevs.openjdk.java
On Tue, 24 May 2022 12:58:45 GMT, Raffaello Giulietti
wrote:
>> Extend the range of Random.doubles(double, double) and similar methods.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8202449: overflow handling in R
On Wed, 1 Jun 2022 09:18:38 GMT, Severin Gehwolf wrote:
> Please review this cleanup change in the cgroup subsystem which used to use
> hard-coded stack allocated
> buffers for concatenating strings in memory. We can use `stringStream`
> instead which doesn't have the issue
> of hard-coding max
On Thu, 2 Jun 2022 14:32:28 GMT, Severin Gehwolf wrote:
> This adds a regression test for a recent fix (JDK-8287073). I've restructured
> the linux specific JDK code to call a separate static function to enable this
> test. It'll help future tests too.
>
> Testing:
> - [x] Container tests cont
On Tue, 7 Jun 2022 04:17:44 GMT, Ioi Lam wrote:
> > We should try to consolidate these test cases to improve maintainability.
>
> I filed [JDK-8287185](https://bugs.openjdk.org/browse/JDK-8287185)
Agreed. Thanks for the review @iklam
-
PR: https://git.openjdk.java.net/jdk/pull/899
On Fri, 27 May 2022 22:59:47 GMT, Raffaello Giulietti
wrote:
>> BigDecimal(String) currently fails to accept some strings produced by
>> BigDecimal.toString(). This PR removes this limitation.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since
> When generating `MethodHandle`-based concatenation expressions in
> `StringConcatFactory` we can reduce the number of classes generated at
> runtime by creating small batches of prependers and mixers before binding
> them into the root expression tree.
>
> Improvements on one-off tests are m
On Mon, 6 Jun 2022 22:24:03 GMT, Joe Darcy wrote:
>> Generally add apiNote's to map from Java library methods to particular IEEE
>> 754 operations. For now, I only added such notes to java.lang.Math and not
>> java.lang.StrictMath.
>
> Joe Darcy has updated the pull request incrementally with o
On Wed, 30 Mar 2022 10:31:59 GMT, Xiaohong Gong wrote:
> Currently the vector load with mask when the given index happens out of the
> array boundary is implemented with pure java scalar code to avoid the IOOBE
> (IndexOutOfBoundaryException). This is necessary for architectures that do
> not
On Thu, 12 May 2022 16:07:54 GMT, Paul Sandoz wrote:
>> Xiaohong Gong has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rename "use_predicate" to "needs_predicate"
>
> Yes, the tests were run in debug mode. The reporting of the missing con
On Tue, 7 Jun 2022 04:29:40 GMT, Xiaohong Gong wrote:
>> Currently the vector load with mask when the given index happens out of the
>> array boundary is implemented with pure java scalar code to avoid the IOOBE
>> (IndexOutOfBoundaryException). This is necessary for architectures that do
>> n
On Fri, 3 Jun 2022 11:16:29 GMT, Claes Redestad wrote:
> - Add explicit run configurations to java.lang.invoke micros, aiming to
> reduce runtime while maintaining a decently high confidence that there's
> enough warmup to produce good enough data.
>
> - Remove several trivial baseline micros,
On Fri, 3 Jun 2022 15:05:33 GMT, Claes Redestad wrote:
> - Reduce runtime by providing explicit configurations that try to run the
> micros as fast as possible while giving enough time for warmup.
> - Remove some excessive parameters
> - Remove some benchmarks testing experimental features
> (O
On Fri, 3 Jun 2022 12:46:31 GMT, Claes Redestad wrote:
> Add explicit run configurations to java.lang.reflect and .runtime micros,
> aiming to reduce runtime while maintaining a decently high confidence that
> there's enough warmup to produce good enough data.
>
> Roughly halves runtime of run
On Tue, 7 Jun 2022 00:45:17 GMT, Thiago Henrique Hüpner
wrote:
> 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved
> flags is used
The change looks okay but I think we should add a test. You'll have to check
the test tree to see if there are existing tests for incuba
Alexander,
I had an existing local GitHub repo for the jdk I updated that appeared to
accept the parameters you indicated. It generated a jdk 19.
If you are saying I’m not getting the main branch or the update for some reason
has dependencies I’m not getting I would have to determine how to co
66 matches
Mail list logo
