Re: RFR: JDK-8217269: jpackage Makefile improvments

Hi Andy, Looks good. Thanks, Alexander On 1/18/2019 6:18 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). The webrev includes all the jpackage Makefile Improvements listed

RFR: JDK-8215019: Allow --install-dir on windows

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Added support for --install-dir on Windows. It should be relative path to "Program Files" or "AppData". - If --install-dir is invalid we will use

Re: RFR: JDK-8215019: Allow --install-dir on windows

message says: 'sub-path under default installation location" which is a little better. (though there should be a "the" before default). /Andy On 3/20/2019 8:05 PM, Alexander Matveev wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-

RFR: JDK-8221101: Update JNLPConverter to support latest jpackage CLI changes

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Updated JNLPConverter to support latest CLI changes and bug fixes. - Added getMessage() to exceptions, otherwise null was printed. - Restored

Re: RFR: JDK-8208652: JPackageCreateInstallerFileAssociationsTest.java fails on Mac.

Hi Semyon, Looks good. I assume you did run all tests on all platforms, since it is shared code for most tests. Thanks, Alexander On 4/3/2019 12:16 PM, semyon.sadet...@oracle.com wrote: Hello, bug: https://bugs.openjdk.java.net/browse/JDK-8208652 webrev:

Re: RFR: JDK-8221876:[macOS] JPackage install takes long time

Hi Semyon, Looks good. Thanks, Alexander On 4/3/2019 2:30 PM, semyon.sadet...@oracle.com wrote: Hello, bug: https://bugs.openjdk.java.net/browse/JDK-8221876 webrev: http://cr.openjdk.java.net/~ssadetsky/8221876/webrev.00/ The fix eliminate delay in install which is caused by postinstall

Re: RFR: JDK-8221779: Help text changes from JDK-8221777 and other jpackage EA5 feedback

Hi Andy, Looks good. Thanks, Alexander On 4/4/2019 4:27 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8221779 [2]

Re: RFR: JDK8221777: CLI changes from jpackage EA5 feedback

Hi Andy, Looks good. Thanks, Alexander On 4/4/2019 4:32 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). This change renames the "create-image" mode to "create-app-image",

Re: RFR: JDK-8221582: Rename jvm-args option to java-options

Hi Andy, webrev.02 looks fine. Thanks, Alexander On 3/28/2019 11:20 AM, Alexey Semenyuk wrote: Agreed. Would you like me to create a record to track this follow up clean up? - Alexey On 3/28/2019 2:01 PM, Andy Herrick wrote: On 3/28/2019 1:54 PM, Kevin Rushforth wrote: That seems like a

Re: RFR: JDK-8221256: Fix create-installer specific options on MAC

Hi Andy, Looks good. Thanks, Alexander On 3/26/2019 12:53 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8221256 [2]

Re: RFR: JDK-8221565: Linux build broken after merge with default branch

Hi Andy, Changes looks fine, but do we really need such try/catch block? I think this code needs to be modify, so we do not need such try/catch or handle this error as real error. Probably another bug can be filed to do this. Thanks, Alexander On 3/27/2019 12:33 PM, Andy Herrick wrote:

Re: RFR: JDK-8215241: Permissions are not set correctly on sub-folders in /Applications

Hi Semyon, Looks good. Thanks, Alexander On 3/27/2019 1:43 PM, semyon.sadet...@oracle.com wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8215241 webrev: http://cr.openjdk.java.net/~ssadetsky/8215241/webrev.00/ The fix adds

RFR: JDK-8221525: jpackage fails with non-ASCII characters in --copyright

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - .properties file was written in default encoding (file.encoding=Cp1252). Native code was expecting UTF-8 and thus was not able to read non-ASCII

Re: RFR: JDK-8218055: Use ToolProvider instead of AppRuntimeImageBuilder.

Hi Andy, Updated version looks fine as well. Thank, Alexander On 2/25/2019 5:19 AM, Andy Herrick wrote: I uploaded webrev version 04 (http://cr.openjdk.java.net/~herrick/8218055/webrev.04) which is same as version 03 except "JLink" is changed to "jlink" in several messages. /ANdy On

RFR: JDK-8219889 : Update jpackage tests for JDK-8219678 changes

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Remove JPackageCreateImageOverwriteTest and JPackageCreateImageStripNativeCommandsTest. - Remove usage of --overwrite. [1]

RFR: JDK-8219144 : Cannot find installed application on Mac

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). By default pkgbuild generates package with BundleIsRelocatable set to true, which means if an application already exist on system (installed,

Re: RFR: JDK-8217902: jpackage fails with --app-image option on mac

Hi Andy, http://cr.openjdk.java.net/~herrick/8217902/webrev.01/src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WinAppBundler.java.frames.html Line 135 - Did you mean to put error message in else statement before throwing exception? Otherwise looks fine. Thanks, Alexander On 2/26/2019

Re: RFR: JDK-8219678: CLI changes in jpackage

Hi Andy, http://cr.openjdk.java.net/~herrick/8219678/webrev.03/src/jdk.jpackage/share/classes/jdk/jpackage/internal/BundlerParamInfo.java.frames.html Line 32: Do we need this import? I do not see any changes which might require it. Otherwise looks fine. Thanks, Alexander On 3/3/2019 7:48

Re: RFR: JDK-8219679: Help text changes in jpackage

Hi Andy, http://cr.openjdk.java.net/~herrick/8219679/webrev.02/src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources.properties.frames.html Line 109: Missing ">" after main class? Line 132: additionl - > additional Otherwise looks fine. Thanks, Alexander On 3/3/2019

RFR: JDK-8214566 : --win-dir-chooser does not prompt if destination folder is not empty

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Added custom action to check installation folder and display confirmation dialog to ask user to continue installation if destination folder is not

RFR: JDK-8218681 : Windows exe's generated by jpackage have wrong info

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - User provided version was not display, because it was added as additional LANG_ENGLISH resource and Windows Explorer was displaying default one

Re: RFR: JDK-8218055: Use ToolProvider instead of AppRuntimeImageBuilder.

Hi Andy, Updated changes looks fine. Thanks, Alexander On 2/22/2019 9:50 AM, Andy Herrick wrote: revised webrev t address issues brought up by Mandy: [2] http://cr.openjdk.java.net/~herrick/8218055/webrev.03 /Andy On 2/21/2019 8:54 PM, Mandy Chung wrote: On 2/21/19 4:49 PM, Andy

Re: RFR: JDK-8217902: jpackage fails with --app-image option on mac

Hi Andy, Revised webrev looks good. Thanks, Alexander On 2/27/2019 4:41 PM, Andy Herrick wrote: revised webrev at http://cr.openjdk.java.net/~herrick/8217902/webrev.02/ Do not Log a verbose message when cfg not found in getAppName() - just use APP_NAME parameter as is done on Linux and Mac

Re: RFR: JDK-8191709 : javapackager detects WiX 3.10 as 3.1 and fails to use WiX 3.6+ compatible code

, for example, that 4.1 will be considered less than 3.6. -- Kevin On 2/26/2019 3:25 PM, Alexander Matveev wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Problem was in how we compare

RFR: JDK-8191709 : javapackager detects WiX 3.10 as 3.1 and fails to use WiX 3.6+ compatible code

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Problem was in how we compare versions. We used to compare it as float number, so 3.10 -> 3.1 which was less then 3.6. - Fixed by comparing major

RFR: JDK-8215574 : Investigate and document usage of --category, --copyright, --vendor and --description

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Removed unused TITLE which is just APP_NAME. - Fix maintainer for DEB packages "vendor " instead of vendor or just email. - Fixed description for

Re: RFR: JDK-171959: add-launcher is not working when normal jar is used for first launcher and module is used for second launcher

Hi Andy, Looks good. Thanks, Alexander On 3/8/2019 12:57 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8171959 [2]

Re: RFR: JDK-8214566 : --win-dir-chooser does not prompt if destination folder is not empty

) and TOOLCHAIN_LINK_CXX have no effect on Windows, so should be removed to avoid confusion in the future. This new library does not link with libjava so I see no need to add that prerequisite declaration. /Erik On 2019-03-06 17:10, Alexander Matveev wrote: Please review the jpackage fix for bug [1

Re: RFR: JDK-8220804: Help message for @ argfile option is printed in the wrong place

Hi Andy, Looks good. Thanks, Alexander On 3/18/2019 5:44 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8220804 [2]

Re: RFR: 8220505: Allow building available installers when --installer-type not specified

Hi Andy, Looks good. Thanks, Alexander On 3/12/2019 9:46 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8220505 [2]

RFR: JDK-8220264: msi installer does not remove some files if app installed into non-default location

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Problem was that we did not restore APPLICATIONFOLDER correctly and it was set to default value. Fixed by forcing reading registry from 64-bit.

Re: RFR: JDK-8217687: jpackage --help improvements

Hi Andy, http://cr.openjdk.java.net/~herrick/8217687/webrev.01/src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/MainResources.properties.frames.html Line 140: I think we do not need " at the end. Otherwise looks fine. Thanks, Alexander On 2/7/2019 9:11 AM, Andy Herrick wrote:

Re: RFR: JDK-8217802: Invalid Option warning message.

Looks good. On 2/15/2019 7:30 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). This is a simple fix to the unsupported Option warning message, and also fixes a problem when

RFR: JDK-8212091 : Move native code under platform specific folders and files

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Moved native code under platform specific folder. - Removed most usage on #ifdefs for WINDOWS, LINUX, MAC and POSIX. - MAC define is still used in

Re: RFR: JDK-8212091 : Move native code under platform specific folders and files

ie wrote: On 2019-02-15 04:31, Alexander Matveev wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Moved native code under platform specific folder. - Removed most usage on #ifdefs for

RFR: JDK-8214564 : --win-upgrade-uuid does not work as expected

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Upgrade did not work, because element was missing. Fixed by adding this element if --win-upgrade-uuid was provided. - Minor code clean up. Removed

Re: RFR: JDK-8217894: jpackage CLI syntax changes

Hi Andy, http://cr.openjdk.java.net/~herrick/8217894/webrev.01/src/jdk.jpackage/share/classes/jdk/jpackage/internal/ValidOptions.java.frames.html Line 108 and 113 looks same. I think one of them can be removed.

Re: RFR: JDK-8212091 : Move native code under platform specific folders and files

On 02/15/2019 10:03 PM, Alexander Matveev wrote: Hi Magnus, http://cr.openjdk.java.net/~almatvee/8212091/webrev.01/ Moved all files from "posix" to "unix" folder and reverted Lib-jdk.jpackage.gmk changes. Webrev updated with files moved, instead of add/remove. Thanks, Alexander

Re: RFR: JDK-8217798: modular jar linking in jpackage

Hi Andy, Looks good. Thanks, Alexander On 2/19/2019 7:59 AM, Andy Herrick wrote: JDK-8217798: modular jar linking in jpackage Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1]

Re: RFR: JDK-8217331: Problems when space in application name

Hi Andy, Looks fine. Thanks, Alexander On 1/27/2019 4:56 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). The webrev includes removal of the APP_FS_NAME DeployParam, and

Re: RFR: JKDK-8217331, JDK-8217792

Hi Andy, http://cr.openjdk.java.net/~herrick/8217792/webrev.01/src/jdk.jpackage/share/classes/jdk/jpackage/internal/JLinkBundlerHelper.java.frames.html Line 419 - Log.info() logs always. I think it is better to use Log.verbose() or just remove it. Otherwise looks good. Thanks, Alexander On

Re: RFR: JDK-82177923: Modular jars in jpackage are not working

Hi Andy, Looks fine. Thanks, Alexander On 1/30/2019 5:27 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). JDK-8217793 fixes the use of modular jars [1]

Re: RFR: JDK-8217792 : Investigate what modules are included

Hi Andy, http://cr.openjdk.java.net/~herrick/8217792/webrev.03/src/jdk.jpackage/share/classes/jdk/jpackage/internal/JLinkBundlerHelper.java.frames.html Line 272: Did you mean "if" here? I think it should be changed back to "else if". Otherwise looks fine. Thanks, Alexander On 1/30/2019 2:05

RFR: JDK-8217317 : Create jpackage native library for windows

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - jpackage launcher will now build same as Linux and OS X using SetupBuildLauncher. - jpackage.dll was added based on Windows jpackage.exe launcher

Re: RFR: JDK-8217317 : Create jpackage native library for windows

Hi Magnus, http://cr.openjdk.java.net/~almatvee/8217317/webrev.01/ Moved files to libjpackage and remove JPACKAGELIB_SRC. Old wmain() was in jpackage.cpp line 461. Thanks, Alexander On 2/1/2019 3:39 AM, Magnus Ihse Bursie wrote: Hi Alexander, On 2019-02-01 05:22, Alexander Matveev wrote

Re: RFR: JDK-8217751: jpackage messages and failures

Hi Andy, Looks good. Thanks, Alexander On 2/1/2019 6:54 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). RFR:  JDK-8217751: jpackage messages and failures This is a fix to

Re: RFR: JDK-8221641: Follow up code clean up for JDK-8221582

Hi Andy, Looks good. Thanks, Alexander On 4/9/2019 9:33 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8221641 [2]

Re: RFR: JDK-8221749: Error messages

Hi Andy, webrev.02 looks good. Thanks, Alexander On 4/9/2019 4:45 AM, Andy Herrick wrote: On 4/8/2019 6:05 PM, Andy Herrick wrote: On 4/8/2019 5:41 PM, Alexander Matveev wrote: Hi Andy, Looks good. Also, many messages (including added in this review) in MainResources.properties do have

Re: RFR: JDK-8221749: Error messages

Hi Andy, Looks good. Also, many messages (including added in this review) in MainResources.properties do have "." at the end and some don't. I think we should cleanup it and add "." if needed. Thanks, Alexander On 4/8/2019 4:41 AM, Andy Herrick wrote: Please review the jpackage fix for

Re: RFR: 8222486: Reorder sample usage in jpackage help output

Hi Andy, Looks good. Thanks, Alexander On 4/15/2019 6:32 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8222486 [2]

Re: RFR: JDK-8222406: Multiple arguments for the same option - aggragation broken.

Hi Andy, Looks good. Thanks, Alexander On 4/12/2019 10:35 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8222406 [2]

Re: RFE: JDK-8217895: jpackage --identifier purpose

Hi Andy, Looks good. Thanks, Alexander On 4/11/2019 12:05 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8217895 [2]

Re: RFR: JDK-8224597: create automated tests for platform create-app-image options

by jpackage looks fragile. - Alexey On 6/6/2019 5:37 PM, Alexander Matveev wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Added tests for --win-console, --mac-bundle-identifier and --mac

Re: RFR: JDK-8223333: Use try-with-resources where feasible

Hi Andy, Looks good. As well as other fixes you send yesterday for review. Thanks, Alexander On 6/6/2019 12:48 PM, Andy Herrick wrote: OK - revised MacCertificate as per below: webrev: http://cr.openjdk.java.net/~herrick/822/webrev.03 /Andy On 6/6/2019 12:47 PM, Alexey Semenyuk wrote:

RFR: JDK-8224597: create automated tests for platform create-app-image options

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Added tests for --win-console, --mac-bundle-identifier and --mac-bundle-name. [1] https://bugs.openjdk.java.net/browse/JDK-8224597 [2]

Re: RFR: JDK-8225569: jpackage app-image layout

Looks good. On 6/14/2019 8:54 AM, Andy Herrick wrote: On 6/14/2019 11:44 AM, Kevin Rushforth wrote: Looks good. Btw, there is a trailing whitespace you might want to fix (although that can be done later as a bulk update if you prefer).

RFR: JDK-8226193: BundleNameTest and BundleIdentifierTest fails if run without network connection

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Fixed by disabling loading external DTD files. [1] https://bugs.openjdk.java.net/browse/JDK-8226193 [2]

Re: RFR: JDK-8221333: Replace Inno Setup with custom MSI wrapper for .exe bundler

Hi Alexey, Looks good. Thanks, Alexander On 6/14/2019 10:09 AM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Get rid of dependency on Inno Setup for .exe installers on

Re: RFR: JDK-8224597: create automated tests for platform create-app-image options

Expected value: [foo]     at sample.Sample.main(Sample.java:25) java sample.Sample jp_sandbox\jdk\open\src\jdk.jpackage\macosx\classes\jdk\jpackage\internal\resources\Info-lite.plist.templateDEPLOY_BUNDLE_IDENTIFIER - Alexey On 6/6/2019 10:56 PM, Alexander Matveev wrote: http://cr.openjdk.java

RFR: JDK-8225023: JPackageCreateAppImageBundleNameTest fails

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Fixed by using correct id for MAC_CF_BUNDLE_NAME, otherwise it was not set from CLI. [1] https://bugs.openjdk.java.net/browse/JDK-8225023 [2]

RFR: JDK-8224486: Arguments from jpackager cfg file not processed correctly

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Duplicated Java options were not read correctly from OrderedMap, instead we read only unique from map. Fixed by reading duplicated Java options.

Re: RFR: JDK-8224486: Arguments from jpackager cfg file not processed correctly

are not allowed? - Alexey On 6/24/2019 9:18 PM, Alexander Matveev wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Duplicated Java options were not read correctly from OrderedMap, instead we read

Re: RFR: JDK-8225569: jpackage app-image layout

Hi Andy, 1) I think it is better to move mksure() to common place like IOUtils, otherwise it is duplicated in WindowsAppImageBuilder.java and LinuxAppImageBuilder.java. 2) For Alexey comment I think it is good idea to use Paths.get(), but I think it should be done as separate cleanup bug.

Re: RFR: JDK-8225428: CLI change to remove "mode", rename to "package", and build only one target

Hi Andy, 1) Looks like you forgot to update HelpResources_ja.properties and HelpResources_zh_CN.properties. 2) http://cr.openjdk.java.net/~herrick/8225428/webrev.01/src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/MainResources.properties.frames.html Line 84: Error: creating

Re: RFR: JDK-8223643: Provide better defined context for custom installer steps on Windows

Hi Alexey, Looks fine. Thanks, Alexander On 5/23/2019 11:57 AM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage).

Re: RFR: JDK-8224222: Inno setup 6 broke jpackage

Hi Alexey, Is there better way to figure out InnoSetup version? Creating empty project file seems complicated. If there no such way, then fix looks fine. Thanks, Alexander On 5/20/2019 8:27 AM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

Hi Andy, Looks good overall. http://cr.openjdk.java.net/~herrick/8212780/webrev.ea6/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/Info-lite.plist.template.html

Re: RFR: JDK-8223038: JPackage code signing fails on Mac.

Hi Semyon, Looks good. Thanks, Alexander On 4/26/2019 12:28 PM, semyon.sadet...@oracle.com wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8223038 webrev: http://cr.openjdk.java.net/~ssadetsky/8223038/webrev.00/ This is a regression of 8219683 where Java runtime was moved out from

Re: RFR: 8223402: Create tests for some Mac installer specific options

Hi Semyon, Looks good. Add space after several if statements. Thanks, Alexander On 5/7/2019 9:59 AM, semyon.sadet...@oracle.com wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8223402 webrev: http://cr.openjdk.java.net/~ssadetsky/8223402/webrev.00/ By this change tests added for

Re: RFR: JDK-8222733: Modify jpackage option --add-launcher syntax

Hi Andy, Looks good. Thanks, Alexander On 4/18/2019 12:49 PM, Andy Herrick wrote: Please review the jpackage fix for bugs [1] and [2] at [3]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8222733

RFR: JDK-8222676: create-installer with --app-image fails on mac

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Fixed issue when app image is located at root of working folder, since fix for JDK-8219144 assumed app image located under some folder other then

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

Hi Kevin, See below. On 5/2/2019 5:38 PM, Kevin Rushforth wrote: Here are a few follow-on comments. As with my earlier comments, none of these need to be addressed prior to integration. 1. I found a few more classes that do I/O and could benefit from using try-with-resources:    IOUtils,

Re: RFR: JDK-8226835: Command window pops up building exe package

Hi Alexey, Looks good. Thanks, Alexander On 6/27/2019 3:02 PM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Eliminate unexpected console window in .exe installers on

Re: RFR: JDK-8227058: Regressions related to no longer setting user.dir

Hi Andy, Looks good. Thanks, Alexander On 7/3/2019 7:16 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8227058 [2]

Re: RFR: JDK-8226599 use code coverage results to remove dead code

Hi Andy, Why only some tests are renamed? Otherwise looks fine. Thanks, Alexander On 6/26/2019 4:09 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1]

Re: RFR (S): JDK-8222778: Packaging Tool (JEP 343) on Linux/AArch64

Hi Dmitry, http://cr.openjdk.java.net/~dchuyko/8222778/webrev.00/src/jdk.jpackage/unix/native/libapplauncher/PosixPlatform.cpp.frames.html Why code between lines 215 and 219 was disabled? Not sure what it tries to do, if it tries to guarantee NULL termination we should probably keep it or

Re: RFR: JDK-8226751: "Exception: ..." for missing file

Looks good. On 7/1/2019 11:12 AM, Alexey Semenyuk wrote: Looks good. On 7/1/2019 1:07 PM, Andy Herrick wrote: Updated webrev at https://bugs.openjdk.java.net/browse/JDK-8226751/webrev.02 to use Files.isReadable() /Andy On 6/29/2019 9:54 AM, Kevin Rushforth wrote: The rest of the

Re: RFR: JDK-8226891: rename and re-layout jpackage tests.

Hi Andy, Looks good. Thanks, Alexander On 6/30/2019 2:11 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8226891 [2]

Re: RFR: JDK-8226904: current working directory wrong running jpackage app

Hi Andy, http://cr.openjdk.java.net/~herrick/8226904/webrev.01/test/jdk/tools/jpackage/createappimage/JPackageCreateAppImageRuntimeBase.java.frames.html Do we need these extra System.out? Otherwise looks fine. Thanks, Alexander On 6/28/2019 10:59 AM, Andy Herrick wrote: Please review the

Re: RFR: JDK-8224486: Arguments from jpackager cfg file not processed correctly

if we want to add values from OrderedMap which does not have duplicates flag set to true. Thanks, Alexander On 6/26/2019 7:21 AM, Andy Herrick wrote: then I'm fine with original fix. /Andy On 6/25/2019 6:08 PM, Alexander Matveev wrote: Hi Alexey, I cannot use index to get items from map

Re: RFR: JDK-8229138: Add --linux-app-release option for DEB and RPM packages

Looks good. On 8/13/2019 12:56 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8229138?filter=-1 [2]

Re: RFR: JDK-8215447: Investigate if current implementation of --license-file is correct for RPM packagesI

Looks good. On 8/13/2019 12:10 PM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Install license file in the correct location in stead of the app's installation

Re: RFR: JDK-8229750: Fix bad merge of JDK-8215447 patch

Looks good. On 8/14/2019 11:29 AM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - bad merge fix [1] https://bugs.openjdk.java.net/browse/JDK-8229750 [2]

Re: RFR: JDK-8213941: Debian linux problems in JavaPackager

Looks good. Is it possible to have test for this new option? If yes, then as part of this fix or as separate issue should be fine. Thanks, Alexander On 8/16/2019 11:28 AM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch

Re: RFR:JDK-8229791: Code clean up regressions

Looks good. Thanks, Alexander On 8/16/2019 1:36 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8229791 [2]

Re: RFR: JDK-8224594: Simplify jpackage Logging

Looks good. Thanks, Alexander On 8/15/2019 1:50 PM, Andy Herrick wrote: ok - revised [3] to restore the second trace statement (now Log.verbose()) [3]: http://cr.openjdk.java.net/~herrick/8224594/webrev.02/ /Andy On 8/15/2019 3:40 PM, Andy Herrick wrote: The first of these doesn't convey

Re: RFR: JDK-8224594: Simplify jpackage Logging

Looks good and probably lets restore removed log statements. On 8/15/2019 12:09 PM, Alexey Semenyuk wrote: Andy, What is the reason to remove log statements in

Re: RFR: JDK-8227172: revert JDK-8225569 on windows

Looks good. On 8/10/2019 3:44 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). This change will remove the "bin" directory on windows and revert to putting the executable(s)

RFR: JDK-8226534: combination of windows options cause exception in MsiBundler

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Fixed by adding --install-dir folders to RemoveFile table as per Wixs requirements. [1] https://bugs.openjdk.java.net/browse/JDK-8226534 [2]

Re: RFR: JDK-8225447: Revise Debian packaging

Looks good. Thanks, Alexander On 8/19/2019 9:56 AM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - fix all permission related issues reported by lintian - cleanup control

RFR: JDK-8229788: Error dialog displays with DLL issue when installing WinChooserTest application

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Fixed by statically linking with runtime. [1] https://bugs.openjdk.java.net/browse/JDK-8229788 [2]

Re: RFR: JDK-8229795: Investigate registry key usage and need for --win-registry-name option.

Looks good. Thanks, Alexander On 8/19/2019 2:16 PM, Kevin Rushforth wrote: OK. Looks good. -- Kevin On 8/19/2019 2:09 PM, Andy Herrick wrote: On 8/19/19 4:53 PM, Kevin Rushforth wrote: The following will take the last in the list of extensions and use that: + entryName =

Re: JDK-8229786: No output after WinShortcutTest.exe is launched

Looks good. Thanks, Alexander On 8/16/2019 12:12 PM, Alexey Semenyuk wrote: Makes sense. Looks good then. - Alexey On 8/16/2019 3:08 PM, Andy Herrick wrote: On 8/16/2019 2:26 PM, Alexey Semenyuk wrote: Andy, I think we want this change in all Windows jtreg tests as they all use this

Re: RFR: JDK-8224833: jpackages differences between platforms

Looks good. Thanks, Alexander On 8/27/2019 4:25 PM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8224833 [2]

Re: RFR: JDK-8228660: .deb files generated by jpackage don't follow naming convention

Looks good. Thanks, Alexander On 8/27/2019 1:13 PM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - fix implementation of --linux-app-release CLI option for Debian

Re: RFR: JDK-8229840: Add jtreg test for --linux-app-category option

Hi Alexey, Looks good. Any plans to convert all tests to use new helper classes? Thanks, Alexander On 8/30/2019 2:55 PM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). -

RFR: JDK-8223211: Remove old code from service support

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). 1) This file is not used and was removed. 2) This file was removed due to JDK-8221333. 3) Removed unused services code. [1]

Re: RFR: JDK-8230152: No appropriate error message when wix tools missing.

Looks good. Thanks, Alexander On 8/29/2019 11:18 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8230152 [2]

Re: jpackage on MacOs: app from pkg cannot write files and create directories inside itself

Hi Andrey, Writing to  /Application on macOS or "Program Files" on Windows requires admin privileges. It is very uncommon when application stores temp files or setting files modifiable by user inside installation folder. For temp files I will recommend to use system provided temp folder. For

Re: RFR: JDK-8229779: Shortcut creation policy

Looks good. On 9/11/2019 6:07 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). This fix: 1.) adds the new option --linux-shortcut, and now only creates a shortcut on linux

  1   2   3   4   5   6   >