Hi Alexey,
Looks good.
Thanks,
Alexander
On 6/10/20 9:21 AM, Alexey Semenyuk wrote:
Please review fix [2] for jpackage bug [1].
Minor jpackage jtreg tests clean up of issues uncovered during the
recent local test runs.
- Alexey
[1] https://bugs.openjdk.java.net/browse/JDK-8247353
[2]
Hi Andy,
Looks good. For changing "jpackagerTest.keychain" to
""jpackageTest.keychain" we can file followup bug for this, since SQE
depend on this value to be "jpackagerTest.keychain".
Thanks,
Alexander
On 6/5/20 2:27 PM, Alexey Semenyuk wrote:
In SigningBase.java:
---
KEYCHAIN = (value ==
Hi Alexey,
Looks good.
Thanks,
Alexander
On 6/8/20 7:26 AM, Alexey Semenyuk wrote:
Please review fix [2] for jpackage bug [1].
Add support to jpackage to create Linux packages installing app images
in '/usr' tree with splicing of the app image.
For --install-dir=/usr jpackag option the
Hi Alexey,
Looks good.
Thanks,
Alexander
On 6/4/20 9:21 AM, Alexey Semenyuk wrote:
Please review fix [2] for jpackage bug [1].
Replace xargs call with --no-run-if-empty parameter with bash
expressions in run_tests.sh
Call run_tests.sh from test_jpackager.sh in a way to avoid shebang
Hi Alexey,
Looks good.
Thanks,
Alexander
On 6/4/20 1:46 PM, Alexey Semenyuk wrote:
Please review fix [2] for jpackage bug [1].
Move duplicated functionality from LinuxAppBundler, MacAppBundler and
WinAppBundler classes in the base class.
[2] webrev is on top of [3] webrev.
- Alexey
[1]
Hi Alexey,
Looks good.
Thanks,
Alexander
On 6/4/20 1:22 PM, Alexey Semenyuk wrote:
Please review fix [2] for jpackage bug [1].
Move functionality to collect data about app (main class name, main
jar, module name, etc) from JLinkBundlerHelper and
StandardBundlerParam classes in dedicated
Hi Alexey,
Looks good.
Thanks,
Alexander
On 6/10/20 2:40 PM, Andy Herrick wrote:
looks good -
This works for me finally.
/Andy
On 6/10/2020 5:29 PM, Alexey Semenyuk wrote:
Please review fix [2] for jpackage bug [1].
Move `.jpackage.xml` file in `app` directory of app image and keep it
Hi Andy,
Looks good.
Thanks,
Alexander
On 6/11/20 1:22 PM, Andy Herrick wrote:
Please review the small jpackage test fix at [1] to issue [2].
[1] http://cr.openjdk.java.net/~herrick/8247418/webrev.01/
[2] https://bugs.openjdk.java.net/browse/JDK-8247418
/Andy
Looks good.
Thanks,
Alexander
On 6/11/20 1:19 PM, Andy Herrick wrote:
looks good.
/Andy
On 6/11/2020 1:23 PM, Alexey Semenyuk wrote:
Please review fix [2] for jpackage bug [1].
Restore handling not only Java runtime home but also Java runtime
root directory in `--runtime-image` option on
Please review the jpackage fix for bug [1] at [2].
This is still a workaround for JDK-8236825. Implemented as per Roger
suggestion to redirect output to temp file. I did a lot of testing using
repro case and was not able to reproduce hang anymore.
[1]
Please review the jpackage fix for bug [1] at [2].
Added support for additional (macOS specific) file association
properties. These additional properties should be set via same property
file which used for file association. Names and values for properties
should match name and values as
Hi Alexey,
http://cr.openjdk.java.net/~almatvee/8233215/webrev.01/
- TKit.assertStringListEquals() will be used instead. Did not noticed
that we had this method already. I removed my implementation.
- Added "mac." prefix.
Thanks,
Alexander
On 6/8/20 10:57 PM, Alexey Semenyuk wrote:
Looks good.
Thanks,
Alexander
On 7/24/20 12:39 PM, Andy Herrick wrote:
looks good
/Andy
On 7/21/2020 2:27 PM, Alexey Semenyuk wrote:
Hi Aleksei,
Looks good!
- Alexey
On 7/21/2020 11:42 AM, Aleksei Voitylov wrote:
Hi,
This is the updated fix which checks if LD_LIBRARY_PATH has been
Please review the jpackage fix for bug [1] at [2].
- "hdiutil detach" resource busy error is fixed in same way as
JDK-8242786 by repeating detach several times.
- pkgbuild timeout will be covered with JDK-8249395.
[1] https://bugs.openjdk.java.net/browse/JDK-8245311
[2]
Hi Alexey,
Fixed as per your suggestion:
http://cr.openjdk.java.net/~almatvee/8245311/webrev.01/
Thanks,
Alexander
On 7/17/20 4:26 PM, Alexey Semenyuk wrote:
Alexander,
The change in RetryExecutor.java results in Executor instance created
only once and not every time command line should be
http://cr.openjdk.java.net/~almatvee/8248248/webrev.01/
- Added INFINITE_TIMEOUT instead of -1.
- Fix actually did not work correctly and process never timeout, since
we were reading process output and wait with timeout never executed,
since reading output was continue until process
Please review the jpackage fix for bug [1] at [2].
- DMG image can get detach even if "hdiutil detach" return resource busy
error. Fixed by stopping trying detach if DMG already got detach.
[1] https://bugs.openjdk.java.net/browse/JDK-8250646
[2]
Hi Andy,
Looks good.
Thanks,
Alexander
On 7/16/20 11:44 AM, Andy Herrick wrote:
yes - revised as suggested - please re review.
/Andy
On 7/15/2020 6:41 PM, alexander.matv...@oracle.com wrote:
Hi Andy,
Can you double check two other places where File.list() was
introduced with JDK-8223955
Hi Andy,
Looks good.
Thanks,
Alexander
On 7/16/20 2:23 PM, Andy Herrick wrote:
Please review fix for jpackage bug [1] at [2].
The behavior is to allow (after a warning message) case where user has
multiple certificates matching the given mac-signing-key-user-name,
and to allow the full
Please review the jpackage fix for bug [1] at [2].
Added timestamp to verbose and test output in form of [HH:mm:ss.SSS].
[1] https://bugs.openjdk.java.net/browse/JDK-8248261
[2] http://cr.openjdk.java.net/~almatvee/8248261/webrev.00/
Thanks,
Alexander
On Sat, 5 Dec 2020 05:33:25 GMT, Alexander Matveev wrote:
> Fixed by using correct localized resources.
This pull request has now been integrated.
Changeset: a265c201
Author: Alexander Matveev
URL: https://git.openjdk.java.net/jdk/commit/a265c201
Stats: 2 lines in 2 files chan
Fixed by using correct localized resources.
-
Commit messages:
- 8255619: Localized WinResources.properties have MsiInstallerStrings_en.wxl
resource
Changes: https://git.openjdk.java.net/jdk/pull/1638/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1638=00
Issue:
Changed all external executables to run via full path to avoid potential issues.
-
Commit messages:
- 8257924: Use full path when running external executable from jpackage
Changes: https://git.openjdk.java.net/jdk/pull/1710/files
Webrev:
On Mon, 7 Dec 2020 20:29:56 GMT, Andy Herrick wrote:
> increase retries and timeout increasing in runMsiexecWithRetries
Looks like test failed due to:
[Fatal Error] b.wxl:3:1: XML document structures must start and end within the
same entity.
So, I am not sure how increased repeat will help.
This is similar issue we used to have for hdiutil create/detach, but for
"convert". Added same workaround to repeat command. I also added repeat for
"udifrez" command just in case.
-
Commit messages:
- 8238781: [macos] jpackage tests failed due to "hdiutil: convert failed" in
On Mon, 23 Nov 2020 20:16:58 GMT, Andy Herrick wrote:
> When executing msiexec (possibly from batch script) retry on exitCode 1603 as
> well as 1618
Marked as reviewed by almatvee (Committer).
-
PR: https://git.openjdk.java.net/jdk/pull/1400
On Wed, 9 Dec 2020 18:58:54 GMT, Andy Herrick wrote:
> Same code change as https://github.com/openjdk/jdk/pull/1676 that got messed
> up with merge
Marked as reviewed by almatvee (Committer).
-
PR: https://git.openjdk.java.net/jdk/pull/1720
On Tue, 8 Dec 2020 07:45:30 GMT, Alexander Matveev wrote:
> This is similar issue we used to have for hdiutil create/detach, but for
> "convert". Added same workaround to repeat command. I also added repeat for
> "udifrez" command just in case.
This pull re
On Wed, 9 Dec 2020 18:39:14 GMT, Alexey Semenyuk wrote:
>> as long as your sure these are always in /usr/bin this is fine.
>> If there is any chance of them being somewhere else instead we need a
>> findTool type mechanism
>
> What if users would like to use not the default tools with jpackage?
On Wed, 9 Dec 2020 08:05:17 GMT, Alexander Matveev wrote:
> Changed all external executables to run via full path to avoid potential
> issues.
This pull request has now been integrated.
Changeset: eb1c8a15
Author:Alexander Matveev
URL: https://git.openjdk.java.net/jdk/
On Thu, 17 Dec 2020 20:46:50 GMT, Andy Herrick wrote:
> Remove all non final static variables in jpackage java code (using
> InheritableThreadLocal for Logger and Argument instances) and remove
> sychronization in JPackageToolProvider.
Changes looks fine, but are we sure that external 3rd
On Wed, 16 Dec 2020 00:24:20 GMT, Alexey Semenyuk wrote:
> Ignore files created by prefs subsystem when checking if source runtime
> contains the same files as packed runtime.
Marked as reviewed by almatvee (Committer).
-
PR: https://git.openjdk.java.net/jdk16/pull/31
On Mon, 14 Dec 2020 19:33:44 GMT, Alexey Semenyuk wrote:
> Adds support for "uninstall" parameter for exe uninstallers created by
> jpackage.
> Added logging and error reporting to exe uninstallers.
>
> - jpackage jni lib (jpackage.cpp): added functionality to extract ProductCode
> property
On Fri, 6 Nov 2020 21:59:51 GMT, Alexey Semenyuk wrote:
> 822: Need to create exploded tests covering all forms of modules
Marked as reviewed by almatvee (Committer).
-
PR: https://git.openjdk.java.net/jdk/pull/1103
On Thu, 12 Nov 2020 20:48:13 GMT, Andy Herrick wrote:
>> JDK-8189198: Add "forRemoval = true" to Applet APIs
>
> Andy Herrick has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the
> This is regression from JDK-8242302 and for some reason removing -psn
> argument code was removed during refactoring. Fixed be adding removing -psn
> argument back. Also, test was added to test this functionality.
Alexander Matveev has updated the pull request incrementally
On Wed, 11 Nov 2020 04:28:02 GMT, Alexander Matveev
wrote:
> This is regression from JDK-8242302 and for some reason removing -psn
> argument code was removed during refactoring. Fixed be adding removing -psn
> argument back. Also, test was added to test this functionality.
This pul
> This is regression from JDK-8242302 and for some reason removing -psn
> argument code was removed during refactoring. Fixed be adding removing -psn
> argument back. Also, test was added to test this functionality.
Alexander Matveev has updated the pull request incrementally
On Thu, 19 Nov 2020 22:26:20 GMT, Alexey Semenyuk wrote:
>> 8235304: JPackage Windows test should be added to set Publisher
>
> Alexey Semenyuk has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in
On Thu, 19 Nov 2020 20:45:23 GMT, Andy Herrick wrote:
>> …n name.
>
> Andy Herrick has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8256475: Fix Behavior when Installer name differs from application name.
Marked as reviewed by almatvee
On Wed, 18 Nov 2020 22:17:07 GMT, Andy Herrick wrote:
> …n name.
src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WinMsiBundler.java line
312:
> 310: Path appDir;
> 311: if (appName == null) {
> 312: // this can only happen when no name is given and using
>
On Wed, 18 Nov 2020 21:57:13 GMT, Alexey Semenyuk wrote:
> Fix test failures. They didn't fail in Mach5 test runs as WiX was not
> available on test machines and these tests were not executed.
Marked as reviewed by almatvee (Committer).
-
PR:
This is regression from JDK-8242302 and for some reason removing -psn argument
code was removed during refactoring. Fixed be adding removing -psn argument
back. Also, test was added to test this functionality.
-
Commit messages:
- 8255947: [macos] Signed macOS jpackage app doesn't
On Fri, 30 Oct 2020 12:47:08 GMT, Andy Herrick wrote:
>> JVM
>
> Andy Herrick has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8254920: Application launched with jpackage produced .exe crashes JVM
Marked as reviewed by almatvee
On Sat, 17 Oct 2020 14:01:22 GMT, Andy Herrick wrote:
> …from installer name
> JDK-8254783: jpackage fails on Windows when application name differs from
> installer name
> When using --app-image, to create MSI installer, use the application name
> from AppImageData instead of the Msi
>
On Wed, 6 Jan 2021 15:52:07 GMT, Andy Herrick wrote:
> JDK-8259062: Remove MacAppStoreBundler
Marked as reviewed by almatvee (Committer).
-
PR: https://git.openjdk.java.net/jdk/pull/1962
On Thu, 7 Jan 2021 16:40:26 GMT, Andy Herrick wrote:
> JDK-8259238: Clean up Log.java and remove usage of non-final static variables.
Marked as reviewed by almatvee (Committer).
-
PR: https://git.openjdk.java.net/jdk/pull/1977
On Mon, 11 Jan 2021 17:42:21 GMT, Andy Herrick wrote:
> JDK-8258755: jpackage: Invalid 32-bit exe when building app-image
src/jdk.jpackage/share/native/applauncher/JvmLauncher.cpp line 37:
> 35:
> 36: #if defined(_WIN32) && !defined(_WIN64)
> 37: #define LAUNCH_FUNC "_JLI_Launch@56"
Why
On Mon, 11 Jan 2021 17:42:21 GMT, Andy Herrick wrote:
> JDK-8258755: jpackage: Invalid 32-bit exe when building app-image
Marked as reviewed by almatvee (Committer).
-
PR: https://git.openjdk.java.net/jdk/pull/2030
d seems to solves problem as well when hdiutil cannot acquire lock on
> file. I also fixed in same way detach in our test helper.
Alexander Matveev has updated the pull request incrementally with one
additional commit since the last revision:
8259570: (macos) tools/jpackage test
On Tue, 2 Feb 2021 00:29:39 GMT, Alexey Semenyuk wrote:
>> We did not able to run "hdiutil convert" due to hdiutil did not able to
>> acquire lock on DMG image file. In this condition we got "Resource busy"
>> from "hdiutil detach" and on repeated attempt we was getting "File Not
>> Found"
On Wed, 3 Feb 2021 14:08:13 GMT, Andy Herrick wrote:
> Remove lines in WixSourceBuilder that adds directive to rm-rf the parent
> dir(s) of the install-dir. These directories get removed anyway if they are
> empty without these lines, and should be left alone if not empty after
> removing
On Thu, 28 Jan 2021 23:41:44 GMT, Alexey Semenyuk wrote:
>> I would prefer to have separate messages for "headless" and "desktop
>> capable". I can merge these, if you insist.
>
> Duplicated messages are not much help in understanding control flow. I'd
> change the new message or merge
On Wed, 27 Jan 2021 12:43:40 GMT, Andy Herrick wrote:
> Fixing FileUtils.dirname() to skip over "/.".
Marked as reviewed by almatvee (Committer).
-
PR: https://git.openjdk.java.net/jdk/pull/2260
On Fri, 29 Jan 2021 23:06:20 GMT, Alexey Semenyuk wrote:
>> Fix for https://bugs.openjdk.java.net/browse/JDK-8254702
>>
>> The fix splits Linux app launcher in app launcher and launcher shared lib.
>> App launcher is pure C and doesn't have C++ code. App launcher lib
>> incorporates bulk of
On Tue, 8 Jun 2021 17:25:46 GMT, Alexey Semenyuk wrote:
>> …ages
>
> Alexey Semenyuk has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull request contains two
Looks like another "Resource busy" issue similar to recent fixes for "hdiutil
convert" and "hdiutil detach". Workaround in same way by repeating "create"
command. Modified RetryExecutor to pass write to file flag, otherwise "hdiutil
create" might deadlock.
Also, repeat is done only for creating
On Fri, 18 Jun 2021 22:46:24 GMT, Alexey Semenyuk wrote:
> GetApplicationHomeFromDll() fails if the path to libjli.so contains "bin"
> component (/tmp/bin/HelloWorld/lib/runtime/lib/libjli.so). TruncatePath()
> looks for "/bin/" first in "/tmp/bin/HelloWorld/lib/runtime/lib/libjli.so"
>
.
> - Fixed issue with jtreg.SkippedException which caused test to fail instead
> of being skipped, since it was wrapped in ExceptionBox.
Alexander Matveev has updated the pull request incrementally with one
additional commit since the last revision:
8266456: Replace direc
On Sat, 8 May 2021 01:44:46 GMT, Alexander Matveev wrote:
>> - Replaced direct TKit.run() calls with Test annotation.
>> - Increased timeout for SigningPackageTest from default to 360 due to
>> timeout. This is regression from JDK-8248904 due to changes done in signin
Looks like it is similar to JDK-8236282, except for "hdiutil create". Based on
call stack from failed test we launched "hdiutil create" and were waiting for
it to terminate while reading output from it. However, based on process dump
from machine which reproduced this issue, hdiutil no longer
On Fri, 14 May 2021 04:24:42 GMT, Alexander Matveev
wrote:
> Looks like it is similar to JDK-8236282, except for "hdiutil create". Based
> on call stack from failed test we launched "hdiutil create" and were waiting
> for it to terminate while reading output from
- Replaced direct TKit.run() calls with Test annotation.
- Increased timeout for SigningPackageTest from default to 360 due to timeout.
This is regression from JDK-8248904 due to changes done in signing and
--remove-signature adds additional time since it is run per file.
- Fixed issue with
On Fri, 7 May 2021 19:57:17 GMT, Alexey Semenyuk wrote:
>> jpackage should create copyright file in /usr/share/doc directory tree when
>> building .deb package for Java runtime with installation directory in /usr
>> directory tree.
>>
>> jpackage creates share/doc/copyright file in
On Fri, 7 May 2021 02:48:44 GMT, Alexander Matveev wrote:
> - Replaced direct TKit.run() calls with Test annotation.
> - Increased timeout for SigningPackageTest from default to 360 due to
> timeout. This is regression from JDK-8248904 due to changes done in signing
> and --remo
On Fri, 7 May 2021 16:50:15 GMT, Alexey Semenyuk wrote:
>> - Replaced direct TKit.run() calls with Test annotation.
>> - Increased timeout for SigningPackageTest from default to 360 due to
>> timeout. This is regression from JDK-8248904 due to changes done in signing
>> and --remove-signature
.
> - Fixed issue with jtreg.SkippedException which caused test to fail instead
> of being skipped, since it was wrapped in ExceptionBox.
Alexander Matveev has updated the pull request incrementally with one
additional commit since the last revision:
8266456: Replace direc
On Wed, 12 May 2021 20:34:08 GMT, Alexey Semenyuk wrote:
> 8266162: Remove JPackage duplicate tests
Marked as reviewed by almatvee (Committer).
-
PR: https://git.openjdk.java.net/jdk/pull/4003
Looks like another issue similar to hdiutil (JDK-8249395) when process is gone,
but we still waiting for it. I was not able to reproduce this issue by running
test or pkgbuild separately and conclusion was made based on logs. Fixed in
same way as hdiutil issue. Also, I added logging PID for
On Wed, 19 May 2021 21:00:07 GMT, Alexander Matveev
wrote:
> For debug build on macOS, runtime which used for test fill be located in
> /path/jdk-17/fastdebug and /path/jdk-17 will not contain any other files
> except fastdebug and in this case our check to decide if we need to
rrect. Fixed by skipping
> this check for runtime and only using it for app. Also, added ignoring
> .DS_Store to test which is needed if user used Finder to look inside runtime
> folder which will cause .DS_Store to be created and will cause test to fail,
> since this file is not be
On Thu, 20 May 2021 16:15:21 GMT, Alexey Semenyuk wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8267056: tools/jpackage/share/RuntimePackageTest.java fails with
>> No
For debug build on macOS, runtime which used for test fill be located in
/path/jdk-17/fastdebug and /path/jdk-17 will not contain any other files except
fastdebug and in this case our check to decide if we need to copy app or
runtime will return /path/jdk-17 which is not correct. Fixed by
On Fri, 7 May 2021 02:48:44 GMT, Alexander Matveev wrote:
> - Replaced direct TKit.run() calls with Test annotation.
> - Increased timeout for SigningPackageTest from default to 360 due to
> timeout. This is regression from JDK-8248904 due to changes done in signing
> and --remo
On Wed, 26 May 2021 11:26:24 GMT, Andy Herrick wrote:
> JDK-8267598: jpackage removes system libraries from java.library.path
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4203
On Wed, 2 Jun 2021 13:48:47 GMT, Andy Herrick wrote:
> JDK-8267764: jpackage cannot handle window screensaver files when EXE renamed
> as SCR
Marked as reviewed by almatvee (Reviewer).
Can we add a simple test for .scr executables?
-
PR:
On Thu, 3 Jun 2021 00:47:45 GMT, Jonathan Gibbons wrote:
> Please review a small test fix, to include hamcrest.jar, as required by the
> latest version of JUnit in jtreg 6.
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4328
On Fri, 21 May 2021 04:34:22 GMT, Alexander Matveev
wrote:
> Looks like another issue similar to hdiutil (JDK-8249395) when process is
> gone, but we still waiting for it. I was not able to reproduce this issue by
> running test or pkgbuild separately and conclusion was made base
On Fri, 2 Jul 2021 22:17:09 GMT, Alexey Semenyuk wrote:
> Disable stripping to prevent rpmbuild from modifying executables
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.java.net/jdk17/pull/207
On Fri, 25 Jun 2021 22:41:10 GMT, Alexey Semenyuk wrote:
> jpackage app launcher randomly crashes JVM at termination in EMS enabled JDK
> builds.
> Until the root cause of the issue is understood and fixed let's add a
> workaround to jpackage tests to run test app few more times if the first
On Tue, 22 Jun 2021 21:59:43 GMT, Alexander Matveev
wrote:
> Looks like another "Resource busy" issue similar to recent fixes for "hdiutil
> convert" and "hdiutil detach". Workaround in same way by repeating "create"
> command. Modified Re
jpackage should specify architecture for produced PKG files via
hostArchitectures="x86_x64 or arm64". aarch64 installer will be installable on
x64 without specifying hostArchitectures which is not correct and if install on
arm Mac it will request Rosetta 2. With proposed fix by setting
On Fri, 30 Apr 2021 04:22:37 GMT, Alexander Matveev
wrote:
> jpackage should specify architecture for produced PKG files via
> hostArchitectures="x86_x64 or arm64". aarch64 installer will be installable
> on x64 without specifying hostArchitectures which is not correc
n x64 Mac and will be installable on arm Mac
> without triggering installation of Rosetta 2.
Alexander Matveev has updated the pull request incrementally with one
additional commit since the last revision:
8266179: [macos] jpackage should specify architecture for produced pkg file
On Fri, 30 Apr 2021 15:25:13 GMT, Andy Herrick wrote:
> JDK-8266227: Fix help text for --mac-signing-keychain
Marked as reviewed by almatvee (Committer).
-
PR: https://git.openjdk.java.net/jdk/pull/3819
On Fri, 30 Apr 2021 20:19:25 GMT, Andy Herrick wrote:
> JDK-8266129: tools/jpackage/windows/WinInstallerIconTest.java hangs with
> fastdebug
>
> just disabling this test when vm.debug
Marked as reviewed by almatvee (Committer).
-
PR: https://git.openjdk.java.net/jdk/pull/3827
On Mon, 3 May 2021 16:01:36 GMT, Alexey Semenyuk wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8266179: [macos] jpackage should specify architecture for produced pkg
>>
n x64 Mac and will be installable on arm Mac
> without triggering installation of Rosetta 2.
Alexander Matveev has updated the pull request incrementally with one
additional commit since the last revision:
8266179: [macos] jpackage should specify architecture for produced pkg file
On Fri, 30 Apr 2021 04:22:37 GMT, Alexander Matveev
wrote:
> jpackage should specify architecture for produced PKG files via
> hostArchitectures="x86_x64 or arm64". aarch64 installer will be installable
> on x64 without specifying hostArchitectures which is not correc
On Mon, 3 May 2021 15:58:56 GMT, Alexey Semenyuk wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8266179: [macos] jpackage should specify architecture for produced pkg
>>
n x64 Mac and will be installable on arm Mac
> without triggering installation of Rosetta 2.
Alexander Matveev has updated the pull request incrementally with one
additional commit since the last revision:
8266179: [macos] jpackage should specify architecture for produced pkg file
On Mon, 3 May 2021 22:52:21 GMT, Alexander Matveev wrote:
>> jpackage should specify architecture for produced PKG files via
>> hostArchitectures="x86_x64 or arm64". aarch64 installer will be installable
>> on x64 without specifying hostArchitectures which is no
On Mon, 8 Feb 2021 15:25:02 GMT, Aleksey Shipilev wrote:
>> After JDK-8254702, SonarCloud instance complains about blocks like these:
>> "Change this loop body so that it can be executed more than once."
>>
>> int initJvmlLauncherData(JvmlLauncherData* ptr) const {
>> // Store path
On Mon, 8 Feb 2021 08:49:17 GMT, Aleksey Shipilev wrote:
> SonarCloud instance reports as new warning after JDK-8254702:
>
> This branch can not be reached because the condition duplicates a previous
> condition in the same sequence of "if/else if" statements.
>
> char*
On Mon, 8 Feb 2021 22:26:22 GMT, Alexey Semenyuk wrote:
> Remove needless `#ifdef __cplusplus` from .cpp sources
Marked as reviewed by almatvee (Committer).
-
PR: https://git.openjdk.java.net/jdk/pull/2466
We did not able to run "hdiutil convert" due to hdiutil did not able to acquire
lock on DMG image file. In this condition we got "Resource busy" from "hdiutil
detach" and on repeated attempt we was getting "File Not Found" error.
According to some research "Resource Busy" is normal error
On Mon, 1 Feb 2021 23:41:38 GMT, Alexander Matveev wrote:
> We did not able to run "hdiutil convert" due to hdiutil did not able to
> acquire lock on DMG image file. In this condition we got "Resource busy" from
> "hdiutil detach" and on repeated
On Mon, 22 Mar 2021 20:40:09 GMT, Andy Herrick wrote:
> JDK-8259926: Error in jpackage sample usage in the help text
Marked as reviewed by almatvee (Committer).
-
PR: https://git.openjdk.java.net/jdk/pull/3132
On Mon, 22 Mar 2021 13:03:10 GMT, Andy Herrick wrote:
> JDK-8263887: Re-create default icons
Marked as reviewed by almatvee (Committer).
-
PR: https://git.openjdk.java.net/jdk/pull/3118
On Mon, 5 Apr 2021 19:46:43 GMT, Alexey Semenyuk wrote:
> Use value of `--icon` jpackage CLI option to set icon for exe installers.
Marked as reviewed by almatvee (Committer).
-
PR: https://git.openjdk.java.net/jdk/pull/3347
301 - 400 of 501 matches
Mail list logo
