Re: RFR 8207750 : Native handle leak in java.io.WinNTFileSystem.list()

2018-07-19 Thread Bernd Eckenfels
Hello, I am not sure about the JNi conventions, but does the jObjectArray rv need to be released as local reference in some of the early returns as well? Gruss Bernd Gruss Bernd -- http://bernd.eckenfels.net Von: -1031249216m Auftrag von Gesendet: Mittwoch,

Are TimeZone instances guaranteed to be thread-safe

2018-08-31 Thread Bernd Eckenfels
Hello, I am not sure I missed it, but it looks like there is no definition in the JCL JavaDoc about instances of j.u.TimeZone (specifically SimpleTimeZone as well as instances obtained with getDefault or by Id) beeing reentrant/thread Safe or not. (There are for examplequite a few non-final

Re: Are TimeZone instances guaranteed to be thread-safe

2018-08-31 Thread Bernd Eckenfels
Ah BTW, there is a TimeZone.getTimezone(ZoneOffset.UTC) construct which can be used. The ZoneId is also immutable, but that construct does say nothing about TimeZone instance. Gruss Bernd -- http://bernd.eckenfels.net Von: Bernd Eckenfels Gesendet: Samstag

Re: [PATCH] JDK-7033681 - Improve the documentation of Arrays.asList

2018-09-06 Thread Bernd Eckenfels
List.of can be used instead now. So @see List#of and let the reader figure out when to use them? Gruss Bernd -- http://bernd.eckenfels.net Von: Jaikiran Pai Gesendet: Donnerstag, September 6, 2018 9:13 AM An: Bernd Eckenfels; core-libs-dev@openjdk.java.net Betreff: Re

Re: RFR 8196298 Add null Reader and Writer with latest changes

2018-03-06 Thread Bernd Eckenfels
Just a nit, Should append(CharSequence,int,int) also use checkFromIndexSize? Greetings Bernd -- http://bernd.eckenfels.net Von: Alan Bateman Gesendet: Dienstag, 6. März 2018 20:35 An: Patrick Reinhart; core-libs-dev Betreff: Re: RFR 8196298 Add null Reader and Writer with latest changes On

Re: JDK-8197594: String#repeat

2018-03-01 Thread Bernd Eckenfels
Hello, I would not encourage makeshift number formatting by mentioning left padding as a major usecase: Just remove that part: + * + * This method may be used to create space padding for + * formatting text or zero padding for formatting numbers. I think this error without an

Re: uploading of new code

2018-04-18 Thread Bernd Eckenfels
Hello, I would put it on a standalone Git repo on one of the public hosting sites lile.Github, especially for a first discussion (especially good if added JMH comparisions). I would not expect a id quickly/easily and a in-tree webrev could be created by sponsor for final ok. Bernd Von:

Re: RFR: 8198888: Reduce string allocation churn inInvokerBytecodeGenerator

2018-03-01 Thread Bernd Eckenfels
Another question is it safe to keep an unbounded strong reference to classes here? Maybe better Cache getName() results? -- http://bernd.eckenfels.net Von: Paul Sandoz Gesendet: Donnerstag, 1. März 2018 19:05 An: Claes Redestad Cc: core-libs-dev Betreff: Re: RFR: 819: Reduce string

Re: 8198888: Reduce string allocation churninInvokerBytecodeGenerator

2018-03-01 Thread Bernd Eckenfels
On 2018-03-01 19:39, Bernd Eckenfels wrote: > +if (nameMap == null) { > +nameMap = new HashMap<>(2); > > What is the typical size the map ends up with? If it stays this small > linearly searching an Array (or „last value“) may be faster. > > If the ma

Re: Floating Point and Arithmetic Changes for Java SE Lnguage

2018-03-02 Thread Bernd Eckenfels
Hello Anon, It is impossible to Change the Java behavior for already existing Features like the simple Floating Point types. I would not expect much in this area. There was a JSR to add a new mode, but it seems to be abandoned: https://jcp.org/en/jsr/detail?id=84 I think there was some

Re: Draft JEP proposal: JDK-8200758: Packaging Tool

2018-06-28 Thread Bernd Eckenfels
Eckenfels Cc: core-libs-dev Betreff: Re: Draft JEP proposal: JDK-8200758: Packaging Tool no you can't, --add-modules requires the module to have a module-info, being an automatic module is not good enough. regards, Rémi - Mail original - > De: "Bernd Eckenfels" > À

Re: Draft JEP proposal: JDK-8200758: Packaging Tool

2018-06-28 Thread Bernd Eckenfels
you can jlink without any/complete module info files by specifying the module names on the command line (--add-modules)as well. It produces a jre like Directory including Java launcher which allows additions on the classpath. -- https://Bernd.eckenfels.net From:

Re: Is it possible to find PDB (windows debugging info) for publishedjvm.dll?

2018-10-17 Thread Bernd Eckenfels
Sorry for offtopic – figured might still be a good Addition to the question, If you can switch the JDK (and do not yet need Java 11) then you can use the binaries from the ojdkbuild Project (Fedora/RH upstream), they provide the PDB files in the *debuginfo* packages (havent tested them myself).

Re: RFR(M) 8212605: Pure-Java implementation of AccessController.doPrivileged

2018-10-31 Thread Bernd Eckenfels
http://cr.openjdk.java.net/~dlong/8212605/webrev.1/src/java.base/share/classes/java/security/AccessController.java.udiff.html In checkContext should the security manager be null checked first instead of last to optimize for the typical case? (If the side effects in that expression are desired

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

2018-11-12 Thread Bernd Eckenfels
Hello, I wonder if in the Windows temp case LocalLow is (still) the right place. If this Installer is not started in the low context it will endanger its extracted temp file by making them accessible to low integrity processes, right? And if this should search %TEMP%., %LOCALAPPDATA%\temp

Re: JarFile constructor throws undocumented exception (only) on Windows OS

2018-10-05 Thread Bernd Eckenfels
Why does that actually throw an Exception on Linux/Unix, it is a perfectly legal file name. Gruss Bernd Gruss Bernd -- http://bernd.eckenfels.net Von: -2122936656m Auftrag von Gesendet: Freitag, Oktober 5, 2018 11:00 AM An: core-libs-dev@openjdk.java.net

Re: are there src git repositories for javase (was: core-libs-dev Digest, Vol 138, Issue 30)

2018-10-08 Thread Bernd Eckenfels
Hello, there is no official/canonical one as far as I know, but there are a few (externally maintained) Repos which are produced by mirroring the HG trees. I cannot endores any of them, but in GitHub you find: Older versions: https://github.com/openjdk-mirror SAP maintained:

Re: RFR: 8211859: (fc) Avoid initializing AtomicBooleanfromRandomAccessFile

2018-10-08 Thread Bernd Eckenfels
probably not called that often anyway) Gruss Bernd -- http://bernd.eckenfels.net Von: Bernd Eckenfels Gesendet: Montag, 8. Oktober 2018 21:28 An: core-libs-dev Betreff: AW: RFR: 8211859: (fc) Avoid initializing AtomicBooleanfromRandomAccessFile getChannel() Synchronizes only on `this` and `close

AW: RFR: 8211859: (fc) Avoid initializing AtomicBoolean fromRandomAccessFile

2018-10-08 Thread Bernd Eckenfels
getChannel() Synchronizes only on `this` and `close()` on `closeLock`. It does I guess work since the important part is make sure only one thread does the close work, however Publishing the close change to getChannel is a secondary effect of the AtomicBoolean which the new Version does not

Re: jpackage usage

2019-01-16 Thread Bernd Eckenfels
Is this a console application? I think the launcher won’t show that. So the program actually runs, it just not displays a console window. Gruss Bernd -- http://bernd.eckenfels.net Von: core-libs-dev im Auftrag von Skillzore Gaming Gesendet: Mittwoch, Januar

Re: Modular Applications - Regression

2019-01-14 Thread Bernd Eckenfels
JLink works fine with applications on the classpath, all you have to do is to list the modules needed manually (and JDeps helps with that). Gruss Bernd -- http://bernd.eckenfels.net Von: core-libs-dev im Auftrag von Scott Palmer Gesendet: Montag, Januar 14,

Re: Modular Applications - Regression

2019-01-14 Thread Bernd Eckenfels
. Januar 2019 21:21 An: Bernd Eckenfels Cc: core-libs-dev Betreff: Re: Modular Applications - Regression Aren’t you just saying that jlink works when you don’t use the stuff that broke? Can you use jlink with JAXB or JAX-WS that does not rely on the .jmod files from JDK 9 or 10? Is there a way

Re: High memory usage / leaks was: Best mailing list for JVM embedding

2019-01-22 Thread Bernd Eckenfels
I don’t think the launcher is doing this, it is the class loader, that’s nothing new. You can turn on verbose security debug to see it in all versions. -- https://Bernd.eckenfels.net Von: core-libs-dev im Auftrag von Robert Marcano Gesendet: Mittwoch, Januar

Throwable.addSuppressed again

2018-12-15 Thread Bernd Eckenfels
Hello, a while back I reported a Problem with „self Suppression“ in the context of FilterOutputStream where a „cached“ exception thrown by flush() and close() resulted in a IllegalArgumentException: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-May/026743.html This was fixed for

Re: Throwable.addSuppressed again

2018-12-15 Thread Bernd Eckenfels
Just an Addition: looks like the OOME uses already enableSuppression=true (in most? Cases) so a change to check enableSuppression before checking self-supression seems like an very effective change (if it is decided to Keep this Assertion at all). Gruss Bernd -- http://bernd.eckenfels.net

Re: 8215441: Increase uniformity of the distribution of BigIntegers constructed by BigInteger(int, Random)

2018-12-20 Thread Bernd Eckenfels
Hm strange, never saw it this way. Would other types have the same problem (should be visible in your histogram for long as well, right?) Gruss Bernd -- http://bernd.eckenfels.net Von: core-libs-dev im Auftrag von Brian Burkhalter Gesendet: Donnerstag,

DataTruncation has static message

2018-11-30 Thread Bernd Eckenfels
Hello, The java.sql.DataTruncation Exception/warning has a few detail members, especially the index of the field in question. Yet it will not be reflected in getMessage/toString. I wonder if the message should be dynamic to at least include the index (if known).

Re: RFR(S)JDK-8214074: Ghash optimization using AVX instructions

2018-11-19 Thread Bernd Eckenfels
Hello, What is the purpose of setting some of them to 0 twice? (It’s a new array which should be all-0 anyway.) + for (int i = 1; i < 9 ; i++) { +subkeyHtbl[2*i] = 0; +subkeyHtbl[2*i+1] = 0; +} Also, is the subkeyH no longer be needed (or can be redesigned

Re: can File.exists can return false if the file exists?

2019-04-04 Thread Bernd Eckenfels
Yes it can and does, the getBooleanAttributes method of the filesystem providers cannot communicate IOExceptions, so it will have to return unset flags for this’s case. (Also there are some OS specific conditions where the file stat might be stale, especially if it is a networked filesystem).

Re: LTS releases and JEP 182: Policy for Retiring javac -source and -target Options ?

2019-02-27 Thread Bernd Eckenfels
I had the same doubts about the @deprecation N+1 Policy. In both cases a „must be deprecated in at least a LTS version“ would be more conservative (but understandable very expensive) Gruss Bernd -- http://bernd.eckenfels.net Von: core-libs-dev im Auftrag von

"java.lang.Error: Probable fatal error:No fonts found" does not show on 11

2019-02-27 Thread Bernd Eckenfels
Hello, (please let me know in case I picked the wrong list.) Since OpenJDK does not ship Default *.ttf font files the change that a JRE is installed in a way that no System Fonts can be found is quite high. In OpenJDK8 it is a bit unfortunate that in this situation even for the headless

Re: "java.lang.Error: Probable fatal error:No fonts found" does not show on 11

2019-02-28 Thread Bernd Eckenfels
enfels.net Von: Philip Race Gesendet: Donnerstag, Februar 28, 2019 12:45 AM An: Bernd Eckenfels; 2d-dev Cc: awt-...@openjdk.java.net; Java Core Libs Betreff: Re: "java.lang.Error: Probable fatal error:No fonts found" does not show on 11 Wrong list. You want 2d-dev. -phil.

Re: jpackage ALL-SYSTEM

2019-03-08 Thread Bernd Eckenfels
Can you confir it works if you start your application with a stand-alone JDK? I suspect you have a custom jlink Image which misses the modules. Can you share your jpackage configuration or at least run „Java –list-modules“ and –validate-modules in your installed app? I think you Need at least

Re: jpackage ALL-SYSTEM

2019-03-08 Thread Bernd Eckenfels
Hm, we really should think about renaming --bind-services into --add-all-junk. Will using the option by default make image creation even less useful (i.e. does not safe much) in jpackage? Will there be a option to turn it off? Otherwise I guess it’s best to only support --runtime-Image method.

Re: RFR(S): 8221262: Cleanups in UnixFileSystem/WinNTFileSystem implementation classes

2019-03-22 Thread Bernd Eckenfels
Instead of removing the file path, would it be possible to add it to all implementations guarded by jdk.includeInExceptions=filename? Gruss Bernd -- http://bernd.eckenfels.net Von: core-libs-dev im Auftrag von Alan Bateman Gesendet: Freitag, März 22, 2019

Re: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

2019-02-12 Thread Bernd Eckenfels
For security reasons I would add it to `jdk.includeInExceptions`, but maybe as a default? Gruss Bernd -- http://bernd.eckenfels.net Von: core-libs-dev im Auftrag von Roger Riggs Gesendet: Dienstag, Februar 12, 2019 8:07 PM An: Lindenmaier, Goetz; Java Core

PreparedStatement.setBinaryStream Javadoc

2019-02-01 Thread Bernd Eckenfels
Hello, The JavaDoc for some of the setBinary/ASCII... methods of PS say something about „more practical“ but it is not clear if it means this method is more practical than another method, or if this method should not be used in favor of another. When a very large binary value is input to

Re: High memory usage / leaks was: Best mailing list for JVM embedding

2019-01-24 Thread Bernd Eckenfels
, Januar 24, 2019 5:26 PM An: core-libs-dev@openjdk.java.net Betreff: Re: High memory usage / leaks was: Best mailing list for JVM embedding On 1/23/19 8:59 AM, Sean Mullan wrote: > On 1/22/19 8:50 PM, Bernd Eckenfels wrote: >> I don’t think the launcher is doing this, it is the class loader,

Re: RFR 8225474: JDI connector accept fails "Address already in use" with concurrent listeners

2019-06-07 Thread Bernd Eckenfels
stopListening seems not atomically using listenMap. (Ie change get/remove to remove only) BTW this would be a good usecase for a CopyOnWriteMap... -- http://bernd.eckenfels.net Von: core-libs-dev im Auftrag von Andrew Leonard Gesendet: Freitag, Juni 7,

Re: RFR 8230365 : Pattern for a control-char matches non-control characters

2019-09-04 Thread Bernd Eckenfels
Hallo, Since not all combinations make sense (Exception+convert) a multi value might be better: jdk.regex.control=WARN|EXCEPTION|STANDARD|LEGACY With Exception generating an error, Standard beeing the planned new default (treating upper/lower same and error on all undefined chars) and legacy

Re: [JSR] [JEP] Java Specification Requirement / Java Enhancement Proposal : 'Parallel OR' and 'Parallel AND'

2019-07-24 Thread Bernd Eckenfels
Hello, I don’t think you will get a new infix operator for this. And adding it to existing operators will be acquire risky change, might not improve performance for most situations - and most of all it is quite unlikely that you have a large number of terms at static compile time anyway.

Re: RFR [14/java.xml] 8233686: XML transformer uses excessive amount of memory

2019-11-08 Thread Bernd Eckenfels
This does save object allocations and churn, not memory footprint I guess. The namespace mapping contains multiple stacks (with object arrays) and a hashtable and initialized records, so it seems to allocate a few kb on every node visited. (But 100MB allocation does sound like a very

Re: Apache Phoenix with OpenJDK

2019-10-11 Thread Bernd Eckenfels
Hello, If you can’t find the needed information on the Project Website it is probably best to contact the project on the user mailing list. https://phoenix.apache.org/mailing_list.html You might want to give more information like which component is failing, what are the exact error logs and

Re: jpackage current status

2020-02-24 Thread Bernd Eckenfels
Hello Michael, Currently the native binaries (java launcher) are not included. If you want to do that, you need to generate the jlink image first (what you need to do anyway if you want a specific version). This is kind of by design, but it looks like if this can be configured in future

Re: New candidate JEP: 371: Hidden Classes

2020-01-24 Thread Bernd Eckenfels
Hello, I wonder will this (weak class) be useful for reflective method accessors and even be able to reduce/remove the need of jdk.internal.reflect.DelegatingClassLoaders? If so, that would be a good example to mention in the JEP (it only mentions Proxies). (And I was really surprised to see

Re: RFR(S): 8240734: ModuleHashes attribute not reproducible between builds

2020-03-09 Thread Bernd Eckenfels
Hello, I wonder why there are two times the same logic in internal public static methods. Maybe that could be consolidated as well? Gruss Bernd -- http://bernd.eckenfels.net Von: core-libs-dev im Auftrag von Yangfei (Felix) Gesendet: Tuesday, March 10, 2020

Fwd: RFR: 8223187: Investigate setLocale() call in jpackage native launcher

2020-09-12 Thread Bernd Eckenfels
Hello, What about system errors (exception messages from strerr?). I mean in case one wants to enforce English version with user.locale for support reasons? Gruss Bernd -- http://bernd.eckenfels.net Von: core-libs-dev im Auftrag von Alexander Matveev

Re: jpackage OS X codesign IOException

2020-09-26 Thread Bernd Eckenfels
Looks like the codesign command is not in your PATH Gruss Bernd -- http://bernd.eckenfels.net Von: core-libs-dev im Auftrag von Michael Hall Gesendet: Saturday, September 26, 2020 1:57:06 PM An: core-libs-dev@openjdk.java.net Betreff: jpackage OS X codesign

Re: RFR: 8245527: LDAP Cnannel Binding support for Java GSS/Kerberos

2020-05-26 Thread Bernd Eckenfels
Not completely sure about which of the involved apIs have what possible extensions. Maybe we can somehow make two mechanisms one which is the compatible default and one would be the rfc compliant method. Then SASL can be configured and use different mechanism names with a new propert? That

Re: RFR: 8245527: LDAP Cnannel Binding support for Java GSS/Kerberos

2020-05-27 Thread Bernd Eckenfels
LdapCtxt: 2568 /** 2569 * Sets the read timeout value 2570 */ 2571 private void setChannelBindingType(String cbTypeProp) { Not sure if that javadoc is the right one? And I also wonder if enforcing the timeout is needed, and if yes if it should be documented why. Was not

Language locales have different calendars than country locales in 9+

2020-07-31 Thread Bernd Eckenfels
Hello, Just wanted to mention a thing I noticed when switching from 8 to 11. I knew before that the Locale data provider has changed, and I could notice that for example in the writing style for abbreviated words in dates. However something I did not expect is, that the definition of Calemdars

Re: Language locales have different calendars than country locales in 9+

2020-07-31 Thread Bernd Eckenfels
, is there any plans on how long the JRE locale provider will be available, I.e. ist it s safe bet to use it? Gruss Bernd -- http://bernd.eckenfels.net Von: naoto.s...@oracle.com Gesendet: Friday, July 31, 2020 11:24:33 PM An: Bernd Eckenfels ; core-libs-dev Betreff: Re

Re: RFR [16/java.xml] 8248348: Regression caused by the update to BCEL 6.0

2020-06-25 Thread Bernd Eckenfels
Hello, What is the advantage of having such a narrow hashcode value space compared to the built in idendity hashcode? Would stocking to the object idendity not only reduce the footprint, but also make hash lookups faster? Without the unclear relationship to the op code? Gruss Bernd --

Re: RFR [16/java.xml] 8248348: Regression caused by the update to BCEL 6.0

2020-06-27 Thread Bernd Eckenfels
it) Gruss Bernd -- http://bernd.eckenfels.net Von: Joe Wang Gesendet: Friday, June 26, 2020 8:29:41 AM An: Bernd Eckenfels ; Core-Libs-Dev Betreff: Re: RFR [16/java.xml] 8248348: Regression caused by the update to BCEL 6.0 On 6/25/2020 5:14 PM, Bernd Eckenfels wrote

Re: JNLP

2020-12-10 Thread Bernd Eckenfels
Hello, We ported a big JWS gui app to stand-alone swing with a home made installer/update mechanism. This was very easy to do (it had a main method for debugging anyway). The installer is not the most comfortable, but we can live with it since the whole application will be replaced by an web

Re: RFR: JDK-8255395 Implement Enhanced Pseudo-Random Number Generators (CSR)

2020-11-05 Thread Bernd Eckenfels
Hello, Not sure if it is needed to implement a new RandumGenerator interface instead of extending SecureRandom, but the extensions and the discovery mechanism looks good. One thing I am wondering about is if reseed() and reseed(Param) should be part of the new RandomGenerator interface as

Re: RFR: JDK-8257086: Clarify differences between {Float, Double}.equals and ==

2021-01-28 Thread Bernd Eckenfels
I like the text it’s good to mix object and value identities. I would only miss unequal behavior of NaN in the description. Gruss Bernd -- http://bernd.eckenfels.net Von: core-libs-dev im Auftrag von Joe Darcy Gesendet: Thursday, January 28, 2021 8:17:39 AM

Re: RFR: 8191441: (Process) add Readers and Writer access to java.lang.Process streams

2021-05-20 Thread Bernd Eckenfels
Hello, Hm, how is that list used? - StandardCharaet.ISO_8859_1 is a guaranteed Charset for JVM, and since the encoding is done in Java it should be fine. Added benefit is, it’s 8bit transparent. As for OS there is not a single standard charset (ebcdic vs latin families) but ASCII is probably

Re: [jdk17] RFR: 8269543: The warning for System::setSecurityManager should only appear once for each caller

2021-06-30 Thread Bernd Eckenfels
Hello, sorry for being unpopular, but I just hate it to waste developer resources, I realy think this deprecation message should be re-considered, it broke a lot of things, the amount of work to implement a caching solution feels like a waste of time and on top of it, there is no clear

Re: New candidate JEP: 400: UTF-8 by Default

2021-03-10 Thread Bernd Eckenfels
I like it. The only thing which I feel is missing would be an official API to get the operating environments default encoding (essentially to get the value used if COMPAT would have been specified). For example, in our server application, we do have some code which is specified as using

Re: New candidate JEP: 400: UTF-8 by Default

2021-03-10 Thread Bernd Eckenfels
in regards to the default constructor) -- http://bernd.eckenfels.net Von: Remi Forax Gesendet: Thursday, March 11, 2021 2:19:19 AM An: Bernd Eckenfels Cc: core-libs-dev ; jdk-dev Betreff: Re: New candidate JEP: 400: UTF-8 by Default - Mail original

Re: RFR: JDK-8262875: doccheck: empty paragraphs, etc in java.base module

2021-03-02 Thread Bernd Eckenfels
Hello, Actually, in HTML was a separator, and in xhtml it should enclose paragraphs. However I was under the impression Javadoc always used the separator style (it would be strange to start the first sentence in Javadoc with . Is this doccheck enforcing a new policy? This officially Oracle

Re: RFR: 8264208: Console charset API [v2]

2021-04-09 Thread Bernd Eckenfels
Hello, I like the API, it is useful, however not enough to replace the defaultCharset once the Change to UTF8 is done. You still need a way to query the platforms file encoding (especially on Windows). Also I wonder if the Javadoc needs to discuss platform aspects of console, especially

Re: Proposal: JDK-8231640 - (prop) Canonical property storage

2021-08-31 Thread Bernd Eckenfels
BTW it is probably not a good idea to overwrite Properties (for example to get a defined store order). Especially since changes in the past already broke this. However the attached discussion shows that people do need insert-order and/or alphabetical ordered properties — maybe a more general

Re: what does the spec say about file paths that are too long?

2021-08-25 Thread Bernd Eckenfels
I think what constitutes a „too long path“ is highly environment and data dependent. For some OS it depends on configuration, version, filesystem type, mount structure, encoding, canonicalisation and API used. Java would have a really hard time to codify this all. So the current solution „try

Re: RFR: 8272600: (test) Use native "sleep" in Basic.java [v4]

2021-09-15 Thread Bernd Eckenfels
The message should probably more along the line of be „external sleep process terminated unexpected early“. But maybe it is better to actually fail the test when true is returned as it should not happen instead of diag output? (And for diag output the exit code would be more helpful than the

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v3]

2021-09-16 Thread Bernd Eckenfels
I also wonder if it makes sense to either only serve files with public permissions, or at least Filter some critical files like .ssh/* and *.jks. Those command-line servers are often started „accidentially“ in the home directory. -- http://bernd.eckenfels.net

Re: RFR: 8272600: (test) Use native "sleep" in Basic.java [v5]

2021-09-16 Thread Bernd Eckenfels
I like it, but I think you don’t Need the %n linebreak (at least the other fail message has none) -- http://bernd.eckenfels.net Von: core-libs-dev im Auftrag von Roger Riggs Gesendet: Donnerstag, September 16, 2021 6:13 PM An: core-libs-dev@openjdk.java.net

Re: RFR: 8258117: jar tool sets the time stamp of module-info.class entries to the current time

2021-09-13 Thread Bernd Eckenfels
Is there support for repeatable builds planned? Using the source file might be acceptable, but the class file timestamp could be changing more likely for repeated builds? -- http://bernd.eckenfels.net Von: core-libs-dev im Auftrag von Jaikiran Pai Gesendet:

Re: (ch) InnocuousThread names

2021-10-16 Thread Bernd Eckenfels
by it?) * If it can skip the priveledged call as IThread does that itself. https://github.com/openjdk/jdk/blob/6765f902505fbdd02f25b599f942437cd805cad1/src/java.base/share/classes/sun/nio/ch/ThreadPool.java#L76 -- http://bernd.eckenfels.net Von: Bernd Eckenfels Gesendet

InnocuousThread names (was: [8u] RFR 8190482: InnocuousThread creation should not require the caller to possess enableContextClassLoaderOverride)

2021-10-16 Thread Bernd Eckenfels
Apropos InnocousThread backporting - I Wonder if we should remove the auto threadname infrastructure and only create properly named threads. The generic name seems to be rather confusing and it seems it is only used in an NIO Pool, where a thread-name should be set, anyway?

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v7]

2021-09-28 Thread Bernd Eckenfels
Just a nit, but how about: * For all interfaces use “-b ​​​0.0.0.0“ (IPv4) or “-b ::“ (IPv6) Instead of: * For 0.0.0.0 (all interfaces) use -b 0.0.0.0 or -b ::0 In the usage? (I think „::“ is canon?) Gruss Bernd -- http://bernd.eckenfels.net Von: net-dev

Re: Windows 10 (since Windows 10 version 1903) and Windows 11 support UTF-8 as the default codepage through an executable manifest option

2021-10-04 Thread Bernd Eckenfels
John do you know if this also switches a console window into utf8 for such a launcher? (And if so, also for a already open console?) The problem will be similar to initial jep400 that some still might need to know the legacy ansi codepage for the OS, and I guess the new method won’t give us

Re: Implementing JEP 400 on Windows 10 and Windows 11

2021-10-05 Thread Bernd Eckenfels
I think the last sentence was missing a „not“ and referring to the same manifest? However the results are a bit of a mess, but utf-8 handling for argv would be great plus (if converted correctly), right? -- http://bernd.eckenfels.net Von: core-libs-dev im

Re: a quick question about String

2021-12-23 Thread Bernd Eckenfels
new String() always creates a new instance. Gruss Bernd -- http://bernd.eckenfels.net Von: core-libs-dev im Auftrag von Alan Snyder Gesendet: Thursday, December 23, 2021 6:59:18 PM An: core-libs-dev Betreff: a quick question about String Do the public

OutputStreamWriter (not) flushing stateful Charsetencoder

2021-11-10 Thread Bernd Eckenfels
(I thought this was discussed a while back on a OpenJDK mailing list, but I can’t find it. So apologies if this is a duplicate, but I might have seen it on Apache Commons-io instead - which fixed a similar issue on reader side) The problem: I have code using a OutputStreamWriter with a

Re: RFR: JDK-8277175 : Add a parallel multiply method to BigInteger [v3]

2021-11-18 Thread Bernd Eckenfels
What about a new API multiply method which takes an forkjoinpool, and only if that is used/specified it will use the parallel mode (and only if Notsitzes threshold applies?). Most of the pool tuning can then done with this argument. It also avoids surprise threads. Gruss Bernd --

Re: RFR: JDK-8277175 : Add a parallel multiply method to BigInteger [v3]

2021-11-18 Thread Bernd Eckenfels
the performance but it does allow users to use it - majority would be crypto anyway where it can be used by the JCE and JSSE (maybe?). Gruss Bernd -- http://bernd.eckenfels.net Von: Remi Forax Gesendet: Thursday, November 18, 2021 12:16:31 PM An: Bernd Eckenfels Cc: core

Re: RFR: 8190753: (zipfs): Accessing a large entry (> 2^31 bytes) leads to a negative initial size for ByteArrayOutputStream [v8]

2021-07-22 Thread Bernd Eckenfels
Hello, > So although you can transfer the contents to the file without requiring the > access > to the byte array, you end up creating a new copy of that array (through the > use > of `baos.toByteArray()`) You can avoid the copy and the additional buffer with baos.writeTo() I think. try

Re: RFR: 8266936: Add a finalization JFR event [v4]

2021-07-27 Thread Bernd Eckenfels
Hello, I know I am a bit late, but just wanted to mention, that since finding finalizers with Bytecode analysis is doable (and probably easier to deal with such scan reports), I don’t see much value in a JFR event, especially considering it even has native code executed. (Not so sure about

Re: RFR: 8282701: Use Class.getInterfaces(false) where possible to reduce allocation pressure

2022-03-05 Thread Bernd Eckenfels
Should probably explain why it removes the private modifier? Gruss Bernd -- http://bernd.eckenfels.net Von: core-libs-dev im Auftrag von Сергей Цыпанов Gesendet: Saturday, March 5, 2022 2:14:20 PM An: core-libs-dev@openjdk.java.net Betreff: RFR: 8282701: Use

Re: Discussion about Java Floating Point?

2022-03-15 Thread Bernd Eckenfels
Please stop sending mails marked as urgent to a mailing list, you just make a fool of yourself. The need to round floating point numbers for commercial math (and the risk involved in doing so) is nothing new, it predates the IEEE standard and should be subject for even basic comp sci

Re: Should System.exit be controlled by a Scope Local?

2022-02-28 Thread Bernd Eckenfels
Alternatively you can make this “first setter wins” (either globally or per thread), then you don’t have to care or check from where the call is coming. Could be even integrated with a system property similar to the securitymanager=allow. Gruss Bernd -- http://bernd.eckenfels.net

Re: RFR: 8283411: InflaterInputStream holds on to a temporary byte array of 512 bytes

2022-03-20 Thread Bernd Eckenfels
Hello, Not sure how often skip is actually used so it might not matter, but this change would increase allocations if skip is called regularly. Not sure if EA can prevent that if it is only medium hot and therefore the callsite is not compiled or inlined? An alternative would be to make this

Re: RFR: JDK-8283668: Update IllegalFormatException to use sealed classes

2022-03-25 Thread Bernd Eckenfels
I wonder should the CSR not describe what’s the advantage of this change is and what the compatibility problems are and why they don’t apply here? Especially given the fact that the specific sub exceptions are not sealed I wonder if the risk of breaking existing code is worth it? (But I do see

Re: fast way to infer caller

2022-04-07 Thread Bernd Eckenfels
Some loggers do need to find the location of the log statement (class and line where the logger is used not where it is instantiated). for those (it makes loggers more useful) getting the call site is time critical even if they are not in tight performance critical loops. But it actually does

Re: RFR: 8285445: cannot open file "NUL:"

2022-04-22 Thread Bernd Eckenfels
Is that really a needed fix? enabling ADS and less strict parsing might introduce vulnerability but on the other hand NUL: should be allowed for it is a drive style not a ADS. I would also think the number of users who want use NUL: is smaller than the number of users who benefit from ADS

Zlib update

2022-04-21 Thread Bernd Eckenfels
Since the new upstream version for zlib 1.2.12 is available since 4 weeks and I don’t see them in GitHub (not even after April cpu merges) I wonder when is an update planned? (I also noticed at least one vendor claims to have a zlib fix, I am not yet sure if this is a vendor specific thing)

Regression after April Java 17 Update (mime types)

2022-04-25 Thread Bernd Eckenfels
Hello, We just tried to push out the Java 17 April Update but it failed with some incompatible behavior. We found out it is caused due to a new mime-type (and a bug in Apache VFS) that JAR files could no longer be opened in an overlay (technically a JAR URL suddenly had a mime-type and

Re: Regression after April Java 17 Update (mime types)

2022-04-26 Thread Bernd Eckenfels
Von: Langer, Christoph Gesendet: Tuesday, April 26, 2022 5:18:38 PM An: Bernd Eckenfels ; jdk-updates-...@openjdk.java.net Cc: core-libs-dev Betreff: RE: Regression after April Java 17 Update (mime types) Hi Bernd, I just noticed your report regarding

Re: RFR: JDK-8288207: Enhance MalformedURLException in Uri.parseCompat [v3]

2022-06-14 Thread Bernd Eckenfels
The change does not seem to be related to your description, and the description does not match the shown exception. In fact the example stacktrace contains the authority value twice and your change adds a diagnostic which is not really helpful for the case of the underscore? I would not be too

Re: RFR: 8284638: store skip buffers in InputStream Object [v2]

2022-04-13 Thread Bernd Eckenfels
If you consider doing benchmarks in detail maybe consider a static buffer, too? (Especially if it can be used in multiple implementations?) Gruss Bernd -- http://bernd.eckenfels.net Von: core-libs-dev im Auftrag von XenoAmess Gesendet: Wednesday, April 13,

Re: RFR: 8284932: [Vector API] Incorrect implementation of LSHR operator for negative byte/short elements

2022-04-17 Thread Bernd Eckenfels
Hello, Maybe offer operations which can do all variants (shift, roll, signed/unsigned) - maybe even with support for byte/int conversion? Any of those bit fiddling activities in a pipeline can benefit from vectoring. And also, the Javadoc can list the equivalent operator based code and maybe

<    1   2