RE: RFR 8143628: Fork sun.misc.Unsafe and jdk.internal.misc.Unsafe native method tables

2015-11-30 Thread Christian Tornqvist
Hi Paul, >> Tests don't think we use testng with any hotspot tests so not sure >> about that part. > >There are already quite a few, primarily in the serviceability area, search >for “testng”. We don't use testng for our runtime tests, please change these into normal jtreg tests. Thanks

Re: RFR 8143628: Fork sun.misc.Unsafe and jdk.internal.misc.Unsafe native method tables

2015-11-30 Thread Christian Tornqvist
ember 30, 2015 4:57:13 PM GMT -05:00 US/Canada Eastern Subject: Re: RFR 8143628: Fork sun.misc.Unsafe and jdk.internal.misc.Unsafe native method tables > On 30 Nov 2015, at 22:17, Christian Tornqvist > wrote: > > Hi Paul, > > >>> Tests don't think we use

RE: RFR 8143628: Fork sun.misc.Unsafe and jdk.internal.misc.Unsafe native method tables

2015-12-01 Thread Christian Tornqvist
Nov 2015, at 23:33, Paul Sandoz wrote: > > >> On 30 Nov 2015, at 23:05, Christian Tornqvist >> wrote: >> >> Because jtreg is the test framework that we use, we've been working hard to >> reduce the number of test frameworks in use. >> >

Re: RFR of JDK-8214431: tests failed because can not find removed library folder at test/jdk/lib/testlibrary/jdk/testlibrary

2018-11-28 Thread Christian Tornqvist
Hi Hamlin, Change looks good, thanks for fixing this. Thanks, Christian > On Nov 28, 2018, at 4:52 AM, Hamlin Li wrote: > > Hi David, > > Yes, they'd better be removed too, so I create another bug > https://bugs.openjdk.java.net/browse/JDK-8214435 to track it. > > With only /lib/testlibrary

RE: RFR(XXS): 8164520 - java/lang/ProcessHandle/Basic.java is missing @library tag

2016-08-20 Thread Christian Tornqvist
Hi Alan, The change that broke this was pushed to jdk9/hs yesterday, this will fix it before we integrate with jdk9/dev. Thanks, Christian -Original Message- From: Alan Bateman [mailto:alan.bate...@oracle.com] Sent: Saturday, August 20, 2016 11:22 AM To: Christian Tornqvist ; core-libs

Re: 8201226 missing JNIEXPORT / JNICALL at some places in function declarations/implementations - was : RE: missing JNIEXPORT / JNICALL at some places in function declarations/implementations

2018-04-12 Thread Christian Tornqvist
ication that the job has been started if that would help? Thanks, Christian > Would have been helpful in this situation . > > Best regards, Matthias > > >> -Original Message- >> From: Christian Tornqvist [mailto:christian.tornqv...@oracle.com] >>

Re: 8201226 missing JNIEXPORT / JNICALL at some places in function declarations/implementations - was : RE: missing JNIEXPORT / JNICALL at some places in function declarations/implementations

2018-04-12 Thread Christian Tornqvist
cement for adding a notification once the job has been handed off to our build and test farm. Thanks, Christian > > Thanks, > Iris > > -Original Message- > From: Christian Tornqvist > Sent: Thursday, April 12, 2018 6:12 AM > To: Baesken, Matthias > Cc: core

RFR: 8201609 - Split test/jdk/:tier2 to enable better parallel execution

2018-04-16 Thread Christian Tornqvist
Please review this small change that splits the tier2 test group into three smaller test groups that can be executed in parallel. Webrev: http://cr.openjdk.java.net/~ctornqvi/webrev/8201609/webrev.00/ Bug: https://bugs.openjdk.java

Re: RFR: 8201609 - Split test/jdk/:tier2 to enable better parallel execution

2018-04-16 Thread Christian Tornqvist
Hi Alan > On Apr 16, 2018, at 4:14 05PM, Alan Bateman wrote: > > On 16/04/2018 19:15, Christian Tornqvist wrote: >> Please review this small change that splits the tier2 test group into three >> smaller test groups that can be executed in parallel. >> >> W

Re: RFR: 8201609 - Split test/jdk/:tier2 to enable better parallel execution

2018-04-17 Thread Christian Tornqvist
I’ll add a comment in TEST.groups referencing these bugs > On Apr 17, 2018, at 7:01 38AM, Alan Bateman wrote: > > On 17/04/2018 11:57, Seán Coffey wrote: >> The Cipher tests were re-grouped via >> https://bugs.openjdk.java.net/browse/JDK-8132855 >> >> NIO re-grouped via https://bugs.openjdk.ja

RFR: 8202997: Split test/jdk/:tier1 to enable better parallel execution

2018-05-11 Thread Christian Tornqvist
Please review this small change that splits the test/jdk/:tier1 group into 3 parts to enable us to better execute it in parallel, also fixed the tier2 group to correctly include java/util/Arrays/TimSortStackSize2.java Webrev: http://cr.openjdk.java.net/~ctornqvi/webrev/8202997/webrev.00/

RE: RRF(XS)(10): 8176797: [TESTBUG] tools/launcher/Settings.java -Xss size is too small

2017-03-16 Thread Christian Tornqvist
Hi Chris, This looks good, thanks for fixing this. Thanks, Christian -Original Message- From: hotspot-runtime-dev [mailto:hotspot-runtime-dev-boun...@openjdk.java.net] On Behalf Of Chris Plummer Sent: Thursday, March 16, 2017 12:59 AM To: hotspot-runtime-dev ; core-libs-dev@openjdk.jav