> Supporting `IsoFields` temporal fields in chronologies that are similar to
> ISO chronology. Corresponding CSR has also been drafted.
Naoto Sato has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes b
On Tue, 19 Apr 2022 13:37:32 GMT, Roger Riggs wrote:
> Nice Catch!
+1
-
PR: https://git.openjdk.java.net/jdk/pull/8292
On Tue, 19 Apr 2022 08:50:09 GMT, Claes Redestad wrote:
> There is no pair of character values in the latin1 range (0-255) that will
> make the condition at line 401 in `StringLatin1.java` true, so this test can
> be removed.
>
> Added a test and a microbenchmark (which as expected sees a few
On Thu, 14 Apr 2022 20:52:44 GMT, Naoto Sato wrote:
> Added the test case, and eliminated the immediate hashmap value, replaced
> with the ordinal number of `Character.UnicodeScript.UNKNOWN`.
This pull request has now been integrated.
Changeset: eb9c457b
Author: Naoto Sat
> Added the test case, and eliminated the immediate hashmap value, replaced
> with the ordinal number of `Character.UnicodeScript.UNKNOWN`.
Naoto Sato has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 29 commits:
- Merge
> Supporting `IsoFields` temporal fields in chronologies that are similar to
> ISO chronology. Corresponding CSR has also been drafted.
Naoto Sato has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes b
> Added the test case, and eliminated the immediate hashmap value, replaced
> with the ordinal number of `Character.UnicodeScript.UNKNOWN`.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Fixed a typo
-
Changes:
Added the test case, and eliminated the immediate hashmap value, replaced with
the ordinal number of `Character.UnicodeScript.UNKNOWN`.
-
Depends on: https://git.openjdk.java.net/jdk/pull/7928
Commit messages:
- 8284856: Add a test case for checking UnicodeScript entity numbers
On Thu, 14 Apr 2022 18:32:03 GMT, Naoto Sato wrote:
>>> Good point! Filed an issue: https://bugs.openjdk.java.net/browse/JDK-8284856
>>
>> @stuart-marks @naotoj I can help solve JDK-8284856 after this pr. But
>> usually we only solve 1 issue in 1 pr, so I thin
On Thu, 14 Apr 2022 19:07:09 GMT, Magnus Ihse Bursie wrote:
> I ran `codespell` on the `src/java.base` directory, and accepted those
> changes where it indeed discovered real typos.
>
> (Due to false positives this can unfortunately not be run automatically)
>
> The majority of fixes are in
On Thu, 14 Apr 2022 17:06:53 GMT, XenoAmess wrote:
>> Good point! Filed an issue: https://bugs.openjdk.java.net/browse/JDK-8284856
>
>> Good point! Filed an issue: https://bugs.openjdk.java.net/browse/JDK-8284856
>
> @stuart-marks @naotoj I can help solve JDK-8284856 after this pr. But usually
On Wed, 13 Apr 2022 23:48:06 GMT, Stuart Marks wrote:
> but I suspect the cleanup may simply be removing them entirely.
+1 for removing it.
-
PR: https://git.openjdk.java.net/jdk/pull/7928
On Wed, 13 Apr 2022 22:40:38 GMT, Stuart Marks wrote:
>> XenoAmess has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update LastModified
>
> src/java.base/share/classes/java/lang/Character.java line 8574:
>
>> 8572: private
> Supporting `IsoFields` temporal fields in chronologies that are similar to
> ISO chronology. Corresponding CSR has also been drafted.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Modified class desc of `Iso
On Wed, 13 Apr 2022 16:29:11 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> revert changes in:
> src/java.desktop
> src/java.management
>
> Supporting `IsoFields` temporal fields in chronologies that are similar to
> ISO chronology. Corresponding CSR has also been drafted.
Naoto Sato has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes b
On Tue, 12 Apr 2022 06:36:29 GMT, Koichi Sakata wrote:
>> # Summary
>> Running jdeprscan with --help option causes an exception on any OSs when the
>> locale is ja, zh_CN or de.
>>
>> # How to reproduce this issue
>>
>> $ jdeprscan -J-Duser.language=ja --help
>> Exception in thread "main"
On Tue, 12 Apr 2022 03:21:00 GMT, Glavo wrote:
> `java.time.LocalDate.EPOCH` was introduced in Java 9, but there is no
> corresponding `@since` in the javadoc. The absence of `@since` makes it
> impossible for IDEs to check for misuse of it, it may be misused by users
> targeting Java 8 and
On Mon, 11 Apr 2022 05:31:49 GMT, Koichi Sakata wrote:
> # Summary
> Running jdeprscan with --help option causes an exception on any OSs when the
> locale is ja or zh_CN.
>
> # How to reproduce this issue
>
> $ jdeprscan -J-Duser.language=ja --help
> Exception in thread "main"
On Thu, 7 Apr 2022 21:20:20 GMT, Naoto Sato wrote:
> This is to upgrade the CLDR data from version 39 to version 41 which was
> released yesterday. The vast majority of the changes are basically replacing
> the CLDR data, along with tools/testcase alignments. Here is the link to CLDR
de.org/index/downloads/cldr-41
Naoto Sato has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 22 commits:
- Merge branch 'master' into cldr+
- Merge branch 'master' into cldr+
- CLDR v41 final
- CLDR v41 beta2
- Merge branch 'master' into c
On Thu, 7 Apr 2022 21:20:20 GMT, Naoto Sato wrote:
> This is to upgrade the CLDR data from version 39 to version 41 which was
> released yesterday. The vast majority of the changes are basically replacing
> the CLDR data, along with tools/testcase alignments. Here is the link to CLDR
On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato wrote:
> This is a follow-on task after deprecating the Locale constructors
> (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are
> simple replacements to Locale constructors with `Locale.of()` or Locale
&g
This is to upgrade the CLDR data from version 39 to version 41 which was
released yesterday. The vast majority of the changes are basically replacing
the CLDR data, along with tools/testcase alignments. Here is the link to CLDR
v41's release notes:
On Thu, 7 Apr 2022 00:09:58 GMT, Joe Wang wrote:
>> This is a follow-on task after deprecating the Locale constructors
>> (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are
>> simple replacements to Locale constructors with `Locale.of()` or Locale
>> constants, such
This is a follow-on task after deprecating the Locale constructors
(https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are
simple replacements to Locale constructors with `Locale.of()` or Locale
constants, such as `Locale.US`.
-
Commit messages:
- 8283698:
On Wed, 6 Apr 2022 16:48:38 GMT, Daniel Jeliński wrote:
>> src/java.base/share/classes/jdk/internal/icu/text/StringPrep.java line 63:
>>
>>> 61: * http://www.ietf.org/rfc/rfc3454.txt;>RFC 3454.
>>> 62: * StringPrep prepares Unicode strings for use in network protocols.
>>> 63: * Profiles of
On Wed, 6 Apr 2022 01:23:15 GMT, Joe Wang wrote:
>> Clean up the usages of isAssignableFrom in a few xpath and jdk/internal
>> classes where the checks were really about equality or whether they were the
>> exact class types. It was why they worked nonetheless even though some of
>> them were
On Wed, 6 Apr 2022 14:12:17 GMT, Daniel Jeliński wrote:
>> This patch adds missing `r` in `string`s
>
> Daniel Jeliński has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Revert liblcms changes
On Tue, 5 Apr 2022 23:05:47 GMT, Joe Wang wrote:
> Clean up the usages of isAssignableFrom in a few xpath and jdk/internal
> classes where the checks were really about equality or whether they were the
> exact class types. It was why they worked nonetheless even though some of
> them were
On Wed, 30 Mar 2022 12:06:39 GMT, Claes Redestad wrote:
> A few integer divisions and multiplications can be replaced with test +
> addition, leading to a decent speed-up on java.time microbenchmarks such as
> `GetYearBench`. Numbers from my local x86 workstation, seeing similar
> speed-up on
Fixes test failures caused by depending on the default locale. Specifying
explicit `Locale.US` will do.
-
Commit messages:
- 8283842: TestZoneTextPrinterParser.test_roundTripAtOverlap fails:
DateTimeParseException
Changes: https://git.openjdk.java.net/jdk/pull/8045/files
Webrev:
On Wed, 30 Mar 2022 00:43:49 GMT, Alisen Chung wrote:
> redo of 8280400
I believe
`src/jdk.localedata/share/classes/sun/util/resources/ext/CurrencyNames_zh_CN.properties`
and `test/jdk/sun/text/resources/LocaleData` have to be adjusted according to
the l10n changes.
-
PR:
On Wed, 30 Mar 2022 00:46:49 GMT, Joe Wang wrote:
>> Resets state of a Catalog instance on each matching call so that it can be
>> reused. Adjusts CatalogResolver's resolve routine so that it continues to
>> observes the PREFER feature in a resolution process. Without the adjustment,
>>
On Tue, 29 Mar 2022 16:39:50 GMT, Joe Wang wrote:
> Resets state of a Catalog instance on each matching call so that it can be
> reused. Adjusts CatalogResolver's resolve routine so that it continues to
> observes the PREFER feature in a resolution process. Without the adjustment,
>
On Tue, 29 Mar 2022 21:28:44 GMT, Naoto Sato wrote:
>> Proposing to deprecate the constructors in the `java.util.Locale` class.
>> There is already a factory method and a builder to return singletons, so
>> there is no need to have constructors anymore unless one
couraged. We cannot
> terminally deprecate those constructors for the compatibility to serialized
> objects created with older JDKs. Please see the draft CSR for more detail.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Cha
On Tue, 29 Mar 2022 15:27:28 GMT, Claes Redestad wrote:
>> In `LocalDate::ofEpochDays` we validate the epoch day input, then we also
>> validate the year derived from that value. This second validation is
>> redundant since the minimum and maximum valid epoch day line up with the
>> first and
On Mon, 28 Mar 2022 21:20:00 GMT, Alisen Chung wrote:
> This reverts commit c0aecd15ae8d7abf37901f785fccaff2317c3b23.
LGTM
-
Marked as reviewed by naoto (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/8005
On Mon, 28 Mar 2022 21:06:35 GMT, Roger Riggs wrote:
>> While it is true for completeness, I would limit the addition of new method
>> as little as possible, because there are already several ways to obtain a
>> Locale object.
>
> As with other varargs method calls, it is possible to pass an
couraged. We cannot
> terminally deprecate those constructors for the compatibility to serialized
> objects created with older JDKs. Please see the draft CSR for more detail.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
On Mon, 28 Mar 2022 17:13:44 GMT, Lance Andersen wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> New unit test. IllegalArgumentException.
>
> test/jdk/java/util/Locale/TestOf.jav
couraged. We cannot
> terminally deprecate those constructors for the compatibility to serialized
> objects created with older JDKs. Please see the draft CSR for more detail.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
couraged. We cannot
> terminally deprecate those constructors for the compatibility to serialized
> objects created with older JDKs. Please see the draft CSR for more detail.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision
On Mon, 28 Mar 2022 10:35:04 GMT, Claes Redestad wrote:
> - Add capability to ignore fields explicitly when checking for immutability
> of classes in java.time
> - Use this to avoid a test failure due the new `rules` cache in `ZoneOffset`
> - Remove `TestZoneOffset` from problem list.
Marked
On Mon, 28 Mar 2022 11:52:38 GMT, Claes Redestad wrote:
> This address a minor inefficiency in that the `ZoneRules` of any `ZoneOffset`
> (and some `ZoneRegion`s) allocate `lastRulesCache` unnecessarily.
Marked as reviewed by naoto (Reviewer).
-
PR:
On Sun, 27 Mar 2022 08:45:01 GMT, ExE Boss wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed a build failure
>
> src/java.base/share/classes/java/util/Locale.java line 819:
>
On Sat, 26 Mar 2022 11:30:53 GMT, Lance Andersen wrote:
> One suggestion As part of the PR, we should probably update
> test/jdk/java/util/Locale/LocaleTest.java. or perhaps add a new test for
> Locale.of() for completeness.
Thanks, Lance. Sure, I will add some new unit tests for the new
couraged. We cannot
> terminally deprecate those constructors for the compatibility to serialized
> objects created with older JDKs. Please see the draft CSR for more detail.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Fix
On Fri, 25 Mar 2022 01:56:33 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/sun/util/locale/provider/LocaleServiceProviderPool.java
>> line 375:
>>
>>> 373: (locale.getLanguage().isEmpty() ? "und" :
couraged. We cannot
> terminally deprecate those constructors for the compatibility to serialized
> objects created with older JDKs. Please see the draft CSR for more detail.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Added a
On Fri, 25 Mar 2022 15:16:42 GMT, Claes Redestad wrote:
>> Richard Startin prompted me to have a look at a case where java.time
>> underperforms relative to joda time
>> (https://twitter.com/richardstartin/status/1506975932271190017).
>>
>> It seems the java.time test of his suffer from
On Fri, 25 Mar 2022 15:37:36 GMT, Roger Riggs wrote:
>> Proposing to deprecate the constructors in the `java.util.Locale` class.
>> There is already a factory method and a builder to return singletons, so
>> there is no need to have constructors anymore unless one purposefully wants
>> to
On Fri, 25 Mar 2022 00:18:54 GMT, Stuart Marks wrote:
>> Proposing to deprecate the constructors in the `java.util.Locale` class.
>> There is already a factory method and a builder to return singletons, so
>> there is no need to have constructors anymore unless one purposefully wants
>> to
On Thu, 24 Mar 2022 18:21:05 GMT, Joe Wang wrote:
> The issue was caused by the difference on handling control characters between
> the parser and serializer. The parser rejected control characters while the
> serializer converted them to NCRs. The fix is for the later to be aligned
> with
Proposing to deprecate the constructors in the `java.util.Locale` class. There
is already a factory method and a builder to return singletons, so there is no
need to have constructors anymore unless one purposefully wants to create
`ill-formed` Locale objects, which is discouraged. We cannot
On Thu, 24 Mar 2022 18:21:05 GMT, Joe Wang wrote:
> The issue was caused by the difference on handling control characters between
> the parser and serializer. The parser rejected control characters while the
> serializer converted them to NCRs. The fix is for the later to be aligned
> with
On Tue, 22 Mar 2022 18:44:09 GMT, Naoto Sato wrote:
> Fixing the out-of-date number of entries in
> `Character.UnicodeBlock.NUM_ENTITIES` field. The regression test has been
> renamed and now repurposed just to examine whether the `NUM_ENTITIES`
> correctly has the `map.s
On Tue, 22 Mar 2022 17:59:15 GMT, Brent Christian wrote:
> Please review this change to the java/util/prefs/AddNodeChangeListener.jar
> test.
>
> Although the test specifies "-Djava.util.prefs.userRoot=." to ensure a fresh
> Preferences on each test run, MacOS does not seem to honor this, and
> Fixing the out-of-date number of entries in
> `Character.UnicodeBlock.NUM_ENTITIES` field. The regression test has been
> renamed and now repurposed just to examine whether the `NUM_ENTITIES`
> correctly has the `map.size()` value.
Naoto Sato has updated the pull request i
On Tue, 22 Mar 2022 21:42:04 GMT, Stuart Marks wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Comment adjusted per review suggestion
>
> src/java.base/share/classes/java/lang/Char
Fixing the out-of-date number of entries in
`Character.UnicodeBlock.NUM_ENTITIES` field. The regression test has been
renamed and now repurposed just to examine whether the `NUM_ENTITIES` correctly
has the `map.size()` value.
-
Commit messages:
- 8283465:
On Thu, 17 Mar 2022 18:10:17 GMT, Naoto Sato wrote:
> This is to incorporate the ISO 4217 amendment 171 for Sierra Leonean LEONE
> redenomination (removing 3 zeros). Its effective date is 4/1, but I went
> ahead as JDK19 won't be released by 4/1.
This pull request has now been i
This is to incorporate the ISO 4217 amendment 171 for Sierra Leonean LEONE
redenomination (removing 3 zeros). Its effective date is 4/1, but I went ahead
as JDK19 won't be released by 4/1.
-
Commit messages:
- 8283277: ISO 4217 Amendment 171 Update
Changes:
On Thu, 17 Mar 2022 00:12:38 GMT, Magnus Ihse Bursie wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module.
>> For instance, the publicsuffixlist is used by java.base, and fontconfig by
>> java.desktop. (A few directories, like mainmanifest, is *actually* used by
On Wed, 16 Mar 2022 21:56:53 GMT, Magnus Ihse Bursie wrote:
>> make/modules/jdk.charsets/Gensrc.gmk line 32:
>>
>>> 30: # Generate files using the charsetmapping tool
>>> 31: #
>>> 32: CHARSET_DATA_DIR := $(TOPDIR)/src/java.base/share/data/charsetmapping
>>
>> Is it intentional to leave
On Wed, 16 Mar 2022 18:31:55 GMT, Alisen Chung wrote:
>> msg drop for jdk19, Mar 9, 2022
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> removed incorrect translation of compiler configuration file
LGTM. Thanks for the
On Tue, 15 Mar 2022 23:50:20 GMT, Magnus Ihse Bursie wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module.
>> For instance, the publicsuffixlist is used by java.base, and fontconfig by
>> java.desktop. (A few directories, like mainmanifest, is *actually* used by
On Mon, 14 Mar 2022 20:39:46 GMT, Alisen Chung wrote:
>> msg drop for jdk19, Mar 9, 2022
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> removed repeated lines from ROOT bundle in CurrencyNames
On Sat, 12 Mar 2022 03:12:30 GMT, Alexander Matveev
wrote:
> - Fixed by adding missing ']'.
> - I changed '()' to '[]', since other error messages use '[]' and not '()'.
It is OK as it stands, but usually localized files are provided by the l10n
process, so engineers only need to modify the
On Fri, 11 Mar 2022 19:53:20 GMT, Naoto Sato wrote:
> `DecimalFormat.toLocalizedPattern()` was not honoring the monetary
> decimal/grouping separator symbols. Fix is straightforward to use the correct
> symbols depending on the formatter type.
This pull request has now been i
On Sat, 12 Mar 2022 16:27:51 GMT, Lance Andersen wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Refined the test
>
> test/jdk/java/text/Format/DecimalFormat/ToLocalizedPatt
> `DecimalFormat.toLocalizedPattern()` was not honoring the monetary
> decimal/grouping separator symbols. Fix is straightforward to use the correct
> symbols depending on the formatter type.
Naoto Sato has updated the pull request incrementally with one additional
commit since
`DecimalFormat.toLocalizedPattern()` was not honoring the monetary
decimal/grouping separator symbols. Fix is straightforward to use the correct
symbols depending on the formatter type.
-
Commit messages:
- 8282929: Localized monetary symbols are not reflected in
On Thu, 10 Mar 2022 17:55:44 GMT, Alisen Chung wrote:
>> msg drop for jdk19, Mar 9, 2022
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> moved CurrencyNames changes to jdk.localedata
On Thu, 10 Mar 2022 18:40:13 GMT, Zhengyu Gu wrote:
> Please review this small patch that fixes early `CHECK_NULL_RETURN` results
> not releasing native `jchar` array returned by `GetStringChars()`.
LGTM.
-
Marked as reviewed by naoto (Reviewer).
PR:
On Thu, 10 Mar 2022 13:33:05 GMT, Zhengyu Gu wrote:
> Please review this trivial patch to correct last parameter of
> `GetStringChars()` call, which should be a `jboolean*`, instead of `jboolean`
LGTM. Thanks for the fix!
-
Marked as reviewed by naoto (Reviewer).
PR:
On Thu, 10 Mar 2022 02:30:35 GMT, Brian Burkhalter wrote:
> Add a statement to the `java.io` package documentation clarifying how a
> `String` representing a _pathname string_ is interpreted in the package.
I believe a CSR is needed for this change?
-
PR:
On Thu, 10 Mar 2022 02:30:35 GMT, Brian Burkhalter wrote:
> Add a statement to the `java.io` package documentation clarifying how a
> `String` representing a _pathname string_ is interpreted in the package.
Looks good, Brian.
-
Marked as reviewed by naoto (Reviewer).
PR:
On Wed, 9 Mar 2022 21:09:30 GMT, Alisen Chung wrote:
> msg drop for jdk19, Mar 9, 2022
IIRC, localized resource files should have the same copyright year as the base
English one. That's what I was told by the l10n engineer when I had the same
comment.
-
PR:
On Wed, 9 Mar 2022 21:09:30 GMT, Alisen Chung wrote:
> msg drop for jdk19, Mar 9, 2022
`src/java.base/share/classes/sun/util/resources/CurrencyNames_de.properties`
`src/java.base/share/classes/sun/util/resources/CurrencyNames_ja.properties`
On Wed, 9 Mar 2022 17:55:47 GMT, Ian Graves wrote:
>> Proposed change in behavior to correct inconsistencies between `\w` and `\b`
>> metacharacters
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removing superfluous 'if'
On Tue, 8 Mar 2022 13:19:39 GMT, Jim Laskey wrote:
>> Several attempts have been made to improve Formatter's numeric performance
>> by caching the current Locale zero. Such fixes, however, ignore the real
>> issue, which is the slowness of fetching DecimalFormatSymbols. By directly
>> caching
On Mon, 7 Mar 2022 20:36:36 GMT, Jim Laskey wrote:
>> Several attempts have been made to improve Formatter's numeric performance
>> by caching the current Locale zero. Such fixes, however, ignore the real
>> issue, which is the slowness of fetching DecimalFormatSymbols. By directly
>> caching
On Mon, 7 Mar 2022 17:04:25 GMT, Joe Wang wrote:
>> Is `IsoBased` is fine with me. "isISOLike" is too vague.
>
> That matches the javadoc as well, that it "supports ISO based fields".
Renamed the new method to `isIsoBased()`. Modified the CSR accordingly.
-
PR:
On Mon, 7 Mar 2022 18:30:28 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
> Supporting `IsoFields` temporal fields in chronologies that are similar to
> ISO chronology. Corresponding CSR has also been drafted.
Naoto Sato has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes b
On Sun, 6 Mar 2022 17:12:31 GMT, Stephen Colebourne
wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addresses review comments
>
> src/java.base/share/classes/java/time/chrono/Chron
On Sun, 6 Mar 2022 15:00:47 GMT, Jaikiran Pai wrote:
>> src/java.base/share/classes/java/util/Formatter.java line 2012:
>>
>>> 2010: public final class Formatter implements Closeable, Flushable {
>>> 2011: // Caching DecimalFormatSymbols
>>> 2012: static DecimalFormatSymbols DFS = null;
> Supporting `IsoFields` temporal fields in chronologies that are similar to
> ISO chronology. Corresponding CSR has also been drafted.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Addresses review comments
-
C
On Fri, 4 Mar 2022 21:26:57 GMT, Joe Wang wrote:
> Is the public API change, adding the isIsoLike() method, necessary?
Yes, I believe so. Without a means to tell whether the `TemporalAccessor`, such
as `LocalDate`, supports `IsoFields`, `IsoFields` would have to hard-code which
temporal
On Fri, 4 Mar 2022 05:02:37 GMT, Naoto Sato wrote:
>> Supporting `IsoFields` temporal fields in chronologies that are similar to
>> ISO chronology. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional
>
On Fri, 4 Mar 2022 21:17:50 GMT, Jim Laskey wrote:
>> Several attempts have been made to improve Formatter's numeric performance
>> by caching the current Locale zero. Such fixes, however, ignore the real
>> issue, which is the slowness of fetching DecimalFormatSymbols. By directly
>> caching
On Fri, 4 Mar 2022 19:33:07 GMT, Jim Laskey wrote:
>> src/java.base/share/classes/java/util/Formatter.java line 2016:
>>
>>> 2014: static DecimalFormatSymbols getDecimalFormatSymbols(Locale
>>> locale) {
>>> 2015: DecimalFormatSymbols dfs = DFS;
>>> 2016: if (dfs != null &&
On Fri, 4 Mar 2022 17:54:20 GMT, Jim Laskey wrote:
> Several attempts have been made to improve Formatter's numeric performance by
> caching the current Locale zero. Such fixes, however, ignore the real issue,
> which is the slowness of fetching DecimalFormatSymbols. By directly caching
>
On Mon, 28 Feb 2022 23:17:57 GMT, Naoto Sato wrote:
> Fixing the definition and implementation of the pattern symbol `F`. Although
> it is an incompatible change, I believe it is worth the fix. For that, a CSR
> has been drafted.
This pull request has now been integrated.
Changeset:
> Supporting `IsoFields` temporal fields in chronologies that are similar to
> ISO chronology. Corresponding CSR has also been drafted.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
copyright year fix
-
C
On Thu, 3 Mar 2022 22:34:43 GMT, Joe Wang wrote:
>> Update BCEL md to include the copyright notice.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> remove the section that's no longer in the notice file
Marked as reviewed by
Supporting `IsoFields` temporal fields in chronologies that are similar to ISO
chronology. Corresponding CSR has also been drafted.
-
Commit messages:
- 8279185: Support for IsoFields in JapaneseDate/MinguoDate/ThaiBuddhistDate
Changes:
On Wed, 2 Mar 2022 18:56:40 GMT, Tim Prinzing wrote:
> The caller class returned by Reflection::getCallerClass was used to gain
> access to it's module in most cases and class loader in one case. I added a
> method to translate the caller class to caller module so that the decision of
> what
101 - 200 of 1638 matches
Mail list logo
