On Wed, 29 Sep 2021 17:56:49 GMT, Andrey Turbanov
wrote:
> StringBuffer is a legacy synchronized class. There are more modern
> alternatives which perform better:
> 1. Plain String concatenation should be preferred
> 2. StringBuilder is a direct replacement to StringBuffer which generally have
On Thu, 30 Sep 2021 10:10:31 GMT, Ichiroh Takiguchi
wrote:
> * Using native.encoding system property. But
> test/langtools/tools/javac/diags/CheckResourceKeys.java was failed.
What was the cause of the failure?
> * Use java.io.Console, like Console cons = System.console() and
>
On Sat, 25 Sep 2021 03:38:24 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which proposes to fix the issue
>> reported in https://bugs.openjdk.java.net/browse/JDK-8273790?
>>
>> As noted in that issue, trying to class load
>> `sun.util.calendar.CalendarSystem` and
On Tue, 21 Sep 2021 21:58:48 GMT, Claes Redestad wrote:
> This patch extends the `ISO_8859_1.implEncodeISOArray` intrinsic on x86 to
> work also for ASCII encoding, which makes for example the `UTF_8$Encoder`
> perform on par with (or outperform) similarly getting charset encoded bytes
> from
On Fri, 24 Sep 2021 14:36:07 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which proposes to fix the issue
> reported in https://bugs.openjdk.java.net/browse/JDK-8273790?
>
> As noted in that issue, trying to class load
> `sun.util.calendar.CalendarSystem` and
On Tue, 21 Sep 2021 21:45:40 GMT, Naoto Sato wrote:
> Simple doc fix.
This pull request has now been integrated.
Changeset: c4345285
Author: Naoto Sato
URL:
https://git.openjdk.java.net/jdk/commit/c43452859d7211f0d6537d71bd0df89412d4ff6f
Stats: 14 lines in 3 files changed: 0
On Wed, 22 Sep 2021 17:41:18 GMT, Roger Riggs wrote:
>> The Mac OS specific code to determine the os.version property in
>> java_props_macosx.c is updated
>> to replace the code extracting the version from the SystemVersion.plist by
>> reading the version using t\
>> he hidden link:
>
> Roger
On Wed, 22 Sep 2021 15:00:59 GMT, Roger Riggs wrote:
> The Mac OS specific code to determine the os.version property in
> java_props_macosx.c is updated
> to replace the code extracting the version from the SystemVersion.plist by
> reading the version using t\
> he hidden link:
I would think these are some left-overs from the 310 project, as I see
the same fields in 310's Hijrah chronology. These should be cleaned up.
https://github.com/ThreeTen/threetenbp/blob/master/src/main/java/org/threeten/bp/chrono/HijrahChronology.java
BTW, it would be moot once they are gone,
On Tue, 21 Sep 2021 12:47:00 GMT, Naoto Sato wrote:
> Fixing an AIOOBE on normalizing the month value.
This pull request has now been integrated.
Changeset: d39aad92
Author: Naoto Sato
URL:
https://git.openjdk.java.net/jdk/commit/d39aad92308fbc28bd2de164e331062ebf62da85
St
> Fixing an AIOOBE on normalizing the month value.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Removed the unnecessary space
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/5611/files
- new: ht
On Tue, 21 Sep 2021 22:03:30 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed the unnecessary space
>
> src/java.base/share/classes/sun/util/calendar/BaseCal
Simple doc fix.
-
Commit messages:
- 8273546: DecimalFormat documentation contains literal HTML character
references
Changes: https://git.openjdk.java.net/jdk/pull/5620/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=5620=00
Issue:
On Tue, 21 Sep 2021 18:14:17 GMT, Roger Riggs wrote:
> Correct the check if any field has been appended to the StringBuilder in
> ProcessHandleImpl.Info.toString().
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5618
Fixing an AIOOBE on normalizing the month value.
-
Commit messages:
- 8273924: ArrayIndexOutOfBoundsException thrown in
java.util.JapaneseImperialCalendar.add()
Changes: https://git.openjdk.java.net/jdk/pull/5611/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=5611=00
On Thu, 16 Sep 2021 01:08:45 GMT, Naoto Sato wrote:
> Fixing failing regression tests caused by the JEP 400: UTF-8 by Default.
>
> `JcmdOutputEncodingTest` test case uses `file.encoding=UTF-8` in `C` locale.
> The output from the agent library is in `UTF-8` so it succeeded befor
Fixing failing regression tests caused by the JEP 400: UTF-8 by Default.
`JcmdOutputEncodingTest` test case uses `file.encoding=UTF-8` in `C` locale.
The output from the agent library is in `UTF-8` so it succeeded before the JEP
has been implemented, as System.out used `UTF-8` converter. After
On Thu, 9 Sep 2021 23:29:24 GMT, Naoto Sato wrote:
> Small spec clarification. Corresponding CSR has also been drafted.
This pull request has now been integrated.
Changeset: 31667daa
Author: Naoto Sato
URL:
https://git.openjdk.java.net/jdk/com
On Thu, 2 Sep 2021 19:26:12 GMT, Naoto Sato wrote:
> Simple spec clarification. A CSR has also been drafted
> (https://bugs.openjdk.java.net/browse/JDK-8273296).
This pull request has now been integrated.
Changeset: 4cfa230e
Author: Naoto Sato
URL:
https://git.openjdk.java.n
On Fri, 10 Sep 2021 20:53:35 GMT, Joe Wang wrote:
>> Hi Naoto,
>>
>> A couple of questions:
>>
>> - Are there any scenarios where invoking setProperty will not override the
>> command line setting ?
>> - Did you consider an `@ImplNote` for your clarification given the behavior
>> "might" be
On Fri, 10 Sep 2021 20:57:34 GMT, Ian Graves wrote:
>> The duplicate condition in this chain of expressions needs to be shrunk to
>> drop a couple of character that are not excluded spacing marks.
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the
On Fri, 10 Sep 2021 18:11:37 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflecting review comment.
>
> src/java.base/share/classes/java/util/spi/LocaleServicePro
> Small spec clarification. Corresponding CSR has also been drafted.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Reflecting review comment.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/5457/files
-
On Tue, 7 Sep 2021 18:18:49 GMT, Naoto Sato wrote:
> Please review the fix to the issue. Avoiding overflow by not calling
> nanosUntil() directly, which will overflow beyond Long.MAX_VALUE difference
> in nano unit.
This pull request has now been integrated.
Changeset: 81d2ac
> Simple spec clarification. A CSR has also been drafted
> (https://bugs.openjdk.java.net/browse/JDK-8273296).
Naoto Sato has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/
On Thu, 9 Sep 2021 23:54:25 GMT, Brian Burkhalter wrote:
>> Modify the class level specification of `java.io.FilterInputStream` to be
>> more exact about `java.io.InputStream` methods that it overrides.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional
Small spec clarification. Corresponding CSR has also been drafted.
-
Commit messages:
- 8273491: java.util.spi.LocaleServiceProvider spec contains statement that is
too strict
Changes: https://git.openjdk.java.net/jdk/pull/5457/files
Webrev:
On Wed, 8 Sep 2021 22:15:12 GMT, Naoto Sato wrote:
> The gist of the issue is that the test case now always creates the boot
> classpath with non-ASCII chars appended, because the default encoding is
> fixed to UTF-8 with the fix to JDK-8260265.
>
> On macOS, javaagent tries to
On Wed, 8 Sep 2021 23:38:38 GMT, David Holmes wrote:
> Pre-existing: The initialization logic in this code is quite odd for the case
> when no conversion is necessary (we call `utfInitialize` on every call to
> `convertUtf8ToPlatformString`!), but I assume we do not call
>
On Wed, 8 Sep 2021 22:15:12 GMT, Naoto Sato wrote:
> The gist of the issue is that the test case now always creates the boot
> classpath with non-ASCII chars appended, because the default encoding is
> fixed to UTF-8 with the fix to JDK-8260265.
>
> On macOS, javaagent tries to
The gist of the issue is that the test case now always creates the boot
classpath with non-ASCII chars appended, because the default encoding is fixed
to UTF-8 with the fix to JDK-8260265.
On macOS, javaagent tries to load the class with US-ASCII determined by
nl_langinfo() (in
On Wed, 8 Sep 2021 20:24:31 GMT, Ian Graves wrote:
> The duplicate condition in this chain of expressions needs to be shrunk to
> drop a couple of character that are not excluded spacing marks.
The copyright year in Grapheme.java should be 2021, otherwise looks good.
-
Marked as
On Wed, 8 Sep 2021 19:31:46 GMT, Roger Riggs wrote:
>> The ExecCommand test of Runtime.exec is difficult to maintain; the parallel
>> arrays are hard to keep in sync.
>> This cleanup converts to use TestNG DataProviders and other improvements.
>
> Roger Riggs has updated the pull request with a
On Wed, 8 Sep 2021 15:35:27 GMT, Stephen Colebourne
wrote:
> `toEpochMilli()` overflows at large/small values. Thus any attempt to
> calculate the difference between two very large instants would fail.
Thanks. Fixed.
-
PR: https://git.openjdk.java.net/jdk/pull/5396
> Please review the fix to the issue. Avoiding overflow by not calling
> nanosUntil() directly, which will overflow beyond Long.MAX_VALUE difference
> in nano unit.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
On Wed, 8 Sep 2021 13:58:59 GMT, Stephen Colebourne
wrote:
> This change looks fine, but I think you also need a `millisUntil` private
> method to fix the identical overflow problem with millis (which might as well
> be fixed now).
`until()` for millis simply subtracts its `toEpochMilli()`
> Simple spec clarification. A CSR has also been drafted
> (https://bugs.openjdk.java.net/browse/JDK-8273296).
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Refined wordings.
-
Changes:
- all:
On Wed, 8 Sep 2021 00:15:46 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Moved the constant to LocalTime for consistency.
>
> test/jdk/java/time/test/java/time/TestIn
> Please review the fix to the issue. Avoiding overflow by not calling
> nanosUntil() directly, which will overflow beyond Long.MAX_VALUE difference
> in nano unit.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Added
On Wed, 1 Sep 2021 16:37:24 GMT, Roger Riggs wrote:
> The ExecCommand test of Runtime.exec is difficult to maintain; the parallel
> arrays are hard to keep in sync.
> This cleanup converts to use TestNG DataProviders and other improvements.
LGTM.
> Please review the fix to the issue. Avoiding overflow by not calling
> nanosUntil() directly, which will overflow beyond Long.MAX_VALUE difference
> in nano unit.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Moved the
> Please review the fix to the issue. Avoiding overflow by not calling
> nanosUntil() directly, which will overflow beyond Long.MAX_VALUE difference
> in nano unit.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
On Tue, 7 Sep 2021 18:46:56 GMT, Roger Riggs wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added a constant for nanos per micro.
>
> src/java.base/share/classes/java/time/Inst
> Please review the fix to the issue. Avoiding overflow by not calling
> nanosUntil() directly, which will overflow beyond Long.MAX_VALUE difference
> in nano unit.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Added a
Please review the fix to the issue. Avoiding overflow by not calling
nanosUntil() directly, which will overflow beyond Long.MAX_VALUE difference in
nano unit.
-
Commit messages:
- 8273369: Computing micros between two instants unexpectedly overflows for
some cases
Changes:
On Tue, 7 Sep 2021 11:26:01 GMT, Masanori Yano wrote:
>> Hi all,
>>
>> Could you please review the 8269373 bug fixes?
>>
>> These tests call java.lang.ProcessBuilder in direct, so not used jtreg
>> command option. To run non-localized tests, -Duser.language=en and
>> -Duser.country=US
It does look incorrect. I will take a look.
Naoto
On 9/6/21 12:16 AM, Andrey Turbanov wrote:
Hello.
I found suspicious condition in the method
java.util.regex.Grapheme#isExcludedSpacingMark
It's detected by IntelliJ IDEA inspection 'Condition is covered by
further condition'
On Fri, 3 Sep 2021 13:22:54 GMT, Сергей Цыпанов
wrote:
> Current implementation looks like this:
>
> public byte[] getBytes(String charsetName)
> throws UnsupportedEncodingException {
> if (charsetName == null) throw new NullPointerException();
> return
Simple spec clarification. A CSR has also been drafted
(https://bugs.openjdk.java.net/browse/JDK-8273296).
-
Commit messages:
- 8273259: Character.getName doesn't follow Unicode spec for ideographs
Changes: https://git.openjdk.java.net/jdk/pull/5354/files
Webrev:
On Wed, 1 Sep 2021 19:26:17 GMT, Lance Andersen wrote:
> Hi,
>
> Please review this trivial fix to the javadoc which addresses an issue shown
> via Intellij where the error: "Symbol 'getAdler' is inaccessible from here"
> is generated for the "@See Inflater#getAlder" references.
>
> Best
>
On Wed, 1 Sep 2021 17:33:13 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList
> java/lang/instrument/BootClassPath/BootClassPathTest.sh on all configs.
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5337
On Wed, 1 Sep 2021 06:45:26 GMT, Wu Yan wrote:
> Hi,
> Please help me review the change to enhance getting time zone ID from
> /etc/localtime on linux.
>
> We use `realpath` instead of `readlink` to obtain the link name of
> /etc/localtime, because `readlink` can only read the value of a
On Tue, 31 Aug 2021 19:44:08 GMT, Daniel D. Daugherty
wrote:
> Trivial fixes to reduce the noise in the JDK18 CI:
> JDK-8273197 ProblemList 2 jtools tests due to JDK-8273187
> JDK-8273198 ProblemList
> java/lang/instrument/BootClassPath/BootClassPathTest.sh due to JDK-8273188
>
> These
On Thu, 8 Jul 2021 21:23:00 GMT, Naoto Sato wrote:
> This is an implementation for the `JEP 400: UTF-8 by Default`. The gist of
> the changes is `Charset.defaultCharset()` returning `UTF-8` and
> `file.encoding` system property being added in the spec, but another notable
>
> CSR: https://bugs.openjdk.java.net/browse/JDK-8260266
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Fixed a failing test
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/4733/files
- new: https://git.openj
> CSR: https://bugs.openjdk.java.net/browse/JDK-8260266
Naoto Sato has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains 15 additional commits since the
la
On Wed, 4 Aug 2021 07:25:06 GMT, Masanori Yano wrote:
>> Hi all,
>>
>> Could you please review the 8269373 bug fixes?
>>
>> These tests call java.lang.ProcessBuilder in direct, so not used jtreg
>> command option. To run non-localized tests, -Duser.language=en and
>> -Duser.country=US
On Mon, 23 Aug 2021 16:42:03 GMT, Naoto Sato wrote:
> Please review the fix to the subject issue. When instant seconds and zone
> co-exist in parsed data, instant seconds was not resolved correctly from them.
This pull request has now been integrated.
Changeset: fe7d7088
Author: Naot
On Mon, 23 Aug 2021 21:01:48 GMT, Andrey Turbanov
wrote:
> Collections.sort is just a wrapper, so it is better to use an instance method
> directly.
java.time changes look good.
-
Marked as reviewed by naoto (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5229
Please review the fix to the subject issue. When instant seconds and zone
co-exist in parsed data, instant seconds was not resolved correctly from them.
-
Commit messages:
- 8272473: Parsing epoch seconds at a DST transition with a non-UTC parser is
wrong
Changes:
On Wed, 4 Aug 2021 07:25:06 GMT, Masanori Yano wrote:
>> Hi all,
>>
>> Could you please review the 8269373 bug fixes?
>>
>> These tests call java.lang.ProcessBuilder in direct, so not used jtreg
>> command option. To run non-localized tests, -Duser.language=en and
>> -Duser.country=US
On Wed, 18 Aug 2021 20:59:20 GMT, Andrey Turbanov
wrote:
> remove redundant if
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5171
On 8/18/21 2:03 PM, Simon Nash wrote:
I am the developer of a fairly large application that uses file I/O
extensively. In most cases, the charset should be UTF-8 and I have used
an explicit charset parameter on all method invocations where this
applies. In some cases, the charset needs to be
> CSR: https://bugs.openjdk.java.net/browse/JDK-8260266
Naoto Sato has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains 12 additional commits since the
On Thu, 12 Aug 2021 17:43:48 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review the fix for JDK-8263940 to address an issues when the default
> file system provider is packaged as JAR file on class path.
>
> The patch also addresses the `@bug` line for JDK-8271194
>
> Mach5 Tier1 - Tier3
On Wed, 11 Aug 2021 21:40:52 GMT, Claes Redestad wrote:
>> In #4738 we removed the `checkIndex(value, count)` call in `ASB.charAt` to
>> avoid potentially getting two bounds checks in the UTF-16 case. Problem is
>> this optimization cause a regression since `StringUTF16.charAt(..)` checks
>>
On Tue, 10 Aug 2021 05:08:54 GMT, Sergey Bylokhov wrote:
> This is the continuation of JDK-8233884 and JDK-8271456. This change affects
> fewer cases so I fix all "java." modules at once.
>
> In many places standard charsets are looked up via their names, for example:
>
On Wed, 11 Aug 2021 14:26:32 GMT, Claes Redestad wrote:
> In #4738 we removed the `checkIndex(value, count)` call in `ASB.charAt` to
> avoid potentially getting two bounds checks in the UTF-16 case. Problem is
> this optimization cause a regression since `StringUTF16.charAt(..)` checks
>
On Tue, 10 Aug 2021 05:08:54 GMT, Sergey Bylokhov wrote:
> This is the continuation of JDK-8233884 and JDK-8271456. This change affects
> fewer cases so I fix all "java." modules at once.
>
> In many places standard charsets are looked up via their names, for example:
>
On Fri, 6 Aug 2021 16:39:34 GMT, Naoto Sato wrote:
> Please review the fix to the subject issue. The root cause of this problem is
> that the currency for the country code `XK` is undefined because the country
> code is user-defined in the ISO 3166 standard. However, it is comm
Please review the fix to the subject issue. The root cause of this problem is
that the currency for the country code `XK` is undefined because the country
code is user-defined in the ISO 3166 standard. However, it is commonly used to
represent the region `Kosovo`, which CLDR supports and
On Thu, 5 Aug 2021 21:36:58 GMT, Jonathan Gibbons wrote:
>> src/jdk.hotspot.agent/share/man/jhsdb.1 line 1:
>>
>>> 1: .\" Copyright (c) 2019, 2020, Oracle and/or its affiliates. All rights
>>> reserved.
>>
>> This seems not correct?
>
> According to the comments in the makefile
>
On Thu, 5 Aug 2021 19:20:50 GMT, Jonathan Gibbons wrote:
> Please review a semi-automatic update of the nroff man pages from the
> upstream files.
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.java.net/jdk17/pull/303
On Thu, 5 Aug 2021 19:20:50 GMT, Jonathan Gibbons wrote:
> Please review a semi-automatic update of the nroff man pages from the
> upstream files.
src/jdk.hotspot.agent/share/man/jhsdb.1 line 1:
> 1: .\" Copyright (c) 2019, 2020, Oracle and/or its affiliates. All rights
> reserved.
This
On Wed, 4 Aug 2021 07:25:06 GMT, Masanori Yano wrote:
>> Hi all,
>>
>> Could you please review the 8269373 bug fixes?
>>
>> These tests call java.lang.ProcessBuilder in direct, so not used jtreg
>> command option. To run non-localized tests, -Duser.language=en and
>> -Duser.country=US
On Fri, 30 Jul 2021 15:43:52 GMT, Lance Andersen wrote:
>> Hi,
>>
>> As discussed in the
>> https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-July/079621.html
>> thread, this is the revised patch to address the use of '.' and '..' within
>> Zip FS
>>
>> Zip FS needs to use "." and
On Thu, 29 Jul 2021 18:21:07 GMT, Lance Andersen wrote:
>> Hi,
>>
>> As discussed in the
>> https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-July/079621.html
>> thread, this is the revised patch to address the use of '.' and '..' within
>> Zip FS
>>
>> Zip FS needs to use "." and
On Thu, 29 Jul 2021 19:05:58 GMT, Roger Riggs wrote:
> Improve the clarity of comments in the ObjectInputFilter FilterInThread
> example.
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.java.net/jdk17/pull/293
On Wed, 28 Jul 2021 17:51:31 GMT, Daniel D. Daugherty
wrote:
> 8271412: ProblemList javax/sound/midi/Sequencer/Looping.java
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.java.net/jdk17/pull/291
On Fri, 23 Jul 2021 17:27:27 GMT, Naoto Sato wrote:
> Please review this PR to introduce `java.time.Duration.isPositive()` method.
> A CSR is also drafted.
This pull request has now been integrated.
Changeset: efa63dc1
Author: Naoto Sato
URL:
https://git.openjdk.java.net/jdk/
On Fri, 23 Jul 2021 19:37:44 GMT, Stephen Colebourne
wrote:
>> Please review this PR to introduce `java.time.Duration.isPositive()` method.
>> A CSR is also drafted.
>
> src/java.base/share/classes/java/time/Duration.java line 596:
>
>> 594: */
>> 595: public boolean isPositive() {
On Fri, 23 Jul 2021 17:27:27 GMT, Naoto Sato wrote:
> Please review this PR to introduce `java.time.Duration.isPositive()` method.
> A CSR is also drafted.
Thanks, Roger. Modified the CSR as suggested.
-
PR: https://git.openjdk.java.net/jdk/pull/4892
Please review this PR to introduce `java.time.Duration.isPositive()` method. A
CSR is also drafted.
-
Commit messages:
- 8171382: java.time.Duration missing isPositive method
Changes: https://git.openjdk.java.net/jdk/pull/4892/files
Webrev:
On Wed, 23 Dec 2020 16:06:30 GMT, Andrey Turbanov
wrote:
> I propose to remove 'null' assignment of field CompactByteArray.values in
> `expand` method. In the next statement this field is overridden with another
> value - `tempArray`.
> This code was there from initial load of OpenJDK
On Mon, 19 Jul 2021 21:18:42 GMT, Joe Darcy wrote:
> Given changes in JLS 9.6.4.1, JDK-8261610 in Java SE 17, the statements about
> annotation applicability made in java.lang.annotation.Target need to be
> updated to match.
>
> Please also review the corresponding CSR:
>
On Mon, 28 Jun 2021 20:50:42 GMT, Ian Graves wrote:
> 8199594: Add doc describing how (?x) ignores spaces in character classes
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4618
> CSR: https://bugs.openjdk.java.net/browse/JDK-8260266
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Removed leftover `console` references in `PrintStream`
-
Changes:
- all: https://git.openjdk.jav
On Wed, 14 Jul 2021 20:52:54 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/io/Console.java line 587:
>>
>>> 585: try {
>>> 586: cs = Charset.forName(csname);
>>> 587: } catch (Exception ign
On Wed, 14 Jul 2021 21:03:53 GMT, Roger Riggs wrote:
>> That was intentional. Only those two are supported, others continue to work
>> as before (but not supported).
>
> Still it leaves an uncomfortable feeling, perhaps remedied by an "other
> values have unspecified behavior"
> or the "other
> CSR: https://bugs.openjdk.java.net/browse/JDK-8260266
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Reflects comments
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/4733/files
- new: https://git.openj
On Wed, 14 Jul 2021 16:20:28 GMT, Jesse Glick
wrote:
>> src/java.base/share/classes/java/io/PrintStream.java line 49:
>>
>>> 47: * All characters printed by a {@code PrintStream} are converted
>>> into
>>> 48: * bytes using the given encoding or charset, or the default
>>> 49: * console
> CSR: https://bugs.openjdk.java.net/browse/JDK-8260266
Naoto Sato has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains three additional commits since
On Wed, 14 Jul 2021 14:55:39 GMT, Roger Riggs wrote:
>> Naoto Sato has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three addi
On Wed, 14 Jul 2021 12:39:46 GMT, Giacomo Baso
wrote:
> > Consider an application that creates a java.io.FileWriter with its
> > one-argument constructor and then uses it to write some text to a file. The
> > resulting file will contain a sequence of bytes encoded using the default
> >
This is an implementation for the `JEP 400: UTF-8 by Default`. The gist of the
changes is `Charset.defaultCharset()` returning `UTF-8` and `file.encoding`
system property being added in the spec, but another notable modification is in
`java.io.PrintStream` where it continues to use the
On Wed, 7 Jul 2021 19:05:14 GMT, Roger Riggs wrote:
> The test java/lang/ProcessBuilder/Basic.java continues to fail intermittently
> with unexpected output from the VM.
> It appears that destroying the process causes a vm thread to fail to be
> started.
> Extend the delay between starting the
On Fri, 2 Jul 2021 16:58:18 GMT, Brian Burkhalter wrote:
>> Modify the specification of
>> `java.io.ByteArrayInputStream#read(byte[],int,int)` to indicate that `-1` is
>> returned instead of `0` when the stream is at its end and the third
>> parameter, `len`, is zero.
>
> Brian Burkhalter has
On Fri, 2 Jul 2021 16:55:18 GMT, Brian Burkhalter wrote:
>> Modify the specification of
>> `java.io.ByteArrayInputStream#read(byte[],int,int)` to indicate that `-1` is
>> returned instead of `0` when the stream is at its end and the third
>> parameter, `len`, is zero.
>
> Brian Burkhalter has
On Wed, 30 Jun 2021 21:38:43 GMT, Naoto Sato wrote:
> A trivial typo fix.
This pull request has now been integrated.
Changeset: 54dd510b
Author: Naoto Sato
URL:
https://git.openjdk.java.net/jdk17/commit/54dd510bd5211dc440285dd53ca0e41c85e23552
Stats: 1 line in 1 file changed
On Mon, 28 Jun 2021 16:57:15 GMT, Naoto Sato wrote:
> Please review this small doc change to the system property. Accompanying CSR
> has also been created.
This pull request has now been integrated.
Changeset: 3e022247
Author: Naoto Sato
URL:
https://git.openjdk.java.net
401 - 500 of 1638 matches
Mail list logo
