A trivial typo fix.
-
Commit messages:
- 8269704: Typo in j.t.Normalizer.normalize()
Changes: https://git.openjdk.java.net/jdk17/pull/187/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk17=187=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8269704
Stats: 1 line in
On Fri, 25 Jun 2021 12:10:18 GMT, Masanori Yano wrote:
> Hi all,
>
> Could you please review the 8269373 bug fixes?
>
> These tests call java.lang.ProcessBuilder in direct, so not used jtreg
> command option. To run non-localized tests, -Duser.language=en and
> -Duser.country=US options
> Please review this small doc change to the system property. Accompanying CSR
> has also been created.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Missed one.
-
Changes:
- all: https://git.openjdk.java.net
On Mon, 28 Jun 2021 18:37:34 GMT, Naoto Sato wrote:
>> Please review this small doc change to the system property. Accompanying CSR
>> has also been created.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
&
> Please review this small doc change to the system property. Accompanying CSR
> has also been created.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Refined wording #2.
-
Changes:
- all: https://git.openjdk.ja
> Please review this small doc change to the system property. Accompanying CSR
> has also been created.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Refined wording.
-
Changes:
- all: https://git.openjdk.ja
Please review this small doc change to the system property. Accompanying CSR
has also been created.
-
Commit messages:
- 8269513: Clarify the spec wrt `useOldISOCodes` system property
Changes: https://git.openjdk.java.net/jdk17/pull/163/files
Webrev:
On Fri, 25 Jun 2021 20:04:37 GMT, Weijun Wang wrote:
> More refactoring to limit the scope of `@SuppressWarnings` annotations.
>
> Sometimes I introduce new methods. Please feel free to suggest method names
> you like to use.
LGTM.
-
Marked as reviewed by naoto (Reviewer).
PR:
On Fri, 25 Jun 2021 20:47:21 GMT, Brian Burkhalter wrote:
>> Modify `java.io.ByteArrayInputStream` methods `read(byte[])` and
>> `read(byte[],int,int)` to return zero per the `InputStream` specification
>> when the byte array actual or specified length is zero.
>
> Brian Burkhalter has
On Mon, 21 Jun 2021 18:22:26 GMT, Naoto Sato wrote:
> Please review this doc clarification fix to `toDaysPart()` method. CSR will
> also be filed accordingly.
This pull request has now been integrated.
Changeset: 223759fb
Author: Naoto Sato
URL:
https://git.openjdk.java.n
On Fri, 25 Jun 2021 01:39:21 GMT, Brian Burkhalter wrote:
>> Modify `java.io.ByteArrayInputStream` methods `read(byte[])` and
>> `read(byte[],int,int)` to return zero per the `InputStream` specification
>> when the byte array actual or specified length is zero.
>
> Brian Burkhalter has updated
On Thu, 24 Jun 2021 21:41:48 GMT, Joe Wang wrote:
>> Fix a regression caused by the previous BCEL update. The issue was fixed in
>> the current BCEL repo with a reversal of the previous code, adding back
>> "gos.close();". Note however, doing so will result in a warning: [try]
>> explicit
On Thu, 24 Jun 2021 20:01:27 GMT, Brian Burkhalter wrote:
> Merge identical Unix and Windows versions of FileOutputStream_md.c into
> single, common FileOutputStream.c.
Fine by me.
-
Marked as reviewed by naoto (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/4589
On Thu, 24 Jun 2021 20:36:29 GMT, Joe Wang wrote:
> Fix a regression caused by the previous BCEL update. The issue was fixed in
> the current BCEL repo with a reversal of the previous code, adding back
> "gos.close();". Note however, doing so will result in a warning: [try]
> explicit call to
On Thu, 24 Jun 2021 20:01:27 GMT, Brian Burkhalter wrote:
> Merge identical Unix and Windows versions of FileOutputStream_md.c into
> single, common FileOutputStream.c.
Looks good. Would you consider removing `fos_fd` and passing it as a `jlong` as
suggested in the issue?
-
PR:
On Thu, 24 Jun 2021 18:43:00 GMT, Brian Burkhalter wrote:
>> Augment the specification of
>> `java.io.File.createTempFile(String,String,File)` to clarify its behavior
>> with respect to the `File` parameter `directory`.
>
> Brian Burkhalter has refreshed the contents of this pull request, and
On Wed, 23 Jun 2021 23:02:01 GMT, Brian Burkhalter wrote:
>> Augment the specification of
>> `java.io.File.createTempFile(String,String,File)` to clarify its behavior
>> with respect to the `File` parameter `directory`.
>
> Brian Burkhalter has updated the pull request incrementally with one
On Thu, 24 Jun 2021 12:01:04 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review the second half of my update for the `java.time`
>> package to make use of switch expressions?
>>
>> This PR was split into two parts due to the large number of files affected.
>>
>> Kind
On Wed, 23 Jun 2021 07:34:06 GMT, Masanori Yano wrote:
>> Hi all,
>>
>> Could you please review the 8268457 bug fixes?
>>
>> The problem is that ToHTMLStream applies processing for non-surrogate pairs
>> to the surrogate pair.
>> This fix changes the processing for non-surrogate pairs to the
On Wed, 23 Jun 2021 00:06:25 GMT, Brian Burkhalter wrote:
> Augment the specification of
> `java.io.File.createTempFile(String,String,File)` to clarify its behavior
> with respect to the `File` parameter `directory`.
Looks good. Do we have a test case that verifies the behavior?
On Tue, 22 Jun 2021 17:50:05 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review the second half of my update for the `java.time`
>> package to make use of switch expressions?
>>
>> This PR was split into two parts due to the large number of files affected.
>>
>> Kind
On Wed, 23 Jun 2021 10:39:06 GMT, Patrick Concannon
wrote:
>> src/java.base/share/classes/java/time/Instant.java line 562:
>>
>>> 560: public int get(TemporalField field) {
>>> 561: if (field instanceof ChronoField) {
>>> 562: return switch ((ChronoField) field) {
>>
On Tue, 22 Jun 2021 16:18:11 GMT, Roger Riggs wrote:
>> Add java.util.Objects.newIdentity to supply a unique object with identity.
>> This is a replacement code can be used today for the traditional new
>> Object() idiom, which will be deprecated under Project Valhalla.
>> Refer to [JEP 401:
On Tue, 22 Jun 2021 16:07:12 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review the second half of my update for the `java.time`
>> package to make use of switch expressions?
>>
>> This PR was split into two parts due to the large number of files affected.
>>
>> Kind
On Tue, 22 Jun 2021 09:58:55 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.time`
>> packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull request with a new
Please review this doc clarification fix to `toDaysPart()` method. CSR will
also be filed accordingly.
-
Commit messages:
- 8266901: Clarify the method description of Duration.toDaysPart()
Changes: https://git.openjdk.java.net/jdk/pull/4542/files
Webrev:
On Fri, 18 Jun 2021 04:56:06 GMT, Masanori Yano wrote:
>> Hi all,
>>
>> Could you please review the 8268457 bug fixes?
>>
>> The problem is that ToHTMLStream applies processing for non-surrogate pairs
>> to the surrogate pair.
>> This fix changes the processing for non-surrogate pairs to the
On Thu, 17 Jun 2021 22:03:46 GMT, Joe Wang wrote:
>> The issue was that the attribute was processed before the variable was set
>> (e.g. m_preserveSpaces.push). Reversing the order fixed it.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last
On Thu, 17 Jun 2021 16:13:49 GMT, Joe Wang wrote:
> The issue was that the attribute was processed before the variable was set
> (e.g. m_preserveSpaces.push). Reversing the order fixed it.
Looks good overall. Some minor comments in the test.
On Fri, 11 Jun 2021 12:42:35 GMT, Masanori Yano wrote:
> Hi all,
>
> Could you please review the 8268457 bug fixes?
>
> The problem is that ToHTMLStream applies processing for non-surrogate pairs
> to the surrogate pair.
> This fix changes the processing for non-surrogate pairs to the else
On Tue, 15 Jun 2021 18:05:18 GMT, Joe Darcy wrote:
> The javadoc of AutoCloseable.close is from JDK 7 and thus predates tags like
> @apiNote. However, some of the discussion contained in AutoCloseable.close is
> more appropriate as an apiNote that normal text.
Marked as reviewed by naoto
On Wed, 9 Jun 2021 15:41:59 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.time`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Looks good overall. Some misplaced comments. Also, copyright years
On Mon, 7 Jun 2021 18:49:19 GMT, Joe Wang wrote:
> Fixes the addVariable/addParam methods in the SymbolTable to check types
> before casting.
Looks good. I'd be tempted to write `v instanceof Param p ? p : null;`, but
then it could not be backported.
-
Marked as reviewed by
On Sun, 6 Jun 2021 22:25:44 GMT, David Holmes wrote:
>> I think we need to establish some common ground before proceeding further
>> with this fix. It's a bit of a long read; please, bear with me.
>>
>> The path name starts its life as a `jstring` in
>>
On Fri, 4 Jun 2021 13:36:27 GMT, Maxim Kartashev
wrote:
>> Character strings within JVM are produced and consumed in several formats.
>> Strings come from/to Java in the UTF8 format and POSIX APIs (like fprintf()
>> or dlopen()) consume strings also in UTF8. On Windows, however, the
>>
On Fri, 4 Jun 2021 14:00:25 GMT, Maxim Kartashev
wrote:
>> Not an expert by my understanding is that the VM only deals with modified
>> UTF-8, as does JNI. So the incoming string should be modified-UTF8 IMO and
>> then converted to UTF16.
>>
>> That said, this is shared code being modified
On Thu, 3 Jun 2021 20:59:24 GMT, Stephen Colebourne
wrote:
>> 8266846: Add java.time.InstantSource
>
> Stephen Colebourne has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8266846: Add java.time.InstantSource
Marked as reviewed by naoto
On Thu, 3 Jun 2021 06:59:01 GMT, Maxim Kartashev
wrote:
>> test/hotspot/jtreg/runtime/jni/loadLibraryUnicode/LoadLibraryUnicodeTest.java
>> line 42:
>>
>>> 40: String nativePathSetting = "-Dtest.nativepath=" +
>>> getSystemProperty("test.nativepath");
>>> 41: ProcessBuilder
On Thu, 3 Jun 2021 06:55:26 GMT, Maxim Kartashev
wrote:
>> src/hotspot/os/windows/os_windows.cpp line 1491:
>>
>>> 1489: static errno_t convert_UTF8_to_UTF16(char const* utf8_str, LPWSTR*
>>> utf16_str) {
>>> 1490: return convert_to_UTF16(utf8_str, CP_UTF8, utf16_str);
>>> 1491: }
>>
>>
On Thu, 3 Jun 2021 11:01:02 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.lang`
>> packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull request
On Wed, 2 Jun 2021 22:22:22 GMT, Jonathan Gibbons wrote:
> Please review a test fix to refer to the new name of the TestNG module.
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4325
On Wed, 2 Jun 2021 20:15:55 GMT, Jonathan Gibbons wrote:
>> Please review the change to update to using jtreg 6.
>>
>> The primary change is to the jib-profiles.js file, which specifies the
>> version of jtreg to use, for those systems that rely on this file. In
>> addition, the
On Wed, 2 Jun 2021 16:13:48 GMT, Jonathan Gibbons wrote:
> Please review the change to update to using jtreg 6.
>
> The primary change is to the jib-profiles.js file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the `requiredVersion`
On Wed, 2 Jun 2021 15:25:16 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.lang`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Hi Patrick, some minor comments.
On Wed, 2 Jun 2021 15:00:56 GMT, Roger Riggs wrote:
>> Methods are added to java.lang.Process to read and write characters and
>> lines from and to a spawned Process.
>> The Charset used to encode and decode characters to bytes can be specified
>> or use the
>> operating system native encoding
On Tue, 1 Jun 2021 20:29:30 GMT, Joe Wang wrote:
>> Makes a correction to XPathEvaluationResult.XPathResultType.NODESET mapping.
>> Clarifies the supported types for the evaluateExpression methods.
>>
>> Other changes were javadoc tag usages, e.g. s/the code tag/{@code
>
> Joe Wang has updated
On Sat, 29 May 2021 00:12:09 GMT, Joe Wang wrote:
> Makes a correction to XPathEvaluationResult.XPathResultType.NODESET mapping.
> Clarifies the supported types for the evaluateExpression methods.
>
> Other changes were javadoc tag usages, e.g. s/the code tag/{@code
On Tue, 1 Jun 2021 17:43:42 GMT, Brian Burkhalter wrote:
>> Modify the specification of `java.io.File.equals` to clarify that equality
>> is based only on a comparison of abstract pathnames as opposed to the file
>> system objects that the `File`s represent.
>
> Brian Burkhalter has updated
On Thu, 27 May 2021 16:14:38 GMT, Maxim Kartashev
wrote:
>> Character strings within JVM are produced and consumed in several formats.
>> Strings come from/to Java in the UTF8 format and POSIX APIs (like fprintf()
>> or dlopen()) consume strings also in UTF8. On Windows, however, the
>>
On Sun, 30 May 2021 00:49:56 GMT, Stephen Colebourne
wrote:
>> 8266846: Add java.time.InstantSource
>
> Stephen Colebourne has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8266846: Add java.time.InstantSource
Looks good to me.
As I commented on the PR, the test needs to run in othervm mode:
https://github.com/openjdk/jdk/pull/4016#issuecomment-844551175
--- a/test/jdk/java/time/test/TEST.properties
+++ b/test/jdk/java/time/test/TEST.properties
@@ -1,5 +1,5 @@
# java.time tests use TestNG
TestNG.dirs = ..
On Thu, 27 May 2021 17:38:42 GMT, Claes Redestad wrote:
> This patch fixes a regression caused by
> https://bugs.openjdk.java.net/browse/JDK-8265237 where the result of
> String.join always get a UTF-16 coder if the delimiter is UTF-16, even when
> no delimiter is emitted.
Marked as reviewed
On Tue, 25 May 2021 16:40:53 GMT, Naoto Sato wrote:
> Please review the fix. The issue was informed yesterday by @amaembo that it
> offends some code analysis tools.
> Although the fix is to change the condition error, it turned out that
> `JapaneseImperialCalendar.roll()`
On Tue, 25 May 2021 16:53:28 GMT, Roger Riggs wrote:
>> Methods are added to java.lang.Process to read and write characters and
>> lines from and to a spawned Process.
>> The Charset used to encode and decode characters to bytes can be specified
>> or use the
>> operating system native
On Mon, 17 May 2021 16:55:35 GMT, Naoto Sato wrote:
> Please review the changes to the subject issue. java.util.Locale class has a
> long-standing issue for those obsolete ISO 639 languages where its
> normalization ends up in the obsolete codes. This change intend
On Wed, 26 May 2021 01:28:17 GMT, Roger Riggs wrote:
> The class `test/lib/jtreg/SkippedException.java` is missing a
> serialVersionUID causing additional noise in compiler output of tests.
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4197
On Tue, 25 May 2021 21:43:36 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.io`,
>> `java.math`, and `java.text` packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated
Please review the fix. The issue was informed yesterday by @amaembo that it
offends some code analysis tools.
Although the fix is to change the condition error, it turned out that
`JapaneseImperialCalendar.roll()` did not work for `WEEK_OF_MONTH` and
`DAY_OF_MONTH`. There was an inherent issue
On Tue, 25 May 2021 09:37:58 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.io`,
> `java.math`, and `java.text` packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Hi Tagir,
Thank you for reporting the issue. It is in fact already reported here:
https://bugs.openjdk.java.net/browse/JDK-8187649
This is a low priority (rarely occuring) bug, but since it is now
offending static analyzers, I will take a second look.
Naoto
On 5/24/21 1:46 AM, Tagir Valeev
On Mon, 24 May 2021 00:33:06 GMT, Roger Riggs wrote:
>> Methods are added to java.lang.Process to read and write characters and
>> lines from and to a spawned Process.
>> The Charset used to encode and decode characters to bytes can be specified
>> or use the
>> operating system native
On Thu, 20 May 2021 20:46:36 GMT, Roger Riggs wrote:
>> test/jdk/java/lang/ProcessBuilder/ReaderWriterTest.java line 64:
>>
>>> 62: return new Object[][] {
>>> 63: {"UTF-8"},
>>> 64: {"ISO8859-1"},
>>
>> `ISO8859-1` may not be available on all underlying
On Thu, 20 May 2021 19:57:22 GMT, Roger Riggs wrote:
> Methods are added to java.lang.Process to read and write characters and lines
> from and to a spawned Process.
> The Charset used to encode and decode characters to bytes can be specified or
> use the
> operating system native encoding as
On Wed, 19 May 2021 21:58:08 GMT, Stephen Colebourne
wrote:
>> 8266846: Add java.time.InstantSource
>
> Stephen Colebourne has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8266846: Add java.time.InstantSource
I believe that the default
On Tue, 18 May 2021 23:18:42 GMT, Stephen Colebourne
wrote:
>> 8266846: Add java.time.InstantSource
>
> Stephen Colebourne has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8266846: Add java.time.InstantSource
The Error was caused by the
On Tue, 18 May 2021 23:18:42 GMT, Stephen Colebourne
wrote:
>> 8266846: Add java.time.InstantSource
>
> Stephen Colebourne has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8266846: Add java.time.InstantSource
Another test started failing
On Tue, 18 May 2021 23:22:49 GMT, Stephen Colebourne
wrote:
>> test/jdk/java/time/test/java/time/TestInstantSource.java line 86:
>>
>>> 84: assertEquals(test.instant(), instant);
>>> 85: assertSame(test.equals(InstantSource..fixed(instant));
>>> 86:
On Tue, 18 May 2021 23:18:42 GMT, Stephen Colebourne
wrote:
>> 8266846: Add java.time.InstantSource
>
> Stephen Colebourne has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8266846: Add java.time.InstantSource
ing a system property for
> compatibility behavior. ResourceBundle class is also modified to load either
> obsolete/current bundles. For more detail, take a look at the CSR.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Locale's
On Tue, 18 May 2021 22:22:06 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Locale's class description modification
>
> src/java.base/share/classes/java/util/L
On Mon, 17 May 2021 17:19:19 GMT, Stephen Colebourne
wrote:
>> 8266846: Add java.time.InstantSource
>
> Stephen Colebourne has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8266846: Add java.time.InstantSource
On Tue, 18 May 2021 10:37:21 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.util`
> package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Classes in the i18n area look good.
-
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote:
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
>
On Mon, 17 May 2021 17:14:53 GMT, Erik Joelsson wrote:
> I see no relevant build changes to comment on as the build label was only
> added because the buildtool java source was touched, so this looks ok from a
> build perspective.
Removed `build` label.
-
PR:
Please review the changes to the subject issue. java.util.Locale class has a
long-standing issue for those obsolete ISO 639 languages where its
normalization ends up in the obsolete codes. This change intends to flip the
normalization towards the current codes, providing a system property for
On Thu, 13 May 2021 20:52:33 GMT, Stephen Colebourne
wrote:
> 8266846: Add java.time.InstantSource
src/java.base/share/classes/java/time/Clock.java line 2:
> 1: /*
> 2: * Copyright (c) 2012, 2019, 2021, Oracle and/or its affiliates. All
> rights reserved.
`2019, ` should be removed.
On Fri, 14 May 2021 17:44:20 GMT, Lance Andersen wrote:
> Please review this fix for a typo in the copyright header in HashTest which
> the jdk-tier1 does not catch
>
> Best
> Lance
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4034
On Wed, 12 May 2021 16:28:54 GMT, Naoto Sato wrote:
> Please review the changes to the subject issue. This is to incorporate the
> latest language subtag registry definition into the JDK.
This pull request has now been integrated.
Changeset: a259ab4a
Author: Naoto Sato
URL:
Please review the changes to the subject issue. This is to incorporate the
latest language subtag registry definition into the JDK.
-
Commit messages:
- Renaming the test case
- LSR 2021-05-11
- LSR 2021-03-05
- LSR 2021-02-23
- LSR 2020-12-18
Changes:
On Mon, 10 May 2021 23:12:04 GMT, Naoto Sato wrote:
> Please review this test case fix for the upcoming jtreg 6. The test was using
> `@BeforeGroups` annotation, and the behavior of it has changed in TestNG 7.1
> so that it is only issued when the test was configured with filtering.
On Fri, 30 Apr 2021 16:11:30 GMT, Ichiroh Takiguchi
wrote:
>> When an invalid character is converted by getBytes() method, the character
>> is converted to replacement byte data.
>> Shift code (SO/SI) may not be added into right place by EBCDIC Mix charset.
>> EBCDIC Mix charset encoder is
Please review this test case fix for the upcoming jtreg 6. The test was using
`@BeforeGroups` annotation, and the behavior of it has changed in TestNG 7.1 so
that it is only issued when the test was configured with filtering. Changed to
use `@BeforeClass` instead.
-
Commit
On Fri, 7 May 2021 22:46:08 GMT, Naoto Sato wrote:
> Please review this small fix to Windows system property init code. This is
> leftover from the support for `Console.charset()` method, where it lacked to
> initialize `sun.stdout/err.encoding` to `UTF-8` for the code page
Please review this small fix to Windows system property init code. This is
leftover from the support for `Console.charset()` method, where it lacked to
initialize `sun.stdout/err.encoding` to `UTF-8` for the code page `cp65001`.
The fix has been manually verified, but no automated test case is
On Thu, 6 May 2021 16:57:12 GMT, Daniel Fuchs wrote:
>> Hi, please find here a trivial test change that adds some diagnostic (time
>> stamps) to the LoggerFinder/modules subprocess test logs.
>
> Daniel Fuchs has updated the pull request incrementally with one additional
> commit since the
On Thu, 6 May 2021 16:42:16 GMT, Daniel Fuchs wrote:
>> Hi, please find here a trivial test change that adds some diagnostic (time
>> stamps) to the LoggerFinder/modules subprocess test logs.
>
> Daniel Fuchs has updated the pull request incrementally with one additional
> commit since the
On Thu, 6 May 2021 15:25:10 GMT, Daniel Fuchs wrote:
> Hi, please find here a trivial test change that adds some diagnostic (time
> stamps) to the LoggerFinder/modules subprocess test logs.
Could those be replaced with just `Instant.now()`? `Instant.toString()` uses
the same formatter as
On Wed, 5 May 2021 19:10:21 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this patch which updates
> test/jdk/java/lang/ProcessHandle/PermissionTest.java &
> test/jdk/java/sql/testng/util/TestPolicy.java to include :
>
> `new PropertyPermission("testng.memory.friendly", "read");
On Wed, 5 May 2021 17:56:09 GMT, Joe Darcy wrote:
>> 8244146: javac changes for JEP 306
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Respond to review feedback.
On Wed, 28 Apr 2021 22:24:31 GMT, Naoto Sato wrote:
> After some internal discussion, we thought it was good to expose the native
> environment's default character encoding, which Charset.defaultCharset() is
> currently based on. This way applications will have a better migration path
net/jeps/400) is implemented, in
> which Charset.defaultCharset() will return UTF-8, but the value of this new
> system property will remain intact. A
> [CSR](https://bugs.openjdk.java.net/browse/JDK-8266075) has been filed with
> more detailed information.
Naoto Sato has updated the pu
On Fri, 30 Apr 2021 21:09:36 GMT, Roger Riggs wrote:
> To support the statement that changing the property has no effect.
> Please add it to the jdk.internal.util.StaticProperties cached values and an
> internal access method.
Thanks. Added.
-
PR:
net/jeps/400) is implemented, in
> which Charset.defaultCharset() will return UTF-8, but the value of this new
> system property will remain intact. A
> [CSR](https://bugs.openjdk.java.net/browse/JDK-8266075) has been filed with
> more detailed information.
Naoto Sato has updated the pu
On Wed, 28 Apr 2021 22:24:31 GMT, Naoto Sato wrote:
> After some internal discussion, we thought it was good to expose the native
> environment's default character encoding, which Charset.defaultCharset() is
> currently based on. This way applications will have a better migration path
On Thu, 29 Apr 2021 13:23:42 GMT, Alan Bateman wrote:
>> `native.encoding` preserves the encoding that current
>> `Charset.defaultCharset()` is returning, which is based on `file.encoding`.
>> So I believe the current implementation is correct. If it is biased toward
>> `sun.jnu.encoding`, it
On Thu, 29 Apr 2021 07:17:26 GMT, Alan Bateman wrote:
>> After some internal discussion, we thought it was good to expose the native
>> environment's default character encoding, which Charset.defaultCharset() is
>> currently based on. This way applications will have a better migration path
>>
On Thu, 29 Apr 2021 05:38:21 GMT, Iris Clark wrote:
>> src/java.base/share/classes/java/lang/System.java line 704:
>>
>>> 702: * {@systemProperty native.encoding}
>>> 703: * Character encoding name derived from the host
>>> environment and/or
>>> 704: * the user's
On Wed, 28 Apr 2021 16:58:50 GMT, Naoto Sato wrote:
> This new regression test was introduced with the Console::charset(), but it
> fails on ubuntu platforms assuming its locales/encoding incorrectly. To not
> make false-alarm/noise on test runs, this fix minimizes the tests not
&g
After some internal discussion, we thought it was good to expose the native
environment's default character encoding, which Charset.defaultCharset() is
currently based on. This way applications will have a better migration path
after the [JEP 400](https://openjdk.java.net/jeps/400) is
This new regression test was introduced with the Console::charset(), but it
fails on ubuntu platforms assuming its locales/encoding incorrectly. To not
make false-alarm/noise on test runs, this fix minimizes the tests not depending
on the underlying OS's environment variables.
-
501 - 600 of 1638 matches
Mail list logo
