On Tue, 27 Apr 2021 21:34:02 GMT, Ian Graves wrote:
> 8266155: Convert java.base to use Stream.toList()
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3734
On Tue, 27 Apr 2021 01:26:53 GMT, Brian Burkhalter wrote:
> Please consider this request to correct a minor problem with the optimization
> added for JDK-4926314. The change is to attempt to read the number of
> elements remaining in the target buffer unless that number is non-positive in
>
On Mon, 26 Apr 2021 02:36:54 GMT, Hamlin Li wrote:
>> code like below will create Deflater before null check, although it's not a
>> real mem leak, but it's better to do null check before new Deflater.
>>
>> try {
>> DeflaterOutputStream dos = new
On Fri, 9 Apr 2021 16:47:55 GMT, Naoto Sato wrote:
> Please review the changes for the subject issue. This has been suggested in
> a recent discussion thread for the JEP 400
> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
> A CSR has also
On Fri, 23 Apr 2021 15:38:53 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review the second half of my update for the `java.time`
>> package to make use of the `instanceof` pattern variable?
>>
>> This PR was split into two parts due to the large number of files affected.
On Thu, 22 Apr 2021 16:29:35 GMT, Roger Riggs wrote:
>> Then `charset()` in the shared secret would return `null`. Would that
>> suffice your case?
>
> I read lines 575-587 as initializing CHARSET regardless of whether the
> Console was created.
OK, revived the charset() method.
> [[2](https://bugs.openjdk.java.net/browse/JDK-8264209)].
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Revived charset() in JavaIOAccess interface.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/3419/files
On Thu, 22 Apr 2021 16:03:12 GMT, Roger Riggs wrote:
>> Would the singleton `Console.cons` be instantiated in your use case? It is
>> created only when isatty() (or Windows' equivalent) in the native code
>> returns true.
>
> Not always, for example, if stderr was redirected to a terminal but
On Thu, 22 Apr 2021 15:18:11 GMT, Roger Riggs wrote:
>> Naoto Sato has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 13 addi
On Wed, 21 Apr 2021 11:06:16 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.time`
>> package to make use of the `instanceof` pattern variable?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull request
> [[2](https://bugs.openjdk.java.net/browse/JDK-8264209)].
Naoto Sato has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains 13 additional commits since the
last revisi
On Tue, 20 Apr 2021 17:46:38 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.time`
>> package to make use of the `instanceof` pattern variable?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull request
> [[2](https://bugs.openjdk.java.net/browse/JDK-8264209)].
Naoto Sato has updated the pull request incrementally with two additional
commits since the last revision:
- Changed shell based test into java based
- Added link to Charset#defaultChaset() in InputStreamReader.
-
Changes:
On Fri, 16 Apr 2021 21:10:42 GMT, Naoto Sato wrote:
> Please review the fix to the tier4 build failure. The piece of code that made
> into `CLDRLocaleProviderAdapter.java` was also needed in the build tool
> counterpart (`CLDRConverter`).
This pull request has now been integrated.
> Please review the fix to the tier4 build failure. The piece of code that made
> into `CLDRLocaleProviderAdapter.java` was also needed in the build tool
> counterpart (`CLDRConverter`).
Naoto Sato has updated the pull request incrementally with one additional
commit since the last
Please review the fix to the tier4 build failure. The piece of code that made
into `CLDRLocaleProviderAdapter.java` was also needed in the build tool
counterpart (`CLDRConverter`).
-
Commit messages:
- 8265375: Bootcycle builds fail with StackOverflowError in cldrconverter
On Fri, 16 Apr 2021 18:15:41 GMT, Roger Riggs wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Modified javadocs per suggestions.
>
> src/java.base/share/classes/java/io/InputStrea
On Fri, 16 Apr 2021 04:06:54 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this proposed fix for
>> https://bugs.openjdk.java.net/browse/JDK-8262108?
>>
>> As noted in a comment in that issue, the bug relates to the return value of
>> `Calendar.getDisplayNames` for the
On Fri, 16 Apr 2021 02:35:23 GMT, Jaikiran Pai wrote:
>> test/jdk/java/util/Calendar/NarrowNamesTest.java line 115:
>>
>>> 113: } else {
>>> 114: testMap(US, AM_PM, ALL_STYLES,
>>> 115: "AM", "PM",
>>
>> What I meant was there is no need to check the
On Wed, 14 Apr 2021 21:13:51 GMT, Naoto Sato wrote:
> Please review the changes to support CLDR version 39. The vast majority of
> the changes are purely data changes from Unicode. The only change affected in
> logic was in `CLDRLocaleProviderAdapter.java`, where it neede
On Thu, 15 Apr 2021 14:17:11 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added @see links.
>
> src/java.base/share/classes/java/io/Console.java line
> [[2](https://bugs.openjdk.java.net/browse/JDK-8264209)].
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Modified javadocs per suggestions.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/3419/files
- new: https://git.o
On Thu, 15 Apr 2021 01:57:01 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this proposed fix for
>> https://bugs.openjdk.java.net/browse/JDK-8262108?
>>
>> As noted in a comment in that issue, the bug relates to the return value of
>> `Calendar.getDisplayNames` for the
On Wed, 14 Apr 2021 21:13:51 GMT, Naoto Sato wrote:
> Please review the changes to support CLDR version 39. The vast majority of
> the changes are purely data changes from Unicode. The only change affected in
> logic was in `CLDRLocaleProviderAdapter.java`, where it neede
Please review the changes to support CLDR version 39. The vast majority of the
changes are purely data changes from Unicode. The only change affected in logic
was in `CLDRLocaleProviderAdapter.java`, where it needed to deal with CLDR's
Norwegian language code switch
On Wed, 14 Apr 2021 17:14:55 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this proposed fix for
>> https://bugs.openjdk.java.net/browse/JDK-8262108?
>>
>> As noted in a comment in that issue, the bug relates to the return value of
>> `Calendar.getDisplayNames` for the
> [[2](https://bugs.openjdk.java.net/browse/JDK-8264209)].
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Added @see links.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/3419/files
- new: https://git.openjdk.java.ne
On Wed, 14 Apr 2021 15:03:19 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added comment to System.out/err init.
>
> src/java.base/share/classes/java/lang/S
> [[2](https://bugs.openjdk.java.net/browse/JDK-8264209)].
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Added Console::charset() relation with System.in
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/3419/files
On Tue, 13 Apr 2021 15:03:28 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this proposed fix for
>> https://bugs.openjdk.java.net/browse/JDK-8262108?
>>
>> As noted in a comment in that issue, the bug relates to the return value of
>> `Calendar.getDisplayNames` for the
On Tue, 13 Apr 2021 18:56:22 GMT, Lance Andersen wrote:
>> Hi all,
>>
>> Please review the following patch which adds additional permissions needed
>> for when JTREG upgrades to a newer version of TestNG.
>>
>> Best,
>> Lance
>
> Lance Andersen has updated the pull request incrementally with
> [[2](https://bugs.openjdk.java.net/browse/JDK-8264209)].
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Added comment to System.out/err init.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/3419/files
On Tue, 13 Apr 2021 19:30:53 GMT, Joe Wang wrote:
>> Although the code path is different, the logic to determine the encoding is
>> not changed, as `sun.stdout/err.encoding` are only set if the VM is invoked
>> from a terminal (in fact, there's a bug where they aren't set even in a
>>
On Tue, 13 Apr 2021 13:04:17 GMT, Alan Bateman wrote:
> 1. I think method name "charset()" is too short. It's not called frequently.
> This method name should explain functionality.
As for this one, I am open for suggestions. I thought `consoel()` was concise,
and analogous to
On Tue, 13 Apr 2021 02:34:15 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reverted PrintStream changes
>
> src/java.base/share/classes/java/lang/System.java line 2020:
> [[2](https://bugs.openjdk.java.net/browse/JDK-8264209)].
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Reflected further review comments.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/3419/files
- new: https://git.o
On Tue, 13 Apr 2021 15:03:28 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this proposed fix for
>> https://bugs.openjdk.java.net/browse/JDK-8262108?
>>
>> As noted in a comment in that issue, the bug relates to the return value of
>> `Calendar.getDisplayNames` for the
On Mon, 12 Apr 2021 21:12:08 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/io/Console.java line 397:
>>
>>> 395: /**
>>> 396: * Returns the {@link java.nio.charset.Charset Charset} object
>>> used in
>>> 397: * this {@
> [[2](https://bugs.openjdk.java.net/browse/JDK-8264209)].
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Reverted PrintStream changes
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/3419/files
- new: https://git.openj
On Sun, 11 Apr 2021 13:44:05 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflected the review comments.
>
> src/java.base/share/classes/java/io/Console.java line
> [[2](https://bugs.openjdk.java.net/browse/JDK-8264209)].
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Reflecting the review comments.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/3419/files
- new: https://git.openj
Von: security-dev im Auftrag von Naoto Sato
Gesendet: Friday, April 9, 2021 11:06:00 PM
An: core-libs-dev@openjdk.java.net ;
security-...@openjdk.java.net
Betreff: Re: RFR: 8264208: Console charset API [v2]
Please review the changes for the subject issue. This has been
> [[2](https://bugs.openjdk.java.net/browse/JDK-8264209)].
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Reflected the review comments.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/3419/files
- new: https://git.openj
On Fri, 9 Apr 2021 19:25:02 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflected the review comments.
>
> src/java.base/share/classes/java/io/Console.java line
On Thu, 8 Apr 2021 18:19:20 GMT, Naoto Sato wrote:
> Please review the fix to the subject issue. It is not actually related to
> "parenthesized", but period-comma sequence was regarded as a break on a
> backward traverse.
This pull request has now been integrated.
Changes
Please review the changes for the subject issue. This has been suggested in a
recent discussion thread for the JEP 400
[[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
A CSR has also been drafted, and comments are welcome
Please review the fix to the subject issue. It is not actually related to
"parenthesized", but period-comma sequence was regarded as a break on a
backward traverse.
-
Commit messages:
- 8264765: BreakIterator sees bogus sentence boundary in parenthesized “i.e.”
phrase
Changes:
On Wed, 7 Apr 2021 21:01:48 GMT, Brian Burkhalter wrote:
> The specification of the method `flush()` in the `java.io` classes
> `CharArrayWriter` and `StringWriter` is not explicit about the fact that the
> method has no effect. This request proposes to add to the specification of
> each
On Fri, 2 Apr 2021 21:45:58 GMT, Brian Burkhalter wrote:
> This test emits to a `java.io.ByteArrayOutputStream` the contents of a
> `java.utils.prefs.Preferences` node. The `UTF-8` character encoding is used
> [1]. The `ByteArrayOutputStream` is then converted to a `String` using
>
On Thu, 1 Apr 2021 03:24:04 GMT, Naoto Sato wrote:
> Please review the fix to the subject issue. Thanks to the contribution by
> Chris Johnson.
This pull request has now been integrated.
Changeset: 6c145c47
Author: Naoto Sato
URL: https://git.openjdk.java.net/jdk/commit/6c
On Thu, 1 Apr 2021 22:15:01 GMT, Joe Darcy wrote:
> Simple change to make the exception/error messages more informative for
> various malformed annotation situations.
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3317
Please review the fix to the subject issue. Thanks to the contribution by Chris
Johnson.
-
Commit messages:
- 8264544: Case-insensitive comparison issue with supplementary characters.
Changes: https://git.openjdk.java.net/jdk/pull/3300/files
Webrev:
Hi Chris,
Thank you for your contribution. I believe this can be divided into two
parts, one is the bug in the current implementation, and the other is
the enhancement to refactor the whole implementation for performance. I
have created two JIRA issues for each:
On Tue, 23 Mar 2021 23:38:28 GMT, Naoto Sato wrote:
> Please review the fix to the DST transition bug after the year 2037. The
> logic had the side effect that it adjusted the dst offset every time the
> method `getOffsets()` is issued. Only adjust the offset when issued with wal
On Thu, 25 Mar 2021 20:08:14 GMT, Roger Riggs wrote:
> A number of HexFormat methods converting from strings to numbers do not use
> delimiter, prefix, suffix, and uppercase parameters and would be more
> convenient if the methods were static.
>
> These APIs were added early in JDK 17 and
Please review the fix to the DST transition bug after the year 2037. The logic
had the side effect that it adjusted the dst offset every time the method
`getOffsets()` is issued. Only adjust the offset when issued with wall time.
-
Commit messages:
- Set time zone to the
On Wed, 24 Mar 2021 09:56:16 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.time`
> package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
LGTM. Thanks for the cleanup!
-
Marked as
On Mon, 22 Mar 2021 20:40:09 GMT, Andy Herrick wrote:
> JDK-8259926: Error in jpackage sample usage in the help text
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3132
On Fri, 19 Mar 2021 17:57:31 GMT, Naoto Sato wrote:
> Fixed several broken links to Unicode.org.
This pull request has now been integrated.
Changeset: 96e5c3f1
Author: Naoto Sato
URL: https://git.openjdk.java.net/jdk/commit/96e5c3f1
Stats: 37 lines in 8 files changed: 4 ins
On Fri, 19 Mar 2021 18:43:30 GMT, Joe Wang wrote:
> Some minor comments.
Thanks, Joe. Addressed them as suggested.
-
PR: https://git.openjdk.java.net/jdk/pull/3093
> Fixed several broken links to Unicode.org.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Addressed review comments.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/3093/files
- new: ht
On Fri, 19 Mar 2021 18:23:00 GMT, Alex Blewitt
wrote:
> Additional changes found in `java.base` of `final private` -> `private
> final`. Filed with existing bug because it's the same module; can change to a
> different bug number if required.
Marked as reviewed by naoto (Reviewer).
Fixed several broken links to Unicode.org.
-
Commit messages:
- 8263890: Broken links to Unicode.org
Changes: https://git.openjdk.java.net/jdk/pull/3093/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=3093=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8263890
On Tue, 16 Mar 2021 21:39:26 GMT, Joe Wang wrote:
>> Consolidate and move javadoc for the lookup mechanism to the module summary.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix typos: s/XMLEventFactory/XMLInputFactory
>
On Tue, 16 Mar 2021 00:52:24 GMT, Joe Wang wrote:
> Consolidate and move javadoc for the lookup mechanism to the module summary.
src/java.xml/share/classes/javax/xml/stream/XMLInputFactory.java line 172:
> 170:* Creates a new instance of the factory. This method uses the
> 171:* JAXP
On Sat, 13 Mar 2021 20:26:42 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this trivial cleanup?
> from JBS:
>
>> jtreg `@modules X` directive does two things:
>> - exclude a test from execution if JDK under test doesn't have module X
>> - if JDK under test has module X,
On Wed, 10 Mar 2021 02:31:28 GMT, Ian Graves wrote:
>> This fixes a zero-adding issue observed in the hex float conversion.
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updating Formatter copyright date
Looks good to me.
On Mon, 8 Mar 2021 20:42:21 GMT, Claes Redestad wrote:
>> This patch optimizes String.format expressions that uses trivial specifiers.
>> In the JDK, the most common variation of String.format is a variation of
>> format("foo: %s", s), which gets a significant speed-up from this.
>>
>>
On Mon, 8 Mar 2021 18:48:30 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.io`,
> `java.math`, and `java.text` packages to make use of the `instanceof` pattern
> variable?
>
> Kind regards,
> Patrick
Marked as reviewed by
On Mon, 8 Mar 2021 18:52:19 GMT, Claes Redestad wrote:
>> This patch optimizes String.format expressions that uses trivial specifiers.
>> In the JDK, the most common variation of String.format is a variation of
>> format("foo: %s", s), which gets a significant speed-up from this.
>>
>>
On Mon, 8 Mar 2021 16:00:27 GMT, Claes Redestad wrote:
>> This patch optimizes String.format expressions that uses trivial specifiers.
>> In the JDK, the most common variation of String.format is a variation of
>> format("foo: %s", s), which gets a significant speed-up from this.
>>
>>
On Fri, 5 Mar 2021 18:53:29 GMT, Claes Redestad wrote:
>> This patch refactors Locale.getDefault(Category) so that the volatile field
>> holding the Locale is typically only read once. This has a small performance
>> advantage, and might be more robust if initialization is racy.
>
> Claes
On Fri, 5 Mar 2021 14:24:34 GMT, Claes Redestad wrote:
> This patch removes the CharacterData.isOtherUppercase and isOtherLowercase
> methods. It also exploits the fact that isOtherUppercase is always false for
> all codepoints in the CharacterDataLatin1 range for a small speed-up.
>
> I have
On Fri, 5 Mar 2021 14:14:14 GMT, Claes Redestad wrote:
> This patch refactors Locale.getDefault(Category) so that the volatile field
> holding the Locale is typically only read once. This has a small performance
> advantage, and might be more robust if initialization is racy.
On Mon, 1 Mar 2021 23:59:11 GMT, Joe Wang wrote:
>> Add the documentation for XML processing limits to module summary. The
>> limits were previously documented in Java tutorial and guide.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last
On Fri, 26 Feb 2021 08:04:02 GMT, Joe Wang wrote:
>> Add the documentation for XML processing limits to module summary. The
>> limits were previously documented in Java tutorial and guide.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last
On Thu, 25 Feb 2021 22:41:46 GMT, Jonathan Gibbons wrote:
> Please review a small doc fix to remove some superfluous `` tags and an
> erroneous `` tag, all reported by doclint..
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2733
On Thu, 25 Feb 2021 22:04:41 GMT, Joe Wang wrote:
> Add the documentation for XML processing limits to module summary. The limits
> were previously documented in Java tutorial and guide.
src/java.xml/share/classes/module-info.java line 231:
> 229: *
> 230: * A positive integer. A value
On Sat, 20 Feb 2021 00:44:29 GMT, Naoto Sato wrote:
> The subject test case is failing under the JMS-enabled environment.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.java.net/jdk/pull/2657
On Sat, 20 Feb 2021 02:16:49 GMT, Daniel D. Daugherty
wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Limit the exclustion to linux-x64
>
> Changes requested by dcubed (Rev
On Tue, 23 Feb 2021 02:09:01 GMT, Naoto Sato wrote:
> Please review the fix to this test case failure that occurs with the usage
> tracker enabled JRE.
This pull request has now been integrated.
Changeset: 9d9ad969
Author: Naoto Sato
URL: https://git.openjdk.java.net/jdk/
> Please review the fix to this test case failure that occurs with the usage
> tracker enabled JRE.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Reflecting review comments.
-
Changes:
- all:
On Tue, 23 Feb 2021 09:49:47 GMT, Daniel Fuchs wrote:
>> Please review the fix to this test case failure that occurs with the usage
>> tracker enabled JRE.
>
> test/jdk/java/util/Locale/LocaleProviders.java line 416:
>
>> 414: // Set the root logger on loading the logging class
>> 415:
Please review the fix to this test case failure that occurs with the usage
tracker enabled JRE.
-
Commit messages:
- 8261919: java/util/Locale/LocaleProvidersRun.java failed with
"RuntimeException: Expected log was not emitted. LogRecord: null"
Changes:
> The subject test case is failing under the JMS-enabled environment.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Limit the exclustion to linux-x64
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2657/fi
On Sat, 20 Feb 2021 02:16:43 GMT, Daniel D. Daugherty
wrote:
>> The subject test case is failing under the JMS-enabled environment.
>
> test/jdk/ProblemList.txt line 799:
>
>> 797: # jdk_util
>> 798:
>> 799: java/util/Locale/LocaleProvidersRun.java8261919
>>
On Fri, 19 Feb 2021 22:12:35 GMT, Joe Wang wrote:
> A quick fix to the test, removing Windows carriage return in the result.
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2656
On Fri, 12 Feb 2021 17:25:00 GMT, Brian Burkhalter wrote:
>> Please review this clarification of the specification of the method
>> `skip(long)` in `java.io.Reader` and its subclasses. Specifically, the
>> behavior of the method is made clear for the case when the `Reader` is
>> already at
On Wed, 17 Feb 2021 19:34:47 GMT, Naoto Sato wrote:
> Please review this simple doc fix. A CSR will be filed accordingly.
This pull request has now been integrated.
Changeset: 8a1c712c
Author: Naoto Sato
URL: https://git.openjdk.java.net/jdk/commit/8a1c712c
Stats: 8 lines i
On Thu, 18 Feb 2021 23:16:00 GMT, Claes Redestad wrote:
>> This patch exposes a couple of intrinsics used by String to speed up ASCII
>> checking and byte[] -> char[] inflation, which can be used by latin1 and
>> ASCII-compatible CharsetDecoders to speed up decoding operations.
>>
>> -
On Thu, 18 Feb 2021 14:49:20 GMT, Roger Riggs wrote:
>>>
>>>
>>> The table is informative and should not be construed as specification.
>>> The wording "has supported" should be sufficient.
>>
>> If this is not specification then doesn't that imply that any provider of
>> any version of
On Wed, 17 Feb 2021 23:10:57 GMT, Brian Burkhalter wrote:
>> Please review this minor specification update to highlight that
>> `File.renameTo(File)` does not modify the `File` instance on which the
>> method is invoked.
>
> Brian Burkhalter has updated the pull request incrementally with one
On Wed, 17 Feb 2021 22:12:06 GMT, Brian Burkhalter wrote:
>> Please review this minor specification update to highlight that
>> `File.renameTo(File)` does not modify the `File` instance on which the
>> method is invoked.
>
> Brian Burkhalter has updated the pull request incrementally with one
On Fri, 12 Feb 2021 02:50:35 GMT, Naoto Sato wrote:
> Please review this doc fix to j.l.Character, which now includes the table of
> the history of supported Unicode versions. A corresponding CSR will be filed
> accordingly.
This pull request has now been integrated.
Changeset:
On Wed, 17 Feb 2021 20:04:33 GMT, Lance Andersen wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Made the additional text an @apiNote
>
> Hi Naoto,
>
> Looks good.
>
&
> Please review this simple doc fix. A CSR will be filed accordingly.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Made the additional text an @apiNote
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2
Please review this simple doc fix. A CSR will be filed accordingly.
-
Commit messages:
- 8261728: SimpleDateFormat should link to DateTimeFormatter
Changes: https://git.openjdk.java.net/jdk/pull/2616/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=2616=00
Issue:
> Please review this doc fix to j.l.Character, which now includes the table of
> the history of supported Unicode versions. A corresponding CSR will be filed
> accordingly.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Add
On Mon, 15 Feb 2021 15:19:01 GMT, Claes Redestad wrote:
>> This patch exposes a couple of intrinsics used by String to speed up ASCII
>> checking and byte[] -> char[] inflation, which can be used by latin1 and
>> ASCII-compatible CharsetDecoders to speed up decoding operations.
>>
>> -
> Please review this doc fix to j.l.Character, which now includes the table of
> the history of supported Unicode versions. A corresponding CSR will be filed
> accordingly.
Naoto Sato has updated the pull request with a new target base due to a merge
or a rebase. The pull request now
601 - 700 of 1638 matches
Mail list logo
