On Thu, 16 Sep 2021 01:29:12 GMT, wxiang
wrote:
>> There is a bug for URLClassPath.findResources with JarIndex.
>> Currently, there was agreement on dropping the support from the
>> URLClassLoader implementation but it was suggested that it should be
>> disabled for a release or two before the
Hi all,
Please review this patch which addresses the issue where Zip FS will throw a
UOE instead of returning null when Files.getFileAttributeView() is invoked
and the view not supported.
Mach5 tiers1 - tier3 are clean.
Best
Lance
-
Commit messages:
- Add Cleanup Method
- ad
On Mon, 20 Sep 2021 11:28:10 GMT, Alan Bateman wrote:
>> Hi all,
>>
>> Please review this patch which addresses the issue where Zip FS will throw a
>> UOE instead of returning null when Files.getFileAttributeView() is invoked
>> and the view not supported.
>>
>> Mach5 tiers1 - tier3 are cl
On Mon, 20 Sep 2021 17:05:33 GMT, Severin Gehwolf wrote:
>> Hi all,
>>
>> Please review this patch which addresses the issue where Zip FS will throw a
>> UOE instead of returning null when Files.getFileAttributeView() is invoked
>> and the view not supported.
>>
>> Mach5 tiers1 - tier3 are
> Hi all,
>
> Please review this patch which addresses the issue where Zip FS will throw a
> UOE instead of returning null when Files.getFileAttributeView() is invoked
> and the view not supported.
>
> Mach5 tiers1 - tier3 are clean.
>
> Best
> Lance
Lance
> Hi all,
>
> Please review this patch which addresses the issue where Zip FS will throw a
> UOE instead of returning null when Files.getFileAttributeView() is invoked
> and the view not supported.
>
> Mach5 tiers1 - tier3 are clean.
>
> Best
> Lance
Lance
On Tue, 21 Sep 2021 16:48:53 GMT, Brian Burkhalter wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Tweak wording for Throwable constructor parameters
>
> src/java.base/share/classes/java/lang/Throwable.java line 68:
On Tue, 21 Sep 2021 13:16:02 GMT, Pavel Rappo wrote:
>> 8274075: Fix miscellaneous typos in java.base
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Tweak wording for Throwable constructor parameters
Overall looks like a g
On Tue, 21 Sep 2021 12:05:27 GMT, Pavel Rappo wrote:
> This PR fixes an inline comment typo and reduces "overlinking" in a doc
> comment in `java.lang.ref.Reference`. Overlinking happens because the
> `reachabilityFence` method:
> * Links `package-summary.html#reachability` twice.
> * Refers
On Sun, 19 Sep 2021 15:34:44 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this patch which addresses the issue where Zip FS will throw a
> UOE instead of returning null when Files.getFileAttributeView() is invoked
> and the view not supported.
>
> Mach5 tie
On Tue, 21 Sep 2021 21:45:40 GMT, Naoto Sato wrote:
> Simple doc fix.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5620
On Wed, 22 Sep 2021 13:01:34 GMT, Pavel Rappo wrote:
>> 8274075: Fix miscellaneous typos in java.base
>
> Pavel Rappo has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Fix "non-white space"
>
>JDK predominantly uses "non-whitespace"
On Wed, 22 Sep 2021 15:35:54 GMT, Pavel Rappo wrote:
>> 8274075: Fix miscellaneous typos in java.base
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add missing "the"
>
> (Spotted by Brian Burkhalter.)
Marked as revie
On Thu, 23 Sep 2021 14:53:42 GMT, Christian Stein wrote:
>> This commit appends the name of the JAR file to the exception message for
>> when automatic module lists a non-existing provider class.
>
> Christian Stein has updated the pull request incrementally with one
> additional commit since t
On Thu, 23 Sep 2021 19:47:51 GMT, Andrey Turbanov
wrote:
> Usages of methods Integer.valueOf, Byte.valueOf, Short.valueOf,
> Float.valueOf, Double.valueOf, Long.valueOf often can be simplified by using
> their pair methods parseInt/parseLong/parseShort/parseByte/parseFloat.
Marked as reviewed
please?
Hi Jaikiran
This is on my todo list, sorry for the delay.
Hoping we can get a couple additional eyes on this as well.
Best
Lance
-
PR: https://git.openjdk.java.net/jdk/pull/5486
[cid:E1C4E2F0-ECD0-4C9D-ADB4-B16CA7BCB7FC@home]
Lance Andersen| Principal Member of Techni
On Mon, 27 Sep 2021 18:40:10 GMT, Joe Darcy wrote:
> Follow-up change to JDK-8232230, augmentations to javac's Xlint:serial
> checking are out for review (https://github.com/openjdk/jdk/pull/5709) and
> java.util.concurrent would need some changes to pass under the expanded
> checks.
>
> The
On Mon, 27 Sep 2021 18:51:37 GMT, Joe Darcy wrote:
> Follow-up change to JDK-8231442, augmentations to javac's Xlint:serial
> checking are out for review (#5709) and java.sql.rowset would need some
> changes to pass under the expanded checks.
>
> The changes are to suppress warnings where non-
On Tue, 28 Sep 2021 03:10:33 GMT, Lin Zang wrote:
> Dear All， This PR has been pending there for quite a long time. I am
> wondering maybe this PR is not so interesting? I would like to leave this PR
> open for a while more, and if no new update, I would let it close
> automatically by timeout
On Fri, 1 Oct 2021 18:57:28 GMT, Naoto Sato wrote:
> This is to incorporate the ISO 4217 amendment #170, which has been released
> today, effective immediately.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5790
On Thu, 9 Sep 2021 20:12:47 GMT, Andrey Turbanov
wrote:
> Redundant castings make code harder to read.
> Found them by IntelliJ IDEA.
> I tried to select only casts which are definitely safe to remove. Also didn't
> touch primitive types casts.
Marked as reviewed by lancea (Reviewer).
---
On Fri, 17 Sep 2021 08:56:47 GMT, Andrey Turbanov
wrote:
> String.contains was introduced in Java 5.
> Some code in java.base still uses old approach with `String.indexOf` to check
> if String contains specified substring.
> I propose to migrate such usages. Makes code shorter and easier to rea
On Wed, 13 Oct 2021 05:02:15 GMT, Joe Darcy wrote:
> After a refinement to the checks under development in #5709, the new checks
> examine array types of serial fields and warn if the underlying component
> type is not serializable. Per the JLS, all array types are serializable, but
> if the b
Hi all,
Please review the fix to address a javadoc issue for the Deflater::deflate
methods that were added as part of JDK-6341887 that could throw a
ReadOnlyBufferException.
The` @throws ` clause for `ReadOnlyBufferException` was inadvertently omitted
from the javadoc for these new methods
On Wed, 13 Oct 2021 18:20:03 GMT, Brian Burkhalter wrote:
>> Hi all,
>>
>> Please review the fix to address a javadoc issue for the Deflater::deflate
>> methods that were added as part of JDK-6341887 that could throw a
>> ReadOnlyBufferException.
>>
>> The` @throws ` clause for `ReadOnlyBu
On Thu, 14 Oct 2021 01:46:31 GMT, Mitsuru Kariya wrote:
> Sorry for my very slow response.
No problem at all. I was delayed in getting the CSR created and finalized.
> These `{@code bytes}` point to the `bytes` argument, but should I change it
> to `{@code byte}s`?
Yes please make that minor
On Fri, 15 Oct 2021 09:30:18 GMT, Mitsuru Kariya wrote:
>> Fix `SerialBlob.setBytes(long pos, byte[] bytes, int offset, int length)` in
>> the following cases:
>>
>> 1. `pos - 1 + bytes.length - offset > this.length() && pos - 1 + length <=
>> this.length()`
>>The original implementation t
On Wed, 13 Oct 2021 17:43:29 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review the fix to address a javadoc issue for the Deflater::deflate
> methods that were added as part of JDK-6341887 that could throw a
> ReadOnlyBufferException.
>
> The`
On Mon, 18 Oct 2021 20:49:07 GMT, Naoto Sato wrote:
> Removing a problem-listed test case, which has little value in itself.
> Confirmed it did succeed on all platforms before the removal.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5996
On Tue, 19 Oct 2021 17:24:17 GMT, Weijun Wang wrote:
>> As a follow up of JEP 411, we will soon disallow security manager by
>> default. jtreg 6.1 does not set its own security manager if JDK version is
>> >= 18.
>
> Weijun Wang has updated the pull request incrementally with one additional
>
On Tue, 19 Oct 2021 06:32:57 GMT, Mitsuru Kariya wrote:
> The pre-submit test seems to have failed because the compiler was not found
> in some environments.
> Should I take any action?
> Or should I issue the /integrate pull request command?
You should be OK. Just as an extra sanity check, I
On Fri, 15 Oct 2021 09:30:18 GMT, Mitsuru Kariya wrote:
>> Fix `SerialBlob.setBytes(long pos, byte[] bytes, int offset, int length)` in
>> the following cases:
>>
>> 1. `pos - 1 + bytes.length - offset > this.length() && pos - 1 + length <=
>> this.length()`
>>The original implementation t
On Mon, 25 Oct 2021 16:08:29 GMT, Naoto Sato wrote:
> Trivial clean-up.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6110
On Tue, 26 Oct 2021 06:30:39 GMT, Ravi Reddy wrote:
>> Hi all,
>>
>> Please review this fix for Infinite loop in ZipOutputStream.close().
>> The main issue here is when ever there is an exception during close
>> operations on GZip we are not setting the deflator to a finished state which
>> is
On Sun, 24 Oct 2021 07:55:01 GMT, Mitsuru Kariya wrote:
>> Fix `SerialBlob.setBytes(long pos, byte[] bytes, int offset, int length)` in
>> the following cases:
>>
>> 1. `pos - 1 + bytes.length - offset > this.length() && pos - 1 + length <=
>> this.length()`
>>The original implementation t
On Thu, 28 Oct 2021 11:56:45 GMT, Ravi Reddy wrote:
>> Hi all,
>>
>> Please review this fix for Infinite loop in ZipOutputStream.close().
>> The main issue here is when ever there is an exception during close
>> operations on GZip we are not setting the deflator to a finished state which
>> is
On Thu, 4 Nov 2021 20:56:45 GMT, Andrew Leonard wrote:
> This PR enables reproducible Jars, Jmods and openjdk image zip files
> (eg.src.zip).
> It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying
> ZipOutputStream's.
> It fixes the following keys issues relating to reproducib
On Wed, 3 Nov 2021 21:46:08 GMT, Eamonn McManus wrote:
> This change applies the minimal fix suggested in
> https://bugs.openjdk.java.net/browse/JDK-8231490.
> The bug text suggests possibilities for reworking, but notes that
> this change is enough to fix the data race.
> Adding a regression tes
On Wed, 3 Nov 2021 21:46:08 GMT, Eamonn McManus wrote:
> This change applies the minimal fix suggested in
> https://bugs.openjdk.java.net/browse/JDK-8231490.
> The bug text suggests possibilities for reworking, but notes that
> this change is enough to fix the data race.
> Adding a regression tes
On Tue, 9 Nov 2021 22:29:12 GMT, Naoto Sato wrote:
> Simple doc clarification where the `toString()` output only conforms to ISO
> 8601 if the seconds in the offset are zero.
Hi Naoto,
I would probably file a CSR to track this minor update
-
PR: https://git.openjdk.java.net/jdk/p
On Tue, 9 Nov 2021 22:29:12 GMT, Naoto Sato wrote:
> Simple doc clarification where the `toString()` output only conforms to ISO
> 8601 if the seconds in the offset are zero.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6321
Hi all,
This patch addresses a regression introduced in JDK 15 via JDK-8242959 where
you can no longer access a file entry contained within a Zip file when there is
also a directory entry with the same name via ZipFile:getEntry().
Once fixed, the behavior will be consistent with earlier JDK r
On Wed, 10 Nov 2021 21:32:32 GMT, Claes Redestad wrote:
>> Hi all,
>>
>> This patch addresses a regression introduced in JDK 15 via JDK-8242959 where
>> you can no longer access a file entry contained within a Zip file when there
>> is also a directory entry with the same name via ZipFile:getE
On Thu, 11 Nov 2021 02:14:50 GMT, Jaikiran Pai wrote:
>> Hi all,
>>
>> This patch addresses a regression introduced in JDK 15 via JDK-8242959 where
>> you can no longer access a file entry contained within a Zip file when there
>> is also a directory entry with the same name via ZipFile:getEnt
or will be consistent with earlier JDK releases.
>
> Mach5 tiers 1-3 have been run without failure
>
> Best
> Lance
Lance Andersen has updated the pull request incrementally with one additional
commit since the last revision:
Address minor review comments
--
On Thu, 11 Nov 2021 12:50:30 GMT, Claes Redestad wrote:
>> Thank you for that clarification. The "addSlash" param being "false" in the
>> call below that comment is what made me think that the comment had a typo. I
>> read that code in a bit more detail now and I see what that comment means.
On Thu, 11 Nov 2021 12:04:46 GMT, Alan Bateman wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address minor review comments
>
> test/jdk/java/util/zip/ZipFile/ZipFileDuplicateEntr
On Wed, 10 Nov 2021 20:51:20 GMT, Lance Andersen wrote:
> Hi all,
>
> This patch addresses a regression introduced in JDK 15 via JDK-8242959 where
> you can no longer access a file entry contained within a Zip file when there
> is also a directory entry with the same name via Z
On Tue, 9 Nov 2021 15:48:22 GMT, Roger Riggs wrote:
> When set on the command line `jdk.serialFilter` to an invalid value, the
> invalid value is logged but the application is allowed to start without
> setting the filter.
> This leaves the application without the protections of the serial filt
On Sat, 13 Nov 2021 23:16:22 GMT, Sergey Bylokhov wrote:
> The ZipOutputStream class may create bogus zip data which cannot be opened by
> the ZipFile. The root cause is how the comment field is stored by the
> ZipOutputStream. According to the zip specification, the comment field should
> not
On Sun, 14 Nov 2021 11:18:48 GMT, Jaikiran Pai wrote:
>> The ZipOutputStream class may create bogus zip data which cannot be opened
>> by the ZipFile. The root cause is how the comment field is stored by the
>> ZipOutputStream. According to the zip specification, the comment field
>> should no
On Sun, 14 Nov 2021 15:12:16 GMT, Alan Bateman wrote:
>> The ZipOutputStream class may create bogus zip data which cannot be opened
>> by the ZipFile. The root cause is how the comment field is stored by the
>> ZipOutputStream. According to the zip specification, the comment field
>> should no
On Fri, 5 Nov 2021 13:52:49 GMT, Jaikiran Pai wrote:
>> The commit here is a potential fix for the issue noted in
>> https://bugs.openjdk.java.net/browse/JDK-8258117.
>>
>> The change here repurposes an existing internal interface `ModuleInfoEntry`
>> to keep track of the last modified timesta
On Tue, 16 Nov 2021 00:40:10 GMT, Sergey Bylokhov wrote:
>> The ZipOutputStream class may create bogus zip data which cannot be opened
>> by the ZipFile. The root cause is how the comment field is stored by the
>> ZipOutputStream. According to the zip specification, the comment field
>> should
On Wed, 17 Nov 2021 18:43:46 GMT, Sergey Bylokhov wrote:
> > There appears to be a similar test,
> > open/test/jdk/java/util/zip/ZipFile/Comment.java, I think we probably want
> > to fold your changes into the existing test and possibly convert to use
> > TestNG.
>
> I know that test, and I e
On Wed, 17 Nov 2021 19:25:33 GMT, Sergey Bylokhov wrote:
> > Sorry if my point was not clear. I would prefer to have 1 test to exercise
> > a Zip file comment vs have tests in multiple areas. Expanding the existing
> > test in this case keeps the primary coverage in one location and makes it
>
On Tue, 16 Nov 2021 00:40:10 GMT, Sergey Bylokhov wrote:
>> The ZipOutputStream class may create bogus zip data which cannot be opened
>> by the ZipFile. The root cause is how the comment field is stored by the
>> ZipOutputStream. According to the zip specification, the comment field
>> should
On Wed, 17 Nov 2021 19:18:19 GMT, Magnus Ihse Bursie wrote:
>> Both jar and jmod utilise java.io file operations whose methods define no
>> ordering of the return file lists, and in fact rely on OS query file
>> ordering, which can differ by underlying OS architecture.
>> This PR adds sort proc
On Mon, 15 Nov 2021 18:47:34 GMT, Andrew Leonard wrote:
> Both jar and jmod utilise java.io file operations whose methods define no
> ordering of the return file lists, and in fact rely on OS query file
> ordering, which can differ by underlying OS architecture.
> This PR adds sort processing t
On Wed, 17 Nov 2021 21:04:20 GMT, Ravi Reddy wrote:
>> Hi all,
>>
>> Please review this fix for Infinite loop in ZipOutputStream.close().
>> The main issue here is when ever there is an exception during close
>> operations on GZip we are not setting the deflator to a finished state which
>> is
On Wed, 17 Nov 2021 21:24:40 GMT, Andrew Leonard wrote:
>> I agree, we should change this to include braces with the if statement.
>
> I agree, I always use {}, I was being consistent with the rest of the
> expand() method, but I will add {} as I prefer that too, better to set a good
> example!
On Thu, 18 Nov 2021 15:33:26 GMT, Roger Riggs wrote:
>> The ObjectInputStream.GetField.get(String name, Object val) method is
>> returning null instead of throwing an exception when the class of the object
>> is not found. The caller is not able to correctly handle the case where the
>> class
On Thu, 18 Nov 2021 23:43:20 GMT, Joe Wang wrote:
>> Add setProperty/getProperty methods to the XPath API so that properties can
>> be supported in the future.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update as commente
On Thu, 18 Nov 2021 21:51:30 GMT, Brent Christian wrote:
> Here are the code changes for the "Deprecate finalizers in the standard Java
> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code
> review.
>
> This change makes the indicated deprecations, and updates the API spec
On Fri, 5 Nov 2021 13:52:49 GMT, Jaikiran Pai wrote:
>> The commit here is a potential fix for the issue noted in
>> https://bugs.openjdk.java.net/browse/JDK-8258117.
>>
>> The change here repurposes an existing internal interface `ModuleInfoEntry`
>> to keep track of the last modified timesta
On Fri, 19 Nov 2021 10:10:33 GMT, Andrew Leonard wrote:
>> Both jar and jmod utilise java.io file operations whose methods define no
>> ordering of the return file lists, and in fact rely on OS query file
>> ordering, which can differ by underlying OS architecture.
>> This PR adds sort processi
On Fri, 19 Nov 2021 18:30:17 GMT, Lance Andersen wrote:
> The changes look OK.
>
> Have you run the JCK tests in addition to the Mach5 tests for the areas being
> changed to make sure we did not trip over a conformance test?
Sorry wrong PR window please ignore this comment
-
On Fri, 19 Nov 2021 18:30:37 GMT, Andrew Leonard wrote:
>> @LanceAndersen what's your opinion? I'm not totally sure of it's usefulness?
>
> My thought is to remove it from this PR, since we've already determined the
> change has little impact.
> We can raise a new issue if we feel it's needed.
On Fri, 19 Nov 2021 10:10:33 GMT, Andrew Leonard wrote:
>> Both jar and jmod utilise java.io file operations whose methods define no
>> ordering of the return file lists, and in fact rely on OS query file
>> ordering, which can differ by underlying OS architecture.
>> This PR adds sort processi
On Mon, 8 Nov 2021 18:59:06 GMT, Сергей Цыпанов wrote:
>> This is a follow-up for https://github.com/openjdk/jdk/pull/4507, looks like
>> there are some cases that were not covered.
>>
>> Also this is related to https://github.com/openjdk/jdk/pull/3615
>
> Сергей Цыпанов has updated the pull re
On Fri, 19 Nov 2021 10:10:33 GMT, Andrew Leonard wrote:
>> Both jar and jmod utilise java.io file operations whose methods define no
>> ordering of the return file lists, and in fact rely on OS query file
>> ordering, which can differ by underlying OS architecture.
>> This PR adds sort processi
On Fri, 19 Nov 2021 18:55:40 GMT, Mandy Chung wrote:
>> The benchmark should use JMH. @cl4es, what are your thoughts here?
>
>> My thought is to remove it from this PR, since we've already determined the
>> change has little impact.
> We can raise a new issue if we feel it's needed.
>
> This i
On Fri, 19 Nov 2021 20:15:54 GMT, Andrew Leonard wrote:
>> Both jar and jmod utilise java.io file operations whose methods define no
>> ordering of the return file lists, and in fact rely on OS query file
>> ordering, which can differ by underlying OS architecture.
>> This PR adds sort processi
On Fri, 19 Nov 2021 22:04:47 GMT, Andrew Leonard wrote:
>> Both jar and jmod utilise java.io file operations whose methods define no
>> ordering of the return file lists, and in fact rely on OS query file
>> ordering, which can differ by underlying OS architecture.
>> This PR adds sort processi
On Mon, 22 Nov 2021 14:37:47 GMT, Jaikiran Pai wrote:
>> The commit here is a potential fix for the issue noted in
>> https://bugs.openjdk.java.net/browse/JDK-8258117.
>>
>> The change here repurposes an existing internal interface `ModuleInfoEntry`
>> to keep track of the last modified timest
On Wed, 24 Nov 2021 15:04:35 GMT, Jaikiran Pai wrote:
>> The commit here is a potential fix for the issue noted in
>> https://bugs.openjdk.java.net/browse/JDK-8258117.
>>
>> The change here repurposes an existing internal interface `ModuleInfoEntry`
>> to keep track of the last modified timest
On Tue, 23 Nov 2021 20:29:15 GMT, Andrew Leonard wrote:
>> Add a new --source-date (epoch seconds) option to jar and jmod
>> to allow specification of time to use for created/updated jar/jmod entries.
>> This then allows the ability to make the content deterministic.
>>
>> Signed-off-by: Andr
HI all,
Attached is a patch for 4 failing MR tests due the issue that was resolved via
JDK-8272728
Best
Lance
-
Commit messages:
- Fix for JDK-8272728
Changes: https://git.openjdk.java.net/jdk/pull/6546/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6546&range=00
On Wed, 24 Nov 2021 20:08:50 GMT, Lance Andersen wrote:
> HI all,
>
> Attached is a patch for 4 failing MR tests due the issue that was resolved
> via JDK-8272728
>
> Best
> Lance
This pull request has now been integrated.
Changeset: b5841ba3
Author:Lance Anders
On Fri, 26 Nov 2021 12:23:41 GMT, Sean Coffey wrote:
>> src/jdk.jartool/share/classes/sun/tools/jar/Main.java line 2290:
>>
>>> 2288: private void setSourceDate(ZipEntry e, long origTime) {
>>> 2289: if (sourceDate != -1) {
>>> 2290: e.setTimeLocal(LocalDateTime.ofEpochSeco
On Thu, 25 Nov 2021 17:57:20 GMT, Andrew Leonard wrote:
>> test/jdk/tools/jar/JarEntryTime.java line 129:
>>
>>> 127: // Make a jar file from that directory structure with
>>> 128: // --source-date set to epoch seconds 1647302400 (15/03/2022)
>>> 129: long sourceDate = 16
On Mon, 29 Nov 2021 17:07:52 GMT, Alan Bateman wrote:
> > @AlanBateman yes, see above comment, thanks
>
> This is a significant change to the ZipEntry API that will require discussion
> and agreement. Can you start a discussion on core-libs-dev about the topic?
> You could start with a summary
On Mon, 29 Nov 2021 18:48:45 GMT, Naoto Sato wrote:
> Fixing tests that fail at DST->STD offset transition. Simply skipping the
> tests on that occasion.
test/jdk/java/text/Format/DateFormat/DateFormatTest.java line 349:
> 347: var defZone = ZoneId.systemDefault();
> 348: if
>
On Tue, 30 Nov 2021 14:28:05 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which fixes a typo in the javadoc
> of `java.util.zip.ZipEntry.setTime()` method?
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6615
On Mon, 29 Nov 2021 21:59:31 GMT, Naoto Sato wrote:
>> Fixing tests that fail at DST->STD offset transition. Simply skipping the
>> tests on that occasion.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Changed to not skipp
Hi all,
Please review this patch to address a failure at DST->STD offset transition.
The fix mirrors what was done for JDK-8190748
Best,
Lance
-
Commit messages:
- Patch for JDK-8277422
Changes: https://git.openjdk.java.net/jdk/pull/6648/files
Webrev: https://webrevs.openjdk.j
On Wed, 1 Dec 2021 18:33:44 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this patch to address a failure at DST->STD offset transition.
> The fix mirrors what was done for JDK-8190748
>
>
> Best,
> Lance
This pull request has now been integrated.
On Sat, 20 Nov 2021 04:09:51 GMT, Tim Prinzing wrote:
> JDK-8276681: Malformed Javadoc inline tags in JDK source
> jdk/internal/net/http/ResponseSubscribers.java
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6486
On Fri, 3 Dec 2021 10:05:43 GMT, Andrew Leonard wrote:
>> Add a new --source-date (epoch seconds) option to jar and jmod
>> to allow specification of time to use for created/updated jar/jmod entries.
>> This then allows the ability to make the content deterministic.
>>
>> Signed-off-by: Andre
On Mon, 6 Dec 2021 19:11:45 GMT, Andrew Leonard wrote:
>> Add a new --source-date (epoch seconds) option to jar and jmod
>> to allow specification of time to use for created/updated jar/jmod entries.
>> This then allows the ability to make the content deterministic.
>>
>> Signed-off-by: Andre
On Tue, 7 Dec 2021 09:32:47 GMT, Andrew Leonard wrote:
> > I've edited the CSR to make the summary a bit simpler. I've also removed
> > some of text from the Solution section as the discussion about
> > SOURCE_DATE_EPOCH being an issue due to the security manager was confusing.
> > I also remo
On Thu, 9 Dec 2021 18:07:58 GMT, Andrew Leonard wrote:
>> Add a new --source-date (epoch seconds) option to jar and jmod
>> to allow specification of time to use for created/updated jar/jmod entries.
>> This then allows the ability to make the content deterministic.
>>
>> Signed-off-by: Andre
On Fri, 10 Dec 2021 10:54:06 GMT, Andrew Leonard wrote:
>> Add a new --source-date (epoch seconds) option to jar and jmod
>> to allow specification of time to use for created/updated jar/jmod entries.
>> This then allows the ability to make the content deterministic.
>>
>> Signed-off-by: Andr
On Fri, 10 Dec 2021 08:16:46 GMT, Christian Stein wrote:
>> Prior to this PR, `toUri()` of class `ZipPath` in module `jdk.zipfs` and
>> class `PathFileObject` in module `jdk.compiler` were always composed by base
>> path names. Even for versioned entries of a multi-release JAR file.
>>
>> Now,
On Tue, 7 Dec 2021 19:25:05 GMT, Lance Andersen wrote:
>> Andrew Leonard has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8276766: Enable jar and jmod to produce deterministic timestamped content
>>
>
On Fri, 10 Dec 2021 14:09:00 GMT, Andrew Leonard wrote:
>> Add a new --source-date (epoch seconds) option to jar and jmod
>> to allow specification of time to use for created/updated jar/jmod entries.
>> This then allows the ability to make the content deterministic.
>>
>> Signed-off-by: Andr
On Wed, 1 Dec 2021 14:47:54 GMT, Roger Riggs wrote:
> Compilation warnings of the test library introduce noise in test output and
> should be addressed or suppressed.
> Changes include:
> - SuppressWarnings("deprecation") and SuppressWarnings("removal")
> - Adding type parameters to Raw types
On Tue, 14 Dec 2021 18:25:45 GMT, Naoto Sato wrote:
> This is a doc fix to `StringTokenizer`, where the original spec does not
> account for the delimiter's length in the case of a supplementary character.
> Corresponding CSR has been drafted:
> https://bugs.openjdk.java.net/browse/JDK-8278814
On Thu, 16 Dec 2021 06:33:24 GMT, Stuart Marks wrote:
> A small modification to the Launcher's help text.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk18/pull/34
On Mon, 6 Dec 2021 16:01:43 GMT, Roger Riggs wrote:
>> The specification of ObjectInputStream constructors that invoke
>> `ObjectInputFilter.Config.getSerialFilterFactory()` do not mention
>> exceptions that may be thrown by the apply() method.
>>
>> In both constructors, add the following to
501 - 600 of 1961 matches
Mail list logo
