On Tue, 29 Mar 2022 16:39:50 GMT, Joe Wang wrote:
> Resets state of a Catalog instance on each matching call so that it can be
> reused. Adjusts CatalogResolver's resolve routine so that it continues to
> observes the PREFER feature in a resolution process. Without the adjustment,
> PreferFeat
On Tue, 29 Mar 2022 12:45:51 GMT, Volker Simonis wrote:
> > Hello Volker, An additional thing that we might have to consider here is
> > whether adding this javadoc change to `InflaterInputStream` is ever going
> > to "show up" to end user applications. What I mean is, I think in many
> > case
On Wed, 30 Mar 2022 16:28:16 GMT, Brian Burkhalter wrote:
>> Minimal version of possible fixes: make the bulk read `@return` verbiage
>> consistent in the `java.io` package.
>
> Brian Burkhalter has refreshed the contents of this pull request, and
> previous commits have been removed. The incre
On Wed, 30 Mar 2022 02:56:41 GMT, Vicente Romero wrote:
>> Please review this PR which is updating the ASM included in the JDK to ASM
>> 9.2. This version should be included in JDK19. There are basically two
>> commits here, one that was automatically generated and that mostly changes
>> file
On Wed, 6 Apr 2022 01:23:15 GMT, Joe Wang wrote:
>> Clean up the usages of isAssignableFrom in a few xpath and jdk/internal
>> classes where the checks were really about equality or whether they were the
>> exact class types. It was why they worked nonetheless even though some of
>> them were
On Tue, 12 Apr 2022 15:00:29 GMT, Volker Simonis wrote:
>> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)`
>> to highlight that it might write more bytes than the returned number of
>> inflated bytes into the buffer `b`.
>>
>> The superclass `java.io.InputStream` sp
On Tue, 12 Apr 2022 20:09:31 GMT, Ravi Reddy wrote:
> CloseInflaterDeflaterTest.java is failing intermittently(Observed once in
> macOS and Linux), testInflaterOutputStream() is added as an extra test as
> part of https://bugs.openjdk.java.net/browse/JDK-8278794. Disabling this test
> for now
On Wed, 13 Apr 2022 17:42:57 GMT, Volker Simonis wrote:
>> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)`
>> to highlight that it might write more bytes than the returned number of
>> inflated bytes into the buffer `b`.
>>
>> The superclass `java.io.InputStream` sp
On Wed, 13 Apr 2022 16:29:11 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> revert changes in:
> src/java.desktop
> src/java.management
> src/jdk
On Tue, 19 Apr 2022 16:50:12 GMT, Magnus Ihse Bursie wrote:
>> I ran `codespell` on the `src/java.base` directory, and accepted those
>> changes where it indeed discovered real typos.
>>
>> (Due to false positives this can unfortunately not be run automatically)
>>
>> The majority of fixes ar
On Wed, 20 Apr 2022 18:28:19 GMT, Joe Wang wrote:
>> Patch note:
>>
>> The previous patch changed all literal tokens to use constants. However,
>> replacing "." with Token.DOT introduced this bug.
>> While tokens with a single char are inherently of type char, due to the
>> different implemen
On Wed, 20 Apr 2022 21:53:46 GMT, Joe Wang wrote:
>> Patch note:
>>
>> A previous patch had a bug that missed the boundary check, that will cause
>> StringIndexOutOfBoundsException to be thrown instead of
>> XPathExpressionException as expected.
>>
>> Fix: the fix is to check the boundari
On Wed, 20 Apr 2022 15:33:26 GMT, Brian Burkhalter wrote:
>> Remove the `synchronized` keyword from the `mark(int)` and `reset()` methods
>> of `java.io.FilterInputStream`.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
>
On Thu, 21 Apr 2022 22:19:32 GMT, Stuart Marks wrote:
>> Adds `othervm` and `-Xmx2g` options to this test, because the default heap
>> of 768m isn't enough.
>
> Stuart Marks has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add bug id.
Mark
On Mon, 25 Apr 2022 13:19:49 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the
On Thu, 21 Apr 2022 11:35:57 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the
On Mon, 25 Apr 2022 22:22:29 GMT, Joe Darcy wrote:
> Fix typo introduced in JDK-8261123.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8390
On Tue, 26 Apr 2022 17:27:35 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the
On Fri, 22 Apr 2022 15:08:51 GMT, Magnus Ihse Bursie wrote:
> I ran `codespell` on modules owned by core-libs, and accepted those changes
> where it indeed discovered real typos.
>
> I will update copyright years using a script before pushing (otherwise like
> every second change would be a co
On Wed, 27 Apr 2022 17:02:40 GMT, Pavel Rappo wrote:
>> I ran `codespell` on modules owned by core-libs, and accepted those changes
>> where it indeed discovered real typos.
>>
>> I will update copyright years using a script before pushing (otherwise like
>> every second change would be a copy
On Fri, 29 Apr 2022 12:29:35 GMT, Sibabrata Sahoo wrote:
>> A new API to support replacing selective lines with desired content.
>
> Sibabrata Sahoo has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8285452: updated to use lines()
test/jdk/j
On Mon, 2 May 2022 12:32:25 GMT, Volker Simonis wrote:
>> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)`
>> to highlight that it might write more bytes than the returned number of
>> inflated bytes into the buffer `b`.
>>
>> The superclass `java.io.InputStream` spe
On Thu, 5 May 2022 14:33:51 GMT, Roger Riggs wrote:
> Add a failing test library test to the ProblemList.
>
> test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8552
On Wed, 4 May 2022 19:16:14 GMT, Stuart Marks wrote:
>> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
>> in the bug report that breaks `IdentityHashMap` now causes several cases in
>> this new test to fail. There's more that could be done, but the new tests
>> co
On Tue, 10 May 2022 14:02:14 GMT, Alan Bateman wrote:
> > @LanceAndersen @AlanBateman do you think adding the entry name in the
> > exception in ZipFileSystem is ok? If so, should it maybe go into a
> > different patch?
>
> It should be okay as this is the name of an entry in the zip file. It
On Tue, 10 May 2022 14:58:15 GMT, Aleksey Shipilev wrote:
>> There are plenty of tests failing on many architectures due to
>> `--enable-preview` VM code introduced by Loom. This improvement eliminates
>> some of the redundant `--enable-preview` clauses from the Sealed Classes
>> tests, since
On Tue, 10 May 2022 16:30:01 GMT, Lance Andersen wrote:
>>> @LanceAndersen @AlanBateman do you think adding the entry name in the
>>> exception in ZipFileSystem is ok? If so, should it maybe go into a
>>> different patch?
>>
>> It should be okay as this
On Tue, 10 May 2022 16:51:35 GMT, Alan Bateman wrote:
> > I think this would be OK, but would get to get someone from our security
> > team to bless it.
>
> It's print the entry name, I don't think it is leaking the file path to the
> zip file.
I think you are probably right I am probably bei
On Tue, 10 May 2022 16:58:03 GMT, Lance Andersen wrote:
>>> I think this would be OK, but would get to get someone from our security
>>> team to bless it.
>>
>> It's print the entry name, I don't think it is leaking the file path to the
>> zip fi
On Wed, 11 May 2022 09:00:17 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change that addresses
> https://bugs.openjdk.java.net/browse/JDK-8286559?
>
> The commit here removes the `synchronized` on `mark` and `reset` methods of
> `InflaterInputStream`. The `mark` method is a n
On Wed, 11 May 2022 14:25:39 GMT, Jaikiran Pai wrote:
>> I agree with Magnus and try to avoid changing the imported zlib code.
>
>> I did these changes locally but for some reason this format-nonliteral is
>> not getting picked up while building that library.
>
> Turns out that was slightly in
On Wed, 11 May 2022 14:24:38 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which fixes build failures on macos
>> when using `--with-zlib=bundled`?
>>
>> With this change the build now passes (tested both with bundled and system
>> zlib variants).
>>
>> tier1, tier2 and
On Wed, 11 May 2022 15:03:56 GMT, Lance Andersen wrote:
>> Jaikiran Pai has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - copyright years
>> - disable format-nonliteral warning when building LIBSPLA
On Wed, 11 May 2022 15:32:38 GMT, Christoph Langer wrote:
> This augments the ZipException upon rejecting a Zip File containing entry
> names with "." or ".." elements.
>
> It furthermore tries to clean up & compact the logic for detecting "." and
> ".." and it adds a method IndexNode::nameAsS
On Wed, 11 May 2022 20:40:30 GMT, Joe Darcy wrote:
> While doing a CSR review of another issue, I noticed some cases in
> InputStream and OutputStream what would benefit from being upgraded to
> implSpec and related javadoc tags.
>
> The "A subclass must provide an implementation of this metho
On Wed, 11 May 2022 14:24:38 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which fixes build failures on macos
>> when using `--with-zlib=bundled`?
>>
>> With this change the build now passes (tested both with bundled and system
>> zlib variants).
>>
>> tier1, tier2 and
On Wed, 11 May 2022 22:03:38 GMT, Magnus Ihse Bursie wrote:
> It would not make sense to set the disabled warning in the configure script,
> no. The current code looks perfectly fine. Disabled warnings per module are
> set in the makefiles.
OK, that you for your feedback regarding the makefile
On Thu, 12 May 2022 08:43:56 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change to the build system which now makes
> bundled zlib as the default for macos aarch64 systems?
>
> We have been running into various intermittent failures on macos aarch64
> systems for several mont
On Thu, 12 May 2022 16:47:43 GMT, Roger Riggs wrote:
> Updates to modules java.rmi and java.smartcardio to remove warnings about
> lossy-conversions introduced by PR#8599.
>
> Explicit casts are inserted where implicit casts occur.
>
> 8286393: Address possibly lossy conversions in java.rmi
>
On Wed, 30 Mar 2022 10:26:56 GMT, Lance Andersen wrote:
>>> Hello Volker, An additional thing that we might have to consider here is
>>> whether adding this javadoc change to `InflaterInputStream` is ever going
>>> to "show up" to end user applicat
On Fri, 13 May 2022 14:39:44 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix the failure
>> handler command `dmesg` on macOS?
>>
>> As noted in the JBS issue, the command currently fails with permission
>> error. The commit in this PR uses `sudo` as s
On Mon, 16 May 2022 19:34:11 GMT, Joe Wang wrote:
> Update to Xerces 2.12.2.
>
> The update also fixes JDK-8144117. Added a test.
>
> Tests: local XML tests passed. Tier2 running. Two JCK tests failed with this
> update. See related issue report.
Hi Joe,
I think your changes are ok
Are you
On Tue, 17 May 2022 00:39:37 GMT, Joe Wang wrote:
>> Update to Xerces 2.12.2.
>>
>> The update also fixes JDK-8144117. Added a test.
>>
>> Tests: local XML tests passed. Tier2 passed. Two JCK tests failed with this
>> update. See related issue report.
>
> Joe Wang has updated the pull request
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> Also, I fixed a couple of spelling mistakes.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net
On Wed, 18 May 2022 13:58:22 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> I tried to avoid changing external libraries, there are quite a few such
> typos.
> Let me know if I should revert any files.
Marked
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> It's the last issue in the series, and it still touches different areas of
> the code.
Marked as reviewed by lancea (Reviewer).
On Wed, 18 May 2022 14:56:47 GMT, Christian Stein wrote:
> This PR adds an optional description accessor on `ToolProvider` interface.
>
> This PR also adds short description for each of the listed tool:
> - `jar`
> - `javac`
> - `javadoc`
> - `javap` and `jdeps`
> - `jlink` and `jmod`
> - `jpack
On Mon, 23 May 2022 08:49:27 GMT, Christian Stein wrote:
> This commit adds an API note to ToolProvider about being reusable/reentrant.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8833
On Sun, 22 May 2022 05:58:25 GMT, Christian Stein wrote:
> Commit
> https://github.com/openjdk/jdk/commit/655500a4f5e3abcff176599604deceefb6ca6640
> for issue [JDK-8286654](https://bugs.openjdk.java.net/browse/JDK-8286654)
> added an optional description accessor on the `ToolProvider` interfac
Hi all,
This PR addresses the performance issue that is described in JDK-8287162.
With this fix, the ZipFileSystem methods: initOwner, initGroup, and
initPermissions will not be invoked unless enablePosixFileAttributes=true.
Mach5 tiers1-3 are currently running and have not encountered any
On Tue, 24 May 2022 09:52:29 GMT, Alexey Ivanov wrote:
>> Replaces usages of articles that follow each other in all combinations:
>> a/the, an?/an?, the/the…
>>
>> It's the last issue in the series, and it still touches different areas of
>> the code.
>
> Alexey Ivanov has updated the pull req
On Mon, 23 May 2022 19:47:33 GMT, Lance Andersen wrote:
> Hi all,
>
> This PR addresses the performance issue that is described in JDK-8287162.
>
> With this fix, the ZipFileSystem methods: initOwner, initGroup, and
> initPermissions will not be invoked unless enablePosixF
On Fri, 27 May 2022 01:12:18 GMT, Joe Wang wrote:
> Addresses an insufficiency of error handling in the XPath implementation.
> Some cleanup where appropriate, without attempting to do too much as this is
> a component that hasn't had much changes for 15 years, a fairly stable
> application.
>
On Fri, 27 May 2022 17:17:28 GMT, Joe Wang wrote:
>> Addresses an insufficiency of error handling in the XPath implementation.
>> Some cleanup where appropriate, without attempting to do too much as this is
>> a component that hasn't had much changes for 15 years, a fairly stable
>> applicatio
On Fri, 3 Jun 2022 16:48:46 GMT, Naoto Sato wrote:
> The code path calls `String.getBytesNoRepl()`, but it blindly replaces
> unmappable characters with replacements if the encoder is an `ArrayEncoder`.
> Changed only to do so if `doReplace` is `true` in
> `String.encodeWithEncoder()`.
Marked
On Fri, 3 Jun 2022 23:56:31 GMT, Joe Wang wrote:
>> Adjust how XPath operators are counted to improve accuracy. This change does
>> not affect how XPath works.
>>
>> Test:
>> Tier2 passed;
>> JCK XML tests passed.
>
> Joe Wang has updated the pull request incrementally with one add
On Mon, 6 Jun 2022 06:57:23 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which addresses
> https://bugs.openjdk.java.net/browse/JDK-8285405?
>
> I've added the test for `LinkedHashMap.newLinkedHashMap(int)` in the existing
> `test/jdk/java/util/LinkedHashMap/Basic.java`
On Wed, 8 Jun 2022 14:51:59 GMT, Thiago Henrique Hüpner
wrote:
>> 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved
>> flags is used
>
> Thiago Henrique Hüpner has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Fix
On Sat, 28 May 2022 12:00:00 GMT, Andrey Turbanov wrote:
> Hashtable doesn't allow `null` values. So, instead of pair
> `containsKey`/`remove` calls, we can directly call `remove` and then compare
> result with `null`.
> https://github.com/openjdk/jdk/blob/2c461acfebd28fe5ef62805cbb004f91a3b18f
Hi Folks,
I am looking for a reviewer for this update to BatchUpdateException to address
a findbugs issue for exposing a mutable object.
The webrev is at http://cr.openjdk.java.net/~lancea/7038565/
Have a great weekend!
Regards,
lance
--
Lance Andersen
PTR National Tester & Clinicia
Changeset: 28caa191884a
Author:lancea
Date: 2011-04-28 09:46 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/28caa191884a
7038565: address Findbugs issue in BatchUpdateException
Reviewed-by: alanb, forax
! src/share/classes/java/sql/BatchUpdateException.java
Changeset: 0b1354ecf5a3
Author:lancea
Date: 2011-04-29 09:04 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0b1354ecf5a3
7040150: Indexing Error in CachedRowSetImpl.removeCurrentRow
Reviewed-by: smarks
! src/share/classes/com/sun/rowset/CachedRowSetImpl.java
Changeset: 6a3a41e0af88
Author:lancea
Date: 2011-05-10 14:41 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6a3a41e0af88
7043443: address missed reason initialization in BatchUpdateException
Reviewed-by: alanb
! src/share/classes/java/sql/BatchUpdateException.java
Changeset: a00f48c96345
Author:lancea
Date: 2011-06-02 12:02 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a00f48c96345
7049107: Cannot call initCause() on BatchUpdateException
Reviewed-by: darcy
! src/share/classes/java/sql/BatchUpdateException.java
Changeset: 7676670d1e97
Author:lancea
Date: 2011-08-10 16:23 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7676670d1e97
7077451: SerialLob, SerialClob have the wrong checks for setStream methods
Reviewed-by: alanb
Contributed-by: Patrick Reinhart
! src/share/classes/javax/
Changeset: 830d2e46023a
Author:lancea
Date: 2011-11-10 11:41 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/830d2e46023a
7110111: Minor Java SE javadoc & Constructor clean up
Reviewed-by: alanb, darcy
Contributed-by: Martin Desruisseaux
! src/share/classes/java/io/Writer.j
Changeset: 3c524deb8431
Author:lancea
Date: 2011-12-02 19:33 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3c524deb8431
7116445: Miscellaneous warnings in the JDBC/RowSet classes
Reviewed-by: smarks, chegar
! src/share/classes/com/sun/rowset/CachedRowSetImpl.java
! src/shar
Changeset: 303b67074666
Author:lancea
Date: 2012-01-24 15:13 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/303b67074666
7132879: address Findbugs issue in WebRowSetXmlWriter
Reviewed-by: forax
! src/share/classes/com/sun/rowset/internal/WebRowSetXmlWriter.java
Changeset: b518b160607f
Author:lancea
Date: 2012-01-26 19:41 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b518b160607f
7133815: address the findbug errors in CachedRowSetImpl, SerialStruct,
BaseRow, SerialInputImpl, SerialOutputImpl
Reviewed-by: forax
! src/share/classes
Changeset: 4580652d9828
Author:lancea
Date: 2012-05-04 16:00 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4580652d9828
7166598: FilteredRowSetImpl can result in Invalid Cursor Position
Reviewed-by: lancea
Contributed-by: Knut Anders Hatlen
! src/share/classes/com/sun/rows
Changeset: 8305ddc88a5a
Author:lancea
Date: 2012-06-07 20:11 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8305ddc88a5a
7172551: Remove Native calls from DriverManager for jigsaw
Reviewed-by: alanb, chegar, darcy, mchung
! make/java/java/FILES_c.gmk
! make/java/java/mapfile
Changeset: 46ff1b63b0c3
Author:lancea
Date: 2012-06-11 07:10 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46ff1b63b0c3
7171917: CachedRowSetImpl.populate does not handle map properly
Reviewed-by: joehw
! src/share/classes/com/sun/rowset/CachedRowSetImpl.java
Changeset: 6b6a73e8c036
Author:lancea
Date: 2012-06-12 17:32 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6b6a73e8c036
7171918: XmlReaderContentHandler.endElement does not handle a Delete Tag
properly
Reviewed-by: joehw
! src/share/classes/com/sun/rowset/internal/XmlReade
Changeset: 28588ace1fb9
Author:lancea
Date: 2012-06-14 15:05 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/28588ace1fb9
7145913: CachedRowSetSwriter.insertNewRow() throws SQLException
Reviewed-by: joehw, naoto, psandoz, forax
! src/share/classes/com/sun/rowset/internal/Cach
Changeset: 11bfec75d333
Author:lancea
Date: 2012-08-30 13:38 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11bfec75d333
7193683: DriverManager Iterator Warning cleanup
Reviewed-by: lancea
Contributed-by: Dan Xu
! src/share/classes/java/sql/DriverManager.java
Changeset: 8c6895afe204
Author:lancea
Date: 2012-09-06 13:16 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8c6895afe204
7192302: Remove JDBCRowSetImpl dependency on java.beans
Reviewed-by: alanb, mchung
! src/share/classes/com/sun/rowset/JdbcRowSetImpl.java
Changeset: 036c55976cef
Author:lancea
Date: 2012-10-09 08:58 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/036c55976cef
7197395: Add @Deprecated to all deprecated methods to eliminate compiler
warnings in JDBC
Reviewed-by: alanb, smarks
! src/share/classes/com/sun/rowset/C
Changeset: 3c4be36de073
Author:lancea
Date: 2012-10-10 11:15 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3c4be36de073
8000687: Correct javadoc typo for getLogWriter and setLogWriter
Reviewed-by: alanb
! src/share/classes/java/sql/DriverManager.java
Changeset: 734ca9f4719c
Author:lancea
Date: 2012-10-10 17:34 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/734ca9f4719c
8000712: Remove unused fields in SyncFactory
Reviewed-by: mchung
! src/share/classes/javax/sql/rowset/spi/SyncFactory.java
On Jul 16, 2009, at 5:37 AM, Andrew Haley wrote:
Ulf Zibis wrote:
Am 16.07.2009 11:17, Andrew Haley schrieb:
Ulf Zibis wrote:
Andrew,
can you tell me how you got access to the server as external
contributor
to post your patches?
1. Sign the SCA.
Yep, done since long time.
2. Ap
Changeset: 4ec7d1890538
Author:lancea
Date: 2009-08-20 19:21 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4ec7d1890538
6843995: Added RowsetFactory and Deprecate COMMIT_ON_ACCEPT_CHANGES, make
constants final that needed to be. (also reviewed by ksaks, ryano)
Reviewed-by:
Changeset: f1eb4c28b313
Author:lancea
Date: 2009-09-09 20:15 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f1eb4c28b313
6737212: Fixed javadoc warning messages in RowSet classes
Reviewed-by: darcy
! src/share/classes/com/sun/rowset/JdbcRowSetResourceBundle.java
! src/share/
Changeset: 3e239fe92832
Author:lancea
Date: 2010-08-10 10:07 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3e239fe92832
6898593: java.sql.Date.valueOf no exception if date given is not in the JDBC
date escape syntax
Reviewed-by: minqi
! src/share/classes/java/sql/Date.java
Changeset: 1f99ad63eb9e
Author:lancea
Date: 2010-09-04 12:21 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1f99ad63eb9e
6861385: Updated SQLException subclasses to clarify that they may be thrown for
vendor specific conditions
Reviewed-by: alanb
! src/share/classes/java/sq
Changeset: d44696691445
Author:lancea
Date: 2010-09-04 13:56 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d44696691445
6843995: RowSet 1.1 updates
Reviewed-by: darcy, valeriep
+ src/share/classes/com/sun/rowset/RowSetFactoryImpl.java
! src/share/classes/javax/sql/rowset/Ca
Changeset: c4defe31c94a
Author:lancea
Date: 2010-09-04 15:30 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c4defe31c94a
6680198: UnmarshalException caused by incompatible serialVersionUID
Reviewed-by: sherman
! src/share/classes/com/sun/rowset/CachedRowSetImpl.java
! src/sh
Changeset: 5cf79568f0b9
Author:lancea
Date: 2010-09-04 15:37 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5cf79568f0b9
6982510: Updated SQLException subclasses from the outback for 6861385 so that
the copyrights only have 2 years
Reviewed-by: alanb
! src/share/classes/ja
i's comment, it would be good to double check (pun
> intended!) for other synchronization issues in that code, for example in the
> JNDI initialization or between the setLogger and getLogger methods.
>
> -Alan.
Lance Andersen| Principal Member of Technical Staff | +1.781.442.
Changeset: c786a9c927fd
Author:lancea
Date: 2010-09-10 15:26 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c786a9c927fd
6589685: JDBC 4.1 updates
Reviewed-by: darcy
! src/share/classes/com/sun/rowset/CachedRowSetImpl.java
! src/share/classes/com/sun/rowset/JdbcRowSetImpl.ja
! src/share/classes/java/sql/Statement.java
>> ! src/share/classes/java/sql/Timestamp.java
>> ! src/share/classes/javax/sql/CommonDataSource.java
>>
>>
>
> Hi Lance,
> in getPseudoColumns doc comments, Pseudo is written 'Psuedo' twice.
>
> Rémi
>
>
>
Changeset: 73872b992aab
Author:lancea
Date: 2010-09-10 18:51 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/73872b992aab
6983984: Fixed typo in DatabaseMetaData.getPseudoColumns() javadocs
Reviewed-by: darcy
! src/share/classes/java/sql/DatabaseMetaData.java
indexe(s)" should be "index(es)"
>
> Paul
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
Oracle is committed to developing practices and products that help
protect the environment
Changeset: 7794d718ffe2
Author:lancea
Date: 2010-09-17 13:23 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7794d718ffe2
6983452: SyncProvider issue for JoinRowSet implementation
Reviewed-by: darcy, ohair
! src/share/classes/com/sun/rowset/CachedRowSetImpl.java
Changeset: 1
Changeset: 0d78b3eedecc
Author:lancea
Date: 2010-09-18 06:09 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0d78b3eedecc
6984044: RowSet source needs to rebrand vendor references
Reviewed-by: darcy, ohair
! src/share/classes/com/sun/rowset/internal/WebRowSetXmlWriter.java
!
Changeset: 7b2b0131fa61
Author:lancea
Date: 2010-09-27 18:05 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7b2b0131fa61
6987638: javadoc update to RowSetProvider and Statement
Reviewed-by: darcy, alanb
! src/share/classes/java/sql/Statement.java
! src/share/classes/javax/sq
Changeset: 9a8022905f6a
Author:lancea
Date: 2010-10-01 14:36 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9a8022905f6a
6988993: Address Findbugs warnings for the use of String Constructor
Reviewed-by: ohair
! src/share/classes/com/sun/rowset/CachedRowSetImpl.java
! src/sha
Changeset: ffaf6a35b895
Author:lancea
Date: 2010-10-04 13:04 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ffaf6a35b895
6989139: Address JDBC Findbugs where Number type Constructor are used
Reviewed-by: ohair
! src/share/classes/com/sun/rowset/CachedRowSetImpl.java
! src/sh
Changeset: 0f23a139e819
Author:lancea
Date: 2010-10-06 10:09 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0f23a139e819
6988310: SyncFactory.setLogger(Logger,Level) requires unspecified security
permission
Reviewed-by: darcy
! src/share/classes/javax/sql/rowset/spi/SyncFac
Changeset: af2de4de1076
Author:lancea
Date: 2010-11-12 07:15 -0500
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/af2de4de1076
6982530: javadoc update to SyncFactory & JdbcResource bundle for
synchronization issues
Reviewed-by: alanb
! src/share/classes/com/sun/rowset/JdbcRowSet
Changeset: c4a38022fdc1
Author:lancea
Date: 2010-11-12 08:41 -0500
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c4a38022fdc1
6999086: Clarify that SyncFactory.setLogger can throw an NullPointerException
Reviewed-by: alanb
! src/share/classes/javax/sql/rowset/spi/SyncFactory.java
701 - 800 of 1961 matches
Mail list logo
