On 19/06/14 13:53, Remi Forax wrote:
as you can see, javac generate an invokedynamic call with a Foo
instead of a FooBase which I think is the correct behavior.
You mean the other way around?
Maurizio
Changeset: 934a89402f85
Author:mcimadamore
Date: 2012-07-13 12:58 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/934a89402f85
7181578: javac reports uninitialized variable with nested try...finally blocks
Summary: regression introduced in refactoring of Flow.java
Changeset: cddc2c894cc6
Author:mcimadamore
Date: 2012-08-02 18:22 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/cddc2c894cc6
7175911: Simplify error reporting API in Check.CheckContext interface
Summary: Make error messages generated during Check.checkType more
Changeset: db36841709e4
Author:mcimadamore
Date: 2012-09-26 14:22 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/db36841709e4
7188968: New instance creation expression using diamond is checked twice
Summary: Unify method and constructor check logic
Reviewed-by: jjg
!
Changeset: 573ceb23beeb
Author:mcimadamore
Date: 2012-10-05 14:35 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/573ceb23beeb
7177385: Add attribution support for lambda expressions
Summary: Add support for function descriptor lookup, functional interface
inference
Changeset: d4b3cb1ece84
Author:mcimadamore
Date: 2012-10-06 10:35 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d4b3cb1ece84
7177386: Add attribution support for method references
Summary: Add type-checking/lookup routines for method references
Reviewed-by: jjg,
Changeset: d7d932236fee
Author:mcimadamore
Date: 2012-11-04 10:59 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d7d932236fee
7192246: Add type-checking support for default methods
Summary: Add type-checking support for default methods as per
Featherweight-Defender
Changeset: 9b85813d2262
Author:mcimadamore
Date: 2012-11-06 14:45 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9b85813d2262
8002286: Regression: Fix for 8000931 causes a JCK test failure
Summary: Wrong type used as 'site' in Resolve.resolveMethod
Reviewed-by: jjg
!
Changeset: 7538e419a588
Author:mcimadamore
Date: 2012-11-20 15:43 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7538e419a588
8003663: lambda test fails on Windows
Summary: fix path separator issue in test
Reviewed-by: jjg
! test/tools/javac/lambda/abort/Abort.java
Changeset: 4f9853659bf1
Author:mcimadamore
Date: 2012-11-30 15:14 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4f9853659bf1
8004105: Expression statement lambdas should be void-compatible
Summary: Fix lambda compatibility rules as per latest EDR
Reviewed-by: jjg
!
Changeset: 0e70eb71fec0
Author:mcimadamore
Date: 2012-12-04 17:19 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0e70eb71fec0
8004360: regression test DefaultMethodRegressionTests fails in langtools
Summary: ignore broken failing test
Reviewed-by: jjg
-
Changeset: c78acf6c2f3e
Author:mcimadamore
Date: 2012-12-10 12:10 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c78acf6c2f3e
8004094: Javac compiler error - synthetic method accessor generated with
duplicate name
Summary: method clash check logic should skip methods
Changeset: f20568328a57
Author:mcimadamore
Date: 2012-12-17 16:13 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f20568328a57
8004099: Bad compiler diagnostic generated when poly expression is passed to
non-existent method
Summary: Some code paths in resolve do not
Changeset: 250f0acf880c
Author:mcimadamore
Date: 2012-12-18 22:16 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/250f0acf880c
8005193: New regression test test/tools/javac/lambda/BadMethodCall2.java fails
Summary: Bad golden file in negative test
Reviewed-by: jjh
!
Changeset: 38d3d1027f5a
Author:mcimadamore
Date: 2013-01-08 10:15 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/38d3d1027f5a
8005243: Restructure method check code to allow pluggable checkers
Summary: Add interface to perform a method check - to be implemented by
Changeset: f785dcac17b7
Author:mcimadamore
Date: 2013-01-16 16:27 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f785dcac17b7
8005854: Add support for array constructor references
Summary: Support constructor references of the kind int[]::new
Reviewed-by: jjg
!
Changeset: 2d2b2be57c78
Author:mcimadamore
Date: 2013-01-17 18:15 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2d2b2be57c78
8005852: Treatment of '_' as identifier
Summary: warn when '_' is found in an identifier position
Reviewed-by: jjg
!
Changeset: 3d84ae209919
Author:mcimadamore
Date: 2013-01-18 15:38 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3d84ae209919
8006561: Langtools test failure: missing diags/examples
Summary: forgot to hg add tests
Reviewed-by: jjg
+
Changeset: 7873d37f5b37
Author:mcimadamore
Date: 2013-01-21 20:13 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7873d37f5b37
8005244: Implement overload resolution as per latest spec EDR
Summary: Add support for stuck expressions and provisional applicability
Changeset: be443002e970
Author:mcimadamore
Date: 2013-01-22 16:23 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/be443002e970
8006673: TargetType52 fails because of bad golden file
Summary: Fix golden file in negative test
Reviewed-by: jjg
!
Changeset: b61e5f801f7c
Author:mcimadamore
Date: 2013-01-22 16:39 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b61e5f801f7c
8006684: Compiler produces java.lang.VerifyError: Bad type on operand stack
Summary: Lambda desugaring generates spurious references to 'this'
Changeset: 97bd5e7151bc
Author:mcimadamore
Date: 2013-01-23 15:08 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/97bd5e7151bc
8006692: jdk/test/java/util/Collections/BigBinarySearch.java fails to compile
Summary: Missing boxing cause spurious inference failure
Changeset: 1df20330f6bd
Author:mcimadamore
Date: 2013-02-06 14:03 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1df20330f6bd
8007463: Cleanup inference related classes
Summary: Make Infer.InferenceContext an inner class; adjust bound replacement
logic in
Changeset: 2154ed9ff6c8
Author:mcimadamore
Date: 2013-02-12 19:25 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2154ed9ff6c8
8007464: Add graph inference support
Summary: Add support for more aggressive type-inference scheme
Reviewed-by: jjg
!
Changeset: d04960f05593
Author:mcimadamore
Date: 2013-02-13 17:04 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d04960f05593
8006345: Report Synthesized Parameters in java.lang.reflect.Parameter API
8006896: ClassReader doesn't see MethodParameters attr for method of
If we really care about running the test, javac has an hidden flag that
can be used to force the old inference scheme (I left that as an
emergency hatch in cases like these) - so I believe the test can be
compiled by using
-XDuseLegacyInference
That will essentially force a JDK 7-like
On 14/02/13 11:18, Chris Hegarty wrote:
I think it is fine to simply exclude the test for now. It can be
re-enabled whenever the issue is resolved in javac.
Looks fine - go ahead.
Thanks
Maurizio
-Chris.
On 02/14/2013 11:17 AM, Maurizio Cimadamore wrote:
If we really care about running
Changeset: 0baaae675b19
Author:mcimadamore
Date: 2013-02-15 16:28 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0baaae675b19
8006749: compiler does not allow Object protected methods to be used in lambda
Summary: Check.checkFunctionalInterface should take into account
Changeset: da2f7dd53915
Author:mcimadamore
Date: 2013-02-15 18:13 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/da2f7dd53915
8008309: TargetType60 fails because of bad golden file
Summary: bad golden file
Reviewed-by: jjg
! test/tools/javac/lambda/TargetType60.out
Changeset: d686d8a7eb78
Author:mcimadamore
Date: 2013-02-21 15:19 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d686d8a7eb78
8008227: Mixing lambdas with anonymous classes leads to NPE thrown by compiler
Summary: Disentangle cyclic dependency between static-ness of
Changeset: 8e82e4f225e4
Author:mcimadamore
Date: 2013-02-22 13:31 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8e82e4f225e4
8008337: Write test to check for compiler error when static method in interface
is called via super()
Reviewed-by: mcimadamore
Contributed-by:
Changeset: 94e67bed460d
Author:mcimadamore
Date: 2013-02-22 18:19 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/94e67bed460d
8008708: Regression: separate compilation causes crash in wildcards inference
logic
Summary: Invalid use of WildcardType.bound in
Changeset: 133a0a0c2cbc
Author:mcimadamore
Date: 2013-02-28 14:00 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/133a0a0c2cbc
8008723: Graph Inference: bad graph calculation leads to assertion error
Summary: Dependencies are not propagated correctly through merged
Changeset: 69cd2bfd4a31
Author:mcimadamore
Date: 2013-03-05 14:04 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/69cd2bfd4a31
8004962: Code generation crash with lambda and local classes
Summary: Translation info should be propagated from LambdaToMethod to Lower
Changeset: d0178bd8125c
Author:mcimadamore
Date: 2013-03-06 15:29 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d0178bd8125c
8009299: Javac crashes when compiling method reference to static interface
method
Summary: Assertion in Check.checMethod is too strict
Changeset: cc38a6723663
Author:mcimadamore
Date: 2013-03-22 12:38 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/cc38a6723663
8009649: Lambda back-end should generate invokespecial for method handles
referring to private instance methods
Summary: Private lambda
Changeset: 7bebe17ff323
Author:mcimadamore
Date: 2013-03-28 11:38 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7bebe17ff323
8010469: Bad assertion in LambdaToMethod
Summary: Add assertion in LambdaToMethod.serializedLambdaName
Reviewed-by: jjg
!
Changeset: b71a61d39cf7
Author:mcimadamore
Date: 2013-04-08 15:51 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b71a61d39cf7
8010922: Cleanup: add support for ad-hoc method check logic
Summary: Support pluggable method checkers
Reviewed-by: jjg
!
Changeset: b26f36a7ae3b
Author:mcimadamore
Date: 2013-04-15 14:11 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b26f36a7ae3b
8011383: Symbol.getModifiers omits ACC_ABSTRACT from interface with default
methods
Summary: Fixup for default method modifiers erroneously
Changeset: 05ec778794d0
Author:mcimadamore
Date: 2013-05-15 14:00 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/05ec778794d0
8012003: Method diagnostics resolution need to be simplified in some cases
Summary: Unfold method resolution diagnostics when they mention
Changeset: 58329d9f6b68
Author:mcimadamore
Date: 2013-05-24 15:26 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/58329d9f6b68
8014643: Parser regression in JDK 8 when compiling super.x
Summary: Fixed latent bug in JavacParser.analyzeParens()
Reviewed-by: jjg, vromero
Changeset: 5cd3cb69c8b3
Author:mcimadamore
Date: 2013-06-04 11:30 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/5cd3cb69c8b3
7116676: RichDiagnosticFormatter throws NPE when formatMessage is called
directly
Summary: Fix NPE in RichDiagnosticFormatter.formatMessage
Changeset: 6e30a513c945
Author:mcimadamore
Date: 2013-06-06 15:30 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6e30a513c945
6360970: javac erroneously accept ambiguous field reference
Summary: clash between ambiguous fields in superinterface and unambiguous field
in
Changeset: 3582b62dccb2
Author:mcimadamore
Date: 2013-06-10 15:57 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3582b62dccb2
8013576: Add stat support to LambdaToMethod
Summary: LambdaToMethod should emit info to help diagnose/test lambda
metafactory problems
Changeset: f559ef7568ce
Author:mcimadamore
Date: 2013-07-01 14:57 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f559ef7568ce
7034798: Ambiguity error for abstract method call is too eager
Summary: Javac should wait and see if ambiguous methods can be reconciled at
Changeset: 7b756b307e12
Author:mcimadamore
Date: 2013-07-05 11:00 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7b756b307e12
8017618: NullPointerException in RichDiagnosticFormatter for bad input program
Summary: RDF crashes when diagnostic contains type 'void'
On 11/07/13 13:26, Jim Laskey (Oracle) wrote:
+1
On 2013-07-11, at 9:13 AM, A. Sundararajan
sundararajan.athijegannat...@oracle.com wrote:
Bug: http://bugs.sun.com/view_bug.do?bug_id=7187144
Please review http://cr.openjdk.java.net/~sundar/7187144/
Thanks
-Sundar
Looks good
Maurizio
Changeset: 87a951c88a33
Author:mcimadamore
Date: 2013-07-11 15:37 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/87a951c88a33
8013404: Unclear spec for target typing with conditional operator (?:)
Summary: Fix previously ignored test
Reviewed-by: jjg, vromero
!
On 11/07/13 16:11, Remi Forax wrote:
On 07/11/2013 04:37 PM, maurizio.cimadam...@oracle.com wrote:
Changeset: 87a951c88a33
Author:mcimadamore
Date: 2013-07-11 15:37 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/87a951c88a33
8013404: Unclear spec for target typing with
Changeset: 44e27378f523
Author:mcimadamore
Date: 2013-07-17 14:04 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/44e27378f523
8012242: Lambda compatibility and checked exceptions
Summary: Inference variables in 'throws' clause with no constraints should be
inferred as
Changeset: 10711bd8bb2d
Author:jlahoda
Date: 2013-07-17 15:08 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/10711bd8bb2d
8020586: Warning produced for an incorrect file
Summary: Always using DeferredLintHandler.immediateHandler when processing
import classes
On 24/07/13 15:56, Chris Hegarty wrote:
Thanks for the review Alan ;-)
I would also like to add:
+ # 8021186
+ jdk/lambda/vm/DefaultMethodsTest.java generic-all
... until 8021186 can be addressed.
Thanks for taking care of this!
Maurizio
-Chris.
On 24/07/2013 14:48, Alan Bateman
Changeset: 3155e77d2676
Author:mcimadamore
Date: 2013-07-25 14:47 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3155e77d2676
8020804: javac crashes when speculative attribution infers intersection type
with array component
Summary: Assertion is causing javac to crash
Changeset: cd9e8cea1b3c
Author:jlahoda
Date: 2013-07-28 10:17 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/cd9e8cea1b3c
8021338: Diamond finder may mark a required type argument as unnecessary
Reviewed-by: mcimadamore
!
Changeset: 8c4b2987edac
Author:jlahoda
Date: 2013-07-28 10:17 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8c4b2987edac
8020689: Missing LineNumberTable entries in compiled class files
Reviewed-by: ksrini, mcimadamore
!
Changeset: f7f271bd74a2
Author:mcimadamore
Date: 2013-08-12 17:25 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f7f271bd74a2
6537020: JCK tests: a compile-time error should be given in case of ambiguously
imported fields (types, methods)
Summary: Hiding check does
Changeset: ec77c7b46c37
Author:jlahoda
Date: 2013-08-15 22:33 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ec77c7b46c37
8015809: More user friendly compile-time errors for uncaught exceptions in
lambda expression
Summary: Producing individual errors for uncaught
Changeset: bce19889597e
Author:mcimadamore
Date: 2010-11-10 12:37 +
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/bce19889597e
6996914: Diamond inference: problem when accessing protected constructor
Summary: special resolution scheme for diamond inference needs to open
Changeset: 58ceeff50af8
Author:mcimadamore
Date: 2010-11-12 12:32 +
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/58ceeff50af8
6598108: com.sun.source.util.Trees.isAccessible incorrect
Summary: JavacTrees' version of isAccessible should take into account enclosing
Changeset: a7ea58fa3e9a
Author:mcimadamore
Date: 2010-11-15 13:50 +
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/a7ea58fa3e9a
6985719: Alike methods in interfaces (Inheritance and Overriding)
Summary: javac should report error when interface inherits unrelated method
Changeset: 2536dedd897e
Author:mcimadamore
Date: 2010-11-23 11:08 +
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/2536dedd897e
6995200: JDK 7 compiler crashes when type-variable is inferred from expected
primitive type
Summary: 15.12.2.8 should use boxing when expected
Changeset: 9359f4222545
Author:mcimadamore
Date: 2010-12-03 16:31 +
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/9359f4222545
6956758: NPE in com.sun.tools.javac.code.Symbol - isSubClass
Summary: Use of TransTypes.cast() instead of TransTypes.coerce() causes NPE in
Changeset: 5fb14e67c371
Author:mcimadamore
Date: 2010-12-06 11:49 +
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/5fb14e67c371
7003744: Compiler error concerning final variables
Summary: Flow analysis does not cleanup init/uninint bit masks after for-loop
Reviewed-by:
Changeset: 5ef88773462b
Author:mcimadamore
Date: 2010-12-09 15:50 +
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/5ef88773462b
7005095: Cast: compile reject sensible cast from final class to interface
Summary: a previous fix to cast conversion has made the compiler too
Changeset: 2ca5866a8dfb
Author:mcimadamore
Date: 2010-12-10 15:23 +
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/2ca5866a8dfb
7005671: Regression: compiler accepts invalid cast from X[] to primitive array
Summary: regression in type conversion after 292 changes
Changeset: 15484cb7e5ae
Author:mcimadamore
Date: 2011-01-05 09:59 +
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/15484cb7e5ae
7010194: several langtools regression failures after JSR 292 changes (b123)
Summary: Some regression tests rely on unsupported JSR 292 features
On 05/01/11 11:23, Alan Bateman wrote:
Hi maurizio,
In my opinion, XlintWarn should also test invokeGeneric().
Moreover, it will be better to have one test by invoke*() instead of
having one
test for all invoke*()
Rémi
Hi Remi
I agree on your comments; however note that the aim of the
Changeset: 19c900c703c6
Author:mcimadamore
Date: 2011-01-24 15:44 +
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/19c900c703c6
6943278: spurious error message for inference and type-variable with erroneous
bound
Summary: type-inference should ignore erroneous bounds
Changeset: 3aa269645199
Author:mcimadamore
Date: 2011-02-07 18:09 +
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/3aa269645199
7017414: before the move of JSR 292 to package java.lang.invoke, javac must
recognize the new package
Summary: added support for future 292
Changeset: 4ce95dc0b908
Author:mcimadamore
Date: 2011-02-18 12:28 +
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4ce95dc0b908
7020043: Project Coin: diamond allowed on non-generic type
Summary: Diamond oerator should be disallowed on non-generic class types (i.e.
Changeset: 51e643f41a3a
Author:mcimadamore
Date: 2011-02-18 16:17 +
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/51e643f41a3a
7020626: diamond: add diagnostic test for diamond and non-generic classes
Summary: Fix failure in regression test CheckExamples
Reviewed-by:
Changeset: 9286a5d1fae3
Author:mcimadamore
Date: 2011-02-28 11:48 +
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/9286a5d1fae3
7015430: Incorrect thrown type determined for unchecked invocations
Summary: Thrown types do not get updated after 15.12.2.8, and do not get
Changeset: 02b699d97a55
Author:mcimadamore
Date: 2011-03-02 10:56 +
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/02b699d97a55
6541876: Enclosing Instance error new in 1.6
Summary: unqualified 'this' should not be selected in a qualified super() call
in a default
Changeset: e9b8fbb30f5a
Author:mcimadamore
Date: 2011-03-03 09:43 +
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e9b8fbb30f5a
7023233: False positive for -Xlint:try with nested try with resources blocks
Summary: Wrong lint warning issued about unused resource when
Changeset: c15d788cb381
Author:mcimadamore
Date: 2011-03-03 17:32 +
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/c15d788cb381
7023703: Valid code doesn't compile
Summary: leftovers cause problems when analyzing loops in Flow.java
Reviewed-by: jjg
!
Changeset: 8fb48a9ac9ec
Author:mcimadamore
Date: 2011-03-03 18:05 +
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/8fb48a9ac9ec
7024212: TestWarnErrorCount fails
Summary: TestWarnErrorCount should be executed with -Xlint:all,-path to avoid
spurious failures
Reviewed-by:
On 03/03/2011 20:43, David Holmes wrote:
Kumar Srinivasan said the following on 03/04/11 05:40:
Please review, corrections to the diamond operator on anonymous classes
as suggested by langtools team.
http://cr.openjdk.java.net/~ksrini/7023963/webrev.0/
Looks fine of course, but it is sad
Changeset: ca32f2986301
Author:mcimadamore
Date: 2011-03-07 14:31 +
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/ca32f2986301
7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
Summary: Disallow diamond on anonymous innner class creation
Changeset: 74f0c05c51eb
Author:mcimadamore
Date: 2011-03-07 14:11 +
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/74f0c05c51eb
7024568: Very long method resolution causing OOM error
Summary: Resolve.findMethod scans same receiver type more than once in certain
Changeset: 4fd20d5b7295
Author:mcimadamore
Date: 2011-03-09 16:47 +
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4fd20d5b7295
7025988: Test test/tools/javac/file/zip/T6836682.java takes too long to complete
Summary: added @ignore tag to temporarily disable the test
Changeset: 5b29f2a85085
Author:mcimadamore
Date: 2011-03-16 11:12 +
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/5b29f2a85085
6558548: The compiler needs to be aligned with clarified specification of throws
Summary: Javac should issue unconditional warnings when 'dead'
Changeset: 2007998f89f2
Author:mcimadamore
Date: 2011-03-29 16:40 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/2007998f89f2
7030687: Diamond: compiler accepts erroneous code where diamond is used with
non-generic inner class
Summary: Diamond accepts
Changeset: b945b846c979
Author:mcimadamore
Date: 2011-04-01 12:30 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/b945b846c979
7032633: javac -Xlint:all warns about flush() within try on an auto-closeable
resource
Summary: missing name check before calling
Changeset: f00986f55961
Author:mcimadamore
Date: 2011-04-12 20:56 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/f00986f55961
7034511: Loophole in typesafety
Summary: Type-variable substutution takes upper bound of replaced captured
type-variable
Reviewed-by: dlsmith
Changeset: 671bb63f3ed5
Author:mcimadamore
Date: 2011-04-19 13:57 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/671bb63f3ed5
7036906: Scope: CompoundScope.getElements() doesn't pass scope filter to
subscopes
Summary: CompoundScope.getElements() is not filtering
On 27/04/11 09:05, Maurizio Cimadamore wrote:
On 27/04/11 03:42, David Holmes wrote:
Hi Joe,
I sent email to coin-dev on this yesterday but it doesn't seem to
have turned up - at least I haven't seen it.
In some cases at least these catch clauses are in fact reachable -
e.g
On 27/04/11 09:18, David Holmes wrote:
Maurizio Cimadamore said the following on 04/27/11 18:05:
On 27/04/11 03:42, David Holmes wrote:
I sent email to coin-dev on this yesterday but it doesn't seem to
have turned up - at least I haven't seen it.
In some cases at least these catch clauses
On 27/04/11 09:40, David Holmes wrote:
Maurizio Cimadamore said the following on 04/27/11 18:35:
On 27/04/11 09:18, David Holmes wrote:
What I suggested on coin-dev ( which has finally turned up now that
someone has unblocked the openjdk mail pipes ;-) ) is that instead
of doing an analysis
On 27/04/11 09:18, David Holmes wrote:
Special-casing Throwable wouldn't be sufficient as people may use
Exception instead.
I guess this doesn't invalidate the argument - we could special-case
Exception AND Throwable, since they are already treated specially in the
language...
Maurizio
On 27/04/11 13:51, Maurizio Cimadamore wrote:
On 27/04/11 09:18, David Holmes wrote:
Special-casing Throwable wouldn't be sufficient as people may use
Exception instead.
I guess this doesn't invalidate the argument - we could special-case
Exception AND Throwable, since they are already
Changeset: 4c03383f6529
Author:mcimadamore
Date: 2011-04-29 16:05 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4c03383f6529
7040104: javac NPE on Object a[]; Object o = (a=null)[0];
Summary: When a null literal is found on top of stack, if expected type is
Changeset: 4caf17560ae0
Author:mcimadamore
Date: 2011-04-30 11:57 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4caf17560ae0
7039931: Project Coin: diamond inference fail with generic constructor explicit
type-arguments
Summary: diamond should be disallowed in cases
Changeset: 384ea9a98912
Author:mcimadamore
Date: 2011-05-02 12:05 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/384ea9a98912
7040883: Compilation error: length in Array is defined in an inaccessible
class or interface
Summary: Fix of 7034511 (now backed out) is
Changeset: a2d422d480cb
Author:mcimadamore
Date: 2011-05-11 13:10 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/a2d422d480cb
7042566: Regression: new ambiguity between varargs method
Summary: Erroneous ambiguity error when choosing most specific varargs method
Changeset: 5faa9eedc44e
Author:mcimadamore
Date: 2011-05-16 09:38 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/5faa9eedc44e
7043922: Regression: internal compiler error for nested anonymous inner class
featuring varargs constructor
Summary: Attributing a constructor
Changeset: 6bb526ccf5ff
Author:mcimadamore
Date: 2011-05-23 11:55 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/6bb526ccf5ff
7046348: Regression: javac complains of missing classfile for a seemingly
unrelated interface
Summary: Types.implementation forces unnecessary
Changeset: 0b5beb9562c6
Author:mcimadamore
Date: 2011-07-27 19:00 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0b5beb9562c6
7062745: Regression: difference in overload resolution when two methods are
maximally specific
Summary: Fix most specific when two methods are
Changeset: b86277584776
Author:mcimadamore
Date: 2011-08-31 16:11 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b86277584776
7085024: internal error; cannot instantiate Foo
Summary: Types.isConvertible does not handle erroneous types correctly
Reviewed-by: jjg
!
Changeset: ec27e5befa53
Author:mcimadamore
Date: 2011-09-02 17:35 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ec27e5befa53
7086261: javac doesn't report error as expected, it only reports
ClientCodeWrapper$DiagnosticSourceUnwrapper
Summary: Missing override for
Changeset: ed338593b0b6
Author:mcimadamore
Date: 2011-09-13 14:14 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ed338593b0b6
7086595: Error message bug: name of initializer is 'null'
Summary: Implementation of MethodSymbol.location() should take into account
1 - 100 of 813 matches
Mail list logo
