On Thu, 5 May 2022 09:00:47 GMT, Athijegannathan Sundararajan
wrote:
> This test requires jdk8 to be available while running jdk tests. But
> JDK8_HOME is defined to be BOOT_JDK and so version check fails in the test.
> The test vacuously passes just printing a message. There ar
This test requires jdk8 to be available while running jdk tests. But JDK8_HOME
is defined to be BOOT_JDK and so version check fails in the test. The test
vacuously passes just printing a message. There are already tests that exercise
jrt-fs.jar on the same JDK being tested and so basic
On Fri, 22 Apr 2022 15:08:51 GMT, Magnus Ihse Bursie wrote:
> I ran `codespell` on modules owned by core-libs, and accepted those changes
> where it indeed discovered real typos.
>
> I will update copyright years using a script before pushing (otherwise like
> every second change would be a
On Tue, 29 Mar 2022 20:05:50 GMT, Mandy Chung wrote:
> A small improvement to `RawNativeLibraries`. `RawNativeLibraries::load`
> returns the same `NativeLibrary` instance of a given path if it's called
> multiple times. This means that multiple clients have to coordinate that the
> last one
On Mon, 21 Mar 2022 18:17:06 GMT, Mandy Chung wrote:
> > $ javac com/acme/*.java
> > is fine. Am I missing something?
>
> If you make P.Q private, it will fail the compilation.
>
Yes, I got that part. I did make a comment earlier ("Two of those subclasses
are nested "private" in another
On Sun, 20 Mar 2022 21:31:15 GMT, Joe Darcy wrote:
> Small refactoring to use sealed classes in the MethodHandle implementation
> hierarchy.
>
> DelegatingMethodHandle is non-sealed rather than sealed since it has two
> subclasses, one defined as a nested class and only a separate type in the
On Sun, 20 Mar 2022 21:31:15 GMT, Joe Darcy wrote:
> Small refactoring to use sealed classes in the MethodHandle implementation
> hierarchy.
>
> DelegatingMethodHandle is non-sealed rather than sealed since it has two
> subclasses, one defined as a nested class and only a separate type in the
On Sun, 20 Mar 2022 21:31:15 GMT, Joe Darcy wrote:
> Small refactoring to use sealed classes in the MethodHandle implementation
> hierarchy.
>
> DelegatingMethodHandle is non-sealed rather than sealed since it has two
> subclasses, one defined as a nested class and only a separate type in the
On Tue, 8 Mar 2022 10:50:35 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to implement the
> enhancement requested in https://bugs.openjdk.java.net/browse/JDK-8282572?
>
> The (public) `EnumSet` class has 2 package private (JDK) internal sub-classes
> -
On Tue, 8 Mar 2022 10:50:35 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to implement the
> enhancement requested in https://bugs.openjdk.java.net/browse/JDK-8282572?
>
> The (public) `EnumSet` class has 2 package private (JDK) internal sub-classes
> -
On Thu, 17 Feb 2022 05:11:40 GMT, Joe Darcy wrote:
>> Make explicit illegal argument cases of Class.arrayType.
>>
>> Please also review the corresponding CSR:
>> https://bugs.openjdk.java.net/browse/JDK-8268300
>
> Joe Darcy has updated the pull request incrementally with one additional
>
On Thu, 17 Feb 2022 02:56:53 GMT, Joe Darcy wrote:
>> Make explicit illegal argument cases of Class.arrayType.
>>
>> Please also review the corresponding CSR:
>> https://bugs.openjdk.java.net/browse/JDK-8268300
>
> Joe Darcy has updated the pull request with a new target base due to a merge
>
On Thu, 17 Feb 2022 02:56:53 GMT, Joe Darcy wrote:
>> Make explicit illegal argument cases of Class.arrayType.
>>
>> Please also review the corresponding CSR:
>> https://bugs.openjdk.java.net/browse/JDK-8268300
>
> Joe Darcy has updated the pull request with a new target base due to a merge
>
On Fri, 11 Feb 2022 03:49:45 GMT, Mandy Chung wrote:
>> This patch removes the restriction in the raw library loading mechanism that
>> does not allow mix-n-match of loading a library as a JNI library and as a
>> raw library.
>>
>> The raw library loading mechanism is designed for panama to
On Thu, 10 Feb 2022 23:27:49 GMT, Mandy Chung wrote:
> This patch removes the restriction in the raw library loading mechanism that
> does not allow mix-n-match of loading a library as a JNI library and as a raw
> library.
>
> The raw library loading mechanism is designed for panama to load
On Thu, 16 Dec 2021 06:33:24 GMT, Stuart Marks wrote:
> A small modification to the Launcher's help text.
LGTM
-
Marked as reviewed by sundar (Reviewer).
PR: https://git.openjdk.java.net/jdk18/pull/34
On Tue, 14 Dec 2021 10:24:07 GMT, Maurizio Cimadamore
wrote:
>> This patch fixes a number of issues and typos in the foreign API javadoc
>> following another internal round of reviews.
>
> Maurizio Cimadamore has updated the pull request incrementally with one
> additional commit since the
On Tue, 14 Dec 2021 02:07:00 GMT, Maurizio Cimadamore
wrote:
>> This patch fixes a number of issues and typos in the foreign API javadoc
>> following another internal round of reviews.
>
> Maurizio Cimadamore has updated the pull request incrementally with one
> additional commit since the
On Fri, 3 Dec 2021 10:03:30 GMT, Athijegannathan Sundararajan
wrote:
> jlink plugins dump .class files in debug mode. jpackage tests already set
> jlink.debug property to true.
This pull request has now been integrated.
Changeset: ba2a8e5a
Author:Athijegannathan Sundararaja
jlink plugins dump .class files in debug mode. jpackage tests already set
jlink.debug property to true.
-
Commit messages:
- 8278205: jlink plugins should dump .class file in debug mode
Changes: https://git.openjdk.java.net/jdk/pull/6696/files
Webrev:
On Thu, 2 Dec 2021 12:26:33 GMT, Maurizio Cimadamore
wrote:
> This patch adds missing `@throws` tags to the javadoc of `MemorySegment::set`
> and `MemorySegment::setAtIndex`.
> These methods can fail with `UnsupportedOperationException` if the segment is
> read-only.
LGTM
-
On Wed, 24 Nov 2021 08:54:08 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which adds `jlink.debug=true` system
> property while launching `jpackage` tests?
>
> The previous fix for this in https://github.com/openjdk/jdk/pull/6491 didn't
> take into account the part
On Thu, 23 Sep 2021 14:43:21 GMT, Jan Lahoda wrote:
> I'd like to upgrade the internal JLine to 3.20.0, to support the rxvt
> terminal (see JDK-8270943), and to generally use a newer version of the
> library. This patch is basically a application of relevant parts of the diff
> between JLine
On Tue, 29 Jun 2021 04:39:28 GMT, Jonathan Gibbons wrote:
> Please review a trivial `noreg-doc` fix for some javadoc tags for
> `java.lang.Runtime` for JDK17
LGTM
-
Marked as reviewed by sundar (Reviewer).
PR: https://git.openjdk.java.net/jdk17/pull/167
On Mon, 7 Jun 2021 11:00:00 GMT, Athijegannathan Sundararajan
wrote:
> jlink should clean up output directory on any failure. should not leave
> partially filled output.
This pull request has now been integrated.
Changeset: 4d1cf51b
Author:Athijegannathan Sundararajan
URL:
> jlink should clean up output directory on any failure. should not leave
> partially filled output.
Athijegannathan Sundararajan has updated the pull request incrementally with
one additional commit since the last revision:
Fixed resouce closing issue for lib/moduls file. Pre-ex
On Tue, 8 Jun 2021 11:32:29 GMT, Alan Bateman wrote:
>> jlink should clean up output directory on any failure. should not leave
>> partially filled output.
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java line 295:
>
>> 293: cleanupOutput(outputPath);
>> 294:
On Tue, 8 Jun 2021 12:20:32 GMT, Jorn Vernee wrote:
> WRT the test failure on Windows discussed offline: when the directory is
> deleted as a result of a `PluginException` being thrown, there is still an
> open file handle on the `lib/modules` file in the image directory, which
> prevents the
On Mon, 7 Jun 2021 13:23:46 GMT, Jorn Vernee wrote:
> Hi,
>
> The documentation of `CLinker::systemLookup` [1] says this:
>
>
> * Obtains a system lookup which is suitable to find symbols in the standard C
> libraries.
>
>
> However, currently it is not possible to look up common stdio.h
jlink should clean up output directory on any failure. should not leave
partially filled output.
-
Commit messages:
- 8240349: jlink --vm with not present VM does not fail fast
Changes: https://git.openjdk.java.net/jdk/pull/4386/files
Webrev:
On Thu, 27 May 2021 09:23:50 GMT, Athijegannathan Sundararajan
wrote:
> fixed constructor argument passing issue.
This pull request has now been integrated.
Changeset: ec65cf83
Author: Athijegannathan Sundararajan
URL:
https://git.openjdk.java.net/jdk/com
fixed constructor argument passing issue.
-
Commit messages:
- 8240347: remove undocumented options from jlink --help message
Changes: https://git.openjdk.java.net/jdk/pull/4221/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=4221=00
Issue:
On Wed, 26 May 2021 07:55:53 GMT, Athijegannathan Sundararajan
wrote:
> FileVisitOption.FOLLOW_LINKS used. Test extended for file symlinks case.
This pull request has now been integrated.
Changeset: bf8d4a8e
Author: Athijegannathan Sundararajan
URL:
https://git.openjdk.java.net/
FileVisitOption.FOLLOW_LINKS used. Test extended for file symlinks case.
-
Commit messages:
- 8267583: jmod fails on symlink to class file
Changes: https://git.openjdk.java.net/jdk/pull/4202/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=4202=00
Issue:
On Fri, 14 May 2021 05:39:10 GMT, Athijegannathan Sundararajan
wrote:
> Problematic paths that start with /modules/modules prefix are handled properly
This pull request has now been integrated.
Changeset: af4cd04c
Author: Athijegannathan Sundararajan
URL:
ht
> Problematic paths that start with /modules/modules prefix are handled properly
Athijegannathan Sundararajan has updated the pull request incrementally with
one additional commit since the last revision:
edited comment as per code review.
-
Changes:
- all: ht
Problematic paths that start with /modules/modules prefix are handled properly
-
Commit messages:
- fixed typos in comments
- 8266291: (jrtfs) Calling Files.exists may break the JRT filesystem
Changes: https://git.openjdk.java.net/jdk/pull/4022/files
Webrev:
On Tue, 4 May 2021 09:05:38 GMT, Athijegannathan Sundararajan
wrote:
> Instead of BufferReference class, Map.Entry is used as pair implementation.
> This avoids the metaspace leak seen via thread local.
This pull request has now been integrated.
Changeset: c9873c41
Author:Athijegan
Instead of BufferReference class, Map.Entry is used as pair implementation.
This avoids the metaspace leak seen via thread local.
-
Commit messages:
- added comment. generics cleanup.
- 8260621: (jrtfs) ThreadLocal memory leak in ImageBufferCache when using jrtfs
Changes:
On Sun, 28 Mar 2021 13:38:51 GMT, Attila Szegedi wrote:
>> I noticed that `javax.script.ScriptEngineManager` `getEngineByXxx` methods
>> had a lot of code duplication among themselves, and even within each method.
>> I refactored them into a modern unified implementation. While there I also
On Sun, 28 Feb 2021 16:46:31 GMT, Attila Szegedi wrote:
> 8262503: Support records in Dynalink
Looks good
-
Marked as reviewed by sundar (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/2767
On Mon, 25 Jan 2021 16:09:01 GMT, Claes Redestad wrote:
>> This patch optimizes the code paths exercised by
>> `String.class.getResource("String.class")` by:
>>
>> - Adding an ASCII fast-path to methods verifying strings in the jimage,
>> which can then be done allocation-free
>> - Avoiding
On Fri, 15 Jan 2021 05:19:44 GMT, Athijegannathan Sundararajan
wrote:
> Fixed compilation issues with the test. Test compiles and runs fine locally.
This pull request has now been integrated.
Changeset: c0cde7dc
Author: Athijegannathan Sundararajan
URL: https://git.openjdk.java.
> Fixed compilation issues with the test. Test compiles and runs fine locally.
Athijegannathan Sundararajan has updated the pull request incrementally with
one additional commit since the last revision:
Removed CompressorPluginTest.java from ProblemList.txt
-
Changes:
-
Fixed compilation issues with the test. Test compiles and runs fine locally.
-
Commit messages:
- 8259814: test/jdk/tools/jlink/plugins/CompressorPluginTest.java has
compilation issues
Changes: https://git.openjdk.java.net/jdk/pull/2091/files
Webrev:
On Tue, 12 Jan 2021 15:48:18 GMT, Maurizio Cimadamore
wrote:
> When support for shared segment was added, we decided to disable support for
> buffers derived from shared segment in certain async operations, as there's
> currently no way to make sure that the memory won't be reclaimed while
On Mon, 7 Dec 2020 16:35:52 GMT, Athijegannathan Sundararajan
wrote:
> Safe URI encode logic adopted from UnixUriUtils.
This pull request has now been integrated.
Changeset: d2b66196
Author: Athijegannathan Sundararajan
URL: https://git.openjdk.java.net/jdk/commit/d2b66196
St
On Mon, 7 Dec 2020 19:59:40 GMT, Alan Bateman wrote:
>> Athijegannathan Sundararajan has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> renamed the test as per review comment.
>
> test/jdk/jdk/internal/
> Safe URI encode logic adopted from UnixUriUtils.
Athijegannathan Sundararajan has updated the pull request incrementally with
one additional commit since the last revision:
renamed the test as per review comment.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1
Safe URI encode logic adopted from UnixUriUtils.
-
Commit messages:
- 8242258: (jrtfs) Path::toUri throws AssertionError for malformed input
Changes: https://git.openjdk.java.net/jdk/pull/1669/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1669=00
Issue:
On Thu, 3 Dec 2020 14:57:16 GMT, Evan Whelan wrote:
> This is a straightforward fix to resolve a potential memory leak in
> imageFile.cpp.
>
> If `find_location` returns true, the `path` char array is never released.
>
> This has been fixed
Marked as reviewed by sundar (Reviewer).
On Wed, 25 Nov 2020 22:00:13 GMT, Jorn Vernee wrote:
>> This patch fixes several failures on x86_32 of java/foreign tests.
>>
>> This is mostly done by disabling the failing tests, but the impl of CLinker
>> is also adjusted ton properly detect 32 bit platforms as unsupported.
>>
>> CLinker
On Mon, 23 Nov 2020 18:22:14 GMT, Maurizio Cimadamore
wrote:
>> Both the Foreign Memory Access and the Foreign Linker APIs leave something
>> to be desired when it comes to handling NPEs - first, most of the API
>> javadoc is oblivious to NPEs being thrown. Secondly, not all API method
>>
On Wed, 18 Nov 2020 10:08:20 GMT, Maurizio Cimadamore
wrote:
>> The current memory segment implementation defines a hierarchy with 3
>> concrete classes: one for heap segments, one for native segments and one for
>> mapped segments.
>>
>> Since there can be many kinds of heap segments (e.g.
On Wed, 9 Sep 2020 19:38:38 GMT, Mandy Chung wrote:
> `jlink --generate-jli-classes` plugin should retain the original holder
> classes if the default_jli_trace.txt
> file does not exist.
>
> Before JDK-8252725, `JavaLangInvokeAccess::generateXXXHolderClassesBytes`
> methods are invoked
>
55 matches
Mail list logo
