Re: RFR: 6478546: FileInputStream.read() throws OutOfMemoryError when there is plenty available

2022-04-14 Thread Daniel Jeliński
On Thu, 14 Apr 2022 01:40:50 GMT, Brian Burkhalter wrote: > Modify native multi-byte read-write code used by the `java.io` classes to > limit the size of the allocated native buffer thereby decreasing off-heap > memory footprint and increasing throughput. The benchmark results are quite

Re: RFR: 8284161: Implementation of Virtual Threads (Preview)

2022-04-12 Thread Daniel Jeliński
On Fri, 8 Apr 2022 13:43:39 GMT, Alan Bateman wrote: > This is the implementation of JEP 425: Virtual Threads (Preview); TBD which > JDK version to target. > > We will refresh this PR periodically to pick up changes and fixes from the > loom repo. > > Most of the new mechanisms in the

Re: RFR: 8284161: Implementation of Virtual Threads (Preview)

2022-04-12 Thread Daniel Jeliński
On Fri, 8 Apr 2022 13:43:39 GMT, Alan Bateman wrote: > This is the implementation of JEP 425: Virtual Threads (Preview); TBD which > JDK version to target. > > We will refresh this PR periodically to pick up changes and fixes from the > loom repo. > > Most of the new mechanisms in the

Integrated: 8284444: Sting typo

2022-04-07 Thread Daniel Jeliński
On Wed, 6 Apr 2022 12:07:30 GMT, Daniel Jeliński wrote: > This patch adds missing `r` in `string`s This pull request has now been integrated. Changeset: 5bafcfdc Author: Daniel Jeliński URL: https://git.openjdk.java.net/jdk/commit/5bafcfdc171b5a514ecf620703e77fa2f4a49c58 St

Re: RFR: 8284444: Sting typo [v2]

2022-04-06 Thread Daniel Jeliński
On Wed, 6 Apr 2022 15:49:06 GMT, Naoto Sato wrote: >> Daniel Jeliński has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert liblcms changes > > src/java.base/share/classes/jdk/internal/icu/text/Str

Re: RFR: 8284444: Sting typo [v3]

2022-04-06 Thread Daniel Jeliński
> This patch adds missing `r` in `string`s Daniel Jeliński has updated the pull request incrementally with two additional commits since the last revision: - revert xalan changes - revert icu changes - Changes: - all: https://git.openjdk.java.net/jdk/pull/8125/files -

Re: RFR: 8284444: Sting typo [v2]

2022-04-06 Thread Daniel Jeliński
On Wed, 6 Apr 2022 13:36:05 GMT, Alexey Ivanov wrote: >> Daniel Jeliński has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert liblcms changes > > src/jdk.jpackage/windows/classes/jdk/jpackage/internal/res

Re: RFR: 8284444: Sting typo [v2]

2022-04-06 Thread Daniel Jeliński
> This patch adds missing `r` in `string`s Daniel Jeliński has updated the pull request incrementally with one additional commit since the last revision: Revert liblcms changes - Changes: - all: https://git.openjdk.java.net/jdk/pull/8125/files - new: ht

Re: RFR: 8284444: Sting typo

2022-04-06 Thread Daniel Jeliński
On Wed, 6 Apr 2022 13:38:03 GMT, Alexey Ivanov wrote: >> This patch adds missing `r` in `string`s > > src/java.desktop/share/native/liblcms/cmstypes.c line 3668: > >> 3666: // Auxiliary, read an string specified as count + string >> 3667: static >> 3668: cmsBool ReadCountAndString(struct

RFR: 8284444: Sting typo

2022-04-06 Thread Daniel Jeliński
This patch adds missing `r` in `string`s - Commit messages: - Fix sting typo Changes: https://git.openjdk.java.net/jdk/pull/8125/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8125=00 Issue: https://bugs.openjdk.java.net/browse/JDK-828 Stats: 25 lines in 8 files

Re: RFR: 8282429: StringBuilder/StringBuffer.toString() skip compressing for UTF16 strings [v5]

2022-03-26 Thread Daniel Jeliński
On Wed, 23 Mar 2022 00:35:14 GMT, Xin Liu wrote: >> If AbstractStringBuilder only grow, the inflated value which has been >> encoded in UTF16 can't be compressed. >> toString() can skip compression in this case. This can save an >> ArrayAllocation in StringUTF16::compress(). >> >>

Re: RFR: 8282429: StringBuilder/StringBuffer.toString() skip compressing for UTF16 strings [v3]

2022-03-09 Thread Daniel Jeliński
On Wed, 9 Mar 2022 08:33:36 GMT, Xin Liu wrote: >> If AbstractStringBuilder only grow, the inflated value which has been >> encoded in UTF16 can't be compressed. >> toString() can skip compression in this case. This can save an >> ArrayAllocation in StringUTF16::compress(). >> >>

Re: RFR: 8282429: StringBuilder/StringBuffer.toString() skip compressing for UTF16 strings [v2]

2022-03-08 Thread Daniel Jeliński
On Mon, 7 Mar 2022 23:36:41 GMT, Xin Liu wrote: >> If AbstractStringBuilder only grow, the inflated value which has been >> encoded in UTF16 can't be compressed. >> toString() can skip compression in this case. This can save an >> ArrayAllocation in StringUTF16::compress(). >> >>

Re: RFR: 8282429: StringBuilder/StringBuffer.toString() skip compressing for UTF16 strings

2022-03-07 Thread Daniel Jeliński
On Thu, 3 Mar 2022 02:36:58 GMT, Xin Liu wrote: > If AbstractStringBuilder only grow, the inflated value which has been encoded > in UTF16 can't be compressed. > toString() can skip compression in this case. This can save an > ArrayAllocation in StringUTF16::compress(). > >

Re: RFR: 8282429: StringBuilder/StringBuffer.toString() skip compressing for UTF16 strings

2022-03-03 Thread Daniel Jeliński
On Thu, 3 Mar 2022 02:36:58 GMT, Xin Liu wrote: > If AbstractStringBuilder only grow, the inflated value which has been encoded > in UTF16 can't be compressed. > toString() can skip compression in this case. This can save an > ArrayAllocation in StringUTF16::compress(). > >

Re: RFR: 8282429: StringBuilder/StringBuffer.toString() skip compressing for UTF16 strings

2022-03-03 Thread Daniel Jeliński
On Thu, 3 Mar 2022 02:36:58 GMT, Xin Liu wrote: > If AbstractStringBuilder only grow, the inflated value which has been encoded > in UTF16 can't be compressed. > toString() can skip compression in this case. This can save an > ArrayAllocation in StringUTF16::compress(). > >

Re: RFR: 8282551: Properly initialize L32X64MixRandom state

2022-03-02 Thread Daniel Jeliński
On Tue, 18 Jan 2022 01:39:52 GMT, Devin Smith wrote: > Did a cursory review of the other generators, they seem to set the state > correctly. Created https://bugs.openjdk.java.net/browse/JDK-8282551 for this. @devinrsmith please change the issue title to `8282551: Properly initialize

Re: RFR: 8282551: Properly initialize L32X64MixRandom state

2022-03-02 Thread Daniel Jeliński
On Mon, 21 Feb 2022 19:43:52 GMT, Devin Smith wrote: >> Did a cursory review of the other generators, they seem to set the state >> correctly. > > I'm not sure how to move this forward, or get the attention of the people > responsible for this code. I see @turbanoff you liked and may be

Integrated: 8281525: Enable Zc:strictStrings flag in Visual Studio build

2022-02-24 Thread Daniel Jeliński
On Mon, 21 Feb 2022 19:55:14 GMT, Daniel Jeliński wrote: > Please review this PR that enables > [Zc:strictStrings](https://docs.microsoft.com/en-us/cpp/build/reference/zc-strictstrings-disable-string-literal-type-conversion?view=msvc-170) > compiler flag, which makes assigning a strin

Re: RFR: 8281525: Enable Zc:strictStrings flag in Visual Studio build [v2]

2022-02-24 Thread Daniel Jeliński
On Tue, 22 Feb 2022 16:43:28 GMT, Daniel Jeliński wrote: >> Please review this PR that enables >> [Zc:strictStrings](https://docs.microsoft.com/en-us/cpp/build/reference/zc-strictstrings-disable-string-literal-type-conversion?view=msvc-170) >> compiler flag, which makes

Re: RFR: 8281525: Enable Zc:strictStrings flag in Visual Studio build [v2]

2022-02-22 Thread Daniel Jeliński
On Tue, 22 Feb 2022 16:35:09 GMT, Magnus Ihse Bursie wrote: >> Done > > Did you forget to push the fix? Push works better when connected... this time it's pushed for real. - PR: https://git.openjdk.java.net/jdk/pull/7565

Re: RFR: 8281525: Enable Zc:strictStrings flag in Visual Studio build [v2]

2022-02-22 Thread Daniel Jeliński
d that the build passes both with and without `--enable-debug`, both > with VS2017 and VS2019. Daniel Jeliński has updated the pull request incrementally with one additional commit since the last revision: Move strictStrings to toolchain_cflags - Changes: - all: https://

Re: RFR: 8281525: Enable Zc:strictStrings flag in Visual Studio build

2022-02-22 Thread Daniel Jeliński
On Tue, 22 Feb 2022 11:33:52 GMT, Magnus Ihse Bursie wrote: >> Please review this PR that enables >> [Zc:strictStrings](https://docs.microsoft.com/en-us/cpp/build/reference/zc-strictstrings-disable-string-literal-type-conversion?view=msvc-170) >> compiler flag, which makes assigning a string

RFR: 8281525: Enable Zc:strictStrings flag in Visual Studio build

2022-02-21 Thread Daniel Jeliński
Please review this PR that enables [Zc:strictStrings](https://docs.microsoft.com/en-us/cpp/build/reference/zc-strictstrings-disable-string-literal-type-conversion?view=msvc-170) compiler flag, which makes assigning a string literal to a non-const pointer a compile-time error. This type of

Integrated: 8281259: MutableBigInteger subtraction could be simplified

2022-02-11 Thread Daniel Jeliński
On Fri, 4 Feb 2022 10:13:28 GMT, Daniel Jeliński wrote: > The proposed form of borrow bit handling is [already used in BigInteger > class](https://github.com/djelinski/jdk/blob/ce26a19be5e907c11164b46f1bcb370b534d5bf6/src/java.base/share/classes/java/math/BigInteger.java#L1558). &g

Re: RFR: 8281259: MutableBigInteger subtraction could be simplified

2022-02-10 Thread Daniel Jeliński
On Fri, 4 Feb 2022 10:13:28 GMT, Daniel Jeliński wrote: > The proposed form of borrow bit handling is [already used in BigInteger > class](https://github.com/djelinski/jdk/blob/ce26a19be5e907c11164b46f1bcb370b534d5bf6/src/java.base/share/classes/java/math/BigInteger.java#L1558). &g

RFR: 8281259: MutableBigInteger subtraction could be simplified

2022-02-04 Thread Daniel Jeliński
The proposed form of borrow bit handling is [already used in BigInteger class](https://github.com/djelinski/jdk/blob/ce26a19be5e907c11164b46f1bcb370b534d5bf6/src/java.base/share/classes/java/math/BigInteger.java#L1558). JMH results without the patch: Benchmark(maxNumbits) Mode Cnt

Integrated: 8280474: Garbage value passed to getLocaleInfoWrapper in HostLocaleProviderAdapter_md

2022-01-24 Thread Daniel Jeliński
On Fri, 21 Jan 2022 19:28:21 GMT, Daniel Jeliński wrote: > Reported by clang-tidy. Verified manually by running > > Calendar c = Calendar.getInstance(); > System.out.println (c.getDisplayNames(Calendar.MONTH, > Calendar.SHORT_STANDALONE, Lo

Re: RFR: 8280474: Garbage value passed to getLocaleInfoWrapper in HostLocaleProviderAdapter_md

2022-01-24 Thread Daniel Jeliński
On Fri, 21 Jan 2022 19:28:21 GMT, Daniel Jeliński wrote: > Reported by clang-tidy. Verified manually by running > > Calendar c = Calendar.getInstance(); > System.out.println (c.getDisplayNames(Calendar.MONTH, > Calendar.SHORT_STANDALONE, Lo

RFR: 8280474: Garbage value passed to getLocaleInfoWrapper in HostLocaleProviderAdapter_md

2022-01-21 Thread Daniel Jeliński
Reported by clang-tidy. Verified manually by running Calendar c = Calendar.getInstance(); System.out.println (c.getDisplayNames(Calendar.MONTH, Calendar.SHORT_STANDALONE, Locale.getDefault())); with `-Djava.locale.providers=HOST` Without the fix the WINAPI functions fail, and

Re: RFR: 8275512: Upgrade required version of jtreg to 6.1 [v2]

2021-10-23 Thread Daniel Jeliński
On Wed, 20 Oct 2021 09:28:30 GMT, Leslie Zhai wrote: > requires jtreg version 6.1 b1 or higher This confused me a bit too; I was using jtreg-6+1.tar.gz from [Adoption Group build](https://ci.adoptopenjdk.net/view/Dependencies/job/dependency_pipeline/lastSuccessfulBuild/artifact/jtreg/), and