Concurrent formatters

2012-07-03 Thread Diego Belfer
for that, but it does not seem very difficult at first glance to attempt to make this enhancement. What do you think? Have you already tried to accomplish this and found some blocking issues? Do you think this change would make the API documentation confusing ? Best, Diego Belfer [muralx]

Re: PATCH [6901992] : Possible InvalidJarIndexException due to bug in sun.misc.JarIndex.merge()

2012-06-19 Thread Diego Belfer
/efc2791d7c5d Thanks for this valuable contribution Diego. -Chris On 16/06/12 05:20, Diego Belfer wrote: Hi Chris, Here is a new patch containing new version of the tests. The new versions generate a the Jar on the fly as we discussed. Let me know if there is anything else you think should

Re: PATCH [6901992] : Possible InvalidJarIndexException due to bug in sun.misc.JarIndex.merge()

2012-06-15 Thread Diego Belfer
there); jarBList.put(x/y/resourceB.**dat, Goodbye); jarBList.put(x/y/resourceC.**dat, Hello\nfrom\nb\ndot\njar); } Thanks, -Chris. On 14/06/2012 03:20, Diego Belfer wrote: Hi Chris, There is no way to generate a jar without directory entries using the jar tool

Re: PATCH [6901992] : Possible InvalidJarIndexException due to bug in sun.misc.JarIndex.merge()

2012-06-13 Thread Diego Belfer
being indexed. to the workaround section of the bug. You seem to be seeing the opposite, right? -Chris. On 13/06/2012 06:11, Diego Belfer wrote: Hi, I have finally reproduced the InvalidJarIndexException bug as reported in the ticket. I mentioned in a previous email, that the only way

Re: PATCH [6901992] : Possible InvalidJarIndexException due to bug in sun.misc.JarIndex.merge()

2012-06-13 Thread Diego Belfer
/**metaInfFilenames, but at least it is quite understandable. -Chris. On 13/06/2012 20:36, Diego Belfer wrote: Hi Chris, That's right. The only non-cleanup change is the one in the merge. Regarding the test case, I will re-write them in order to generate the jars on fly. I'd scanned the jdk/test

Re: PATCH [6901992] : Possible InvalidJarIndexException due to bug in sun.misc.JarIndex.merge()

2012-06-13 Thread Diego Belfer
a new option to the Jar tool Main class to exclude directory entries? The option does not need to be exposed by the command line tool to final users if this an issue, although I think it may be useful for them too. Best, Diego On Wed, Jun 13, 2012 at 7:12 PM, Diego Belfer dbel...@gmail.com wrote

Re: PATCH [6901992] : Possible InvalidJarIndexException due to bug in sun.misc.JarIndex.merge()

2012-06-12 Thread Diego Belfer
created a new PATCH which includes an additional test case which uses the URLClassLoader to trigger the InvalidIndexException. The patch is attached, please consider it for review. Best, Diego Belfer [muralx] On Mon, Jun 11, 2012 at 4:47 PM, Diego Belfer dbel...@gmail.com wrote: Hi, Here

PATCH [6901992] : Possible InvalidJarIndexException due to bug in sun.misc.JarIndex.merge()

2012-06-11 Thread Diego Belfer
with merged contents. If you think it is possible to commit this fix without actually reproducing the original bug report, please consider this patch for review. Thanks, Diego Belfer [muralx] # HG changeset patch # User muralx # Date 1339374533 10800 # Node ID

6901992 : Possible InvalidJarIndexException due to bug in sun.misc.JarIndex.merge()

2012-06-10 Thread Diego Belfer
Hi, I am working on the bug 6901992. I have already fixed the merge method and I have created a test case for it too. Nevertheless, I was unable to reproduce the bug as a whole (using the ClassLoader mechanism) and get the InvalidJarIndexException, since the only way I might think of triggering

Re: [PATCH] 7164256 : EnumMap.clone doesn't clear the entrySet field, keeping a reference to the original Map

2012-06-07 Thread Diego Belfer
AM, Alan Bateman alan.bate...@oracle.comwrote: On 04/06/2012 16:33, Diego Belfer wrote: Hi Alan, I've already sent the signed OCA. Will you sponsor the patch ? It's pushed now, see: http://mail.openjdk.java.net/**pipermail/core-libs-dev/2012-** June/010443.htmlhttp

Re: [PATCH] 7164256 : EnumMap.clone doesn't clear the entrySet field, keeping a reference to the original Map

2012-06-07 Thread Diego Belfer
I will give it a try. Thanks, muralx On Thu, Jun 7, 2012 at 2:57 PM, RĂ©mi Forax fo...@univ-mlv.fr wrote: On 06/07/2012 07:14 PM, Diego Belfer wrote: Hi Alan, Thanks to you. I will look for another issue I can solve. Is there any other tool for looking for open issues? The bugs database

Re: [PATCH] 7164256 : EnumMap.clone doesn't clear the entrySet field, keeping a reference to the original Map

2012-06-04 Thread Diego Belfer
Hi Alan, I've already sent the signed OCA. Will you sponsor the patch ? Best, Diego On Mon, May 28, 2012 at 11:37 PM, Diego Belfer dbel...@gmail.com wrote: Hi Alan, Thanks for your reply. I am attaching a new patch and it contains the test case now. I have read the contents of the link

Re: [PATCH] 7164256 : EnumMap.clone doesn't clear the entrySet field, keeping a reference to the original Map

2012-05-28 Thread Diego Belfer
Hi, The patch seems to have been removed by the mailer. I am adding it inline. Best, Diego Belfer [muralx] # HG changeset patch # User muralx # Date 1338059940 10800 # Node ID 05cb9ae575a6fb4262d46dcd4d4c56c23594cdcb # Parent 9b8c96f96a0f9a5801b55530a387fefbe50482a3 PATCH 7164256

Re: [PATCH] 7164256 : EnumMap.clone doesn't clear the entrySet field, keeping a reference to the original Map

2012-05-28 Thread Diego Belfer
instance + * @author Diego Belfer + */ + +import java.util.EnumMap; + +public class ProperEntrySetOnClone { +public enum Test { +ONE, TWO +} + +public static void main(String[] args) { +EnumMapTest, String map1 = new EnumMapTest, String(Test.class); +map1.put

[PATCH] 7164256 : EnumMap.clone doesn't clear the entrySet field, keeping a reference to the original Map

2012-05-26 Thread Diego Belfer
method that sets the entrySet field to null. This is my first contribution to the OpenJDK, so let me know if I am missing some step of the process. Thanks, Diego Belfer [muralx]