On Thu, 13 Jan 2022 12:10:11 GMT, Michael McMahon wrote:
> Hi,
>
> This change adds Channel Binding Token (CBT) support to HTTPS
> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, Kerberos)
> authentication scheme. When enabled, the implementation preemptivel
;, "b.c" and all hosts under the domain "d.com" and all of its
> sub-domains.
>
> A test will be added separately to the implementation.
>
> Bug report: https://bugs.openjdk.java.net/browse/JDK-8279842
>
> Thanks,
> Michael
Michael McMahon has
On Thu, 27 Jan 2022 16:47:52 GMT, Daniel Fuchs wrote:
>> It's `java.net.SocketException: Unexpected end of file from server`. Does
>> not include any CBT words so don't know if it's worth parsing.
>
> Thanks. Then it would be better to catch only `SocketException` here rather
> than `Exception`
;, "b.c" and all hosts under the domain "d.com" and all of its
> sub-domains.
>
> A test will be added separately to the implementation.
>
> Bug report: https://bugs.openjdk.java.net/browse/JDK-8279842
>
> Thanks,
> Michael
Michael McMahon has update
;, "b.c" and all hosts under the domain "d.com" and all of its
> sub-domains.
>
> A test will be added separately to the implementation.
>
> Bug report: https://bugs.openjdk.java.net/browse/JDK-8279842
>
> Thanks,
> Michael
Michael McMahon has updated
;, "b.c" and all hosts under the domain "d.com" and all of its
> sub-domains.
>
> A test will be added separately to the implementation.
>
> Bug report: https://bugs.openjdk.java.net/browse/JDK-8279842
>
> Thanks,
> Michael
Michael McMahon has
;, "b.c" and all hosts under the domain "d.com" and all of its
> sub-domains.
>
> A test will be added separately to the implementation.
>
> Bug report: https://bugs.openjdk.java.net/browse/JDK-8279842
>
> Thanks,
> Michael
Michael Mc
On Tue, 25 Jan 2022 11:34:57 GMT, Michael Osipov wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> final review update (pre CSR)
>
> src/java.base/share/classes/sun/net/www
;, "b.c" and all hosts under the domain "d.com" and all of its
> sub-domains.
>
> A test will be added separately to the implementation.
>
> Bug report: https://bugs.openjdk.java.net/browse/JDK-8279842
>
> Thanks,
> Michael
Mich
;, "b.c" and all hosts under the domain "d.com" and all of its
> sub-domains.
>
> A test will be added separately to the implementation.
>
> Bug report: https://bugs.openjdk.java.net/browse/JDK-8279842
>
> Thanks,
> Michael
Michael McMahon has u
On Mon, 24 Jan 2022 15:23:44 GMT, Weijun Wang wrote:
>> Michael McMahon has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
On Fri, 21 Jan 2022 19:48:02 GMT, Weijun Wang wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> added root cause to NamingException
>
> src/java.base/share/classes/java/net/doc-file
;, "b.c" and all hosts under the domain "d.com" and all of its
> sub-domains.
>
> A test will be added separately to the implementation.
>
> Bug report: https://bugs.openjdk.java.net/browse/JDK-8279842
>
> Thanks,
> Michael
Michael McMahon has update
;, "b.c" and all hosts under the domain "d.com" and all of its
> sub-domains.
>
> A test will be added separately to the implementation.
>
> Bug report: https://bugs.openjdk.java.net/browse/JDK-8279842
>
> Thanks,
> Michael
Michael McM
On Fri, 21 Jan 2022 13:39:06 GMT, Michael Osipov wrote:
>> Actually, it turns out I should be throwing `NamingException` here. That is
>> what was being thrown by `TlsChannelBinding.parseType` before and an
>> existing test was expecting that. NamingException only takes a String
>> message. So
;, "b.c" and all hosts under the domain "d.com" and all of its
> sub-domains.
>
> A test will be added separately to the implementation.
>
> Bug report: https://bugs.openjdk.java.net/browse/JDK-8279842
>
> Thanks,
> Michael
Michael McMahon has u
On Fri, 21 Jan 2022 13:38:08 GMT, Michael McMahon wrote:
>> src/java.base/share/classes/sun/net/www/http/HttpClient.java line 189:
>>
>>> 187: } else {
>>> 188: logError("Unexpected value for \"jdk.https.negotiate.cbt\"
>>
On Thu, 20 Jan 2022 11:16:16 GMT, Daniel Fuchs wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> removed sasl module dependency and added SaslException cause
>
> src/java.base/s
On Thu, 20 Jan 2022 11:14:40 GMT, Michael Osipov wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> removed sasl module dependency and added SaslException cause
>
> src/java.naming/s
On Thu, 20 Jan 2022 11:04:18 GMT, Daniel Fuchs wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> removed sasl module dependency and added SaslException cause
>
> src/java.base/share/
On Wed, 19 Jan 2022 22:25:43 GMT, Weijun Wang wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> changes after first review round
>
> src/java.naming/share/classes/com/sun/jndi/ld
;, "b.c" and all hosts under the domain "d.com" and all of its
> sub-domains.
>
> A test will be added separately to the implementation.
>
> Bug report: https://bugs.openjdk.java.net/browse/JDK-8279842
>
> Thanks,
> Michael
Michael McMahon
;, "b.c" and all hosts under the domain "d.com" and all of its
> sub-domains.
>
> A test will be added separately to the implementation.
>
> Bug report: https://bugs.openjdk.java.net/browse/JDK-8279842
>
> Thanks,
> Michael
Michael
On Fri, 14 Jan 2022 15:06:12 GMT, Daniel Fuchs wrote:
> Have you been able to test this on a specific setup? Would be good to hear
> from @msheppar too.
I have tested it with the server setup by Prajwal. Security SQE are looking
into configuring a server with a similar setup which can be teste
On Wed, 19 Jan 2022 15:36:16 GMT, Michael McMahon wrote:
>>> It's actually a purely system property rather than a Net property at the
>>> moment (same as the other spnego ones). Maybe, I should convert them all to
>>> net properties, so they can be documented
On Sat, 15 Jan 2022 14:02:15 GMT, Michael Osipov wrote:
>> I suggest moving the `TlsChannelBinding` class into
>> `java.base/sun.security.util` since it's not only used by LDAP anymore. It's
>> even not restricted to GSS-API. According to
>> https://www.rfc-editor.org/rfc/rfc5056, "Although in
On Mon, 17 Jan 2022 13:44:06 GMT, Daniel Fuchs wrote:
>> Shall we log a message if the value is not one of the 3 forms?
>
> Usually malformed values are just ignored - and the property takes its
> default value. But yes - s.n.w.h.HttpClient has a logger so it wouldn't be
> much effort to log it
On Mon, 17 Jan 2022 13:49:35 GMT, Daniel Fuchs wrote:
>> I vote for "jdk.https.tls.cbt"
>
>> It's actually a purely system property rather than a Net property at the
>> moment (same as the other spnego ones). Maybe, I should convert them all to
>> net properties, so they can be documented/set i
On Fri, 14 Jan 2022 14:52:13 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> This change adds Channel Binding Token (CBT) support to HTTPS
>> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO,
>> Kerberos) authentication scheme. When enabled, the implementation
>> preemptively includes
On Thu, 13 Jan 2022 18:18:24 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> This change adds Channel Binding Token (CBT) support to HTTPS
>> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO,
>> Kerberos) authentication scheme. When enabled, the implementation
>> preemptively includes
Hi,
This change adds Channel Binding Token (CBT) support to HTTPS
(java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, Kerberos)
authentication scheme. When enabled, the implementation preemptively includes a
CBT with authentication requests over Kerberos. The feature is enabled
On Fri, 29 Oct 2021 16:17:46 GMT, Aleksei Efimov wrote:
>> This change implements a new service provider interface for host name and
>> address resolution, so that java.net.InetAddress API can make use of
>> resolvers other than the platform's built-in resolver.
>>
>> The following API classes
On Fri, 29 Oct 2021 15:35:50 GMT, Roger Riggs wrote:
>> The ObjectInputStream.GetField method `get(String name, Object val)` should
>> have been throwing
>> a ClassNotFoundException if the class was not found. Instead the
>> implementation was returning null.
>> A design error does not allow t
On Tue, 26 Oct 2021 16:24:48 GMT, Aleksei Efimov wrote:
>> This change implements a new service provider interface for host name and
>> address resolution, so that java.net.InetAddress API can make use of
>> resolvers other than the platform's built-in resolver.
>>
>> The following API classes
On Tue, 12 Oct 2021 10:40:15 GMT, Julia Boes wrote:
>> This change implements a simple web server that can be run on the
>> command-line with `java -m jdk.httpserver`.
>>
>> This is facilitated by adding an entry point for the `jdk.httpserver`
>> module, an implementation class whose main meth
On Tue, 12 Oct 2021 10:40:15 GMT, Julia Boes wrote:
>> This change implements a simple web server that can be run on the
>> command-line with `java -m jdk.httpserver`.
>>
>> This is facilitated by adding an entry point for the `jdk.httpserver`
>> module, an implementation class whose main meth
On Tue, 21 Sep 2021 14:09:54 GMT, Julia Boes wrote:
>> This change implements a simple web server that can be run on the
>> command-line with `java -m jdk.httpserver`.
>>
>> This is facilitated by adding an entry point for the `jdk.httpserver`
>> module, an implementation class whose main meth
On Tue, 21 Sep 2021 14:09:54 GMT, Julia Boes wrote:
>> This change implements a simple web server that can be run on the
>> command-line with `java -m jdk.httpserver`.
>>
>> This is facilitated by adding an entry point for the `jdk.httpserver`
>> module, an implementation class whose main meth
On Tue, 21 Sep 2021 14:09:54 GMT, Julia Boes wrote:
>> This change implements a simple web server that can be run on the
>> command-line with `java -m jdk.httpserver`.
>>
>> This is facilitated by adding an entry point for the `jdk.httpserver`
>> module, an implementation class whose main meth
On Wed, 15 Sep 2021 08:42:40 GMT, Julia Boes wrote:
>> src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpsServer.java
>> line 152:
>>
>>> 150: return server;
>>> 151: }
>>> 152:
>>
>> Too bad we couldn't simplify the setting up a basic certificate for https.
>
> That wou
On Tue, 14 Sep 2021 16:51:40 GMT, Daniel Fuchs wrote:
>> src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpHandlers.java
>> line 129:
>>
>>> 127: * response body bytes are a {@code UTF-8} encoded byte
>>> sequence of
>>> 128: * {@code body}. The response {@linkplain
>>> Ht
On Wed, 14 Apr 2021 15:27:36 GMT, Alan Bateman wrote:
>> Hi,
>>
>> Could I get the following trivial doc changes reviewed please, caused by:
>>
>> - broken tags in MethodHandles referring to package.html instead of
>> package-summary.html
>>
>> - references to a package level #unixdomain anc
On Wed, 14 Apr 2021 14:03:01 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following trivial doc changes reviewed please, caused by:
>
> - broken tags in MethodHandles referring to package.html instead of
> package-summary.html
>
> - references to a package
Hi,
Could I get the following trivial doc changes reviewed please, caused by:
- broken tags in MethodHandles referring to package.html instead of
package-summary.html
- references to a package level #unixdomain anchor that no longer exists.
- a tag missing a "../" in SocketChannel
Thanks,
On Fri, 5 Feb 2021 09:52:11 GMT, Michael McMahon wrote:
> Could I get the following change reviewed please? It fixes a problem (in
> JEP380) on Windows where some file operations on Unix domain sockets were not
> working and led to the feature being disabled on Windows 2019 Server in
; any specific testing in this area, as I assume the existing unit tests for
> NIO symbolic links should cover that. If I should add more tests here, then I
> can do that.
>
> Thanks,
> Michael
Michael McMahon has updated the pull request with a new target base due to a
merg
On Tue, 9 Feb 2021 15:33:48 GMT, Alan Bateman wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> update
>
> src/java.base/windows/classes/sun/nio/fs/WindowsPath.java line 840:
>
; any specific testing in this area, as I assume the existing unit tests for
> NIO symbolic links should cover that. If I should add more tests here, then I
> can do that.
>
> Thanks,
> Michael
Michael McMahon has updated the pull request with a new target base due to a
merg
; any specific testing in this area, as I assume the existing unit tests for
> NIO symbolic links should cover that. If I should add more tests here, then I
> can do that.
>
> Thanks,
> Michael
Michael McMahon has updated the pull request incrementally with one add
; any specific testing in this area, as I assume the existing unit tests for
> NIO symbolic links should cover that. If I should add more tests here, then I
> can do that.
>
> Thanks,
> Michael
Michael McMahon has updated the pull request incrementally with one additional
commit si
On Mon, 8 Feb 2021 21:59:53 GMT, Michael McMahon wrote:
>> src/java.base/windows/classes/sun/nio/fs/WindowsPath.java line 862:
>>
>>> 860: * and a handle to the socket file if it is.
>>> 861: */
>>> 862: private long openSocketForReadAttr
On Mon, 8 Feb 2021 16:50:02 GMT, Alan Bateman wrote:
>> Michael McMahon has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request cont
; any specific testing in this area, as I assume the existing unit tests for
> NIO symbolic links should cover that. If I should add more tests here, then I
> can do that.
>
> Thanks,
> Michael
Michael McMahon has updated the pull request incrementally with one add
On Mon, 8 Feb 2021 16:48:44 GMT, Alan Bateman wrote:
>> Michael McMahon has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request cont
; any specific testing in this area, as I assume the existing unit tests for
> NIO symbolic links should cover that. If I should add more tests here, then I
> can do that.
>
> Thanks,
> Michael
Michael McMahon has updated the pull request with a new target base due to a
merg
On Sat, 6 Feb 2021 17:10:39 GMT, Alan Bateman wrote:
>> Michael McMahon has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request conta
On Sun, 7 Feb 2021 09:15:35 GMT, Alan Bateman wrote:
>> Though looking at that piece of code, I think its purpose would be clearer
>> if it were put in a separate method with a name that shows were trying to
>> open it as a socket.
>
> Moving it to a separate method would make it easier to main
; any specific testing in this area, as I assume the existing unit tests for
> NIO symbolic links should cover that. If I should add more tests here, then I
> can do that.
>
> Thanks,
> Michael
Michael McMahon has updated the pull request incrementally with one additional
commit
On Sat, 6 Feb 2021 20:35:58 GMT, Michael McMahon wrote:
>> src/java.base/windows/classes/sun/nio/fs/WindowsFileSystemProvider.java line
>> 344:
>>
>>> 342:
>>> Set.of(WindowsChannelFactory.OPEN_REPARSE_POINT),
>>
On Sat, 6 Feb 2021 17:09:11 GMT, Alan Bateman wrote:
>> Michael McMahon has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request conta
; any specific testing in this area, as I assume the existing unit tests for
> NIO symbolic links should cover that. If I should add more tests here, then I
> can do that.
>
> Thanks,
> Michael
Michael McMahon has updated the pull request with a new target base due to a
merg
On Fri, 5 Feb 2021 12:03:30 GMT, Daniel Fuchs wrote:
>> Could I get the following change reviewed please? It fixes a problem (in
>> JEP380) on Windows where some file operations on Unix domain sockets were
>> not working and led to the feature being disabled on Windows 2019 Server in
>> JDK 16
Could I get the following change reviewed please? It fixes a problem (in
JEP380) on Windows where some file operations on Unix domain sockets were not
working and led to the feature being disabled on Windows 2019 Server in JDK 16.
So, the fix re-enables the feature on all versions of Windows tha
On Thu, 17 Dec 2020 14:51:44 GMT, Daniel Fuchs wrote:
> Hi,
>
> Please find an almost trivial fix for:
> 8258582: HttpClient: the HttpClient doesn't explicitly shutdown its default
> executor when stopping.
>
> The HttpClient should shutdown his executor when stopping, when the executor
> was
> Continuing this review as a PR on github with the comments below
> incorporated. I expect there will be a few more
> iterations before integrating.
> On 06/09/2020 19:47, Alan Bateman wrote:
>> On 26/08/2020 15:24, Michael McMahon wrote:
>>>
>>> As I menti
> Continuing this review as a PR on github with the comments below
> incorporated. I expect there will be a few more
> iterations before integrating.
> On 06/09/2020 19:47, Alan Bateman wrote:
>> On 26/08/2020 15:24, Michael McMahon wrote:
>>>
>>> As I menti
> Continuing this review as a PR on github with the comments below
> incorporated. I expect there will be a few more
> iterations before integrating.
> On 06/09/2020 19:47, Alan Bateman wrote:
>> On 26/08/2020 15:24, Michael McMahon wrote:
>>>
>>> As I menti
> Continuing this review as a PR on github with the comments below
> incorporated. I expect there will be a few more
> iterations before integrating.
> On 06/09/2020 19:47, Alan Bateman wrote:
>> On 26/08/2020 15:24, Michael McMahon wrote:
>>>
>>> As I menti
> Continuing this review as a PR on github with the comments below
> incorporated. I expect there will be a few more
> iterations before integrating.
> On 06/09/2020 19:47, Alan Bateman wrote:
>> On 26/08/2020 15:24, Michael McMahon wrote:
>>>
>>> As I menti
On Mon, 7 Sep 2020 12:05:07 GMT, Michael McMahon wrote:
> Continuing this review as a PR on github with the comments below
> incorporated. I expect there will be a few more
> iterations before integrating.
> On 06/09/2020 19:47, Alan Bateman wrote:
>> On 26/08/2020 15:24, Mic
> Continuing this review as a PR on github with the comments below
> incorporated. I expect there will be a few more
> iterations before integrating.
> On 06/09/2020 19:47, Alan Bateman wrote:
>> On 26/08/2020 15:24, Michael McMahon wrote:
>>>
>>> As I menti
Continuing this review as a PR on github with the comments below incorporated.
I expect there will be a few more
iterations before integrating.
On 06/09/2020 19:47, Alan Bateman wrote:
> On 26/08/2020 15:24, Michael McMahon wrote:
>>
>> As I mentioned the other day, I wasn&#x
Hi,
Yes, that report probably should not have been closed as it is
definitely an issue.
I will re-open it.
Michael
On 22/06/2020 16:39, Sebastian Stenzel wrote:
Certain users of my software run into problems with HttpClient.newHttpClient()
on JDK 14.0.1 and I don't feel like I can handle i
Hi Alex,
(and redirecting the thread to net-dev)
It looks like a straight forward solution and perhaps the compatibility test
could be challenged on the basis of reliance on implementation behavior
rather than the spec.
But, more important I think is the behavior change of the fix itself and
file in a
subsequent step. This should be more robust.
* sed doesn't like newlines in replaced text in Mac. I've thus omitted
the newline from the SOURCE template - as that was mostly cosmetic.
Thanks for Michael McMahon to report (and figure out how to deal with)
these issues, and
Looks good Vyom.
- Michael
On 12/09/2017, 09:46, vyom tewari wrote:
On Tuesday 12 September 2017 02:12 PM, Alan Bateman wrote:
On 12/09/2017 09:06, vyom tewari wrote:
Hi,
Please review the below code change.
BugId: https://bugs.openjdk.java.net/browse/JDK-8159526
Webrev-1:
http://cr.ope
Maybe the spec could be tighter around this, but it's not unreasonable
that there is a
delay in receiving onComplete() notification because of the subscriber
controlled flow control.
Notifying onError() is not subject to flow control; so you might expect
that it would be triggered immediately.
On 21/02/2017, 11:15, Pavel Rappo wrote:
I believe, the most appropriate place for concurrency-related questions is
http://altair.cs.oswego.edu/mailman/listinfo/concurrency-interest
As for the question itself. I don't think this behaviour is a bug.
SubmissionPublisher.close() seems to be
Sounds like a bug. It seems like the fact there isn't a call to
Subscription.request()
is what causes the problem. But by my reading of the spec,
Subscriber.onComplete()
should still be called, as it is known that " no additional Subscriber
method invocations will occur".
- Michael.
On 21/02/
Thanks Aleksey,
I will take care of it.
- Michael
On 09/03/16 11:34, Aleksey Shipilev wrote:
Alan mentioned I should have sent this to net-dev@. Instead, I submitted
a new bug:
https://bugs.openjdk.java.net/browse/JDK-8151505
-Aleksey
On 03/09/2016 02:06 PM, Aleksey Shipilev wrote:
Hi,
I
Yes, there is a mutability test already. We will have to fix the thread
safety problem
(and also the fact HttpHeaders1 was left public by mistake). Probably will
separate the mutable and immutable types completely. Vaibhav, if you'd
like to do it,
you can define a package private implementation
On 22/10/15 14:24, Alan Bateman wrote:
On 22/10/2015 14:04, Roger Riggs wrote:
Hi Sandhya,
The folks on net-...@openjdk.java.net will be interested too.
Yes, net-dev is the best list for this.
One other thing to mention is the SocketOption interface and the
setOption/getOption methods. Thi
Looks good Roger. Only minor quibble would be the name of the new type
JavaInetAddressAccess could be JavaNetInetAddressAccess to be consistent.
Michael
On 30/07/15 15:49, Roger Riggs wrote:
Please review this refactoring of SharedSecret initialization to
create and
InetAddressAccess access
On 21/04/15 14:56, Alan Bateman wrote:
On 20/04/2015 18:32, Severin Gehwolf wrote:
:
OK fixed:
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-6991580/webrev.02/
FWIW, I don't think the test needs IP addresses of DNS servers to be
functional, though. All it really does is passing it to
InetAd
On 20/04/15 18:32, Severin Gehwolf wrote:
On Mon, 2015-04-20 at 12:24 -0400, Andrew Hughes wrote:
- Original Message -
Adding in net-dev.
On Mon, 2015-04-20 at 14:02 +0200, Severin Gehwolf wrote:
Hi,
Could I please get a review and a sponsor for the following patch?
The issue is tha
Hi,
[this has already been posted to net-dev]
JEP 110 HTTP 2 client
in JDK 9, is defining and implementing a new API for HTTP which also
supports
the new HTTP version 2 that has recently been working its way through
the IETF.
The work also includes support for websockets (RFC 6455).
In fact
Hi,
I'm afraid you have the wrong Michael McMahon.
-Original Message-
From: Konstantin Shefov
Sent: Monday, December 15, 2014 6:16 AM
To: Ivan Gerasimov; net-...@openjdk.java.net; core-libs-dev@openjdk.java.net;
Alan Bateman; Chris Hegarty; MICHAEL.MCMAHON
Subject: Re: [9] R
On 10/09/14 16:04, Claes Redestad wrote:
On 09/10/2014 04:38 PM, mark.reinh...@oracle.com wrote:
New webrev: http://cr.openjdk.java.net/~redestad/8057936/webrev.4/
Looks fine, but when an exception declaration is on its own line then
the opening brace of the method should be on its own line too
or how about just returning a null Class from the privileged block
instead of the new result type only in the case where
URLClassPath.getResource() returns null?
That's the main "normal" case where the resource doesn't exist, I think.
If defineClass() throws an IOException, then that is more li
I'll file a bug for this Stanimir. Thanks for reporting it.
Should be able to fix it in JDK 9 fairly promptly
and we'll see about back porting it then.
- Michael.
On 18/08/14 15:04, Stanimir Simeonoff wrote:
Hi,
As the title says there is a major bug with HttpsURLConnection as it breaks
the co
Trivial doc change to remove extraneous '}' characters in two places
http://cr.openjdk.java.net/~michaelm/8040809/webrev.1/
Thanks,
Michael
On 14/02/14 18:20, Alan Bateman wrote:
On 14/02/2014 17:42, Michael McMahon wrote:
Could I get the following change reviewed please?
http://cr.openjdk.java.net/~michaelm/8034853/webrev.1/
The change is to remove the class sun.misc.ClassLoaderUtil.
The functionality provided by this class is
Thanks Joe. Will do that.
Michael
On 14/02/14 18:09, Joe Darcy wrote:
Hi Michael,
Good to see more of sun.misc go away :-)
For the test, I recommend updating the @summary and removing the
comment about the old API.
Thanks,
-Joe
On 02/14/2014 09:42 AM, Michael McMahon wrote:
Could I get
Could I get the following change reviewed please?
http://cr.openjdk.java.net/~michaelm/8034853/webrev.1/
The change is to remove the class sun.misc.ClassLoaderUtil.
The functionality provided by this class is now in the public
java.net.URLClassloader.close() method.
Thanks
Michael
On 10/01/14 15:37, roger riggs wrote:
Please review:
To enable native code checking consistently for thrown exceptions,
the macros in net_util.h and java/util/jar/pack/coding.cpp are
made consolidated and promoted to jni_util.h
webrev:
http://cr.openjdk.java.net/~rriggs/webrev-check-exception-8
On 06/12/13 11:44, Alan Bateman wrote:
On 05/12/2013 05:30, Sergey Lugovoy wrote:
Hi all,
please review the fix
http://cr.openjdk.java.net/~yan/8029451/webrev.01/
for
https://bugs.openjdk.java.net/browse/JDK-8029451
This patch cleanup tidy warnings for generated html documentation,
and do
not
On 07/11/13 11:34, Chris Hegarty wrote:
On 11/07/2013 11:19 AM, Michael McMahon wrote:
Chris,
Would it be useful to add some instrumentation/logging (to System.err)
if it's taking
more than one iteration to delete a file? We could end up with degraded
test performance if there is a ge
Chris,
Would it be useful to add some instrumentation/logging (to System.err)
if it's taking
more than one iteration to delete a file? We could end up with degraded
test performance if there is a general problem deleting files, and
otherwise would have
no way of understanding what the problem
Looks fine to me.
Michael
On 11/10/13 16:15, Brian Burkhalter wrote:
Thanks.
Any further comments from anyone else?
Brian
On Oct 10, 2013, at 9:04 PM, David Holmes wrote:
Ship it! :)
Thanks,
David
On 11/10/2013 5:24 AM, Brian Burkhalter wrote:
On Oct 10, 2013, at 11:21 AM, Brian Burkhal
On 08/10/13 12:08, Alan Bateman wrote:
On 04/10/2013 21:58, Brian Burkhalter wrote:
:
An updated webrev which I hope adequately addresses the expressed
concerns may be found at:
http://cr.openjdk.java.net/~bpb/7179567.2/
This looks much better.
If I read the code correctly then the long st
1 - 100 of 162 matches
Mail list logo
