On Wed, 18 May 2022 14:59:49 GMT, Quan Anh Mai wrote:
>> Hi,
>>
>> This patch optimises the matching rules for floating-point comparison with
>> respects to eq/ne on x86-64
>>
>> 1, When the inputs of a comparison is the same (i.e `isNaN` patterns), `ZF`
>> is always set, so we don't need
On Mon, 11 Apr 2022 02:01:17 GMT, David Holmes wrote:
> This change appears to be causing crashes in tier4 - possibly Xcomp related:
>
> # assert(ctrl == kit.control()) failed: Control flow was added although the
> intrinsic bailed out
> I will file a new bug.
Thank you for informing this
On Wed, 6 Apr 2022 06:23:47 GMT, Jatin Bhateja wrote:
>>> Also need a jtreg test for this.
>>
>> Thanks Sandhya for the review. Made the suggested changes and added jtreg
>> tests as well.
>
> Hi @vamsi-parasa , thanks for addressing my comments, looks g
On Tue, 22 Feb 2022 09:24:47 GMT, Srinivas Vamsi Parasa
wrote:
> Optimizes the divideUnsigned() and remainderUnsigned() methods in
> java.lang.Integer and java.lang.Long classes using x86 intrinsics. This
> change shows 3x improvement for Integer methods and upto 25% improvement fo
On Sat, 9 Apr 2022 18:25:54 GMT, Vladimir Kozlov wrote:
> Testing passed.
Thank you Vladimir!
-
PR: https://git.openjdk.java.net/jdk/pull/7572
On Fri, 8 Apr 2022 00:55:50 GMT, Srinivas Vamsi Parasa
wrote:
>> I have few comments.
>
> Hi Vladimir (@vnkozlov),
>
> Incorporated all the suggestions you made in the previous review and pushed a
> new commit.
> Please let me know if anything else is needed.
>
which fuses
> division and modulus operations if needed. The DivMod optimization shows 3x
> improvement for Integer and ~65% improvement for Long.
Srinivas Vamsi Parasa has updated the pull request incrementally with one
additional commit since the last revision:
Fix the divmod crash due
which fuses
> division and modulus operations if needed. The DivMod optimization shows 3x
> improvement for Integer and ~65% improvement for Long.
Srinivas Vamsi Parasa has updated the pull request incrementally with one
additional commit since the last revision:
uncomment zero in int
On Wed, 6 Apr 2022 00:45:37 GMT, Vladimir Kozlov wrote:
>> Thanks for suggesting the enhancement. This enhancement will be implemented
>> as a part of https://bugs.openjdk.java.net/browse/JDK-8282365
>
> You do need `Ideal()` methods at least to check for dead code.
Added the Ideal() methods
On Wed, 6 Apr 2022 00:46:01 GMT, Vladimir Kozlov wrote:
>> Srinivas Vamsi Parasa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> add error msg for jtreg test
>
> I have few comments.
Hi Vladimir
which fuses
> division and modulus operations if needed. The DivMod optimization shows 3x
> improvement for Integer and ~65% improvement for Long.
Srinivas Vamsi Parasa has updated the pull request incrementally with one
additional commit since the last revision:
Idead Ideal for udiv, umo
which fuses
> division and modulus operations if needed. The DivMod optimization shows 3x
> improvement for Integer and ~65% improvement for Long.
Srinivas Vamsi Parasa has updated the pull request with a new target base due
to a merge or a rebase. The pull request now contains 15 commits:
On Wed, 6 Apr 2022 00:46:01 GMT, Vladimir Kozlov wrote:
> I have few comments.
Thank you Vladimir (@vnkozlov) for suggesting the changes! Will incorporate the
suggestions and push an update in few hours.
-
PR: https://git.openjdk.java.net/jdk/pull/7572
which fuses
> division and modulus operations if needed. The DivMod optimization shows 3x
> improvement for Integer and ~65% improvement for Long.
Vamsi Parasa has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 13 commits
On Tue, 5 Apr 2022 17:06:44 GMT, Sandhya Viswanathan
wrote:
>> Vamsi Parasa has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add bmi1 support check and jtreg tests
>
> src/hotspot/cpu/x86/c2_MacroAssembl
which fuses
> division and modulus operations if needed. The DivMod optimization shows 3x
> improvement for Integer and ~65% improvement for Long.
Vamsi Parasa has updated the pull request incrementally with one additional
commit since the last revision:
add error msg for jtreg test
> Implements x86 intrinsics for compare() method in java.lang.Integer and
> java.lang.Long.
Vamsi Parasa has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull r
On Tue, 29 Mar 2022 02:24:21 GMT, Jatin Bhateja wrote:
>> Implements x86 intrinsics for compare() method in java.lang.Integer and
>> java.lang.Long.
>
> src/hotspot/cpu/x86/x86_64.ad line 12107:
>
>> 12105: instruct compareSignedI_rReg(rRegI dst, rRegI op1, rRegI op2, rRegI
>> tmp, rFlagsReg
On Sun, 27 Mar 2022 06:57:58 GMT, Quan Anh Mai wrote:
> This is both complicated and inefficient, I would suggest building the
> intrinsic in the IR graph so that the compiler can simplify
> `Integer.compareUnsigned(x, y) < 0` into `x u< y`. Thanks.
Thank you for the suggestion! This
Implements x86 intrinsics for compare() method in java.lang.Integer and
java.lang.Long.
-
Commit messages:
- add JMH benchmarks
- 8283726: x86 intrinsics for compare method in Integer and Long
Changes: https://git.openjdk.java.net/jdk/pull/7975/files
Webrev:
On Thu, 24 Feb 2022 14:13:47 GMT, Jatin Bhateja wrote:
>> Vamsi Parasa has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix 32bit build issues
>
> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 4408:
&g
which fuses
> division and modulus operations if needed. The DivMod optimization shows 3x
> improvement for Integer and ~65% improvement for Long.
Vamsi Parasa has updated the pull request incrementally with one additional
commit since the last revision:
fix 32bit build issues
which fuses
> division and modulus operations if needed. The DivMod optimization shows 3x
> improvement for Integer and ~65% improvement for Long.
Vamsi Parasa has updated the pull request incrementally with one additional
commit since the last revision:
Fix line at end of file
which fuses
> division and modulus operations if needed. The DivMod optimization shows 3x
> improvement for Integer and ~65% improvement for Long.
Vamsi Parasa has updated the pull request incrementally with one additional
commit since the last revision:
Move intrinsic code to macro
On Wed, 23 Feb 2022 05:52:00 GMT, Jatin Bhateja wrote:
>> Optimizes the divideUnsigned() and remainderUnsigned() methods in
>> java.lang.Integer and java.lang.Long classes using x86 intrinsics. This
>> change shows 3x improvement for Integer methods and upto 25% improvement for
>> Long. This
On Wed, 23 Feb 2022 05:46:45 GMT, Jatin Bhateja wrote:
>> Optimizes the divideUnsigned() and remainderUnsigned() methods in
>> java.lang.Integer and java.lang.Long classes using x86 intrinsics. This
>> change shows 3x improvement for Integer methods and upto 25% improvement for
>> Long. This
On Wed, 23 Feb 2022 05:43:10 GMT, Jatin Bhateja wrote:
>> Optimizes the divideUnsigned() and remainderUnsigned() methods in
>> java.lang.Integer and java.lang.Long classes using x86 intrinsics. This
>> change shows 3x improvement for Integer methods and upto 25% improvement for
>> Long. This
Optimizes the divideUnsigned() and remainderUnsigned() methods in
java.lang.Integer and java.lang.Long classes using x86 intrinsics. This change
shows 3x improvement for Integer methods and upto 25% improvement for Long.
This change also implements the DivMod optimization which fuses division
On Tue, 2 Nov 2021 03:02:42 GMT, Vamsi Parasa wrote:
> This change optimizes random number generators using
> Math.unsignedMultiplyHigh()
This pull request has now been integrated.
Changeset: 38f525e9
Author: vamsi-parasa
Committer: Sandhya Viswanathan
URL:
On Fri, 3 Dec 2021 17:19:17 GMT, Paul Sandoz wrote:
>> @JimLaskey Could you please review this PR which optimizes three of the
>> Pseudo-Random Number Generators you implemented in
>> https://bugs.openjdk.java.net/browse/JDK-8248862 ?
>
> @vamsi-parasa you can now i
On Fri, 3 Dec 2021 00:27:13 GMT, Paul Sandoz wrote:
>> Vamsi Parasa has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update the JMH micro to take RNG parameters for elegant implementation
>
> test/mic
> This change optimizes random number generators using
> Math.unsignedMultiplyHigh()
Vamsi Parasa has updated the pull request incrementally with one additional
commit since the last revision:
minor changes to the benchmark
-
Changes:
- all: https://git.openjdk.java.n
On Thu, 2 Dec 2021 23:02:57 GMT, Paul Sandoz wrote:
>> Vamsi Parasa has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add seeds for the random generators to eliminate run-to-run variance
>
> test/mic
> This change optimizes random number generators using
> Math.unsignedMultiplyHigh()
Vamsi Parasa has updated the pull request incrementally with one additional
commit since the last revision:
Update the JMH micro to take RNG parameters for elegant implementation
-
C
On Thu, 2 Dec 2021 23:02:57 GMT, Paul Sandoz wrote:
>> Vamsi Parasa has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add seeds for the random generators to eliminate run-to-run variance
>
> test/mic
On Thu, 2 Dec 2021 20:43:56 GMT, Vamsi Parasa wrote:
>> This change optimizes random number generators using
>> Math.unsignedMultiplyHigh()
>
> Vamsi Parasa has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
> This change optimizes random number generators using
> Math.unsignedMultiplyHigh()
Vamsi Parasa has updated the pull request incrementally with one additional
commit since the last revision:
add seeds for the random generators to eliminate run-to-run variance
-
C
> This change optimizes random number generators using
> Math.unsignedMultiplyHigh()
Vamsi Parasa has updated the pull request incrementally with one additional
commit since the last revision:
fix trailing whitespace
-
Changes:
- all: https://git.openjdk.java.net/jd
> This change optimizes random number generators using
> Math.unsignedMultiplyHigh()
Vamsi Parasa has updated the pull request incrementally with two additional
commits since the last revision:
- Fix year in copyright
- micro benchmarks to test the performance
-
C
This change optimizes random number generators using Math.unsignedMultiplyHigh()
-
Commit messages:
- Update Math.java
- 8275821: Optimize random number generators developed in JDK-8248862 using
Math.unsignedMultiplyHigh()
Changes: https://git.openjdk.java.net/jdk/pull/6206/files
On Tue, 19 Oct 2021 20:34:55 GMT, Vamsi Parasa wrote:
>> Optimize the new Math.unsignedMultiplyHigh using the x86 mul instruction.
>> This change show 1.87X improvement on a micro benchmark.
>
> Vamsi Parasa has updated the pull request incrementally with one additional
>
On Wed, 13 Oct 2021 18:55:10 GMT, Vamsi Parasa wrote:
> Optimize the new Math.unsignedMultiplyHigh using the x86 mul instruction.
> This change show 1.87X improvement on a micro benchmark.
This pull request has now been integrated.
Changeset: af7c56b8
Author: vamsi-parasa
Com
On Wed, 20 Oct 2021 22:14:33 GMT, Vladimir Kozlov wrote:
> Tests passed. You can integrate changes.
Thanks Vladimir! What are the next steps to integrate the change?
-
PR: https://git.openjdk.java.net/jdk/pull/5933
On Fri, 15 Oct 2021 19:31:24 GMT, Vamsi Parasa wrote:
>> src/hotspot/share/opto/mulnode.cpp line 468:
>>
>>> 466: }
>>> 467:
>>> 468:
>>> //=
>>
>> MulHi
> Optimize the new Math.unsignedMultiplyHigh using the x86 mul instruction.
> This change show 1.87X improvement on a micro benchmark.
Vamsi Parasa has updated the pull request incrementally with one additional
commit since the last revision:
refactoring to remove code duplication by
On Fri, 15 Oct 2021 21:04:12 GMT, Vamsi Parasa wrote:
> > > How you verified correctness of results? I suggest to extend
> > > `test/jdk//java/lang/Math/MultiplicationTests.java` test to cover
> > > unsigned method.
> >
> >
> > Tests for unsigne
On Wed, 13 Oct 2021 18:55:10 GMT, Vamsi Parasa wrote:
> Optimize the new Math.unsignedMultiplyHigh using the x86 mul instruction.
> This change show 1.87X improvement on a micro benchmark.
This pull request has been closed without being integrated.
-
PR:
On Fri, 15 Oct 2021 20:19:31 GMT, Vladimir Kozlov wrote:
> > > How you verified correctness of results? I suggest to extend
> > > `test/jdk//java/lang/Math/MultiplicationTests.java` test to cover
> > > unsigned method.
> >
> >
> > Tests for unsignedMultiplyHigh were already added in
> >
On Fri, 15 Oct 2021 16:14:25 GMT, Andrew Haley wrote:
>> Optimize the new Math.unsignedMultiplyHigh using the x86 mul instruction.
>> This change show 1.87X improvement on a micro benchmark.
>
> src/hotspot/share/opto/mulnode.cpp line 468:
>
>> 466: }
>> 467:
>> 468:
>>
On Fri, 15 Oct 2021 18:45:41 GMT, Vladimir Kozlov wrote:
> How you verified correctness of results? I suggest to extend
> `test/jdk//java/lang/Math/MultiplicationTests.java` test to cover unsigned
> method.
Tests for unsignedMultiplyHigh were already added in
Optimize the new Math.unsignedMultiplyHigh using the x86 mul instruction. This
change show 1.87X improvement on a micro benchmark.
-
Commit messages:
- fix typo in function name
- 8275167: x86 intrinsic for unsignedMultiplyHigh
Changes:
51 matches
Mail list logo
