Re: RFR: 8282819: Deprecate Locale class constructors [v7]

2022-03-29 Thread Naoto Sato
On Tue, 29 Mar 2022 21:28:44 GMT, Naoto Sato  wrote:

>> Proposing to deprecate the constructors in the `java.util.Locale` class. 
>> There is already a factory method and a builder to return singletons, so 
>> there is no need to have constructors anymore unless one purposefully wants 
>> to create `ill-formed` Locale objects, which is discouraged. We cannot 
>> terminally deprecate those constructors for the compatibility to serialized 
>> objects created with older JDKs. Please see the draft CSR for more detail.
>
> Naoto Sato has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Changed from var-args to conventional args. Reflected suggestions.

Per a comment in the CSR discussion 
(https://bugs.openjdk.java.net/browse/JDK-8283478?focusedCommentId=14485037&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14485037),
 I changed the arguments to var-args to conventional ones.

-

PR: https://git.openjdk.java.net/jdk/pull/7947


Re: RFR: 8282819: Deprecate Locale class constructors [v7]

2022-03-29 Thread Naoto Sato
> Proposing to deprecate the constructors in the `java.util.Locale` class. 
> There is already a factory method and a builder to return singletons, so 
> there is no need to have constructors anymore unless one purposefully wants 
> to create `ill-formed` Locale objects, which is discouraged. We cannot 
> terminally deprecate those constructors for the compatibility to serialized 
> objects created with older JDKs. Please see the draft CSR for more detail.

Naoto Sato has updated the pull request incrementally with one additional 
commit since the last revision:

  Changed from var-args to conventional args. Reflected suggestions.

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/7947/files
  - new: https://git.openjdk.java.net/jdk/pull/7947/files/b1d36b52..8ac9d11d

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7947&range=06
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7947&range=05-06

  Stats: 132 lines in 4 files changed: 76 ins; 3 del; 53 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7947.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7947/head:pull/7947

PR: https://git.openjdk.java.net/jdk/pull/7947