> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
> in the bug report that breaks `IdentityHashMap` now causes several cases in
> this new test to fail. There's more that could be done, but the new tests
> cover most of the core functions of `IdentityHashMap`. Unfort
On Fri, 6 May 2022 16:59:16 GMT, Lance Andersen wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add some assertions for entrySet.equals and keySet.equals
>
> I think you have done a nice job on the coverage.
>
> I
On Wed, 4 May 2022 19:16:14 GMT, Stuart Marks wrote:
>> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
>> in the bug report that breaks `IdentityHashMap` now causes several cases in
>> this new test to fail. There's more that could be done, but the new tests
>> co
On Fri, 6 May 2022 06:39:59 GMT, XenoAmess wrote:
> > It would be nice if such a test could be written, but as it stands I think
> > that `Wrappers.java` test is too simplistic.
>
> Would adding `Wrappers.java` a method-name white-list mechanism suitable in
> this situation?
It should really
On Thu, 5 May 2022 23:46:24 GMT, Stuart Marks wrote:
> It would be nice if such a test could be written, but as it stands I think
> that `Wrappers.java` test is too simplistic.
Would adding `Wrappers.java` a method-name white-list mechanism suitable in
this situation?
-
PR: https
On Wed, 4 May 2022 19:16:14 GMT, Stuart Marks wrote:
>> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
>> in the bug report that breaks `IdentityHashMap` now causes several cases in
>> this new test to fail. There's more that could be done, but the new tests
>> co
On Wed, 4 May 2022 19:16:14 GMT, Stuart Marks wrote:
>> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
>> in the bug report that breaks `IdentityHashMap` now causes several cases in
>> this new test to fail. There's more that could be done, but the new tests
>> co
On Wed, 4 May 2022 19:16:14 GMT, Stuart Marks wrote:
>> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
>> in the bug report that breaks `IdentityHashMap` now causes several cases in
>> this new test to fail. There's more that could be done, but the new tests
>> co
On Wed, 4 May 2022 15:02:43 GMT, liach wrote:
>> test/jdk/java/util/IdentityHashMap/Basic.java line 500:
>>
>>> 498: Box newKey = new Box(k1a);
>>> 499: Box newVal = new Box(v1a);
>>> 500: Box r = map.computeIfAbsent(newKey, k -> { called[0] = true;
>>> return newVal; })
On Wed, 4 May 2022 19:16:14 GMT, Stuart Marks wrote:
>> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
>> in the bug report that breaks `IdentityHashMap` now causes several cases in
>> this new test to fail. There's more that could be done, but the new tests
>> co
On Wed, 4 May 2022 18:46:20 GMT, Stuart Marks wrote:
>> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
>> in the bug report that breaks `IdentityHashMap` now causes several cases in
>> this new test to fail. There's more that could be done, but the new tests
>> co
> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
> in the bug report that breaks `IdentityHashMap` now causes several cases in
> this new test to fail. There's more that could be done, but the new tests
> cover most of the core functions of `IdentityHashMap`. Unfort
On Wed, 4 May 2022 14:55:25 GMT, Jaikiran Pai wrote:
>> Stuart Marks has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Assertions over return values. Some refinement of equals() testing.
>> - Add comment about Map.Entry identity not gua
On Wed, 4 May 2022 15:02:43 GMT, liach wrote:
>> test/jdk/java/util/IdentityHashMap/Basic.java line 500:
>>
>>> 498: Box newKey = new Box(k1a);
>>> 499: Box newVal = new Box(v1a);
>>> 500: Box r = map.computeIfAbsent(newKey, k -> { called[0] = true;
>>> return newVal; })
> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
> in the bug report that breaks `IdentityHashMap` now causes several cases in
> this new test to fail. There's more that could be done, but the new tests
> cover most of the core functions of `IdentityHashMap`. Unfort
On Fri, 29 Apr 2022 03:00:40 GMT, Stuart Marks wrote:
>> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
>> in the bug report that breaks `IdentityHashMap` now causes several cases in
>> this new test to fail. There's more that could be done, but the new tests
>> c
On Wed, 4 May 2022 14:57:19 GMT, Jaikiran Pai wrote:
>> Stuart Marks has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Assertions over return values. Some refinement of equals() testing.
>> - Add comment about Map.Entry identity not gua
On Fri, 29 Apr 2022 03:00:40 GMT, Stuart Marks wrote:
>> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
>> in the bug report that breaks `IdentityHashMap` now causes several cases in
>> this new test to fail. There's more that could be done, but the new tests
>> c
> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
> in the bug report that breaks `IdentityHashMap` now causes several cases in
> this new test to fail. There's more that could be done, but the new tests
> cover most of the core functions of `IdentityHashMap`. Unfort
On Fri, 29 Apr 2022 00:06:32 GMT, Stuart Marks wrote:
>> test/jdk/java/util/IdentityHashMap/Basic.java line 257:
>>
>>> 255: checkEntries(map.entrySet(), entry(k1b, v1b),
>>> 256: entry(k2, v2));
>>> 257: }
>>
>> Would an additional check `assert
On Thu, 28 Apr 2022 13:17:59 GMT, Jaikiran Pai wrote:
>> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
>> in the bug report that breaks `IdentityHashMap` now causes several cases in
>> this new test to fail. There's more that could be done, but the new tests
>> c
On Thu, 28 Apr 2022 13:22:34 GMT, Jaikiran Pai wrote:
>> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
>> in the bug report that breaks `IdentityHashMap` now causes several cases in
>> this new test to fail. There's more that could be done, but the new tests
>> c
On Fri, 22 Apr 2022 03:37:27 GMT, Stuart Marks wrote:
> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
> in the bug report that breaks `IdentityHashMap` now causes several cases in
> this new test to fail. There's more that could be done, but the new tests
> cover
On Fri, 22 Apr 2022 03:37:27 GMT, Stuart Marks wrote:
> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
> in the bug report that breaks `IdentityHashMap` now causes several cases in
> this new test to fail. There's more that could be done, but the new tests
> cover
On Wed, 27 Apr 2022 03:28:09 GMT, Stuart Marks wrote:
>> test/jdk/java/util/IdentityHashMap/Basic.java line 77:
>>
>>> 75: E[] contents = (E[]) c.toArray();
>>> 76:
>>> 77: assertEquals(c.size(), given.length);
>>
>> I believe testng has the expected values in front in the `ass
On Wed, 27 Apr 2022 03:11:58 GMT, liach wrote:
>> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
>> in the bug report that breaks `IdentityHashMap` now causes several cases in
>> this new test to fail. There's more that could be done, but the new tests
>> cover mo
On Fri, 22 Apr 2022 03:37:27 GMT, Stuart Marks wrote:
> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
> in the bug report that breaks `IdentityHashMap` now causes several cases in
> this new test to fail. There's more that could be done, but the new tests
> cover
On Fri, 22 Apr 2022 03:37:27 GMT, Stuart Marks wrote:
> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
> in the bug report that breaks `IdentityHashMap` now causes several cases in
> this new test to fail. There's more that could be done, but the new tests
> cover
28 matches
Mail list logo