Re: [RFR] (XS) 8141489: [TESTBUG] requiredVersion in TEST.ROOT needs to updated to 4.1 b12

Hi Chris, Looks fine to me; thanks, -Joe On 11/5/2015 11:12 AM, Chris Plummer wrote: Hi Joe, Here's the updated webrev: http://cr.openjdk.java.net/~cjplummer/8141489/webrev.01 https://bugs.openjdk.java.net/browse/JDK-8141489 These are all the repos that have been updated: >$ grep requiredV

Re: [RFR] (XS) 8141489: [TESTBUG] requiredVersion in TEST.ROOT needs to updated to 4.1 b12

On 11/5/15 10:16 AM, joe darcy wrote: Hi Chris, On 11/5/2015 9:26 AM, Chris Plummer wrote: Hi Joe, Is there a reason to upgrade them if the tests don't actually require b12? BTW, there are more than just those two repos. The following all have TEST.ROOT: bash-4.1$ find . -name TEST.ROOT ./

Re: [RFR] (XS) 8141489: [TESTBUG] requiredVersion in TEST.ROOT needs to updated to 4.1 b12

Hi Chris, On 11/5/2015 9:26 AM, Chris Plummer wrote: Hi Joe, Is there a reason to upgrade them if the tests don't actually require b12? BTW, there are more than just those two repos. The following all have TEST.ROOT: bash-4.1$ find . -name TEST.ROOT ./hotspot/agent/test/jdi/TEST.ROOT ./hots

Re: [RFR] (XS) 8141489: [TESTBUG] requiredVersion in TEST.ROOT needs to updated to 4.1 b12

Hi Joe, Is there a reason to upgrade them if the tests don't actually require b12? BTW, there are more than just those two repos. The following all have TEST.ROOT: bash-4.1$ find . -name TEST.ROOT ./hotspot/agent/test/jdi/TEST.ROOT ./hotspot/test/TEST.ROOT ./deploy/test/TEST.ROOT ./nashorn/te

Re: [RFR] (XS) 8141489: [TESTBUG] requiredVersion in TEST.ROOT needs to updated to 4.1 b12

Hi Chris, The langtools and jaxp repos also have TEST.ROOT files with a requiredVersion clause. I'd prefer if the files in those repos were updated at the same to b12. Thanks, -Joe On 11/4/2015 6:25 PM, Chris Plummer wrote: Please review the following changes: http://cr.openjdk.java.net/~

Re: [RFR] (XS) 8141489: [TESTBUG] requiredVersion in TEST.ROOT needs to updated to 4.1 b12

Hi Joe, Here's the updated webrev: http://cr.openjdk.java.net/~cjplummer/8141489/webrev.01 https://bugs.openjdk.java.net/browse/JDK-8141489 These are all the repos that have been updated: >$ grep requiredVersion `find . -name TEST.ROOT` ./hotspot/test/TEST.ROOT:requiredVersion=4.1 b12 ./deploy

Re: [RFR] (XS) 8141489: [TESTBUG] requiredVersion in TEST.ROOT needs to updated to 4.1 b12

Thanks David and Staffan! Chris On 11/4/15 11:25 PM, Staffan Larsen wrote: Looks good! Thanks, /Staffan On 5 nov. 2015, at 03:25, Chris Plummer wrote: Please review the following changes: http://cr.openjdk.java.net/~cjplummer/8141489/ https://bugs.openjdk.java.net/browse/JDK-8141489 The

Re: [RFR] (XS) 8141489: [TESTBUG] requiredVersion in TEST.ROOT needs to updated to 4.1 b12

Looks good! Thanks, /Staffan > On 5 nov. 2015, at 03:25, Chris Plummer wrote: > > Please review the following changes: > > http://cr.openjdk.java.net/~cjplummer/8141489/ > https://bugs.openjdk.java.net/browse/JDK-8141489 > > The changes I did for 8140189 require that version 4.1 b12 of jtreg

Re: [RFR] (XS) 8141489: [TESTBUG] requiredVersion in TEST.ROOT needs to updated to 4.1 b12

Looks good to me Chris! Thanks, David On 5/11/2015 12:25 PM, Chris Plummer wrote: Please review the following changes: http://cr.openjdk.java.net/~cjplummer/8141489/ https://bugs.openjdk.java.net/browse/JDK-8141489 The changes I did for 8140189 require that version 4.1 b12 of jtreg be used, s

[RFR] (XS) 8141489: [TESTBUG] requiredVersion in TEST.ROOT needs to updated to 4.1 b12

Please review the following changes: http://cr.openjdk.java.net/~cjplummer/8141489/ https://bugs.openjdk.java.net/browse/JDK-8141489 The changes I did for 8140189 require that version 4.1 b12 of jtreg be used, so TEST.ROOT has been updated to reflect this. Testing with JPRT right now. I also