Re: JDK 14 RFR of JDK-8236695: java.lang.Record should be declared with an explicit constructor

2020-01-07 Thread Joe Darcy
On 1/7/2020 4:26 AM, Chris Hegarty wrote: On 6 Jan 2020, at 23:22, Joe Darcy wrote: Hello, The initial implementation of java.lang.Record uses a default constructor; an explicit constructor should be added instead. Please review the code change and CSR for this: JDK-8236695:

Re: JDK 14 RFR of JDK-8236695: java.lang.Record should be declared with an explicit constructor

2020-01-07 Thread Chris Hegarty
> On 6 Jan 2020, at 23:22, Joe Darcy wrote: > > Hello, > > The initial implementation of java.lang.Record uses a default constructor; an > explicit constructor should be added instead. Please review the code change > and CSR for this: > > JDK-8236695: java.lang.Record should be

Re: JDK 14 RFR of JDK-8236695: java.lang.Record should be declared with an explicit constructor

2020-01-06 Thread Paul Sandoz
+1 Paul. > On Jan 6, 2020, at 3:22 PM, Joe Darcy wrote: > > Hello, > > The initial implementation of java.lang.Record uses a default constructor; an > explicit constructor should be added instead. Please review the code change > and CSR for this: > > JDK-8236695: java.lang.Record

JDK 14 RFR of JDK-8236695: java.lang.Record should be declared with an explicit constructor

2020-01-06 Thread Joe Darcy
Hello, The initial implementation of java.lang.Record uses a default constructor; an explicit constructor should be added instead. Please review the code change and CSR for this:     JDK-8236695: java.lang.Record should be declared with an explicit constructor     CSR: