Re: Ping!! Re: RFR: 8203357 Container Metrics

> On Jun 12, 2018, at 1:43 AM, David Holmes wrote: > >> On 12/06/2018 3:31 PM, mandy chung wrote: >> On 6/11/18 10:12 PM, David Holmes wrote: >>> >>> For the Java code ... methods that return arrays should return >>> zero-length arrays when something is not available rather than

Re: Ping!! Re: RFR: 8203357 Container Metrics

> On Jun 12, 2018, at 1:12 AM, David Holmes wrote: > > On 12/06/2018 9:30 AM, Bob Vandette wrote: >>> On Jun 11, 2018, at 5:21 PM, David Holmes wrote: >>> >>> On 12/06/2018 12:12 AM, Bob Vandette wrote: > On Jun 11, 2018, at 4:32 AM, David Holmes >

Re: Ping!! Re: RFR: 8203357 Container Metrics

On 6/11/18 10:43 PM, David Holmes wrote: On 12/06/2018 3:31 PM, mandy chung wrote: On 6/11/18 10:12 PM, David Holmes wrote: For the Java code ... methods that return arrays should return zero-length arrays when something is not available rather than null. All methods do return zero length

Re: Ping!! Re: RFR: 8203357 Container Metrics

On 12/06/2018 3:31 PM, mandy chung wrote: On 6/11/18 10:12 PM, David Holmes wrote: For the Java code ... methods that return arrays should return zero-length arrays when something is not available rather than null. All methods do return zero length arrays except I missed the getPerCpuUsage. 

Re: Ping!! Re: RFR: 8203357 Container Metrics

On 6/11/18 10:12 PM, David Holmes wrote: For the Java code ... methods that return arrays should return zero-length arrays when something is not available rather than null. All methods do return zero length arrays except I missed the getPerCpuUsage.  I’ll fix that one and correct the

Re: Ping!! Re: RFR: 8203357 Container Metrics

On 12/06/2018 9:30 AM, Bob Vandette wrote: On Jun 11, 2018, at 5:21 PM, David Holmes wrote: On 12/06/2018 12:12 AM, Bob Vandette wrote: On Jun 11, 2018, at 4:32 AM, David Holmes mailto:david.hol...@oracle.com>> wrote: Sorry Bob I haven't had a chance to look at this detail. For the Java

Re: Ping!! Re: RFR: 8203357 Container Metrics

> On Jun 11, 2018, at 5:21 PM, David Holmes wrote: > > On 12/06/2018 12:12 AM, Bob Vandette wrote: >>> On Jun 11, 2018, at 4:32 AM, David Holmes >> > wrote: >>> >>> Sorry Bob I haven't had a chance to look at this detail. >>> >>> For the Java code ... methods

Re: Ping!! Re: RFR: 8203357 Container Metrics

On 12/06/2018 12:12 AM, Bob Vandette wrote: On Jun 11, 2018, at 4:32 AM, David Holmes > wrote: Sorry Bob I haven't had a chance to look at this detail. For the Java code ... methods that return arrays should return zero-length arrays when something is not

Re: Ping!! Re: RFR: 8203357 Container Metrics

> On Jun 11, 2018, at 4:07 AM, Robbin Ehn wrote: > > Hi Bob, > > On 06/07/2018 07:43 PM, Bob Vandette wrote: >> Can I get one more reviewer for this RFE so I can integrate it? >>> http://cr.openjdk.java.net/~bobv/8203357/webrev.01 > > Seems okay. > > Metrics.java > "Returns the length of

Re: Ping!! Re: RFR: 8203357 Container Metrics

> On Jun 11, 2018, at 4:32 AM, David Holmes wrote: > > Sorry Bob I haven't had a chance to look at this detail. > > For the Java code ... methods that return arrays should return zero-length > arrays when something is not available rather than null. All methods do return zero length arrays

Re: Ping!! Re: RFR: 8203357 Container Metrics

Sorry Bob I haven't had a chance to look at this detail. For the Java code ... methods that return arrays should return zero-length arrays when something is not available rather than null. For getCpuPeriod() the term "operating system time slice" can be misconstrued as being related to the

Re: Ping!! Re: RFR: 8203357 Container Metrics

Hi Bob, On 06/07/2018 07:43 PM, Bob Vandette wrote: Can I get one more reviewer for this RFE so I can integrate it? http://cr.openjdk.java.net/~bobv/8203357/webrev.01 Seems okay. Metrics.java "Returns the length of the operating system time slice" Note that is is only true if you are

Re: Ping!! Re: RFR: 8203357 Container Metrics

Hi Harsha,   Thank you for the explanation, makes sense to me. Please be aware, if a specific test turns out to be unstable in CI testing, it should be problem listed until solution is found to make it more stable. If the test is highly intermittent (fails intermittently but rarely) then it

Re: Ping!! Re: RFR: 8203357 Container Metrics

I didn’t actually have any ERROR_MARGIN problems during testing. I had issues with the testCpuConsumption test in http://cr.openjdk.java.net/~bobv/8203357/webrev.01/test/lib/jdk/test/lib/containers/cgroup/MetricsTester.java.html

Re: Ping!! Re: RFR: 8203357 Container Metrics

[Replying to all mailing-lists] Hi Misha, The ERROR_MARGIN in tests was introduced to make the tests stable. There are times where metric values (specifically CPU usage) can change drastically in between two reads. The metrics value got from the API and the cgroup file can be different and

Re: Ping!! Re: RFR: 8203357 Container Metrics

Hi Bob, I looked at the tests. In general they look good. I am a bit concerned about the use of ERROR_MARGIN in one of the tests. We need to make sure that the tests are stable, and do not produce intermittent failures. Thank you, Misha On 6/7/18, 10:43 AM, Bob Vandette wrote: Can I

Ping!! Re: RFR: 8203357 Container Metrics

Can I get one more reviewer for this RFE so I can integrate it? > http://cr.openjdk.java.net/~bobv/8203357/webrev.01 Mandy Chung has reviewed this change. I’ve run Mach5 hotspot and core lib tests. I’ve reviewed the tests which were written by Harsha Wardhana I filed a CSR for the command