Hi Volker,
Thanks for the corroboration. I’ll plan to push this tomorrow.
Brian
On Aug 28, 2018, at 5:12 AM, Volker Simonis wrote:
> Our internal testing was successful as well.
>
> Ready to push!
On Tue, Aug 28, 2018 at 2:26 AM Brian Burkhalter
wrote:
>
> Hi Volker,
>
> On Aug 27, 2018, at 6:53 AM, Volker Simonis wrote:
>
> sorry, I'm a little late in the game. I've just looked at your change
> and in general it looks good!
>
>
> Thanks: better late than never!
>
> There's one thing
Hi Volker,
On Aug 27, 2018, at 6:53 AM, Volker Simonis wrote:
> sorry, I'm a little late in the game. I've just looked at your change
> and in general it looks good!
Thanks: better late than never!
> There's one thing however I think you still have to fix. After
> changing 'stat64' to 'stat'
Hi Brian,
sorry, I'm a little late in the game. I've just looked at your change
and in general it looks good!
There's one thing however I think you still have to fix. After
changing 'stat64' to 'stat' in UnixFileSystem_md.c you should define
'stat' to 'stat64' on AIX if you don't want to change
Thanks, Brent!
Brian
On Aug 24, 2018, at 12:14 PM, Brent Christian
wrote:
> The change looks fine to me.
> From my search, I believe all usages have been covered.
Hi, Brian
The change looks fine to me.
From my search, I believe all usages have been covered.
-Brent
On 8/24/18 11:01 AM, Brian Burkhalter wrote:
This one could still use a Reviewer approval or rejection.
Thanks,
Brian
On Aug 14, 2018, at 1:34 PM, Brian Burkhalter
wrote:
Hi Bernard,
This one could still use a Reviewer approval or rejection.
Thanks,
Brian
On Aug 14, 2018, at 1:34 PM, Brian Burkhalter
wrote:
> Hi Bernard,
>
> On Aug 14, 2018, at 4:13 AM, B. Blaser wrote:
>
>> Seems quite good to me, last notes:
>>
>> 1) dealing with 'stat/stat64' in
Hi Bernard,
On Aug 14, 2018, at 4:13 AM, B. Blaser wrote:
> Seems quite good to me, last notes:
>
> 1) dealing with 'stat/stat64' in 'UnixFileSystem_md.c' might be
> outside the scope of this fix (?) even if fully pertinent per [1].
It might be slightly out of scope but I think it’s OK as
Seems quite good to me, last notes:
1) dealing with 'stat/stat64' in 'UnixFileSystem_md.c' might be
outside the scope of this fix (?) even if fully pertinent per [1]. In
the same file, I think '#define dirent dirent64' is probably missing
for AIX.
2) I guess '#if defined(_AIX) ...' is now
Hi Bernard,
I updated the patch per your suggestions and it checks out on our systems.
http://cr.openjdk.java.net/~bpb/8207744/webrev.04/
Thanks,
Brian
On Aug 10, 2018, at 6:20 AM, B. Blaser wrote:
> Among the files you suggest to fix, only the following ones are still
> using 'readdir64'
Hi Brian,
Among the files you suggest to fix, only the following ones are still
using 'readdir64' for other systems than AIX:
http://cr.openjdk.java.net/~bpb/8207744/webrev.03/src/java.base/unix/native/libjava/UnixFileSystem_md.c.frames.html
Hello,
The latest build + test runs with the .03 revision of this patch check out on
AIX, Linux-x64, macOS, Solaris-sparc, and Windows-x64.
If there is a Reviewer available who approves of these changes then please do
so.
Thanks,
Brian
On Aug 7, 2018, at 3:41 PM, Brian Burkhalter
wrote:
Hi Matthias,
Yes, that was intentional. From the documentation it looks as if the Linux /
Solaris *64 functions in question are now legacy so I changed them for
hopefully better consistency. I did not see any problems in building or testing
with these changes. If someone knows these changes to
regards , Matthias
From: Brian Burkhalter
Sent: Samstag, 4. August 2018 00:08
To: Baesken, Matthias
Cc: core-libs-dev@openjdk.java.net; Langer, Christoph
; Simonis, Volker ;
Lindenmaier, Goetz
Subject: Re: [12] (AIX) 8207744: Clean up inconsistent use of opendir/closedir
versus opendir64
HI Matthias,
I think I fixed the dirent problem: thanks for pointing it out.
http://cr.openjdk.java.net/~bpb/8207744/webrev.03/
The usual builds passed and tests are running.
I think that there is some _ALLBSD_SOURCE cruft in UnixNativeDispatcher.c which
could be cleaned up but we’ll leave
Hi Matthias,
No, I don’t know either whether this matters in reality but I will check it
out. As long as I am fooling around in this area we might as well try to get it
clean.
Thanks,
Brian
On Aug 2, 2018, at 11:57 PM, Baesken, Matthias wrote:
> Hi Brian , looks like the function
>
>
; Simonis, Volker
Subject: Re: [12] (AIX) 8207744: Clean up inconsistent use of opendir/closedir
versus opendir64/closedir64
Hi Matthias,
Thanks for the build + test.
I will take a look at what you observed. The whole process is a bit protracted
since I cannot build and test but your
Hi Matthias,
I went back through all this code and looked at the IBM documentation you sent
and man pages on Linux, macOS, and Solaris trying to get some consistency. This
is what I came up with:
http://cr.openjdk.java.net/~bpb/8207744/webrev.02/
It built successfully on our usual Linux,
Hi Matthias,
Thanks for the build + test.
I will take a look at what you observed. The whole process is a bit protracted
since I cannot build and test but your assistance is appreciated.
Thanks,
Brian
On Aug 2, 2018, at 5:24 AM, Baesken, Matthias wrote:
> builds + tests ( with your
.01/raw_files/new/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c
Best regards, Matthias
From: Brian Burkhalter
Sent: Mittwoch, 1. August 2018 16:53
To: Baesken, Matthias
Cc: Langer, Christoph
Subject: Re: [12] (AIX) 8207744: Clean up inconsistent use of opendir/closedir
versus
Hi,
Does anyone have any further comments on this?
Is there anyone willing to volunteer to build and test it on AIX?
Thanks,
Brian
On Jul 30, 2018, at 1:35 PM, Brian Burkhalter
wrote:
> Hi Bernard,
>
> Yes we agree. I believe I already had that change to those two files in the
> revised
Hi Bernard,
Yes we agree. I believe I already had that change to those two files in the
revised (.01) version of the patch which I posted on Friday:
http://cr.openjdk.java.net/~bpb/8207744/webrev.01/index.html
Thanks,
Brian
On Jul 28, 2018, at 7:10 AM, B. Blaser wrote:
> In these files,
I checked Linux [1], Solaris [2], MacOS [3], FreeBSD [4] and AIX [5]
docs and I tried to summarize 64-bit directory usage as follows:
* [1] & [2] seem to use 'opendir/closedir/DIR' in conjunction with 'readdir64'
* [3] seems to be based on [4] which doesn't provide any specific
64-bit interface
Hi Bernard,
I think you are correct. Webrev updated accordingly:
http://cr.openjdk.java.net/~bpb/8207744/webrev.01/
I know you cannot do it, but a build of this on AIX by someone would be
appreciated (not urgent).
Thanks,
Brian
On Jul 27, 2018, at 7:16 AM, B. Blaser wrote:
> I cannot
Hi Brian,
On 26 July 2018 at 22:13, Brian Burkhalter wrote:
> https://bugs.openjdk.java.net/browse/JDK-8207744
> http://cr.openjdk.java.net/~bpb/8207744/webrev.00/
>
> This change simply adds
>
> #if defined(_AIX)
> #define DIR DIR64
> #define opendir opendir64
> #define closedir
25 matches
Mail list logo
