RE: RFR: 8214533 IBM-29626C is required for AIX default charset

2019-01-28 Thread Ichiroh Takiguchi
ar 2019 14:13 To: Baesken, Matthias Cc: build-dev ; ppc-aix-port-dev d...@openjdk.java.net>; core-libs-dev@openjdk.java.net; Alan Bateman Subject: RE: RFR: 8214533 IBM-29626C is required for AIX default charset Hello. I'm very sorry. It's my fault. EUC_JP class was moved to jav

RE: RFR: 8214533 IBM-29626C is required for AIX default charset

2019-01-28 Thread Lindenmaier, Goetz
ag, 28. Januar 2019 14:13 > To: Baesken, Matthias > Cc: build-dev ; ppc-aix-port-dev d...@openjdk.java.net>; core-libs-dev@openjdk.java.net; Alan Bateman > > Subject: RE: RFR: 8214533 IBM-29626C is required for AIX default charset > > Hello. > > I'm very sorry. It'

RE: RFR: 8214533 IBM-29626C is required for AIX default charset

2019-01-28 Thread Ichiroh Takiguchi
@openjdk.java.net Subject: Re: RFR: 8214533 IBM-29626C is required for AIX default charset Hello Alan. Could you review the fix again ? Bug:https://bugs.openjdk.java.net/browse/JDK-8214533 Change: https://cr.openjdk.java.net/~itakiguchi/8214533/webrev.01/ I added IBM29626C charset as standard way. Please

RE: RFR: 8214533 IBM-29626C is required for AIX default charset

2019-01-28 Thread Baesken, Matthias
dk.java.net>; core-libs-dev@openjdk.java.net > Subject: Re: RFR: 8214533 IBM-29626C is required for AIX default charset > > Hello Alan. > > Could you review the fix again ? > > Bug:https://bugs.openjdk.java.net/browse/JDK-8214533 > Change: https://cr.openjdk.java.ne

Re: RFR: 8214533 IBM-29626C is required for AIX default charset

2019-01-23 Thread Roger Riggs
Hi Ichiroh, Sorry for the delay, yes, the change looks fine. I'll sponsor, and push it tomorrow. Thanks, Roger On 01/23/2019 07:21 AM, Ichiroh Takiguchi wrote: Hello. Could you review the fix and give your suggestion ? Thanks, Ichiroh Takiguchi On 2019-01-16 21:32, Ichiroh Takiguchi

Re: RFR: 8214533 IBM-29626C is required for AIX default charset

2019-01-23 Thread Ichiroh Takiguchi
Hello. Could you review the fix and give your suggestion ? Thanks, Ichiroh Takiguchi On 2019-01-16 21:32, Ichiroh Takiguchi wrote: Hello Alan and Roger. I appreciate your suggestions. Could you review the fix again ? Bug:https://bugs.openjdk.java.net/browse/JDK-8214533 Change:

Re: RFR: 8214533 IBM-29626C is required for AIX default charset

2019-01-16 Thread Ichiroh Takiguchi
Hello Alan and Roger. I appreciate your suggestions. Could you review the fix again ? Bug:https://bugs.openjdk.java.net/browse/JDK-8214533 Change: https://cr.openjdk.java.net/~itakiguchi/8214533/webrev.02/ I used "hg cp" command. If I should use git format, please let me know. I changed

Re: RFR: 8214533 IBM-29626C is required for AIX default charset

2019-01-15 Thread Roger Riggs
Hi, I'd suggest using 2002, 2019, for the copyright, since much of the code in the new file comes from an older source. $.02, Roger On 01/15/2019 10:43 AM, Alan Bateman wrote: On 15/01/2019 00:51, Ichiroh Takiguchi wrote: Hello Alan. Could you review the fix again ? Bug:   

Re: RFR: 8214533 IBM-29626C is required for AIX default charset

2019-01-15 Thread Alan Bateman
On 15/01/2019 00:51, Ichiroh Takiguchi wrote: Hello Alan. Could you review the fix again ? Bug:    https://bugs.openjdk.java.net/browse/JDK-8214533 Change: https://cr.openjdk.java.net/~itakiguchi/8214533/webrev.01/ I added IBM29626C charset as standard way. Please give any suggestion and

Re: RFR: 8214533 IBM-29626C is required for AIX default charset

2019-01-14 Thread Ichiroh Takiguchi
Hello Alan. Could you review the fix again ? Bug:https://bugs.openjdk.java.net/browse/JDK-8214533 Change: https://cr.openjdk.java.net/~itakiguchi/8214533/webrev.01/ I added IBM29626C charset as standard way. Please give any suggestion and question. Thanks, Ichiroh Takiguchi IBM Japan,

Re: RFR: 8214533 IBM-29626C is required for AIX default charset

2018-12-14 Thread Ichiroh Takiguchi
Hello Alan. I opened JDK-8215333 for Charset filtering issue [1]. I cannot wait until JDK-8215333 is closed. Is it possible to put IBM-29626C charset with standard way ? [1] https://bugs.openjdk.java.net/browse/JDK-8215333 Thanks, Ichiroh Takiguchi On 2018-12-10 21:21, Ichiroh Takiguchi

Re: RFR: 8214533 IBM-29626C is required for AIX default charset

2018-12-10 Thread Ichiroh Takiguchi
Hello Roger, Magnus and Alan. I may need to put alias information into charsets file. stdcs-xxx cannot handle this information... Still AIX needs IBM-29626C charset for default encoding... I appreciate if you give me further suggestions. Thanks, Ichiroh Takiguchi On 2018-12-10 20:50, Alan

Re: RFR: 8214533 IBM-29626C is required for AIX default charset

2018-12-10 Thread Alan Bateman
On 10/12/2018 11:01, Magnus Ihse Bursie wrote: On 2018-12-07 21:20, Roger Riggs wrote: Hi, It is a nice feature that charsets are selected at build time using the stdcs-xxx files. This change breaks that pattern and embeds os specific information in more than one place. That does not seem

Re: RFR: 8214533 IBM-29626C is required for AIX default charset

2018-12-10 Thread Magnus Ihse Bursie
On 2018-12-07 21:20, Roger Riggs wrote: Hi, It is a nice feature that charsets are selected at build time using the stdcs-xxx files. This change breaks that pattern and embeds os specific information in more than one place. That does not seem like an improvement. Is there any alternative?

Re: RFR: 8214533 IBM-29626C is required for AIX default charset

2018-12-07 Thread Roger Riggs
Hi, It is a nice feature that charsets are selected at build time using the stdcs-xxx files. This change breaks that pattern and embeds os specific information in more than one place. That does not seem like an improvement.  Is there any alternative? Thanks, Roger On 12/06/2018 12:05 PM,