usage of canonicalize function between
libjava, hotspot and libinstrument
Hi Christoph,
On 6/12/2019 2:12 am, Langer, Christoph wrote:
Hi David,
I prepared an updated webrev:
http://cr.openjdk.java.net/~clanger/webrevs/8234185.3/
src/java.base/windows/native/libjava/canonicalize_md.c
+// We
oracle.com
> Cc: core-libs-dev@openjdk.java.net; hotspot-runtime-
> d...@openjdk.java.net; gerard ziemski
> Subject: Re: RFR: 8234185: Cleanup usage of canonicalize function between
> libjava, hotspot and libinstrument
>
> On 06/12/2019 08:04, Langer, Christoph wrote:
> > Th
On 06/12/2019 08:04, Langer, Christoph wrote:
Thanks, David.
I'll run the final change once again through jdk-submit befor pushing.
Alan, Dan, may I consider this reviewed by either of you?
Yes, I think this looks okay.
-Alan
; daniel.daughe...@oracle.com
> Cc: core-libs-dev@openjdk.java.net; hotspot-runtime-
> d...@openjdk.java.net; Alan Bateman ; gerard
> ziemski
> Subject: Re: RFR: 8234185: Cleanup usage of canonicalize function between
> libjava, hotspot and libinstrument
>
> Hi Christop
Hi Christoph,
On 6/12/2019 2:12 am, Langer, Christoph wrote:
Hi David,
I prepared an updated webrev:
http://cr.openjdk.java.net/~clanger/webrevs/8234185.3/
src/java.base/windows/native/libjava/canonicalize_md.c
+// We can't include jdk_util.h here because the file is used in Oracle
in
e-libs-dev@openjdk.java.net; hotspot-runtime-
d...@openjdk.java.net; Alan Bateman ; gerard
ziemski
Subject: Re: RFR: 8234185: Cleanup usage of canonicalize function
between
libjava, hotspot and libinstrument
Hi Christoph,
On 3/12/2019 7:26 pm, Langer, Christoph wrote:
Hi David,
thanks for t
Hi David,
I prepared an updated webrev:
http://cr.openjdk.java.net/~clanger/webrevs/8234185.3/
> src/java.base/windows/native/libjava/canonicalize_md.c
>
> +// We can't include jdk_util.h here because the file is used in Oracle
> in another context
> +// #include "jdk_util.h"
>
> Seems to me
ienstag, 3. Dezember 2019 03:13
To: Langer, Christoph ; Alan Bateman
; gerard ziemski
Cc: core-libs-dev@openjdk.java.net; hotspot-runtime-
d...@openjdk.java.net
Subject: Re: RFR: 8234185: Cleanup usage of canonicalize function
between
libjava, hotspot and libinstrument
Hi Christoph,
Can
ienstag, 3. Dezember 2019 23:52
To: Langer, Christoph
Cc: core-libs-dev@openjdk.java.net; hotspot-runtime-
d...@openjdk.java.net; Alan Bateman ; gerard
ziemski
Subject: Re: RFR: 8234185: Cleanup usage of canonicalize function between
libjava, hotspot and libinstrument
Hi Christoph,
On 3/12/2019 7:26
mber 2019 23:52
> To: Langer, Christoph
> Cc: core-libs-dev@openjdk.java.net; hotspot-runtime-
> d...@openjdk.java.net; Alan Bateman ; gerard
> ziemski
> Subject: Re: RFR: 8234185: Cleanup usage of canonicalize function between
> libjava, hotspot and libinstrument
>
> Hi
oph ; Alan Bateman
; gerard ziemski
Cc: core-libs-dev@openjdk.java.net; hotspot-runtime-
d...@openjdk.java.net
Subject: Re: RFR: 8234185: Cleanup usage of canonicalize function between
libjava, hotspot and libinstrument
Hi Christoph,
Can you please post your updated patch for review and I will use i
va.net; hotspot-runtime-
> d...@openjdk.java.net
> Subject: Re: RFR: 8234185: Cleanup usage of canonicalize function between
> libjava, hotspot and libinstrument
>
> Hi Christoph,
>
> Can you please post your updated patch for review and I will use it to
> check the fix for
-...@openjdk.java.net
Subject: Re: RFR: 8234185: Cleanup usage of canonicalize function
between
libjava, hotspot and libinstrument
On 14/11/2019 15:37, Langer, Christoph wrote:
Hi,
please review this cleanup change regarding function
"canonicalize" of
libjava.
Bug: https://bugs.openjdk.java.net/
...@openjdk.java.net; hotspot-runtime-...@openjdk.java.net
Subject: Re: RFR: 8234185: Cleanup usage of canonicalize function
between
libjava, hotspot and libinstrument
On 14/11/2019 15:37, Langer, Christoph wrote:
Hi,
please review this cleanup change regarding function
"canonicalize" of
libj
Holmes
> Sent: Montag, 25. November 2019 01:02
> To: Langer, Christoph ; Alan Bateman
> ; gerard ziemski
> Cc: core-libs-dev@openjdk.java.net; hotspot-runtime-
> d...@openjdk.java.net
> Subject: Re: RFR: 8234185: Cleanup usage of canonicalize function between
> libjava
Subject: Re: RFR: 8234185: Cleanup usage of canonicalize function
between
libjava, hotspot and libinstrument
On 14/11/2019 15:37, Langer, Christoph wrote:
Hi,
please review this cleanup change regarding function
"canonicalize" of
libjava.
Bug: https://bugs.openjdk.java.net/browse/J
...@openjdk.java.net; hotspot-runtime-...@openjdk.java.net
Subject: Re: RFR: 8234185: Cleanup usage of canonicalize function
between
libjava, hotspot and libinstrument
On 14/11/2019 15:37, Langer, Christoph wrote:
Hi,
please review this cleanup change regarding function
"canonicalize" o
; hotspot-runtime-...@openjdk.java.net
Subject: RE: RFR: 8234185: Cleanup usage of canonicalize function
between
libjava, hotspot and libinstrument
Hi Alan,
thanks for the review. I'll push it then after running through
jdk-submit.
/Christoph
-Original Message-
From: Alan Bateman
Sent: Donnerstag, 21. November 2019 14:19
To: Alan Bateman ; core-libs-
d...@openjdk.java.net; hotspot-runtime-...@openjdk.java.net
Subject: RE: RFR: 8234185: Cleanup usage of canonicalize function between
libjava, hotspot and libinstrument
Hi Alan,
thanks for the review. I'll push it then after
> To: Langer, Christoph ; core-libs-
> > d...@openjdk.java.net; hotspot-runtime-...@openjdk.java.net
> > Subject: Re: RFR: 8234185: Cleanup usage of canonicalize function between
> > libjava, hotspot and libinstrument
> >
> > On 14/11/2019 15:37, Langer, Christoph
penjdk.java.net
> Subject: Re: RFR: 8234185: Cleanup usage of canonicalize function between
> libjava, hotspot and libinstrument
>
> On 14/11/2019 15:37, Langer, Christoph wrote:
> > Hi,
> >
> > please review this cleanup change regarding function "canonicalize" o
On 14/11/2019 15:37, Langer, Christoph wrote:
Hi,
please review this cleanup change regarding function "canonicalize" of libjava.
Bug: https://bugs.openjdk.java.net/browse/JDK-8234185
Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8234185.0/
The goal is to cleanup how this function is
: Cleanup usage of canonicalize function between
libjava, hotspot and libinstrument
Hi Christoph,
The fix looks good to me.
I'd recommend to run the jdk_instrument and vmTestbase_nsk_jvmti tests.
Also, it can be safe to run:
open/test/hotspot/jtreg/serviceability/jvmti
open/test/hotspot/jtreg
; To: Langer, Christoph ; core-libs-
> d...@openjdk.java.net; hotspot-runtime-...@openjdk.java.net; gerard
> ziemski
> Subject: Re: RFR: 8234185: Cleanup usage of canonicalize function between
> libjava, hotspot and libinstrument
>
> Hi Christoph,
>
> The fix look
Hi Christoph,
The fix looks good to me.
I'd recommend to run the jdk_instrument and vmTestbase_nsk_jvmti tests.
Also, it can be safe to run:
open/test/hotspot/jtreg/serviceability/jvmti
open/test/hotspot/jtreg/runtime/cds/appcds
open/test/hotspot/jtreg/runtime/BootClassAppendProp
Thanks,
Guten Tag Langer, Christoph,
am Montag, 18. November 2019 um 14:22 schrieben Sie:
> I saw your other mail already but didn't find time to reply.
Thanks, I wasn't sure if I'm received at all. Now that I know and
because of your negative answer, I'm going to leave this thread alone
and whoever is
234185: Cleanup usage of canonicalize function between
> libjava, hotspot and libinstrument
>
> Guten Tag Langer, Christoph,
> am Donnerstag, 14. November 2019 um 16:37 schrieben Sie:
>
> > please review this cleanup change regarding function "canonicalize" of
> libjav
Guten Tag Langer, Christoph,
am Donnerstag, 14. November 2019 um 16:37 schrieben Sie:
> please review this cleanup change regarding function "canonicalize" of
> libjava.
[...]
> The goal is to cleanup how this function is defined and used.[...]
If you are already changing "lastErrorReportable"
> I plan to review this change. We also need to figure out how to remove
> the dependency on this function from the JPLIS agent as that should not
> be there.
Agree. I'd hope, however, that this can be done with a different change (unless
you have an idea for a very simple, straightforward way
On 18/11/2019 09:00, Langer, Christoph wrote:
:
Any other reviews (e.g. Gerard?)
I plan to review this change. We also need to figure out how to remove
the dependency on this function from the JPLIS agent as that should not
be there.
-Alan
Hi David,
> This all seems fine to me. One clarification:
Thanks for the review.
>
> - /* The appropriate location of getPrefixed() should be io_util_md.c, but
> -java.lang.instrument package has hardwired canonicalize_md.c into their
> -dll, to avoid complicate solution such as
Hi Christoph,
This all seems fine to me. One clarification:
- /* The appropriate location of getPrefixed() should be io_util_md.c, but
-java.lang.instrument package has hardwired canonicalize_md.c into their
-dll, to avoid complicate solution such as including io_util_md.c into
-
32 matches
Mail list logo
