Re: RFR: 8209837: Avoid initializing ExpiringCache during bootstrap

2018-08-24 Thread forax
- Mail original - > De: "Claes Redestad" > À: "Remi Forax" > Cc: "core-libs-dev" > Envoyé: Vendredi 24 Août 2018 11:38:35 > Objet: Re: RFR: 8209837: Avoid initializing ExpiringCache during bootstrap > Hi, > &

Re: RFR: 8209837: Avoid initializing ExpiringCache during bootstrap

2018-08-24 Thread Claes Redestad
Hi, On 2018-08-23 17:12, Remi Forax wrote: Hi Claes, useCanonPrefixCache = useCanonCaches ? getBooleanProperty("sun.io.useCanonPrefixCache",false) : false; can be written useCanonPrefixCache = useCanonCaches && getBooleanProperty("sun.io.useCanonPrefixCache",false); sure. and the

Re: RFR: 8209837: Avoid initializing ExpiringCache during bootstrap

2018-08-23 Thread Remi Forax
nonPrefixCache should follow the coding convention USE_CANON_CACHES/USE_CANON_PREFIX_CACHE. otherwise, looks good ! Rémi - Mail original - > De: "Claes Redestad" > À: "core-libs-dev" > Envoyé: Jeudi 23 Août 2018 16:09:59 > Objet: RFR: 8209837: Avoid initial

Re: RFR: 8209837: Avoid initializing ExpiringCache during bootstrap

2018-08-23 Thread Claes Redestad
On 2018-08-23 16:30, Sundararajan Athijegannathan wrote: Looks good Thanks, Sundar! /Claes

Re: RFR: 8209837: Avoid initializing ExpiringCache during bootstrap

2018-08-23 Thread Sundararajan Athijegannathan
Looks good -Sundar On 23/08/18, 7:39 PM, Claes Redestad wrote: Hi, it's a tiny startup improvement to rearrange code so that the ExpiringCaches used in the FileSystem implementations aren't created if they aren't going to be used: Webrev:

RFR: 8209837: Avoid initializing ExpiringCache during bootstrap

2018-08-23 Thread Claes Redestad
Hi, it's a tiny startup improvement to rearrange code so that the ExpiringCaches used in the FileSystem implementations aren't created if they aren't going to be used: Webrev: http://cr.openjdk.java.net/~redestad/8209837/open.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8209837 3