Re: RFR: 8229516: Thread.isInterrupted() always returns false after thread termination

Thanks Doug! Appreciate the help getting the Graal bits correct. David On 31/10/2019 5:47 pm, Doug Simon wrote: On 31 Oct 2019, at 05:30, David Holmes > wrote: Hi Doug, On 30/10/2019 10:06 pm, Doug Simon wrote: On 30 Oct 2019, at 05:28, David Holmes

Re: RFR: 8229516: Thread.isInterrupted() always returns false after thread termination

> On 31 Oct 2019, at 05:30, David Holmes wrote: > > Hi Doug, > > On 30/10/2019 10:06 pm, Doug Simon wrote: >>> On 30 Oct 2019, at 05:28, David Holmes >> > wrote: >>> >>> Hi Doug, >>> >>> Your proposed patch wasn't quite right. I made some adjustments but I'm

Re: RFR: 8229516: Thread.isInterrupted() always returns false after thread termination

Hi Doug, On 30/10/2019 10:06 pm, Doug Simon wrote: On 30 Oct 2019, at 05:28, David Holmes wrote: Hi Doug, Your proposed patch wasn't quite right. I made some adjustments but I'm still having issues with the test, HotSpotMethodSubstitutionTest.testThreadSubstitutions, as I don't see how

Re: RFR: 8229516: Thread.isInterrupted() always returns false after thread termination

Thanks Serguei! David On 31/10/2019 10:36 am, serguei.spit...@oracle.com wrote: Hi David, The update looks good. Thanks, Serguei On 10/29/19 9:28 PM, David Holmes wrote: Hi Doug, Your proposed patch wasn't quite right. I made some adjustments but I'm still having issues with the test,

Re: RFR: 8229516: Thread.isInterrupted() always returns false after thread termination

Hi David, The update looks good. Thanks, Serguei On 10/29/19 9:28 PM, David Holmes wrote: Hi Doug, Your proposed patch wasn't quite right. I made some adjustments but I'm still having issues with the test, HotSpotMethodSubstitutionTest.testThreadSubstitutions, as I don't see how to make

Re: RFR: 8229516: Thread.isInterrupted() always returns false after thread termination

Hi Alan, Thanks for taking a look at this. On 31/10/2019 1:33 am, Alan Bateman wrote: On 29/10/2019 07:42, David Holmes wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8229516 CSR: https://bugs.openjdk.java.net/browse/JDK-8232676 (already approved) webrev:

Re: RFR: 8229516: Thread.isInterrupted() always returns false after thread termination

On 29/10/2019 07:42, David Holmes wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8229516 CSR: https://bugs.openjdk.java.net/browse/JDK-8232676 (already approved) webrev: http://cr.openjdk.java.net/~dholmes/8229516/webrev/ The implNote has "In the JDK Reference Implementation". I think you

Re: RFR: 8229516: Thread.isInterrupted() always returns false after thread termination

> On 30 Oct 2019, at 05:28, David Holmes wrote: > > Hi Doug, > > Your proposed patch wasn't quite right. I made some adjustments but I'm still > having issues with the test, > HotSpotMethodSubstitutionTest.testThreadSubstitutions, as I don't see how to > make the test execution

Re: RFR: 8229516: Thread.isInterrupted() always returns false after thread termination

Hi Doug, Your proposed patch wasn't quite right. I made some adjustments but I'm still having issues with the test, HotSpotMethodSubstitutionTest.testThreadSubstitutions, as I don't see how to make the test execution conditional on the VM config. Updated webrev:

Re: RFR: 8229516: Thread.isInterrupted() always returns false after thread termination

uot; , "Roger Riggs" Envoyé: Mardi 29 Octobre 2019 08:42:08 Objet: RFR: 8229516: Thread.isInterrupted() always returns false after thread termination Bug: https://bugs.openjdk.java.net/browse/JDK-8229516 CSR: https://bugs.openjdk.java.net/browse/JDK-8232676 (already approved) webrev: http:

Re: RFR: 8229516: Thread.isInterrupted() always returns false after thread termination

Thanks for the review Dan! Fixed the nit in thread.c Thanks, David On 30/10/2019 6:51 am, Daniel D. Daugherty wrote: On 10/29/19 3:42 AM, David Holmes wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8229516 CSR: https://bugs.openjdk.java.net/browse/JDK-8232676 (already approved) webrev:

Re: RFR: 8229516: Thread.isInterrupted() always returns false after thread termination

On 30/10/2019 4:05 am, serguei.spit...@oracle.com wrote: Hi David, The fix looks good to me. Thanks Serguei! David I did not pay much attention to the Graal related changes though. The test coverage for Serviceability is complete. Running java/lang/instrument tests is not necessary.

Re: RFR: 8229516: Thread.isInterrupted() always returns false after thread termination

original - > De: "David Holmes" > À: "hotspot-runtime-dev" , "hotspot > compiler" > , "core-libs-dev" > , "Doug Simon" > , "TOM.RODRIGUEZ" , > "serviceability-dev" > , "Roger Riggs" > Envo

Re: RFR: 8229516: Thread.isInterrupted() always returns false after thread termination

On 10/29/19 3:42 AM, David Holmes wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8229516 CSR: https://bugs.openjdk.java.net/browse/JDK-8232676 (already approved) webrev: http://cr.openjdk.java.net/~dholmes/8229516/webrev/ make/hotspot/symbols/symbols-unix     No comments.

Re: RFR: 8229516: Thread.isInterrupted() always returns false after thread termination

Hi David, The fix looks good to me. I did not pay much attention to the Graal related changes though. The test coverage for Serviceability is complete. Running java/lang/instrument tests is not necessary. Thanks, Serguei On 10/29/19 00:42, David Holmes wrote: Bug:

Re: RFR: 8229516: Thread.isInterrupted() always returns false after thread termination

> On 29 Oct 2019, at 10:12, David Holmes wrote: > > Hi Doug, > > Thanks for taking a look so quickly! :) > > On 29/10/2019 6:55 pm, Doug Simon wrote: >> Hi David, >> Since Graal needs to work against multiple JVMCI versions (and VM >> versions!), the Graal changes should only disable the

Re: RFR: 8229516: Thread.isInterrupted() always returns false after thread termination

Hi Doug, Thanks for taking a look so quickly! :) On 29/10/2019 6:55 pm, Doug Simon wrote: Hi David, Since Graal needs to work against multiple JVMCI versions (and VM versions!), the Graal changes should only disable the intrinsic when the relevant VM config is missing: So to be clear I

Re: RFR: 8229516: Thread.isInterrupted() always returns false after thread termination

Hi David, Since Graal needs to work against multiple JVMCI versions (and VM versions!), the Graal changes should only disable the intrinsic when the relevant VM config is missing: diff --git a/compiler/src/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/GraalHotSpotVMConfig.java

RFR: 8229516: Thread.isInterrupted() always returns false after thread termination

Bug: https://bugs.openjdk.java.net/browse/JDK-8229516 CSR: https://bugs.openjdk.java.net/browse/JDK-8232676 (already approved) webrev: http://cr.openjdk.java.net/~dholmes/8229516/webrev/ This cross-cuts core-libs, hotspot-runtime and the JIT compilers, but only in small pieces each. There is