Re: RFR: 8242451: ensure semantics of non-capturing lambdas are preserved independent of execution mode [v4]

2020-09-22 Thread Mandy Chung
On Tue, 22 Sep 2020 18:24:02 GMT, Gilles Duboscq wrote: > Thanks @mlchung. Do I need a second review? No need. You can integrate once you run the regression tests (I usually run tier1-tier3). - PR: https://git.openjdk.java.net/jdk/pull/93

Re: RFR: 8242451: ensure semantics of non-capturing lambdas are preserved independent of execution mode [v4]

2020-09-22 Thread Gilles Duboscq
On Tue, 22 Sep 2020 18:17:49 GMT, Mandy Chung wrote: >> Gilles Duboscq has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental >> views will show differences compared to the previous content of the PR. The >> pull request contains six new

Re: RFR: 8242451: ensure semantics of non-capturing lambdas are preserved independent of execution mode [v4]

2020-09-22 Thread Mandy Chung
On Tue, 22 Sep 2020 18:03:37 GMT, Gilles Duboscq wrote: >> [JDK-8232806](https://bugs.openjdk.java.net/browse/JDK-8232806) introduced >> the >> jdk.internal.lambda.disableEagerInitialization system property to be able to >> disable eager initialization of lambda >> classes. This was necessary

Re: RFR: 8242451: ensure semantics of non-capturing lambdas are preserved independent of execution mode [v4]

2020-09-22 Thread Gilles Duboscq
> [JDK-8232806](https://bugs.openjdk.java.net/browse/JDK-8232806) introduced the > jdk.internal.lambda.disableEagerInitialization system property to be able to > disable eager initialization of lambda > classes. This was necessary to prevent side effects of class initializers > triggered by such

Re: RFR: 8242451: ensure semantics of non-capturing lambdas are preserved independent of execution mode [v3]

2020-09-11 Thread Mandy Chung
On Wed, 9 Sep 2020 16:41:22 GMT, Mandy Chung wrote: >> Gilles Duboscq has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove disableEagerInitialization concerns from BridgeMethod.java > > Looks good. I agree with Jan's suggestion that

Re: RFR: 8242451: ensure semantics of non-capturing lambdas are preserved independent of execution mode [v3]

2020-09-11 Thread Gilles Duboscq
On Thu, 10 Sep 2020 16:34:02 GMT, Mandy Chung wrote: >> Gilles Duboscq has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove disableEagerInitialization concerns from BridgeMethod.java > >

Re: RFR: 8242451: ensure semantics of non-capturing lambdas are preserved independent of execution mode [v3]

2020-09-11 Thread Gilles Duboscq
> [JDK-8232806](https://bugs.openjdk.java.net/browse/JDK-8232806) introduced the > jdk.internal.lambda.disableEagerInitialization system property to be able to > disable eager initialization of lambda > classes. This was necessary to prevent side effects of class initializers > triggered by such

Re: RFR: 8242451: ensure semantics of non-capturing lambdas are preserved independent of execution mode [v2]

2020-09-10 Thread Mandy Chung
On Thu, 10 Sep 2020 15:23:14 GMT, Gilles Duboscq wrote: >> [JDK-8232806](https://bugs.openjdk.java.net/browse/JDK-8232806) introduced >> the >> jdk.internal.lambda.disableEagerInitialization system property to be able to >> disable eager initialization of lambda >> classes. This was necessary

Re: RFR: 8242451: ensure semantics of non-capturing lambdas are preserved independent of execution mode [v2]

2020-09-10 Thread Gilles Duboscq
On Thu, 10 Sep 2020 11:50:04 GMT, Gilles Duboscq wrote: >> It's a good suggestion as `disableEagerInitialization` support is not part >> of javac. > > OK makes sense. I guess it's still good to clean the test comments of the old > `disableEagerInitialization` references? I have created a new

Re: RFR: 8242451: ensure semantics of non-capturing lambdas are preserved independent of execution mode [v2]

2020-09-10 Thread Gilles Duboscq
> [JDK-8232806](https://bugs.openjdk.java.net/browse/JDK-8232806) introduced the > jdk.internal.lambda.disableEagerInitialization system property to be able to > disable eager initialization of lambda > classes. This was necessary to prevent side effects of class initializers > triggered by such

Re: RFR: 8242451: ensure semantics of non-capturing lambdas are preserved independent of execution mode [v2]

2020-09-10 Thread Gilles Duboscq
On Wed, 9 Sep 2020 16:36:43 GMT, Mandy Chung wrote: >> Gilles Duboscq has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Remove extra field test from LambdaTest6 >> - Wrap long lines >> - Add deciated test in the jdk tests > >

Re: RFR: 8242451: ensure semantics of non-capturing lambdas are preserved independent of execution mode

2020-09-10 Thread Gilles Duboscq
On Wed, 9 Sep 2020 16:39:25 GMT, Mandy Chung wrote: >> test/langtools/tools/javac/lambda/lambdaExpression/LambdaTest6.java line 29: >> >>> 27: * @summary Add lambda tests >>> 28: * Test bridge methods for certain SAM conversions >>> 29: * Test the set of generate fields >> >> I would

Re: RFR: 8242451: ensure semantics of non-capturing lambdas are preserved independent of execution mode

2020-09-09 Thread Mandy Chung
On Wed, 9 Sep 2020 08:18:11 GMT, Gilles Duboscq wrote: > [JDK-8232806](https://bugs.openjdk.java.net/browse/JDK-8232806) introduced the > jdk.internal.lambda.disableEagerInitialization system property to be able to > disable eager initialization of lambda > classes. This was necessary to

Re: RFR: 8242451: ensure semantics of non-capturing lambdas are preserved independent of execution mode

2020-09-09 Thread Mandy Chung
On Wed, 9 Sep 2020 12:19:04 GMT, Jan Lahoda wrote: >> [JDK-8232806](https://bugs.openjdk.java.net/browse/JDK-8232806) introduced >> the >> jdk.internal.lambda.disableEagerInitialization system property to be able to >> disable eager initialization of lambda >> classes. This was necessary to

Re: RFR: 8242451: ensure semantics of non-capturing lambdas are preserved independent of execution mode

2020-09-09 Thread Mandy Chung
On Wed, 9 Sep 2020 08:18:11 GMT, Gilles Duboscq wrote: > [JDK-8232806](https://bugs.openjdk.java.net/browse/JDK-8232806) introduced the > jdk.internal.lambda.disableEagerInitialization system property to be able to > disable eager initialization of lambda > classes. This was necessary to

Re: RFR: 8242451: ensure semantics of non-capturing lambdas are preserved independent of execution mode

2020-09-09 Thread Jan Lahoda
On Wed, 9 Sep 2020 08:18:11 GMT, Gilles Duboscq wrote: > [JDK-8232806](https://bugs.openjdk.java.net/browse/JDK-8232806) introduced the > jdk.internal.lambda.disableEagerInitialization system property to be able to > disable eager initialization of lambda > classes. This was necessary to

RFR: 8242451: ensure semantics of non-capturing lambdas are preserved independent of execution mode

2020-09-09 Thread Gilles Duboscq
[JDK-8232806](https://bugs.openjdk.java.net/browse/JDK-8232806) introduced the jdk.internal.lambda.disableEagerInitialization system property to be able to disable eager initialization of lambda classes. This was necessary to prevent side effects of class initializers triggered by such