Re: RFR: 8244778: Archive full module graph in CDS [v6]

2020-09-13 Thread Claes Redestad
On Sat, 12 Sep 2020 22:41:36 GMT, Ioi Lam wrote: >> This is the same patch as >> [8244778-archive-full-module-graph.v03](http://cr.openjdk.java.net/~iklam/jdk16/8244778-archive-full-module-graph.v03/) >> published in >>

Re: RFR: 8244778: Archive full module graph in CDS [v6]

2020-09-12 Thread Ioi Lam
> This is the same patch as > [8244778-archive-full-module-graph.v03](http://cr.openjdk.java.net/~iklam/jdk16/8244778-archive-full-module-graph.v03/) > published in > [hotspot-runtime-...@openjdk.java.net](https://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2020-August/041496.html). > The

Re: RFR: 8244778: Archive full module graph in CDS [v5]

2020-09-12 Thread Ioi Lam
> This is the same patch as > [8244778-archive-full-module-graph.v03](http://cr.openjdk.java.net/~iklam/jdk16/8244778-archive-full-module-graph.v03/) > published in > [hotspot-runtime-...@openjdk.java.net](https://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2020-August/041496.html). > The

Re: RFR: 8244778: Archive full module graph in CDS [v4]

2020-09-12 Thread Ioi Lam
On Sat, 12 Sep 2020 12:34:06 GMT, Claes Redestad wrote: >> Ioi Lam has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes >> the unrelated changes brought in by the merge/rebase. The pull request >> contains eight additional commits

Re: RFR: 8244778: Archive full module graph in CDS [v4]

2020-09-12 Thread Claes Redestad
On Sat, 12 Sep 2020 06:35:31 GMT, Ioi Lam wrote: >> This is the same patch as >> [8244778-archive-full-module-graph.v03](http://cr.openjdk.java.net/~iklam/jdk16/8244778-archive-full-module-graph.v03/) >> published in >>

Re: RFR: 8244778: Archive full module graph in CDS [v4]

2020-09-12 Thread Ioi Lam
> This is the same patch as > [8244778-archive-full-module-graph.v03](http://cr.openjdk.java.net/~iklam/jdk16/8244778-archive-full-module-graph.v03/) > published in > [hotspot-runtime-...@openjdk.java.net](https://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2020-August/041496.html). > The

Re: RFR: 8244778: Archive full module graph in CDS [v3]

2020-09-09 Thread Coleen Phillimore
On Wed, 9 Sep 2020 18:46:33 GMT, Lois Foltan wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Feedback from Coleen > > Thanks Ioi for addressing my review comments. Overall, looks great! Ok thanks! So many emails

Re: RFR: 8244778: Archive full module graph in CDS [v3]

2020-09-09 Thread Ioi Lam
On Tue, 8 Sep 2020 17:32:44 GMT, Coleen Phillimore wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Feedback from Coleen > > src/hotspot/share/classfile/classLoaderDataShared.cpp line 171: > >> 169: } >> 170: >> 171:

Re: RFR: 8244778: Archive full module graph in CDS [v3]

2020-09-09 Thread Ioi Lam
> This is the same patch as > [8244778-archive-full-module-graph.v03](http://cr.openjdk.java.net/~iklam/jdk16/8244778-archive-full-module-graph.v03/) > published in > [hotspot-runtime-...@openjdk.java.net](https://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2020-August/041496.html). > The

Re: RFR: 8244778: Archive full module graph in CDS [v2]

2020-09-09 Thread Ioi Lam
On Wed, 9 Sep 2020 18:41:25 GMT, Lois Foltan wrote: >> Ioi Lam has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes >> the unrelated changes brought in by the merge/rebase. The pull request >> contains six additional commits since

Re: RFR: 8244778: Archive full module graph in CDS [v2]

2020-09-09 Thread Ioi Lam
> This is the same patch as > [8244778-archive-full-module-graph.v03](http://cr.openjdk.java.net/~iklam/jdk16/8244778-archive-full-module-graph.v03/) > published in > [hotspot-runtime-...@openjdk.java.net](https://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2020-August/041496.html). > The

Re: RFR: 8244778: Archive full module graph in CDS

2020-09-09 Thread Lois Foltan
On Tue, 8 Sep 2020 15:59:33 GMT, Ioi Lam wrote: > This is the same patch as > [8244778-archive-full-module-graph.v03](http://cr.openjdk.java.net/~iklam/jdk16/8244778-archive-full-module-graph.v03/) > published in >

Re: RFR: 8244778: Archive full module graph in CDS

2020-09-09 Thread Coleen Phillimore
On Tue, 8 Sep 2020 15:59:33 GMT, Ioi Lam wrote: > This is the same patch as > [8244778-archive-full-module-graph.v03](http://cr.openjdk.java.net/~iklam/jdk16/8244778-archive-full-module-graph.v03/) > published in >

Re: RFR: 8244778: Archive full module graph in CDS

2020-09-08 Thread Erik Joelsson
On Tue, 8 Sep 2020 15:59:33 GMT, Ioi Lam wrote: > This is the same patch as > [8244778-archive-full-module-graph.v03](http://cr.openjdk.java.net/~iklam/jdk16/8244778-archive-full-module-graph.v03/) > published in >

Re: RFR: 8244778: Archive full module graph in CDS

2020-09-08 Thread Ioi Lam
On Tue, 8 Sep 2020 15:59:33 GMT, Ioi Lam wrote: > This is the same patch as > [8244778-archive-full-module-graph.v03](http://cr.openjdk.java.net/~iklam/jdk16/8244778-archive-full-module-graph.v03/) > published in >

RFR: 8244778: Archive full module graph in CDS

2020-09-08 Thread Ioi Lam
This is the same patch as [8244778-archive-full-module-graph.v03](http://cr.openjdk.java.net/~iklam/jdk16/8244778-archive-full-module-graph.v03/) published in [hotspot-runtime-...@openjdk.java.net](https://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2020-August/041496.html). The rest of