On Fri, 8 Jan 2021 13:20:38 GMT, Aleksei Efimov wrote:
>> This issue is blocked by [8258657][1]. It should not be integrated until
>> after 8258657 has been resolved. The JIRA issues have been linked up to
>> reflect this.
>>
>> [1]: https://bugs.openjdk.java.net/browse/JDK-8258657
>
>
On Sat, 19 Dec 2020 10:29:23 GMT, Chris Hegarty wrote:
>> Thank you for checking `HttpURLConnection` and `Socket`.
>> The latest version looks good to me.
>
> This issue is blocked by [8258657][1]. It should not be integrated until
> after 8258657 has been resolved. The JIRA issues have been
On Thu, 17 Dec 2020 13:16:31 GMT, Aleksei Efimov wrote:
>> Andrey Turbanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8258422: Cleanup unnecessary null comparison before instanceof check in
>> java.base
>> take advantage of
On Thu, 17 Dec 2020 13:32:06 GMT, Daniel Fuchs wrote:
>> Actually, I'm not sure if `oth` is better name for variable than `other1`.
>> I would say they have the same rank :)
>
> I believe Alan is suggesting to do:
>
> /**
> * Compares the equality of two Signal objects.
> *
>
On Thu, 17 Dec 2020 11:35:26 GMT, Andrey Turbanov
wrote:
>> src/java.base/share/classes/jdk/internal/misc/Signal.java line 102:
>>
>>> 100: */
>>> 101: public boolean equals(Object other) {
>>> 102: if (this == other) {
>>
>> It might be a bit cleaner to rename Object other
On Wed, 16 Dec 2020 10:32:12 GMT, Andrey Turbanov
wrote:
>> 8258422: Cleanup unnecessary null comparison before instanceof check in
>> java.base
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8258422: Cleanup
On Thu, 17 Dec 2020 10:29:50 GMT, Alan Bateman wrote:
>> Andrey Turbanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8258422: Cleanup unnecessary null comparison before instanceof check in
>> java.base
>> take advantage of "flow
On Wed, 16 Dec 2020 10:32:12 GMT, Andrey Turbanov
wrote:
>> 8258422: Cleanup unnecessary null comparison before instanceof check in
>> java.base
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8258422: Cleanup
On Wed, 16 Dec 2020 10:32:12 GMT, Andrey Turbanov
wrote:
>> 8258422: Cleanup unnecessary null comparison before instanceof check in
>> java.base
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8258422: Cleanup
> 8258422: Cleanup unnecessary null comparison before instanceof check in
> java.base
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8258422: Cleanup unnecessary null comparison before instanceof check in
java.base
take
10 matches
Mail list logo
