Re: RFR: 8258917: NativeMemoryTracking is handled by launcher inconsistenly [v2]

Hi Alex, On 28/01/2021 7:44 am, Alex Menkov wrote: On Tue, 19 Jan 2021 23:18:04 GMT, David Holmes wrote: Alex Menkov has updated the pull request incrementally with one additional commit since the last revision: Non-lava launchers should process all "-J" arguments Hi Alex, I think

Re: RFR: 8258917: NativeMemoryTracking is handled by launcher inconsistenly [v2]

On Tue, 19 Jan 2021 23:18:04 GMT, David Holmes wrote: >> Alex Menkov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Non-lava launchers should process all "-J" arguments > > Hi Alex, > > I think this is functionally correct now -

Re: RFR: 8258917: NativeMemoryTracking is handled by launcher inconsistenly [v2]

Alex, On 20/01/2021 11:47 am, Alex Menkov wrote: On Tue, 19 Jan 2021 23:16:30 GMT, David Holmes wrote: What do you mean by this? The -J args are not "translated" here but later in TranslateApplicationArgs. I meant that they are translated in TranslateApplicationArgs. Looks like it's not

Re: RFR: 8258917: NativeMemoryTracking is handled by launcher inconsistenly [v2]

On Tue, 19 Jan 2021 23:16:30 GMT, David Holmes wrote: > What do you mean by this? The -J args are not "translated" here but later in > TranslateApplicationArgs. I meant that they are translated in TranslateApplicationArgs. Looks like it's not clear. Updated the comment as you suggested.

Re: RFR: 8258917: NativeMemoryTracking is handled by launcher inconsistenly [v2]

On Tue, 19 Jan 2021 23:02:54 GMT, Alex Menkov wrote: >> The fix adds NMT handling for non-java launchers > > Alex Menkov has updated the pull request incrementally with one additional > commit since the last revision: > > Non-lava launchers should process all "-J" arguments Hi Alex, I

Re: RFR: 8258917: NativeMemoryTracking is handled by launcher inconsistenly [v2]

On Sun, 17 Jan 2021 12:55:35 GMT, David Holmes wrote: >> Alex Menkov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Non-lava launchers should process all "-J" arguments > > Alex, > > This approach results in two scans of the argument

Re: RFR: 8258917: NativeMemoryTracking is handled by launcher inconsistenly [v2]

On Sun, 17 Jan 2021 12:55:35 GMT, David Holmes wrote: >> Alex Menkov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Non-lava launchers should process all "-J" arguments > > Alex, > > This approach results in two scans of the argument

Re: RFR: 8258917: NativeMemoryTracking is handled by launcher inconsistenly [v2]

> The fix adds NMT handling for non-java launchers Alex Menkov has updated the pull request incrementally with one additional commit since the last revision: Non-lava launchers should process all "-J" arguments - Changes: - all: https://git.openjdk.java.net/jdk/pull/2106/files