Re: RFR: 8269384: Determine native byte order for StringUTF16 via ByteOrder

2021-06-28 Thread Yi Yang
On Fri, 25 Jun 2021 13:40:54 GMT, Yi Yang wrote: > Prefer using ByteOrder to compute byte order for StringUTF16 to determining > byte order by native method StringUTF16.isBigEndian. Thanks for the detailed clarification! The purpose of this PR is to skip the native call and use ByteOrder. Now

Re: RFR: 8269384: Determine native byte order for StringUTF16 via ByteOrder

2021-06-28 Thread David Holmes
On Mon, 28 Jun 2021 03:25:09 GMT, Yi Yang wrote: >> Prefer using ByteOrder to compute byte order for StringUTF16 to determining >> byte order by native method StringUTF16.isBigEndian. > > Hi Aleksey, do you have a concrete issue/discussion about bootstrapping > problems? I don't see it because

Re: RFR: 8269384: Determine native byte order for StringUTF16 via ByteOrder

2021-06-28 Thread Andrew Dinn
On Fri, 25 Jun 2021 13:40:54 GMT, Yi Yang wrote: > Prefer using ByteOrder to compute byte order for StringUTF16 to determining > byte order by native method StringUTF16.isBigEndian. Hi Yi Yang, This is more complex than it seems. The general policy is not to change boot order if at all

Re: RFR: 8269384: Determine native byte order for StringUTF16 via ByteOrder

2021-06-27 Thread Yi Yang
On Fri, 25 Jun 2021 13:40:54 GMT, Yi Yang wrote: > Prefer using ByteOrder to compute byte order for StringUTF16 to determining > byte order by native method StringUTF16.isBigEndian. Hi Aleksey, do you have a concrete issue/discussion about bootstrapping problems? I don't see it because I can

Re: RFR: 8269384: Determine native byte order for StringUTF16 via ByteOrder

2021-06-25 Thread Aleksey Shipilev
On Fri, 25 Jun 2021 13:40:54 GMT, Yi Yang wrote: > Prefer using ByteOrder to compute byte order for StringUTF16 to determining > byte order by native method StringUTF16.isBigEndian. Adding new dependencies in `String` quite probably risks bootstrapping issues. There is a reason why `String`

RFR: 8269384: Determine native byte order for StringUTF16 via ByteOrder

2021-06-25 Thread Yi Yang
Prefer using ByteOrder to compute byte order for StringUTF16 to determining byte order by native method StringUTF16.isBigEndian. - Commit messages: - replace Changes: https://git.openjdk.java.net/jdk/pull/4596/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=4596=00