Re: RFR: 8282280: Update Xerces to Version 2.12.2 [v2]
On Tue, 17 May 2022 00:39:37 GMT, Joe Wang wrote: >> Update to Xerces 2.12.2. >> >> The update also fixes JDK-8144117. Added a test. >> >> Tests: local XML tests passed. Tier2 passed. Two JCK tests failed with this >> update. See related issue report. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > provider description Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8732
Re: RFR: 8282280: Update Xerces to Version 2.12.2 [v2]
On Tue, 17 May 2022 00:39:37 GMT, Joe Wang wrote: >> Update to Xerces 2.12.2. >> >> The update also fixes JDK-8144117. Added a test. >> >> Tests: local XML tests passed. Tier2 passed. Two JCK tests failed with this >> update. See related issue report. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > provider description Marked as reviewed by naoto (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8732
Re: RFR: 8282280: Update Xerces to Version 2.12.2 [v2]
On Mon, 16 May 2022 21:54:52 GMT, Naoto Sato wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> provider description
>
> test/jaxp/javax/xml/jaxp/unittest/validation/SchemaTest.java line 48:
>
>> 46: */
>> 47: public class SchemaTest {
>> 48: private static final String XSD_8144117 = "\n" +
>
> If it is not from the upstream Xerces test but our own, can we utilize text
> blocks here?
Our source level is still generally 8. The expectation is also that this patch
will be backported.
> test/jaxp/javax/xml/jaxp/unittest/validation/SchemaTest.java line 79:
>
>> 77:
>> 78: /*
>> 79: * DataProvider: valid xsd
>
> This comment is the same as the above provider. Can we change it to a more
> meaningful one?
Updated with a bit more description.
-
PR: https://git.openjdk.java.net/jdk/pull/8732
Re: RFR: 8282280: Update Xerces to Version 2.12.2 [v2]
> Update to Xerces 2.12.2. > > The update also fixes JDK-8144117. Added a test. > > Tests: local XML tests passed. Tier2 passed. Two JCK tests failed with this > update. See related issue report. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: provider description - Changes: - all: https://git.openjdk.java.net/jdk/pull/8732/files - new: https://git.openjdk.java.net/jdk/pull/8732/files/ae224c6d..db91b60e Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=8732=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=8732=00-01 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/8732.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/8732/head:pull/8732 PR: https://git.openjdk.java.net/jdk/pull/8732
Re: RFR: 8282280: Update Xerces to Version 2.12.2
On Mon, 16 May 2022 19:34:11 GMT, Joe Wang wrote:
> Update to Xerces 2.12.2.
>
> The update also fixes JDK-8144117. Added a test.
>
> Tests: local XML tests passed. Tier2 passed. Two JCK tests failed with this
> update. See related issue report.
Changes look good to me. Some minor nits follow.
test/jaxp/javax/xml/jaxp/unittest/validation/SchemaTest.java line 48:
> 46: */
> 47: public class SchemaTest {
> 48: private static final String XSD_8144117 = "\n" +
If it is not from the upstream Xerces test but our own, can we utilize text
blocks here?
test/jaxp/javax/xml/jaxp/unittest/validation/SchemaTest.java line 79:
> 77:
> 78: /*
> 79: * DataProvider: valid xsd
This comment is the same as the above provider. Can we change it to a more
meaningful one?
-
PR: https://git.openjdk.java.net/jdk/pull/8732
Re: RFR: 8282280: Update Xerces to Version 2.12.2
On Mon, 16 May 2022 19:34:11 GMT, Joe Wang wrote: > Update to Xerces 2.12.2. > > The update also fixes JDK-8144117. Added a test. > > Tests: local XML tests passed. Tier2 passed. Two JCK tests failed with this > update. See related issue report. Thanks Lance. Yes, I've notified the JCK team, will wait till they've resolved the issue (or at least put them in the known list). Meanwhile, just want to get the patch reviewed. - PR: https://git.openjdk.java.net/jdk/pull/8732
Re: RFR: 8282280: Update Xerces to Version 2.12.2
On Mon, 16 May 2022 19:34:11 GMT, Joe Wang wrote: > Update to Xerces 2.12.2. > > The update also fixes JDK-8144117. Added a test. > > Tests: local XML tests passed. Tier2 running. Two JCK tests failed with this > update. See related issue report. Hi Joe, I think your changes are ok Are you going to wait until the JCK is updated to either patch or exclude these tests? It would be good to get the JCK addressed prior to pushing the changes - PR: https://git.openjdk.java.net/jdk/pull/8732
RFR: 8282280: Update Xerces to Version 2.12.2
Update to Xerces 2.12.2. The update also fixes JDK-8144117. Added a test. Tests: local XML tests passed. Tier2 running. Two JCK tests failed with this update. See related issue report. - Commit messages: - 8282280: Update Xerces to Version 2.12.2 Changes: https://git.openjdk.java.net/jdk/pull/8732/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8732=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282280 Stats: 310 lines in 17 files changed: 296 ins; 3 del; 11 mod Patch: https://git.openjdk.java.net/jdk/pull/8732.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/8732/head:pull/8732 PR: https://git.openjdk.java.net/jdk/pull/8732
