Re: RFR: 8283715: Update ObjectStreamClass to be final [v2]

2022-03-30 Thread Stuart Marks
On Wed, 30 Mar 2022 00:43:57 GMT, Jaikiran Pai wrote: >> Stuart Marks has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adjust nonfinal CSMs and rework error reporting in CheckCSMs.java test > > Hello Stuart, the test change looks fine to

Re: RFR: 8283715: Update ObjectStreamClass to be final [v3]

2022-03-30 Thread Jaikiran Pai
On Wed, 30 Mar 2022 06:17:54 GMT, Stuart Marks wrote: >> Pretty much just what it says. > > Stuart Marks has updated the pull request incrementally with one additional > commit since the last revision: > > Update copyright year. Marked as reviewed by jpai (Committer). - PR:

Re: RFR: 8283715: Update ObjectStreamClass to be final [v3]

2022-03-30 Thread Stuart Marks
> Pretty much just what it says. Stuart Marks has updated the pull request incrementally with one additional commit since the last revision: Update copyright year. - Changes: - all: https://git.openjdk.java.net/jdk/pull/8009/files - new:

Re: RFR: 8283715: Update ObjectStreamClass to be final [v2]

2022-03-29 Thread Jaikiran Pai
On Tue, 29 Mar 2022 16:07:18 GMT, Stuart Marks wrote: >> Pretty much just what it says. > > Stuart Marks has updated the pull request incrementally with one additional > commit since the last revision: > > Adjust nonfinal CSMs and rework error reporting in CheckCSMs.java test Hello Stuart,

Re: RFR: 8283715: Update ObjectStreamClass to be final [v2]

2022-03-29 Thread Mandy Chung
On Tue, 29 Mar 2022 16:07:18 GMT, Stuart Marks wrote: >> Pretty much just what it says. > > Stuart Marks has updated the pull request incrementally with one additional > commit since the last revision: > > Adjust nonfinal CSMs and rework error reporting in CheckCSMs.java test Looks good.

Re: RFR: 8283715: Update ObjectStreamClass to be final [v2]

2022-03-29 Thread Daniel Fuchs
On Tue, 29 Mar 2022 16:07:18 GMT, Stuart Marks wrote: >> Pretty much just what it says. > > Stuart Marks has updated the pull request incrementally with one additional > commit since the last revision: > > Adjust nonfinal CSMs and rework error reporting in CheckCSMs.java test Nice update to

Re: RFR: 8283715: Update ObjectStreamClass to be final [v2]

2022-03-29 Thread Mandy Chung
On Tue, 29 Mar 2022 16:07:18 GMT, Stuart Marks wrote: >> Pretty much just what it says. > > Stuart Marks has updated the pull request incrementally with one additional > commit since the last revision: > > Adjust nonfinal CSMs and rework error reporting in CheckCSMs.java test Marked as

Re: RFR: 8283715: Update ObjectStreamClass to be final [v2]

2022-03-29 Thread Stuart Marks
On Tue, 29 Mar 2022 16:07:18 GMT, Stuart Marks wrote: >> Pretty much just what it says. > > Stuart Marks has updated the pull request incrementally with one additional > commit since the last revision: > > Adjust nonfinal CSMs and rework error reporting in CheckCSMs.java test Yes, the

Re: RFR: 8283715: Update ObjectStreamClass to be final [v2]

2022-03-29 Thread Stuart Marks
> Pretty much just what it says. Stuart Marks has updated the pull request incrementally with one additional commit since the last revision: Adjust nonfinal CSMs and rework error reporting in CheckCSMs.java test - Changes: - all:

Re: RFR: 8283715: Update ObjectStreamClass to be final

2022-03-29 Thread Roger Riggs
On Tue, 29 Mar 2022 01:07:33 GMT, Stuart Marks wrote: > Pretty much just what it says. Close by is `java.io.ObjectStreamField` which seems also useful to make final. Though it does have a public constructor so is more likely to raise a compatibility concern. - PR:

Re: RFR: 8283715: Update ObjectStreamClass to be final

2022-03-29 Thread Daniel Fuchs
On Tue, 29 Mar 2022 01:07:33 GMT, Stuart Marks wrote: > Pretty much just what it says. Yes - it looks like jdk/internal/reflect/CallerSensitive/CheckCSMs.java needs to be updated. - PR: https://git.openjdk.java.net/jdk/pull/8009

Re: RFR: 8283715: Update ObjectStreamClass to be final

2022-03-29 Thread Jaikiran Pai
On Tue, 29 Mar 2022 01:07:33 GMT, Stuart Marks wrote: > Pretty much just what it says. The test failures caught by GitHub Actions jobs look related to the area of this change: 2022-03-29T02:21:21.2187570Zat CheckCSMs.main(CheckCSMs.java:98) 2022-03-29T02:21:21.2188140Zat

Re: RFR: 8283715: Update ObjectStreamClass to be final

2022-03-29 Thread Jaikiran Pai
On Tue, 29 Mar 2022 01:07:33 GMT, Stuart Marks wrote: > Pretty much just what it says. Marked as reviewed by jpai (Committer). - PR: https://git.openjdk.java.net/jdk/pull/8009

Re: RFR: 8283715: Update ObjectStreamClass to be final

2022-03-28 Thread Joe Darcy
On Tue, 29 Mar 2022 01:07:33 GMT, Stuart Marks wrote: > Pretty much just what it says. Marked as reviewed by darcy (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8009

Re: RFR: 8283715: Update ObjectStreamClass to be final

2022-03-28 Thread Stuart Marks
On Tue, 29 Mar 2022 01:07:33 GMT, Stuart Marks wrote: > Pretty much just what it says. Please review CSR request [JDK-8283811](https://bugs.openjdk.java.net/browse/JDK-8283811). - PR: https://git.openjdk.java.net/jdk/pull/8009

RFR: 8283715: Update ObjectStreamClass to be final

2022-03-28 Thread Stuart Marks
Pretty much just what it says. - Commit messages: - Make ObjectStreamClass final. Changes: https://git.openjdk.java.net/jdk/pull/8009/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8009=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283715 Stats: 1 line in 1