Re: RFR: 8284435: Add dedicated filler objects for known dead Java heap areas [v3]

2022-05-02 Thread Thomas Schatzl
On Mon, 11 Apr 2022 14:55:32 GMT, Thomas Schatzl wrote: >> Hi all, >> >> can I have reviews for this change that adds dedicated filler objects to >> the VM? >> >> Currently, when formatting areas of dead objects all gcs use instances of >> j.l.Object and int-arrays. >> >> This has the

Re: RFR: 8284435: Add dedicated filler objects for known dead Java heap areas [v3]

2022-05-02 Thread Thomas Schatzl
On Fri, 29 Apr 2022 16:45:01 GMT, Ioi Lam wrote: >> Thomas Schatzl has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix test > > The latest version looks good to me. Thanks @iklam @walulyai for your reviews - PR:

Re: RFR: 8284435: Add dedicated filler objects for known dead Java heap areas [v3]

2022-05-02 Thread Ivan Walulya
On Mon, 11 Apr 2022 14:55:32 GMT, Thomas Schatzl wrote: >> Hi all, >> >> can I have reviews for this change that adds dedicated filler objects to >> the VM? >> >> Currently, when formatting areas of dead objects all gcs use instances of >> j.l.Object and int-arrays. >> >> This has the

Re: RFR: 8284435: Add dedicated filler objects for known dead Java heap areas [v3]

2022-04-29 Thread Ioi Lam
On Mon, 11 Apr 2022 14:55:32 GMT, Thomas Schatzl wrote: >> Hi all, >> >> can I have reviews for this change that adds dedicated filler objects to >> the VM? >> >> Currently, when formatting areas of dead objects all gcs use instances of >> j.l.Object and int-arrays. >> >> This has the

Re: RFR: 8284435: Add dedicated filler objects for known dead Java heap areas [v3]

2022-04-19 Thread Thomas Schatzl
On Mon, 11 Apr 2022 21:51:32 GMT, David Holmes wrote: > Do you really need to define a real `FillerObject.java` class? Can't you use > an internal-only variant of a hidden class to represent this? I am not sure I understand this request, but of course I am open to try different approaches. An

Re: RFR: 8284435: Add dedicated filler objects for known dead Java heap areas [v3]

2022-04-11 Thread David Holmes
On Mon, 11 Apr 2022 14:55:32 GMT, Thomas Schatzl wrote: >> Hi all, >> >> can I have reviews for this change that adds dedicated filler objects to >> the VM? >> >> Currently, when formatting areas of dead objects all gcs use instances of >> j.l.Object and int-arrays. >> >> This has the

Re: RFR: 8284435: Add dedicated filler objects for known dead Java heap areas [v3]

2022-04-11 Thread Thomas Schatzl
> Hi all, > > can I have reviews for this change that adds dedicated filler objects to > the VM? > > Currently, when formatting areas of dead objects all gcs use instances of > j.l.Object and int-arrays. > > This has the drawback of not being easily able to discern whether a given > object

Re: RFR: 8284435: Add dedicated filler objects for known dead Java heap areas [v2]

2022-04-11 Thread Thomas Schatzl
On Fri, 8 Apr 2022 16:45:54 GMT, Ioi Lam wrote: >> Thomas Schatzl has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - iklam review >> - Test case > > src/hotspot/share/classfile/systemDictionaryShared.cpp line 1727: > >> 1725:

Re: RFR: 8284435: Add dedicated filler objects for known dead Java heap areas [v2]

2022-04-11 Thread Thomas Schatzl
> Hi all, > > can I have reviews for this change that adds dedicated filler objects to > the VM? > > Currently, when formatting areas of dead objects all gcs use instances of > j.l.Object and int-arrays. > > This has the drawback of not being easily able to discern whether a given > object

Re: RFR: 8284435: Add dedicated filler objects for known dead Java heap areas

2022-04-08 Thread Ioi Lam
On Fri, 8 Apr 2022 08:13:33 GMT, Thomas Schatzl wrote: > Hi all, > > can I have reviews for this change that adds dedicated filler objects to > the VM? > > Currently, when formatting areas of dead objects all gcs use instances of > j.l.Object and int-arrays. > > This has the drawback of

RFR: 8284435: Add dedicated filler objects for known dead Java heap areas

2022-04-08 Thread Thomas Schatzl
Hi all, can I have reviews for this change that adds dedicated filler objects to the VM? Currently, when formatting areas of dead objects all gcs use instances of j.l.Object and int-arrays. This has the drawback of not being easily able to discern whether a given object is actually dead