Re: RFR: 8285517: System.getenv() returns unexpected value if environment variable has non ASCII character [v8]
On Mon, 16 May 2022 17:16:31 GMT, Ichiroh Takiguchi wrote: > The 1st word changed from Return to Returns. Is it OK ? That's more of plain English to me. Maybe some natives can correct it if needed. > And it seems @return is translated to Japanese on Japanese environment. Yes. I believe that's what is supposed to work. - PR: https://git.openjdk.java.net/jdk/pull/8378
Re: RFR: 8285517: System.getenv() returns unexpected value if environment variable has non ASCII character [v8]
On Fri, 13 May 2022 18:29:56 GMT, Naoto Sato wrote:
>> Ichiroh Takiguchi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8285517: System.getenv() returns unexpected value if environment variable
>> has non ASCII character
>
> src/java.base/share/classes/jdk/internal/util/StaticProperty.java line 251:
>
>> 249:
>> 250: /**
>> 251: * Return the {@code sun.jnu.encoding} system property.
>
> This can be eliminated by changing the`@return` block tag below to `{@return
> the {@code sun.jnu.encoding} ...}`.
Hello @naotoj .
I appreciate your comment.
I'd like to confirm one thing.
I applied following change
/**
* {@return the {@code sun.jnu.encoding} system property}
*
* {@link SecurityManager#checkPropertyAccess} is NOT checked
* in this method. The caller of this method should take care to ensure
* that the returned property is not made accessible to untrusted
code.
*/
By javadoc command with -html5 option, above part was converted to
Returns the sun.jnu.encoding system property.
SecurityManager.checkPropertyAccess(java.lang.String)
is NOT checked in this method. The caller of this method should take care to
ensure that the returned
property is not made accessible to untrusted code.
The 1st word changed from **Return** to **Returns**.
Is it OK ?
And it seems `@return` is translated to Japanese on Japanese environment.
-
PR: https://git.openjdk.java.net/jdk/pull/8378
Re: RFR: 8285517: System.getenv() returns unexpected value if environment variable has non ASCII character [v8]
On Fri, 13 May 2022 17:38:48 GMT, Ichiroh Takiguchi
wrote:
>> On JDK19 with Linux ja_JP.eucjp locale,
>> System.getenv() returns unexpected value if environment variable has
>> Japanese EUC characters.
>> It seems this issue happens because of JEP 400.
>> Arguments for ProcessBuilder have same kind of issue.
>
> Ichiroh Takiguchi has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8285517: System.getenv() returns unexpected value if environment variable
> has non ASCII character
src/java.base/share/classes/jdk/internal/util/StaticProperty.java line 251:
> 249:
> 250: /**
> 251: * Return the {@code sun.jnu.encoding} system property.
This can be eliminated by changing the`@return` block tag below to `{@return
the {@code sun.jnu.encoding} ...}`.
src/java.base/share/classes/jdk/internal/util/StaticProperty.java line 264:
> 262:
> 263: /**
> 264: * Return charset for {@code sun.jnu.encoding} system property.
Same as above. `charset` can be capitalized and changed to `{@code}`.
-
PR: https://git.openjdk.java.net/jdk/pull/8378
Re: RFR: 8285517: System.getenv() returns unexpected value if environment variable has non ASCII character [v8]
> On JDK19 with Linux ja_JP.eucjp locale, > System.getenv() returns unexpected value if environment variable has Japanese > EUC characters. > It seems this issue happens because of JEP 400. > Arguments for ProcessBuilder have same kind of issue. Ichiroh Takiguchi has updated the pull request incrementally with one additional commit since the last revision: 8285517: System.getenv() returns unexpected value if environment variable has non ASCII character - Changes: - all: https://git.openjdk.java.net/jdk/pull/8378/files - new: https://git.openjdk.java.net/jdk/pull/8378/files/6dbaa751..12018014 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=8378=07 - incr: https://webrevs.openjdk.java.net/?repo=jdk=8378=06-07 Stats: 72 lines in 3 files changed: 10 ins; 2 del; 60 mod Patch: https://git.openjdk.java.net/jdk/pull/8378.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/8378/head:pull/8378 PR: https://git.openjdk.java.net/jdk/pull/8378
