Re: RFR: JDK-8231281: Consider eliminating --identifier option

2019-09-28 Thread Philip Race
+// Get indetifier from app image if user provided app image and +// does not provided identifier via CLI. +String indentifier = extractBundleIdentifier(params); +if (indentifier != null) { +

Re: RFR: JDK-8231281: Consider eliminating --identifier option

2019-09-28 Thread Andy Herrick
looks good. /Andy On 9/27/2019 11:55 PM, Alexander Matveev wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Removed --identifier option, since it only usage is to specify identifier when

RFR: JDK-8231281: Consider eliminating --identifier option

2019-09-27 Thread Alexander Matveev
Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Removed --identifier option, since it only usage is to specify identifier when generating pkg on macOS and as default value for