Re: RFR [6968459] JNDI timeout fails before timeout is reached

2013-12-19 Thread David Holmes
If you track the elapsed waiting time using System.nanoTime you do not need to be concerned whether anyone messes with the TOD clock. David On 4/12/2013 2:05 AM, Peter Levart wrote: On 12/03/2013 03:35 PM, Ivan Gerasimov wrote: Hi Peter! Thank you for your review! You are right, the patch c

Re: RFR [6968459] JNDI timeout fails before timeout is reached

2013-12-03 Thread Peter Levart
On 12/03/2013 03:35 PM, Ivan Gerasimov wrote: Hi Peter! Thank you for your review! You are right, the patch changed the behavior of the code. I've reverted back all the unnecessary changes. This should minimize the risk. I've also made another correction: After decrementing the remaining ti

Re: RFR [6968459] JNDI timeout fails before timeout is reached

2013-12-03 Thread Vincent Ryan
Hello Ivan, Thanks for the updated patch. I would like to see a testcase along with this fix, since it is modifying a critical component of the LDAP client code. An LDAP server may not even be required in order to exercise the timeouts. Thanks. On 3 Dec 2013, at 14:35, Ivan Gerasimov wrote:

Re: RFR [6968459] JNDI timeout fails before timeout is reached

2013-12-03 Thread Ivan Gerasimov
Hi Peter! Thank you for your review! You are right, the patch changed the behavior of the code. I've reverted back all the unnecessary changes. This should minimize the risk. I've also made another correction: After decrementing the remaining timeOut, the startTime should be set to currTime.

Re: RFR [6968459] JNDI timeout fails before timeout is reached

2013-12-03 Thread Peter Levart
On 11/29/2013 09:06 PM, Ivan Gerasimov wrote: Thank you Alan for the reply! On 29.11.2013 21:03, Alan Bateman wrote: On 19/11/2013 17:58, Ivan Gerasimov wrote: Hello all! Would you please help review a fix for the bug? https://bugs.openjdk.java.net/browse/JDK-6968459 It was reported that cre

Re: RFR [6968459] JNDI timeout fails before timeout is reached

2013-12-01 Thread Alan Bateman
On 29/11/2013 20:06, Ivan Gerasimov wrote: I modified the patch in the way you suggest. http://cr.openjdk.java.net/~igerasim/6968459/1/webrev/ The timeOut variable now holds the remaining time. If the system time had changed back, we start counting from the beginning. If it had changed forward

Re: RFR [6968459] JNDI timeout fails before timeout is reached

2013-11-29 Thread Ivan Gerasimov
Thank you Alan for the reply! On 29.11.2013 21:03, Alan Bateman wrote: On 19/11/2013 17:58, Ivan Gerasimov wrote: Hello all! Would you please help review a fix for the bug? https://bugs.openjdk.java.net/browse/JDK-6968459 It was reported that creating new InitialLdapContext() can fail with "

Re: RFR [6968459] JNDI timeout fails before timeout is reached

2013-11-29 Thread Alan Bateman
On 19/11/2013 17:58, Ivan Gerasimov wrote: Hello all! Would you please help review a fix for the bug? https://bugs.openjdk.java.net/browse/JDK-6968459 It was reported that creating new InitialLdapContext() can fail with "javax.naming.NamingException: LDAP response read timed out, timeout used

Re: RFR [6968459] JNDI timeout fails before timeout is reached

2013-11-19 Thread Ivan Gerasimov
Hello all! Would you please help review a fix for the bug? https://bugs.openjdk.java.net/browse/JDK-6968459 It was reported that creating new InitialLdapContext() can fail with "javax.naming.NamingException: LDAP response read timed out, timeout used:3ms", even though the specified timeo

RFR [6968459] JNDI timeout fails before timeout is reached

2013-11-19 Thread Ivan Gerasimov
Hello all! Would you please help review a fix for the bug? https://bugs.openjdk.java.net/browse/JDK-6968459 It was reported that creating new InitialLdapContext() can fail with "javax.naming.NamingException: LDAP response read timed out, timeout used:3ms", even though the specified timeout