Re: RFR 15 (S): 8245068: Implement Deprecation of RMI Activation

2020-05-28 Thread Stuart Marks
On 5/28/20 12:13 PM, Lance Andersen wrote: Thinking about: - @deprecated The RMI Activation mechanism has been deprecated, and it may + * be removed from a future version. Perhaps it might be a bit clearer to say “… from a future Java SE version”?  I realize that is different

Re: RFR 15 (S): 8245068: Implement Deprecation of RMI Activation

2020-05-28 Thread Lance Andersen
Hi Stuart I think your changes read fine. > On May 28, 2020, at 1:34 PM, Stuart Marks wrote: > > I've updated the webrev a little bit in response to previous comments: > >http://cr.openjdk.java.net/~smarks/reviews/8245068/webrev.1/ Thinking about: - @deprecated The RMI

Re: RFR 15 (S): 8245068: Implement Deprecation of RMI Activation

2020-05-28 Thread Stuart Marks
I've updated the webrev a little bit in response to previous comments: http://cr.openjdk.java.net/~smarks/reviews/8245068/webrev.1/ I've also drafted a CSR request and a release note. Please review: CSR: https://bugs.openjdk.java.net/browse/JDK-8245860 Release Note:

Re: RFR 15 (S): 8245068: Implement Deprecation of RMI Activation

2020-05-27 Thread Stuart Marks
Hi Lance, thanks for taking a look at this. On 5/27/20 4:56 AM, Lance Andersen wrote: I think this looks good.  I will add myself as a reviewer for the CSR. I would probably create an issue for the release note and create a draft I believe I was asked for that when I was going through my CSR

Re: RFR 15 (S): 8245068: Implement Deprecation of RMI Activation

2020-05-27 Thread Stuart Marks
On 5/27/20 6:34 AM, Roger Riggs wrote: rmid.properties: 134;  avoid breaking "have\n been" in to separate lines. I would break after the ",". Line break adjusted. module-info.java: 35:  "version" -> "release" for consistency across the messages. package-info.java: 41:  "version" ->

Re: RFR 15 (S): 8245068: Implement Deprecation of RMI Activation

2020-05-27 Thread Roger Riggs
Hi Stuart, Looks good. rmid.properties: 134;  avoid breaking "have\n been" in to separate lines. I would break after the ",". module-info.java: 35:  "version" -> "release" for consistency across the messages. package-info.java: 41:  "version" -> "release" and "it may" -> "may" to be

Re: RFR 15 (S): 8245068: Implement Deprecation of RMI Activation

2020-05-27 Thread Lance Andersen
Hi Stuart, I think this looks good. I will add myself as a reviewer for the CSR. I would probably create an issue for the release note and create a draft I believe I was asked for that when I was going through my CSR review for removal of the Java EE modules and CORBA. Best Lance > On May

RFR 15 (S): 8245068: Implement Deprecation of RMI Activation

2020-05-26 Thread Stuart Marks
Hi all, Here's the implementation of the recently-posted JEP 385, deprecation of RMI Activation for removal. I'm listing this as S ("small") since conceptually it's fairly small, though there are rather a large number of files changed. Essentially the changes are: - java.rmi.activation