Re: RFR 8196298 Add null Reader and Writer with latest changes

Hi Patrick, Committed;  Thanks for the initiative and the perseverance. Roger On 3/18/2018 6:41 AM, Patrick Reinhart wrote: Hi Roger, Seems there are no more comments...   - all shocked :-) -Patrick

Re: RFR 8196298 Add null Reader and Writer with latest changes

Hi Roger, Seems there are no more comments...   - all shocked :-) -Patrick Am 16.03.2018 um 16:21 schrieb Roger Riggs: > Hi Patrick, > > Looks good, > > If there are no more comments, I can sponsor the commit. > > Thanks, Roger > > > On 3/16/18 2:10 AM, Patrick Reinhart wrote: >> Just coming

Re: RFR 8196298 Add null Reader and Writer with latest changes

Hi Patrick, Looks good, If there are no more comments, I can sponsor the commit. Thanks, Roger On 3/16/18 2:10 AM, Patrick Reinhart wrote: Just coming back on my webrev [1]. Are there any more feedbacks implementation wise to that latest version? If no I would need a commit sponsor for

RFR 8196298 Add null Reader and Writer with latest changes

Just coming back on my webrev [1]. Are there any more feedbacks implementation wise to that latest version? If no I would need a commit sponsor for this change as the CSR [2] is reviewed and closed. -Patrick [1] http://cr.openjdk.java.net/~reinhapa/reviews/8196298/webrev.02 [2]

Re: RFR 8196298 Add null Reader and Writer with latest changes

I applied those changes here: http://cr.openjdk.java.net/~reinhapa/reviews/8196298/webrev.02 -Patrick > Am 06.03.2018 um 23:12 schrieb Brian Burkhalter : > > Yes, I think so and and also the parameter ‘csq' is allowed to be null so > Objects.requireNonNull(csq)

Re: RFR 8196298 Add null Reader and Writer with latest changes

Yes, I think so and and also the parameter ‘csq' is allowed to be null so Objects.requireNonNull(csq) should be removed at lines 100 and 107 as no NPE is specified for these methods [1, 2]. Thanks, Brian [1]

Re: RFR 8196298 Add null Reader and Writer with latest changes

Just a nit, Should append(CharSequence,int,int) also use checkFromIndexSize? Greetings Bernd -- http://bernd.eckenfels.net Von: Alan Bateman Gesendet: Dienstag, 6. März 2018 20:35 An: Patrick Reinhart; core-libs-dev Betreff: Re: RFR 8196298 Add null Reader and Writer with latest changes On 05

Re: RFR 8196298 Add null Reader and Writer with latest changes

Updated the CSR API with webrev's content and finalized it.. -Patrick Am 06.03.2018 um 17:35 schrieb Alan Bateman: > On 05/03/2018 21:45, Patrick Reinhart wrote: >> I tried to incorporate all feedback I received so far and updated the >> webrev accordingly: >> >>

Re: RFR 8196298 Add null Reader and Writer with latest changes

On 05/03/2018 21:45, Patrick Reinhart wrote: I tried to incorporate all feedback I received so far and updated the webrev accordingly: http://cr.openjdk.java.net/~reinhapa/reviews/8196298/webrev.01 I think this looks good now.

RFR 8196298 Add null Reader and Writer with latest changes

I tried to incorporate all feedback I received so far and updated the webrev accordingly: http://cr.openjdk.java.net/~reinhapa/reviews/8196298/webrev.01 -Patrick

RFR 8196298 Add null Reader and Writer

Hi every boy that reviewed I tried to incorporate all feedback I received so far and updated the webrev accordingly: http://cr.openjdk.java.net/~reinhapa/reviews/8196298/webrev.01 -Patrick

Re: RFR 8196298 Add null Reader and Writer

Hi everyone responded so far. How should we proceed now? -Patrick Am 07.02.2018 um 18:38 schrieb Patrick Reinhart: >> Am 07.02.2018 um 14:03 schrieb Alan Bateman : >> >> On 03/02/2018 17:05, Patrick Reinhart wrote: >>> : >>> I reworked the tests and Writer

Re: RFR 8196298 Add null Reader and Writer

> Am 07.02.2018 um 14:03 schrieb Alan Bateman : > > On 03/02/2018 17:05, Patrick Reinhart wrote: >> : >> I reworked the tests and Writer implementation accordingly >> >> http://cr.openjdk.java.net/~reinhapa/reviews/8196298/webrev.01 >> > Just catching up on this. > >

Re: RFR 8196298 Add null Reader and Writer

On 03/02/2018 17:05, Patrick Reinhart wrote: : I reworked the tests and Writer implementation accordingly http://cr.openjdk.java.net/~reinhapa/reviews/8196298/webrev.01 Just catching up on this. nullReader's javadoc suggests that mark(int) does not nothing but this seems to conflict with

Re: RFR 8196298 Add null Reader and Writer

> Am 02.02.2018 um 02:45 schrieb Stuart Marks : > > > > On 2/1/18 10:35 AM, Patrick Reinhart wrote: >> Here is my first shot of the actual implementation and tests: >> http://cr.openjdk.java.net/~reinhapa/reviews/8196298/webrev.00 > > I looked at the specification of

Re: RFR 8196298 Add null Reader and Writer

On 2/1/18 10:35 AM, Patrick Reinhart wrote: Here is my first shot of the actual implementation and tests: http://cr.openjdk.java.net/~reinhapa/reviews/8196298/webrev.00 I looked at the specification of ready() vs the implementation. The spec says that ready(), among other methods, behaves

Re: RFR 8196298 Add null Reader and Writer

On Feb 1, 2018, at 12:01 PM, Patrick Reinhart wrote: >> I believe read(CharBuffer), like read(char[], int, int), should test if >> there are remaining chars in the buffer. > > Does it make sense to check for remaining chars in the buffer, wen the source > is basically at

Re: RFR 8196298 Add null Reader and Writer

Hi Rémi, I also found, that I missed the throw an ReadOnlyBufferException on a passed in read only CharBuffer. > Am 01.02.2018 um 19:49 schrieb Remi Forax : > > Hi Patrick, > I believe read(CharBuffer), like read(char[], int, int), should test if there > are remaining chars

Re: RFR 8196298 Add null Reader and Writer

net> > Envoyé: Jeudi 1 Février 2018 19:35:11 > Objet: RFR 8196298 Add null Reader and Writer > Hi, > > Here is my first shot of the actual implementation and tests: > > http://cr.openjdk.java.net/~reinhapa/reviews/8196298/webrev.00 > > Thanks for feedback > > -Patrick

RFR 8196298 Add null Reader and Writer

Hi, Here is my first shot of the actual implementation and tests: http://cr.openjdk.java.net/~reinhapa/reviews/8196298/webrev.00 Thanks for feedback -Patrick