Re: RFR 8241073: Pre-generated Stubs for javax.management, Activation, Naming

Hi Alan, The mismatches are due to the combination of generated Stub and old stub source. I'll clean it up a bit before pushing.  As pretty static code it didn't seem worth much investment. Thanks, Roger On 3/19/20 3:39 AM, Alan Bateman wrote: On 18/03/2020 21:24, Roger Riggs wrote: Hi,

Re: RFR 8241073: Pre-generated Stubs for javax.management, Activation, Naming

On 18/03/2020 21:24, Roger Riggs wrote: Hi, Some small updates to the source files to minimize the changes to javadoc of the _Stub classes. All looks good but the updated ActivationGroup_Stub should probably get a one-pass to eliminate the inconsistencies, e.g. the new version imports some

Re: RFR 8241073: Pre-generated Stubs for javax.management, Activation, Naming

On 2020-03-18 22:24, Roger Riggs wrote: Hi, Some small updates to the source files to minimize the changes to javadoc of the _Stub classes. And fixes to the points Magnus raises below. http://cr.openjdk.java.net/~rriggs/webrev-stubs-classes-8241073-4/ Looks good! Thank you for getting this

Re: RFR 8241073: Pre-generated Stubs for javax.management, Activation, Naming

Looks good. /Erik On 2020-03-18 14:24, Roger Riggs wrote: Hi, Some small updates to the source files to minimize the changes to javadoc of the _Stub classes. And fixes to the points Magnus raises below. http://cr.openjdk.java.net/~rriggs/webrev-stubs-classes-8241073-4/ Thanks, Roger On

Re: RFR 8241073: Pre-generated Stubs for javax.management, Activation, Naming

Hi, Some small updates to the source files to minimize the changes to javadoc of the _Stub classes. And fixes to the points Magnus raises below. http://cr.openjdk.java.net/~rriggs/webrev-stubs-classes-8241073-4/ Thanks, Roger On 3/18/20 9:01 AM, Magnus Ihse Bursie wrote: On 2020-03-17

Re: RFR 8241073: Pre-generated Stubs for javax.management, Activation, Naming

On 2020-03-17 23:07, Roger Riggs wrote: Hi Magnus, Erik, Thanks for the pointers, I'm not familiar with those early build intricacies. Updated: http://cr.openjdk.java.net/~rriggs/webrev-stubs-classes-8241073-2/ Looking much better! Please remove the reference to "rmic" in Global.gmk as

Re: RFR 8241073: Pre-generated Stubs for javax.management, Activation, Naming

This looks good to me. Thanks for hanging in there! /Erik On 2020-03-17 15:07, Roger Riggs wrote: Hi Magnus, Erik, Thanks for the pointers, I'm not familiar with those early build intricacies. Updated: http://cr.openjdk.java.net/~rriggs/webrev-stubs-classes-8241073-2/ More cleanup: -

Re: RFR 8241073: Pre-generated Stubs for javax.management, Activation, Naming

Hi Magnus, Erik, Thanks for the pointers, I'm not familiar with those early build intricacies. Updated:   http://cr.openjdk.java.net/~rriggs/webrev-stubs-classes-8241073-2/ More cleanup: - cleanup of ZipSource.gmk and autoconf/spec.gmk.in and Docs.gmk - The mystery of ActivationGroup_Stub

Re: RFR 8241073: Pre-generated Stubs for javax.management, Activation, Naming

On 2020-03-17 14:17, Erik Joelsson wrote: Hello, That looks better, but there are still some more things to remove. This whole block: # Targets for running rmic. $(eval $(call DeclareRecipesForPhase, RMIC, \  

Re: RFR 8241073: Pre-generated Stubs for javax.management, Activation, Naming

Hello, That looks better, but there are still some more things to remove. This whole block: # Targets for running rmic. $(eval $(call DeclareRecipesForPhase, RMIC, \     TARGET_SUFFIX := rmic, \     FILE_PREFIX

Re: RFR 8241073: Pre-generated Stubs for javax.management, Activation, Naming

Hi Erik, Please review a new webrev that adds the change to remove the interim build parts. (Passes Tier 1-3 of CI testing) http://cr.openjdk.java.net/~rriggs/webrev-stubs-classes-8241073-1/ Thanks, Roger On 3/16/20 12:22 PM, Erik Joelsson wrote: Hello Roger, There is more to be removed

Re: RFR 8241073: Pre-generated Stubs for javax.management, Activation, Naming

Hi Alan, Removal of rmic itself is assigned to Stuart with a fixVersion of 15: 8225319 Remove rmic from the set of supported tools I'll see how to test the build-cycle. Thanks, Roger On 3/16/20 1:39 PM, Alan Bateman wrote: On 16/03/2020

Re: RFR 8241073: Pre-generated Stubs for javax.management, Activation, Naming

On 16/03/2020 16:02, Roger Riggs wrote: Please review adding pre-generated RMI stub classes to the jdk repo and the removal of make files supporting the specific APIs. It removes a dependency on build time generation invoking RMIC. RMIC was  deprecated in JDK 13 [1]. The source files have been

Re: RFR 8241073: Pre-generated Stubs for javax.management, Activation, Naming

Hi Erik, I was thinking that was a separate step, but can pull it in. (And there's something in spec.gmk.in.) Roger On 3/16/20 12:22 PM, Erik Joelsson wrote: Hello Roger, There is more to be removed in the makefiles. This file should also be removed: make/CompileInterimRmic.gmk In

Re: RFR 8241073: Pre-generated Stubs for javax.management, Activation, Naming

Hello Roger, There is more to be removed in the makefiles. This file should also be removed: make/CompileInterimRmic.gmk In make/Main.gmk, all the targets concerning rmic needs to be removed as well as any dependencies declared that involves them. Searching for "rmic" should find all

RFR 8241073: Pre-generated Stubs for javax.management, Activation, Naming

Please review adding pre-generated RMI stub classes to the jdk repo and the removal of make files supporting the specific APIs. It removes a dependency on build time generation invoking RMIC. RMIC was  deprecated in JDK 13 [1]. The source files have been edited to remove or suppress compilation