Re: RFR JDK-8174248: partialUpdateFooMainClass test in tools/jar/modularJar/Basic.java needs to be re-examined

2017-02-14 Thread Chris Hegarty
> On 14 Feb 2017, at 19:09, Xueming Shen wrote: > > Hi, > > Please review the test change for JDK-8174248 > > issue: https://bugs.openjdk.java.net/browse/JDK-8174248 > webrev: http://cr.openjdk.java.net/~sherman/8174248/webrev Looks fine Sherman. -Chris. > The

Re: RFR JDK-8174248: partialUpdateFooMainClass test in tools/jar/modularJar/Basic.java needs to be re-examined

2017-02-14 Thread Lance Andersen
Looks fine Sherman.. > On Feb 14, 2017, at 2:09 PM, Xueming Shen wrote: > > Hi, > > Please review the test change for JDK-8174248 > > issue: https://bugs.openjdk.java.net/browse/JDK-8174248 > webrev: http://cr.openjdk.java.net/~sherman/8174248/webrev > > The change

RFR JDK-8174248: partialUpdateFooMainClass test in tools/jar/modularJar/Basic.java needs to be re-examined

2017-02-14 Thread Xueming Shen
Hi, Please review the test change for JDK-8174248 issue: https://bugs.openjdk.java.net/browse/JDK-8174248 webrev: http://cr.openjdk.java.net/~sherman/8174248/webrev The change is to simply rename the entry name from "IAmNotTheEntryPoint" to a "packaged" one as "