Hi, Mandy,
the client part of the fix looks fine. Let me ask a naive question, though.
From your explanation, I see that System.loadLibrary() is now aware of
modules. What prevents us to change LoadLibraryAction the same way?
FROM code looks much more elegant than the new (the old?) TO one.
On 5/2/2012 11:09 AM, Artem Ananiev wrote:
Hi, Mandy,
the client part of the fix looks fine.
Thanks for the review. I have pushed the changeset and hope you don't
mind I couldn't fix the changeset comment to add you as a reviewer.
Let me ask a naive question, though.
From your
On 26/04/2012 19:49, Mandy Chung wrote:
7164376 Replace use of sun.security.action.LoadLibraryAction
with direct call of System.loadLibrary
Webrev:
http://cr.openjdk.java.net/~mchung/jdk8/webrevs/7164376/webrev.00/
This change is required for jdk modularization.
I went through the
7164376 Replace use of sun.security.action.LoadLibraryAction
with direct call of System.loadLibrary
Webrev:
http://cr.openjdk.java.net/~mchung/jdk8/webrevs/7164376/webrev.00/
This change is required for jdk modularization. High level summary:
it replaces the use of LoadLibraryAction:
Looks fine, just a couple of nits.
src/macosx/classes/com/apple/concurrent/LibDispatchNative.java,
- the closing static brace is not indented the same as the open brace.
src/solaris/classes/sun/management/FileSystemImpl.java
src/windows/classes/sun/management/FileSystemImpl.java
-
Thanks, Sean. I have fixed the 3 files per your comment.
Mandy
On 4/26/2012 1:59 PM, Sean Mullan wrote:
Looks fine, just a couple of nits.
src/macosx/classes/com/apple/concurrent/LibDispatchNative.java,
- the closing static brace is not indented the same as the open brace.
Thanks, Phil. FYI. I plan to use TL gate for the entire changeset.
The change will show up in the awt/2D repos when this gets integrated in
the next promoted build.
Mandy
On 4/26/2012 3:51 PM, Phil Race wrote:
All looks good to me. Compiler won't spot misspelled library names so I
did try
