Review request for 6381464: SimpleFormatter should use one single line format

2011-04-26 Thread Mandy Chung
6381464: SimpleFormatter should use one single line format This is a follow-up of the review for 7006814. I came up with a better solution that allows a user to customize the output format for SimpleFormatter. You can specify the format string using the java.util.Formatter syntax in a new

Re: Review request for 6381464: SimpleFormatter should use one single line format

2011-03-28 Thread Alan Bateman
mark.reinh...@oracle.com wrote: 2011/3/27 12:09 -0700, alan.bate...@oracle.com: : In the test would it be better to use a temporary file rather than a file in the working directory. Why? Unless something's changed, the jtreg harness provides each test run with a fresh working

Re: Review request for 6381464: SimpleFormatter should use one single line format

2011-03-28 Thread Mandy Chung
On 03/27/11 12:09, Alan Bateman wrote: Mandy Chung wrote: 6381464: SimpleFormatter should use one single line format This is a follow-up of the review for 7006814. I came up with a better solution that allows a user to customize the output format for SimpleFormatter. You can specify the

Re: Review request for 6381464: SimpleFormatter should use one single line format

2011-03-28 Thread Alan Bateman
Mandy Chung wrote: '\n' is a character added in the string created in L156 but not in a format string in which %n is used to represents a newline. I'm not sure about this one as \n might not be the line separator on the platform. After creating the PrintWriter then could you use pw.println()

Re: Review request for 6381464: SimpleFormatter should use one single line format

2011-03-28 Thread Mandy Chung
On 3/28/11 9:45 PM, Alan Bateman wrote: Mandy Chung wrote: '\n' is a character added in the string created in L156 but not in a format string in which %n is used to represents a newline. I'm not sure about this one as \n might not be the line separator on the platform. After creating the

Re: Review request for 6381464: SimpleFormatter should use one single line format

2011-03-27 Thread mark . reinhold
2011/3/27 12:09 -0700, alan.bate...@oracle.com: Mandy Chung wrote: 6381464: SimpleFormatter should use one single line format ... Webrev at: http://cr.openjdk.java.net/~mchung/jdk7/6381464/webrev.00/ ... In the test would it be better to use a temporary file rather than a file in the

Review request for 6381464: SimpleFormatter should use one single line format

2011-03-25 Thread Mandy Chung
6381464: SimpleFormatter should use one single line format This is a follow-up of the review for 7006814. I came up with a better solution that allows a user to customize the output format for SimpleFormatter. You can specify the format string using the java.util.Formatter syntax in a new