Re: request for review (M): 4965777 GC changes to support use of discovered field for pending references

2011-09-07 Thread Alan Bateman
Mandy Chung wrote: : It'd be good to write a regression test for this bug to be included in the jdk fix. I can help writing it if you want. I looked at the changes in the jdk repository and they look good to me too. Adding the bit to the jdk_version_info structure is a neat way to deal with

Re: request for review (M): 4965777 GC changes to support use of discovered field for pending references

2011-09-07 Thread Ramki Ramakrishna
On 9/7/2011 9:32 AM, Alan Bateman wrote: Mandy Chung wrote: : It'd be good to write a regression test for this bug to be included in the jdk fix. I can help writing it if you want. I looked at the changes in the jdk repository and they look good to me too. Thanks for the review, Alan.

Re: [Fwd: request for review (M): 4965777 GC changes to support use of discovered field for pending references]

2011-09-06 Thread Y. S. Ramakrishna
Just so that there is no confusion. These changes by themselves are not intended to fix 4243978 and 4268317. They just fix 4965777 -- that is make GC and the ReferenceHandler thread use the discovered field for linking the elements of the pending list. I am assuming that 4243978 and 4268317

Re: request for review (M): 4965777 GC changes to support use of discovered field for pending references

2011-09-06 Thread Y. S. Ramakrishna
[i left the embedded inlines below for the cores-lib folk who may have missed part of the exchange because of non-membership of the posters.] Hi Stefan -- On 09/05/11 10:49, Stefan Karlsson wrote: Hi Ramki, On 09/05/2011 07:29 PM, Ramki Ramakrishna wrote: Hi Stefan -- Thanks for your

Re: request for review (M): 4965777 GC changes to support use of discovered field for pending references

2011-09-06 Thread Mandy Chung
Hi Ramki, I reviewed the JDK webrev: JDK webrev: http://cr.openjdk.java.net/~ysr/4965777/jdk/webrev/ The change looks good. I ran the JCK tests on solaris-i586 that I can reproduce the bug with JDK 7 and verify that they pass with your fix. It'd be good to write a regression test for this

Re: request for review (M): 4965777 GC changes to support use of discovered field for pending references

2011-09-06 Thread Y. S. Ramakrishna
Hi Mandy -- On 09/06/11 17:49, Mandy Chung wrote: Hi Ramki, I reviewed the JDK webrev: JDK webrev: http://cr.openjdk.java.net/~ysr/4965777/jdk/webrev/ The change looks good. I ran the JCK tests on solaris-i586 that I can reproduce the bug with JDK 7 and verify that they pass with your