Re: RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v2]

2022-10-09 Thread David Holmes
On Sun, 9 Oct 2022 17:58:37 GMT, Kim Barrett wrote: >> Julian Waters has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Comment formatting > > src/java.base/share/native/libjli/jli_util.h line 91: > >> 89: *

Re: RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v2]

2022-10-09 Thread David Holmes
On Sun, 9 Oct 2022 08:17:15 GMT, Julian Waters wrote: >> The C99 snprintf is available with Visual Studio 2015 and above, alongside >> Windows 10 and the UCRT, and is no longer identical to the outdated Windows >> _snprintf. Since support for the Visual C++ 2017 compiler was removed a >>

Re: RFR: 8291917: Windows - Improve error messages when the C Runtime Libraries or jvm.dll cannot be loaded [v14]

2022-10-09 Thread David Holmes
On Thu, 6 Oct 2022 12:45:08 GMT, Julian Waters wrote: >> Please review a small patch for dumping the failure reason when the MSVCRT >> libraries or the Java Virtual Machine fails to load on Windows, which can >> provide invaluable insight when debugging related launcher issues. >> >> See

Re: RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v2]

2022-10-09 Thread Kim Barrett
On Sun, 9 Oct 2022 08:17:15 GMT, Julian Waters wrote: >> The C99 snprintf is available with Visual Studio 2015 and above, alongside >> Windows 10 and the UCRT, and is no longer identical to the outdated Windows >> _snprintf. Since support for the Visual C++ 2017 compiler was removed a >>

Re: RFR: 8294696 - BufferedInputStream.transferTo should drain buffer when mark set [v2]

2022-10-09 Thread Markus KARG
On Mon, 3 Oct 2022 05:54:31 GMT, Markus KARG wrote: >> This PR implements JDK-8294696. > > Markus KARG has updated the pull request incrementally with one additional > commit since the last revision: > > Checking explicitly -1 instead of < 0 @bplb Kindly requesting review.  -

Re: RFR: JDK-8294702 - BufferedInputStream uses undefined value range for markpos [v2]

2022-10-09 Thread Markus KARG
On Tue, 4 Oct 2022 15:53:04 GMT, Alan Bateman wrote: >> This is true, but if a broken subclass sets markpos to less than -1 then >> lots of code lines will work incorrectly -- including `transferTo` which was >> the starting point of your change proposal. So do you really only want undo >>

Re: RFR: JDK-8294702 - BufferedInputStream uses undefined value range for markpos [v2]

2022-10-09 Thread Markus KARG
> Fixes JDK-8294702 Markus KARG has updated the pull request incrementally with one additional commit since the last revision: Modified to < 0 as proposed by Alan Batement - Changes: - all: https://git.openjdk.org/jdk/pull/10528/files - new:

Integrated: 8294541 - java/io/BufferedInputStream/TransferTo.java fails with OOME

2022-10-09 Thread Markus KARG
On Sat, 1 Oct 2022 17:54:37 GMT, Markus KARG wrote: > Fixes 8294541 This pull request has now been integrated. Changeset: 8713dfa6 Author:Markus Karg Committer: Alan Bateman URL: https://git.openjdk.org/jdk/commit/8713dfa64ef4c55c8b9a3be8aab2bb5e16c627da Stats: 3 lines in 2

Re: RFR: 8290368: Introduce LDAP and RMI protocol-specific object factory filters to JNDI implementation [v2]

2022-10-09 Thread Aleksei Efimov
On Thu, 6 Oct 2022 16:24:49 GMT, Roger Riggs wrote: >> Aleksei Efimov has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> commits

Re: RFR: 8290368: Introduce LDAP and RMI protocol-specific object factory filters to JNDI implementation [v2]

2022-10-09 Thread Aleksei Efimov
On Thu, 6 Oct 2022 16:10:37 GMT, Roger Riggs wrote: >> Aleksei Efimov has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> commits

Re: RFR: 8290368: Introduce LDAP and RMI protocol-specific object factory filters to JNDI implementation [v2]

2022-10-09 Thread Aleksei Efimov
> ### Summary of the change > This change introduces new system and security properties for specifying > factory filters for the JNDI/LDAP and the JNDI/RMI JDK provider > implementations. > > These new properties allow more granular control over the set of object > factories allowed to

Re: RFR: 8294541 - java/io/BufferedInputStream/TransferTo.java fails with OOME [v2]

2022-10-09 Thread Markus KARG
On Sat, 8 Oct 2022 21:45:29 GMT, Markus KARG wrote: >> Fixes 8294541 > > Markus KARG has updated the pull request incrementally with one additional > commit since the last revision: > > Fixed two more reported cases using 1.2 GiB Did a final test with `MIN_SIZE = 100_000_000` and it did

Re: RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v2]

2022-10-09 Thread Julian Waters
> The C99 snprintf is available with Visual Studio 2015 and above, alongside > Windows 10 and the UCRT, and is no longer identical to the outdated Windows > _snprintf. Since support for the Visual C++ 2017 compiler was removed a while > ago, we can now safely remove the compatibility workaround

RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf

2022-10-09 Thread Julian Waters
The C99 snprintf is available with Visual Studio 2015 and above, alongside Windows 10 and the UCRT, and is no longer identical to the outdated Windows _snprintf. Since support for the Visual C++ 2017 compiler was removed a while ago, we can now safely remove the compatibility workaround on

Re: RFR: 8294541 - java/io/BufferedInputStream/TransferTo.java fails with OOME [v2]

2022-10-09 Thread Alan Bateman
On Sat, 8 Oct 2022 21:45:29 GMT, Markus KARG wrote: >> Fixes 8294541 > > Markus KARG has updated the pull request incrementally with one additional > commit since the last revision: > > Fixed two more reported cases using 1.2 GiB Marked as reviewed by alanb (Reviewer). - PR:

Re: RFR: 8294541 - java/io/BufferedInputStream/TransferTo.java fails with OOME

2022-10-09 Thread Alan Bateman
On Sat, 8 Oct 2022 21:40:37 GMT, Markus KARG wrote: > I increased `-Xmx` from 1G to 1.2G, and cannot reproduce the reported cases > anymore. I gave it ten more random attempts which all passed, too. I did some testing with this value and it does seem be enough. The alternative is to reduce