On Tue, 11 Apr 2023 17:47:56 GMT, Jatin Bhateja wrote:
>> Quan Anh Mai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> special case iotaShuffle
>
> Marked as reviewed by jbhateja (Reviewer).
@jatin-bhateja @iwanowww Thanks a lot for you
On Fri, 7 Apr 2023 12:22:03 GMT, Andy-Tatman wrote:
> See https://bugs.java.com/bugdatabase/view_bug?bug_id=8305734
The BitSet API requires that the logical size fit in an int so I think you'll
end up changing the set methods to disallow an index of MAX_VALUE.
Can you change the title of the P
On Wed, 12 Apr 2023 06:13:04 GMT, David Holmes wrote:
> Sorry, have to ask, but why does the test fail without continuations? IIRC
> the emulated VTs use a carrier-per-VT so I would expect the ThreadLocal test
> to work just fine.
The debugging option is for the VirtualThread implementation on
On Tue, 11 Apr 2023 23:38:23 GMT, Leonid Mesnik wrote:
> Test TraceVirtualThreadLocals verifies that thread locals are dumped for
> virtual threads. It fails when continuations are not available and virtual
> threads are emulated.
>
> The test failed on linux-x86 so I just want to mark it to h
On Tue, 11 Apr 2023 23:38:23 GMT, Leonid Mesnik wrote:
> Test TraceVirtualThreadLocals verifies that thread locals are dumped for
> virtual threads. It fails when continuations are not available and virtual
> threads are emulated.
>
> The test failed on linux-x86 so I just want to mark it to h
Test TraceVirtualThreadLocals verifies that thread locals are dumped for
virtual threads. It fails when continuations are not available and virtual
threads are emulated.
The test failed on linux-x86 so I just want to mark it to have green github
actions results.
-
Commit messages:
On Tue, 11 Apr 2023 18:07:41 GMT, Martin Doerr wrote:
> Another remark: Old JDK on s390 used "os.arch = zArch_64", current one
> "os.arch = s390x". @offamitkumar: You probably want to take a look.
Martin, only concern was that I didn't have a good experience with `s390x`
string in
[past](http
On Tue, 11 Apr 2023 13:40:39 GMT, Weijun Wang wrote:
> Enhance the `Proc` utility to support compilation.
test/lib/jdk/test/lib/process/Proc.java line 331:
> 329:
> 330: if (compile) {
> 331: var comp = CompilerUtils.compile(
I don't find this use of `var` helpful - `var`
On Tue, 11 Apr 2023 13:40:39 GMT, Weijun Wang wrote:
> Enhance the `Proc` utility to support compilation.
test/lib/jdk/test/lib/process/Proc.java line 274:
> 272: }
> 273: // Compile as well
> 274: public Proc compile() throws IOException {
Why "throws IOException" ? I'm surprised
On Sat, 8 Apr 2023 13:24:37 GMT, Julian Waters wrote:
>> C11 has been stable for a long time on all platforms, so native code can use
>> the standard alignas operator for alignment requirements
>
> Julian Waters has updated the pull request incrementally with one additional
> commit since the l
On Sat, 8 Apr 2023 13:24:37 GMT, Julian Waters wrote:
>> C11 has been stable for a long time on all platforms, so native code can use
>> the standard alignas operator for alignment requirements
>
> Julian Waters has updated the pull request incrementally with one additional
> commit since the l
On Tue, Apr 11, 2023 at 4:52 PM Glavo wrote:
> i'm not sure that the methods lowercase() and uppercase() are a good
>> addition.
>> Their names are too close to toLowerCase/toUpperCase thus too easy to
>> misuse ones for the others.
>>
>
> I'm fine with users having to write toLowerCase(Locale.R
> The purpose of this task is to add the difference between -manual jdk_core
> and jdk_core_manual to the jdk_core_manual test goal. Furthermore, in order
> to streamline the manual test execution process, a new test group called
> jdk_core_manual_human has been created for manual tests that dem
On Tue, 11 Apr 2023 20:50:28 GMT, Mark Sheppard wrote:
>> Bill Huang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Implemented review comments.
>
> test/jdk/TEST.groups line 643:
>
>> 641: sun/security/tools/jarsigner/compatibilit
> I'm fine with users having to write toLowerCase(Locale.ROOT) or
toUpperCase(Locale.Root) because this is already what we teach.
This is the current situation, but I don't think it is good.
This idiom forces users to import Locale even in locale-insensitive
scenarios.
I think this brings a lot
On Fri, 7 Apr 2023 12:22:03 GMT, Andy-Tatman wrote:
> See https://bugs.java.com/bugdatabase/view_bug?bug_id=8305734
I think what Alan suggested in JBS is better: explicitly reject setting
Integer.MAX_VALUE bit so that `len` will never return negative.
-
PR Comment: https://git.ope
On Fri, 7 Apr 2023 12:22:03 GMT, Andy-Tatman wrote:
> See https://bugs.java.com/bugdatabase/view_bug?bug_id=8305734
src/java.base/share/classes/java/util/BitSet.java line 653:
> 651:
> 652: int len = length();
> 653: if ( len < 0 )
Suggestion:
if (len < 0)
--
See https://bugs.java.com/bugdatabase/view_bug?bug_id=8305734
-
Commit messages:
- Update src/java.base/share/classes/java/util/BitSet.java
- Removed trailing whitespace
- 8305734: Fixes bug in get(int, int)
Changes: https://git.openjdk.org/jdk/pull/13388/files
Webrev: https://we
On Tue, 11 Apr 2023 21:09:43 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X
> Define an internal jdk.internal.util.Architecture enumeration and static
> methods to replace uses of the system property `os.arch`.
> The enumeration values are defined to match those used in the build.
> The initial values are: `X64, X86, AARCH64, RISCV64, S390, PPC64`
> Note that `amd64` and
On Mon, 20 Mar 2023 23:29:25 GMT, Bill Huang wrote:
>> The purpose of this task is to add the difference between -manual jdk_core
>> and jdk_core_manual to the jdk_core_manual test goal. Furthermore, in order
>> to streamline the manual test execution process, a new test group called
>> jdk_co
Thank you for your reply.
I'm not sure what's best either. I chose to name them lowercase/uppercase
here
because Kotlin chose them, so many users are already familiar with them.
It would be great if there were better ideas.
Glavo
On Wed, Apr 12, 2023 at 4:21 AM Remi Forax wrote:
>
>
>
On Tue, 11 Apr 2023 09:14:29 GMT, Raffaello Giulietti
wrote:
>> Add `split()` overloads to `String` and `java.util.regex.Pattern` that, in
>> addition to the substrings returned by current `split()` variants, also
>> return the delimiters matching the regular expression.
>
> Raffaello Giuliett
On Tue, 11 Apr 2023 18:35:56 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X
On Tue, 11 Apr 2023 08:58:36 GMT, Raffaello Giulietti
wrote:
>> src/java.base/share/classes/java/lang/String.java line 3302:
>>
>>> 3300: *
>>> 3301: * 0
>>> 3302: * {@code { "b", "o", "", "o", ":::and::f", "o", "", "o"
>>> }}
>>
>> These cases might be a bit easier to
> From: "Glavo"
> To: "core-libs-dev"
> Sent: Tuesday, April 11, 2023 10:02:01 PM
> Subject: Draft: Deprecate toLowerCase()/toUpperCase() and provide locale
> insensitive alternative
> Hi everyone,
> A few months ago, I discussed in this mailing list[1] whether
> toLowerCase()/toUpperCase() sho
Hi everyone,
A few months ago, I discussed in this mailing list[1] whether
toLowerCase()/toUpperCase() should be deprecated.
At that time, I received some approval and no one opposed the
idea. Therefore, I thought it might be time
to continue advancing this work, so I created a PR[2] for this.
Th
On Tue, 11 Apr 2023 18:35:56 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X
Thanks for your reply, I've opened a PR[1] where I hope to continue
discussing this issue.
Glavo
[1] https://github.com/openjdk/jdk/pull/13434
On Tue, Apr 11, 2023 at 9:02 PM Quân Anh Mai wrote:
> Hi,
>
> To propose deprecation of String::toLowerCase() and String::toUpperCase(),
> you can crea
On Tue, 11 Apr 2023 19:33:28 GMT, Roger Riggs wrote:
>>> > Would be great if you could support "os.arch = ppc64" for AIX and legacy
>>> > linux, too.
>>>
>>> Changing os.arch is out of scope for this PR. The best way for that would
>>> someone supporting ppc to develop and propose a PR.
>>
>>
On Tue, 11 Apr 2023 18:37:11 GMT, Glavo wrote:
>>> Would be great if you could support "os.arch = ppc64" for AIX and legacy
>>> linux, too.
>>
>> Changing os.arch is out of scope for this PR.
>> The best way for that would someone supporting ppc to develop and propose a
>> PR.
>
>> > Would be
On Tue, 4 Apr 2023 13:46:12 GMT, Quan Anh Mai wrote:
>> `Vector::slice` is a method at the top-level class of the Vector API that
>> concatenates the 2 inputs into an intermediate composite and extracts a
>> window equal to the size of the inputs into the result. It is used in vector
>> conver
On Fri, 7 Apr 2023 17:13:50 GMT, Quan Anh Mai wrote:
>> Hi,
>>
>> This patch reimplements `VectorShuffle` implementations to be a vector of
>> the bit type. Currently, VectorShuffle is stored as a byte array, and would
>> be expanded upon usage. This poses several drawbacks:
>>
>> 1. Ineffici
> Please review a cleanup in DocCommentParser to merge blockContent and
> inlineContent into a single method to parse "rich content" in a doc comment.
Jonathan Gibbons has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 59 commits:
- Me
On Tue, 11 Apr 2023 16:58:13 GMT, Roger Riggs wrote:
> > Would be great if you could support "os.arch = ppc64" for AIX and legacy
> > linux, too.
>
> Changing os.arch is out of scope for this PR. The best way for that would
> someone supporting ppc to develop and propose a PR.
It seems that y
> Define an internal jdk.internal.util.Architecture enumeration and static
> methods to replace uses of the system property `os.arch`.
> The enumeration values are defined to match those used in the build.
> The initial values are: `X64, X86, AARCH64, RISCV64, S390, PPC64`
> Note that `amd64` and
> Please review a cleanup in DocCommentParser to merge blockContent and
> inlineContent into a single method to parse "rich content" in a doc comment.
Jonathan Gibbons has updated the pull request incrementally with 42 additional
commits since the last revision:
- Merge remote-tracking branch
Please review a cleanup in DocCommentParser to merge blockContent and
inlineContent into a single method to parse "rich content" in a doc comment.
-
Depends on: https://git.openjdk.org/jdk/pull/13362
Commit messages:
- JDK-8305713: DocCommentParser: merge blockContent and inlineCon
On Tue, 11 Apr 2023 18:02:14 GMT, Martin Doerr wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Modified test to check Architecture is64bits() and isLittleEndian()
>> against Unsafe respective values.
>> Relocate
On Tue, 11 Apr 2023 17:58:54 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X
On Thu, 6 Apr 2023 10:54:18 GMT, Per Minborg wrote:
>> API changes for the FFM API (third preview)
>>
>> Specdiff:
>> https://cr.openjdk.org/~pminborg/panama/21/v1/specdiff/overview-summary.html
>>
>> Javadoc:
>> https://cr.openjdk.org/~pminborg/panama/21/v1/javadoc/java.base/module-summary.htm
On Tue, 11 Apr 2023 17:58:54 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X
> Define an internal jdk.internal.util.Architecture enumeration and static
> methods to replace uses of the system property `os.arch`.
> The enumeration values are defined to match those used in the build.
> The initial values are: `X64, X86, AARCH64, RISCV64, S390, PPC64`
> Note that `amd64` and
On Thu, 6 Apr 2023 10:54:18 GMT, Per Minborg wrote:
>> API changes for the FFM API (third preview)
>>
>> Specdiff:
>> https://cr.openjdk.org/~pminborg/panama/21/v1/specdiff/overview-summary.html
>>
>> Javadoc:
>> https://cr.openjdk.org/~pminborg/panama/21/v1/javadoc/java.base/module-summary.htm
On Tue, 11 Apr 2023 09:36:06 GMT, Quan Anh Mai wrote:
>> Hi @merykitty , Agree with you that SPECIES_PREFERRED is preferred for
>> vector algorithms intercepting both integral and floating point vectors.
>>
>> FTR, we see a perf regression with Float256 based micro now on AVX=1 targets,
>>
>>
On Fri, 7 Apr 2023 17:13:50 GMT, Quan Anh Mai wrote:
>> Hi,
>>
>> This patch reimplements `VectorShuffle` implementations to be a vector of
>> the bit type. Currently, VectorShuffle is stored as a byte array, and would
>> be expanded upon usage. This poses several drawbacks:
>>
>> 1. Ineffici
On Wed, 5 Apr 2023 09:19:57 GMT, Viktor Klang wrote:
> Adds overrides for common Map operations to avoid having to allocate the
> entrySet for Collectors$Partition maps.
OK, the change is probably good, including removal of the `booleanValue` call.
I'm not sure `containsKey` and `containsValue
On Tue, 11 Apr 2023 10:39:39 GMT, Martin Doerr wrote:
>> This should (probably) be correct:
>> Suggestion:
>>
>> case PPC64 -> !OperatingSystem.isAix() &&
>> Architecture.isLittleEndian();
>
> Looks correct, but makes the test pointless for any linux on PPC64.
Will change to compar
On Tue, 11 Apr 2023 11:41:24 GMT, Glavo wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unused static and import of Stabile
>
> src/java.base/share/classes/jdk/internal/util/PlatformProps.java.template
> lin
On Mon, 10 Apr 2023 21:16:19 GMT, Alexey Semenyuk wrote:
> When `--main-jar` is specified and the name of the main class is picked from
> the jar's manifest, set `app.jarfile` property in launcher cfg file instead
> of `app.mainclass` and `app.classpath` properties to make app launcher run
> t
Hello,
You should be able to file an issue yourself at
https://bugreport.java.com/bugreport/start_form
Brian
On Apr 10, 2023, at 11:59 PM, Benjamin Marwell
mailto:bmarw...@apache.org>> wrote:
Follow up, I would highly appreciate it if anyone would be so kind as
to open an issue for this enhan
Enhance the `Proc` utility to support compilation.
-
Commit messages:
- the fix
Changes: https://git.openjdk.org/jdk/pull/13425/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13425&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8305846
Stats: 139 lines in 4 files c
On Sat, 11 Mar 2023 04:59:07 GMT, Chen Liang wrote:
> Also remove redundant casts to avoid javac warnings.
This pull request has now been integrated.
Changeset: e5ce7d9e
Author:Chen Liang
Committer: Mandy Chung
URL:
https://git.openjdk.org/jdk/commit/e5ce7d9e431e54504ddcf321711fe89
Hi,
To propose deprecation of String::toLowerCase() and String::toUpperCase(),
you can create a patch as normal, with an addition of a CSR ticket that
describes the situation and the proposed solution. After that, you can ask
for someone from core-libs to review the ticket. The change can be merge
On Wed, 5 Apr 2023 05:14:07 GMT, Chen Liang wrote:
>> Also remove redundant casts to avoid javac warnings.
>
> Chen Liang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Redundant casts in benchmark
Keep alive. Would any committer sponsor
On Sat, 8 Apr 2023 18:00:53 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X8
On Tue, 11 Apr 2023 10:26:02 GMT, ExE Boss wrote:
>> test/jdk/jdk/internal/util/ArchTest.java line 128:
>>
>>> 126: case RISCV64 -> true;
>>> 127: case S390 -> false;
>>> 128: case PPC64 -> true;
>>
>> This is not always true. The PPC64 architecture supports
On Tue, 11 Apr 2023 10:15:27 GMT, Martin Doerr wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unused static and import of Stabile
>
> test/jdk/jdk/internal/util/ArchTest.java line 128:
>
>> 126:
On Sat, 8 Apr 2023 18:00:53 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X8
On Mon, 10 Apr 2023 15:16:59 GMT, Jatin Bhateja wrote:
>> Yes I think it is a drawback of this approach, however currently we do not
>> support shuffling for 256-bit vectors on AVX1 machines either, and AVX1
>> seems to be a special case in this regard. This species of float and double
>> may
> Add `split()` overloads to `String` and `java.util.regex.Pattern` that, in
> addition to the substrings returned by current `split()` variants, also
> return the delimiters matching the regular expression.
Raffaello Giulietti has updated the pull request incrementally with one
additional comm
On Mon, 10 Apr 2023 14:35:06 GMT, Roger Riggs wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8305486: Add split() variants that keep the delimiters to String and
>> j.u.r.Pattern
>> Restored original Jav
> Add `split()` overloads to `String` and `java.util.regex.Pattern` that, in
> addition to the substrings returned by current `split()` variants, also
> return the delimiters matching the regular expression.
Raffaello Giulietti has updated the pull request incrementally with one
additional comm
On Mon, 10 Apr 2023 14:14:54 GMT, Roger Riggs wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8305486: Add split() variants that keep the delimiters to String and
>> j.u.r.Pattern
>> Restored original Jav
On Mon, 10 Apr 2023 14:00:46 GMT, Roger Riggs wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8305486: Add split() variants that keep the delimiters to String and
>> j.u.r.Pattern
>> Restored original Jav
On Tue, 11 Apr 2023 01:18:53 GMT, Stuart Marks wrote:
>> Adds overrides for common Map operations to avoid having to allocate the
>> entrySet for Collectors$Partition maps.
>
> I don't think there is any useful relationship between this work at
> SequencedCollections / SequencedMap. The return
On Sat, 8 Apr 2023 13:26:36 GMT, Julian Waters wrote:
>> A couple of spots wrongly refer to boolean and jboolean as the same thing.
>> While this does still compile thanks to a happy accident and implicit
>> conversions, they are not the same at all, and should be fixed before a
>> future comp
Follow up, I would highly appreciate it if anyone would be so kind as
to open an issue for this enhancement.
Am Sa., 8. Apr. 2023 um 17:36 Uhr schrieb Benjamin Marwell
:
>
> Dear Core-Devs,
>
> There was a PR created for an enhancement of SequenceInputStream [1]
> by Romain Manni-Buceau.
>
> Descr
68 matches
Mail list logo
