On Thu, 27 Apr 2023 01:06:23 GMT, Leonid Mesnik wrote:
> The ProcessTools.startProcess (...) has been updated to completely read
> streams after process has been completed.
> The test was updated to run 5 times with different number of lines and line
> sizes.
I missed the previous changes to
On Wed, 26 Apr 2023 20:42:01 GMT, Naoto Sato wrote:
> Updating the collation rules for Swedish to the modern one, which is aligned
> with the CLDR's default collation rules. Since it is changing the existing
> behavior, a release note has also been drafted:
>
> DeInflate.java test fails on s390x platform because size for out1 array which
> is responsible for storing the compressed data is insufficient. And being
> unable to write whole compressed data on array, on s390 whole data can't be
> recovered after compression. This PR updates the check
On Thu, 27 Apr 2023 01:04:44 GMT, Jaikiran Pai wrote:
>> Amit Kumar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> removes out1,out2 parameters
>
> Hello Lance,
>
>> Jai, have you run this acrossed all of our Mach5 platforms?
>
> Yes
On Wed, 26 Apr 2023 20:29:41 GMT, Lance Andersen wrote:
>> Amit Kumar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> removes out1,out2 parameters
>
> test/jdk/java/util/zip/DeInflate.java line 129:
>
>> 127: int m = 0;
>> 128:
On Wed, 26 Apr 2023 20:22:54 GMT, Aleksey Shipilev wrote:
>> Java API has the `Thread.sleep(millis, nanos)` method exposed to users. The
>> documentation for that method clearly says the precision and accuracy are
>> dependent on the underlying system behavior. However, it always rounds up
>>
On Sat, 22 Apr 2023 18:40:45 GMT, Chen Liang wrote:
>> Add a method `internalName` to `ClassDesc`, and unifies handling of string
>> representation of a class constant in CONSTANT_Class_info via
>> `ofInternalName` and `internalName` APIs, documented in `ClassDesc` itself.
>> In particular,
On Sat, 22 Apr 2023 18:40:45 GMT, Chen Liang wrote:
>> Add a method `internalName` to `ClassDesc`, and unifies handling of string
>> representation of a class constant in CONSTANT_Class_info via
>> `ofInternalName` and `internalName` APIs, documented in `ClassDesc` itself.
>> In particular,
The ProcessTools.startProcess (...) has been updated to completely read streams
after process has been completed.
The test was updated to run 5 times with different number of lines and line
sizes.
-
Commit messages:
- fixed num of iters
- fix
Changes:
On Thu, 30 Mar 2023 03:06:51 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be
On Wed, 26 Apr 2023 20:42:01 GMT, Naoto Sato wrote:
> Updating the collation rules for Swedish to the modern one, which is aligned
> with the CLDR's default collation rules. Since it is changing the existing
> behavior, a release note has also been drafted:
>
On Sat, 22 Apr 2023 18:40:45 GMT, Chen Liang wrote:
>> Add a method `internalName` to `ClassDesc`, and unifies handling of string
>> representation of a class constant in CONSTANT_Class_info via
>> `ofInternalName` and `internalName` APIs, documented in `ClassDesc` itself.
>> In particular,
On Wed, 26 Apr 2023 22:10:20 GMT, Mandy Chung wrote:
> What is the issue of calling `ClassDesc.ofDescriptor` for arrays?
Users would have to check the obtained string from a `CONSTANT_Class_info` and
call different factory methods, which feels a bit... weird to me, like calling
`a == null ?
On Wed, 26 Apr 2023 20:08:51 GMT, Lance Andersen wrote:
>> Justin Lu has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Move getErrorCount() back to original spot
>> - Regardles of nothrow, final result should be logged, cache, move
> Please review changes to the IntlTest (test framework) class.
>
> These changes include
> - Logging the actual exception + stack trace. Previously, the test framework
> would throw `InvocationTargetException` but hide the actual underlying
> exception of the failing test unless the test
On Wed, 26 Apr 2023 20:42:01 GMT, Naoto Sato wrote:
> Updating the collation rules for Swedish to the modern one, which is aligned
> with the CLDR's default collation rules. Since it is changing the existing
> behavior, a release note has also been drafted:
>
Please review this PR which adds the method `caseFoldLanguageTag(String
languageTag)` to java.util.Locale.
This method case folds a language tag to adhere to _[section 2.1.1. Formatting
of Language Tags of
RFC5646](https://www.rfc-editor.org/rfc/rfc5646.html#section-2.1)_. This format
is
On Sat, 22 Apr 2023 18:40:45 GMT, Chen Liang wrote:
>> Add a method `internalName` to `ClassDesc`, and unifies handling of string
>> representation of a class constant in CONSTANT_Class_info via
>> `ofInternalName` and `internalName` APIs, documented in `ClassDesc` itself.
>> In particular,
Updating the collation rules for Swedish to the modern one, which is aligned
with the CLDR's default collation rules. Since it is changing the existing
behavior, a release note has also been drafted:
https://bugs.openjdk.org/browse/JDK-8306948
-
Commit messages:
- Added a test,
On Thu, 30 Mar 2023 03:06:51 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be
On Tue, 25 Apr 2023 21:43:54 GMT, Roger Riggs wrote:
> It appears that -Xcomp causes the relative timing of the commands to be
> disturbed enough to prevent the correct operation of the test. The test
> should not be run with -Xcomp
Changes requested by bchristi (Reviewer).
> Java API has the `Thread.sleep(millis, nanos)` method exposed to users. The
> documentation for that method clearly says the precision and accuracy are
> dependent on the underlying system behavior. However, it always rounds up
> `nanos` to 1ms when doing the actual sleep. This means users
On Tue, 25 Apr 2023 23:58:59 GMT, Justin Lu wrote:
>> Please review changes to the IntlTest (test framework) class.
>>
>> These changes include
>> - Logging the actual exception + stack trace. Previously, the test framework
>> would throw `InvocationTargetException` but hide the actual
> This is the first draft of a patch for JEP 440 and JEP 441. Changes included:
>
> - the pattern matching for switch and record patterns features are made
> final, together with updates to tests.
> - parenthesized patterns are removed.
> - qualified enum constants are supported for case
On Wed, 26 Apr 2023 10:46:24 GMT, Adam Sotona wrote:
>> Constants API already provides models for all loadable constants to help
>> programs manipulating class files and modelling bytecode instructions.
>> However no models of module and package constants are provided by Constants
>> API.
On Tue, 25 Apr 2023 23:58:59 GMT, Justin Lu wrote:
>> Please review changes to the IntlTest (test framework) class.
>>
>> These changes include
>> - Logging the actual exception + stack trace. Previously, the test framework
>> would throw `InvocationTargetException` but hide the actual
On Wed, 26 Apr 2023 10:46:24 GMT, Adam Sotona wrote:
>> Constants API already provides models for all loadable constants to help
>> programs manipulating class files and modelling bytecode instructions.
>> However no models of module and package constants are provided by Constants
>> API.
On Wed, 26 Apr 2023 10:46:24 GMT, Adam Sotona wrote:
>> Constants API already provides models for all loadable constants to help
>> programs manipulating class files and modelling bytecode instructions.
>> However no models of module and package constants are provided by Constants
>> API.
On Mon, 24 Apr 2023 21:02:01 GMT, Justin Lu wrote:
> This PR fixes an intermittent failure (that only occurs on Windows) in
> _DateFormatRegression.java_.
>
> With the integration of
> [JDK-8304982](https://bugs.openjdk.org/browse/JDK-8304982),
> _LocaleProviderAdapter.java_ now emits a
On Wed, 26 Apr 2023 06:18:10 GMT, Per Minborg wrote:
> Have we considered moving the Impl classes into a non-public area such as
> `jdk.internal` to improve encapsulation and reduce perceived footprint?
I don't see much of a problem to keep the non-public classes in
`java.lang.constant` since
On Wed, 26 Apr 2023 03:03:58 GMT, Yoshiki Sato wrote:
>> Please review this PR.
>> With this minor change, the javazic compiler (Main.java) can produce the
>> HTML files that display given time zone data correctly.
>
> Yoshiki Sato has updated the pull request incrementally with one
On Fri, 21 Apr 2023 21:43:39 GMT, Leonid Mesnik wrote:
> ProcessTools.startProcess() creates process and read it's output error
> streams. So the any other using of corresponding Process.getInputStream() and
> Process.getErrorStream() doesn't get process streams.
>
> This fix preserve process
> This patch aims to correct handling of annotations on parameters with the
> help of `MethodParameters` attribute, which will be always available once
> #9862 is integrated.
>
> It utilizes and expands upon the existing parameter matching logic present in
>
On Wed, 26 Apr 2023 09:38:45 GMT, Serguei Spitsyn wrote:
>> Right. From the API caller's POV, it is asking for InputStreams that it can
>> use to read the process' stdout or stderr streams.
>
> Okay, thanks.
> I'm thinking about simple/short comments on this to make it clear this naming
>
> ProcessTools.startProcess() creates process and read it's output error
> streams. So the any other using of corresponding Process.getInputStream() and
> Process.getErrorStream() doesn't get process streams.
>
> This fix preserve process streams content and allow to read reuse the date.
> The
On Wed, 26 Apr 2023 11:55:23 GMT, Volker Simonis wrote:
>> This issue was reported by: Yakov Shafranovich
>> ([yako...@amazon.com](mailto:yako...@amazon.com))
>>
>> Currently, `ObjectInputStream::readObject()` doesn't explicitly checks for a
>> negative array length in the deserialization
On Mon, 24 Apr 2023 15:58:49 GMT, Aleksey Shipilev wrote:
>> Volker Simonis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Addresed review comments of @turbanoff, @shipilev and @RogerRiggs
>
>
On Tue, 25 Apr 2023 21:01:04 GMT, Roger Riggs wrote:
>> test/jdk/java/io/ObjectInputStream/NegativeArraySizeTest.java line 88:
>>
>>> 86: } catch (ObjectStreamException ose) {
>>> 87: // OK, because a NegativeArraySizeException should be
>>> converted into a
On Wed, 26 Apr 2023 11:37:23 GMT, Volker Simonis wrote:
>> This issue was reported by: Yakov Shafranovich
>> ([yako...@amazon.com](mailto:yako...@amazon.com))
>>
>> Currently, `ObjectInputStream::readObject()` doesn't explicitly checks for a
>> negative array length in the deserialization
> This issue was reported by: Yakov Shafranovich
> ([yako...@amazon.com](mailto:yako...@amazon.com))
>
> Currently, `ObjectInputStream::readObject()` doesn't explicitly checks for a
> negative array length in the deserialization stream. Instead it calls
> `j.l.r.Array::newInstance(..)` with
On Thu, 30 Mar 2023 03:06:51 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be
On Wed, 26 Apr 2023 10:53:36 GMT, Jaikiran Pai wrote:
> These changes look fine to me.
Thanks @jaikiran for review and explanation. I'll update the PR description .
BTW these are not hotspot changes, So do we need 2 Reviewer for these as well ?
-
PR Comment:
On Thu, 30 Mar 2023 03:06:51 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be
> Constants API already provides models for all loadable constants to help
> programs manipulating class files and modelling bytecode instructions.
> However no models of module and package constants are provided by Constants
> API. Every program manipulating class files must implement own
On Tue, 25 Apr 2023 21:53:44 GMT, Mandy Chung wrote:
> I wonder if `packageName()` and `packageInternalName()` methods can simply be
> `name()` and `internalName()` as the type name is `PackageDesc` and `package`
> prefix seems to be unnecessary. Similarly, `moduleName()` can be `name()`.
>
> Constants API already provides models for all loadable constants to help
> programs manipulating class files and modelling bytecode instructions.
> However no models of module and package constants are provided by Constants
> API. Every program manipulating class files must implement own
> API changes for the FFM API (third preview)
>
> ### Specdiff
> https://cr.openjdk.org/~pminborg/panama/21/v2/specdiff/overview-summary.html
>
> ### Javadoc
> https://cr.openjdk.org/~pminborg/panama/21/v2/javadoc/api/java.base/java/lang/foreign/package-summary.html
>
> ### Tests
>
> Testing
> Constants API already provides models for all loadable constants to help
> programs manipulating class files and modelling bytecode instructions.
> However no models of module and package constants are provided by Constants
> API. Every program manipulating class files must implement own
On Tue, 25 Apr 2023 21:45:57 GMT, Mandy Chung wrote:
>> Adam Sotona has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Update ModuleDesc.java
>> - Update PackageDesc.java
>
>
On Mon, 20 Mar 2023 15:21:57 GMT, Adam Sotona wrote:
>> Marked as reviewed by asotona (Committer).
>
>> @asotona So should I simply throw an `IllegalAccessError` when the Lookup
>> encounters a `IllegalAccessException`, or should I return null? I favor
>> throwing an `IllegalAccessError` as
On Tue, 21 Mar 2023 13:35:25 GMT, Per Minborg wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add example for Option::captureStateLayout
>
> A review of all the copyright years shall be made in this PR.
@minborg :
On Fri, 21 Apr 2023 21:43:39 GMT, Leonid Mesnik wrote:
> ProcessTools.startProcess() creates process and read it's output error
> streams. So the any other using of corresponding Process.getInputStream() and
> Process.getErrorStream() doesn't get process streams.
>
> This fix preserve process
On Tue, 25 Apr 2023 15:50:24 GMT, Daniel D. Daugherty
wrote:
>> Agree, it is confusing, even in standard j.l.Process API . The `InputStream
>> java.lang.Process.getInputStream()`" returns **output** stream of started
>> process. So for our implementation ProcessImpl the 'out' and 'err' mean
> API changes for the FFM API (third preview)
>
> ### Specdiff
> https://cr.openjdk.org/~pminborg/panama/21/v2/specdiff/overview-summary.html
>
> ### Javadoc
> https://cr.openjdk.org/~pminborg/panama/21/v2/javadoc/api/java.base/java/lang/foreign/package-summary.html
>
> ### Tests
>
> Testing
> API changes for the FFM API (third preview)
>
> ### Specdiff
> https://cr.openjdk.org/~pminborg/panama/21/v2/specdiff/overview-summary.html
>
> ### Javadoc
> https://cr.openjdk.org/~pminborg/panama/21/v2/javadoc/api/java.base/java/lang/foreign/package-summary.html
>
> ### Tests
>
> Testing
On Wed, 26 Apr 2023 01:47:07 GMT, Joe Darcy wrote:
>> A reimplementation of `BigDecimal.[double|float]Value()` to enhance
>> performance, avoiding an intermediate string and its subsequent parsing on
>> the slow path.
>
> src/java.base/share/classes/java/math/BigDecimal.java line 3749:
>
>>
> API changes for the FFM API (third preview)
>
> ### Specdiff
> https://cr.openjdk.org/~pminborg/panama/21/v2/specdiff/overview-summary.html
>
> ### Javadoc
> https://cr.openjdk.org/~pminborg/panama/21/v2/javadoc/api/java.base/java/lang/foreign/package-summary.html
>
> ### Tests
>
> Testing
On Wed, 26 Apr 2023 01:41:09 GMT, Joe Darcy wrote:
>> A reimplementation of `BigDecimal.[double|float]Value()` to enhance
>> performance, avoiding an intermediate string and its subsequent parsing on
>> the slow path.
>
> src/java.base/share/classes/java/math/BigDecimal.java line 308:
>
>>
On Wed, 19 Apr 2023 13:37:15 GMT, Per Minborg wrote:
>> API changes for the FFM API (third preview)
>>
>> ### Specdiff
>> https://cr.openjdk.org/~pminborg/panama/21/v2/specdiff/overview-summary.html
>>
>> ### Javadoc
>>
> API changes for the FFM API (third preview)
>
> ### Specdiff
> https://cr.openjdk.org/~pminborg/panama/21/v2/specdiff/overview-summary.html
>
> ### Javadoc
> https://cr.openjdk.org/~pminborg/panama/21/v2/javadoc/api/java.base/java/lang/foreign/package-summary.html
>
> ### Tests
>
> Testing
On Tue, 25 Apr 2023 19:43:29 GMT, Adam Sotona wrote:
>> Constants API already provides models for all loadable constants to help
>> programs manipulating class files and modelling bytecode instructions.
>> However no models of module and package constants are provided by Constants
>> API.
61 matches
Mail list logo
