Re: RFR: 8303530: Add system property for custom JAXP configuration file [v9]

2023-04-27 Thread Joe Wang
> Add a system property, jdk.xml.config.file, to return the path to a custom > JAXP configuration file. The current configuration file, jaxp.properties, > that the JDK supports will become the default configuration file. > > CSR: https://bugs.openjdk.org/browse/JDK-8303531 > > Tests: XML SQE

Re: RFR: 8303796: Optionally build fully statically linked JDK image

2023-04-27 Thread David Holmes
On Fri, 28 Apr 2023 01:03:28 GMT, Jiangli Zhou wrote: > Initial implementation for supporting building a fully statically linked > (with a desired set of JDK native libraries and libjvm) Java launcher > executable, which is named as 'javastatic'. > > In this PR, the support is only added for

Re: RFR: JDK-8306112 Implementation of JEP 445: Flexible Main Methods and Anonymous Main Classes (Preview) [v3]

2023-04-27 Thread David Holmes
On Thu, 27 Apr 2023 18:21:56 GMT, Jim Laskey wrote: >> Add flexible main methods and anonymous main classes to the Java language. > > Jim Laskey has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains 14 commits: > > - Merge branch

Re: RFR: 8302496: Runtime.exit incorrectly says it never throws an exception

2023-04-27 Thread ExE Boss
On Thu, 27 Apr 2023 23:06:42 GMT, Stuart Marks wrote: > Textual specification clarifications. These can use the new generalised `@linkplain` tags available since **JDK 20**: src/java.base/share/classes/java/lang/Runtime.java line 143: > 141: > 142: /** > 143: * Initiates the

RFR: 8303796: Optionally build fully statically linked JDK image

2023-04-27 Thread Jiangli Zhou
Initial implementation for supporting building a fully statically linked (with a desired set of JDK native libraries and libjvm) Java launcher executable, which is named as 'javastatic'. In this PR, the support is only added for the linux platform. Both gcc and clang can be supported. For

Re: RFR: 8301703: java.base jdk.internal.foreign.abi.BindingSpecializer uses ASM to generate classes [v4]

2023-04-27 Thread Jorn Vernee
> Rewrite BindingSpecializer to use the new class file API. > > Note: There is a big try/catch/finally block generated in the `specialize` > method that currently uses labels. I looked at replacing this with a call to > `CodeBuilder::trying` but it would require threading the nested code

Re: RFR: 8303002: Reject packed structs from linker [v7]

2023-04-27 Thread Jorn Vernee
> This patch adds checks in AbstractLinker to reject packed structs and structs > with excess padding (e.g. unnamed bitfields), since both of those are > currently not supported, and the ABI/spec seems too vague to base support on. Jorn Vernee has updated the pull request with a new target base

Re: RFR: 8306698: Add overloads to MethodTypeDesc::of [v2]

2023-04-27 Thread Chen Liang
On Sun, 23 Apr 2023 23:44:41 GMT, Chen Liang wrote: >> Please review this patch adding two new convenience methods that allows >> easier access to MethodTypeDesc instances and its associated CSR as well. >> This is a necessity to allow #13186 to reduce array copies in a few >> scenarios; the

Integrated: 8306711: Improve diagnosis of `IntlTest` framework

2023-04-27 Thread Justin Lu
On Tue, 25 Apr 2023 20:28:33 GMT, Justin Lu wrote: > Please review changes to the IntlTest (test framework) class. > > These changes include > - Logging the actual exception + stack trace. Previously, the test framework > would throw `InvocationTargetException` but hide the actual underlying

Re: RFR: 8305093: Linker cache should not take layout names into account [v4]

2023-04-27 Thread Jorn Vernee
> Strip names from the function descriptors used in linkage requests. The names > are not important for classification, and this will allow the cached > MethodHandle/UpcallStubFactory to be shared across linkage request with the > same structure, but with layouts that have different names. > >

Re: RFR: 8305201: Improve error message for GroupLayouts that are too large on SysV [v3]

2023-04-27 Thread Jorn Vernee
> Using for instance a struct layout that contains an unbounded array will > produce the exception from the JBS issue. > > This patch checks for the case where a GroupLayout is too large more > explicitly, and reports the issue using a more informative exception. Jorn Vernee has updated the

Re: RFR: 8180892: Correct handling of annotations on parameters [v2]

2023-04-27 Thread Joe Darcy
On Wed, 26 Apr 2023 14:46:53 GMT, Chen Liang wrote: >> This patch aims to correct handling of annotations on parameters with the >> help of `MethodParameters` attribute, which will be always available once >> #9862 is integrated. >> >> It utilizes and expands upon the existing parameter

Re: RFR: 8305093: Linker cache should not take layout names into account [v3]

2023-04-27 Thread Jorn Vernee
> Strip names from the function descriptors used in linkage requests. The names > are not important for classification, and this will allow the cached > MethodHandle/UpcallStubFactory to be shared across linkage request with the > same structure, but with layouts that have different names. > >

Re: RFR: 8302496: Runtime.exit incorrectly says it never throws an exception

2023-04-27 Thread Stuart Marks
On Thu, 27 Apr 2023 23:06:42 GMT, Stuart Marks wrote: > Textual specification clarifications. Please review CSR [JDK-8307081](https://bugs.openjdk.org/browse/JDK-8307081). - PR Comment: https://git.openjdk.org/jdk/pull/13706#issuecomment-1526712106

RFR: 8302496: Runtime.exit incorrectly says it never throws an exception

2023-04-27 Thread Stuart Marks
Textual specification clarifications. - Commit messages: - 8302496: Runtime.exit incorrectly says it never throws an exception Changes: https://git.openjdk.org/jdk/pull/13706/files Webrev: https://webrevs.openjdk.org/?repo=jdk=13706=00 Issue:

Re: RFR: JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails [v3]

2023-04-27 Thread Erik Joelsson
On Thu, 27 Apr 2023 21:04:42 GMT, Erik Joelsson wrote: >> Antonios Printezis has updated the pull request incrementally with one >> additional commit since the last revision: >> >> updated > > Marked as reviewed by erikj (Reviewer). > @erikj79 Thanks! I assume the integrate command will

Re: RFR: 8306461: ObjectInputStream::readObject() should handle negative array sizes without throwing NegativeArraySizeExceptions [v3]

2023-04-27 Thread Roger Riggs
On Wed, 26 Apr 2023 11:55:23 GMT, Volker Simonis wrote: >> This issue was reported by: Yakov Shafranovich >> ([yako...@amazon.com](mailto:yako...@amazon.com)) >> >> Currently, `ObjectInputStream::readObject()` doesn't explicitly checks for a >> negative array length in the deserialization

Re: RFR: JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails [v3]

2023-04-27 Thread Antonios Printezis
On Thu, 27 Apr 2023 21:04:42 GMT, Erik Joelsson wrote: >> Antonios Printezis has updated the pull request incrementally with one >> additional commit since the last revision: >> >> updated > > Marked as reviewed by erikj (Reviewer). @erikj79 Thanks! I assume the integrate command will

Re: RFR: JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails [v3]

2023-04-27 Thread Erik Joelsson
On Thu, 27 Apr 2023 20:53:25 GMT, Antonios Printezis wrote: >> Fix is to exclude hsdis when building the buildjdk. > > Antonios Printezis has updated the pull request incrementally with one > additional commit since the last revision: > > updated Marked as reviewed by erikj (Reviewer).

Re: RFR: JDK-8306112 Implementation of JEP 445: Flexible Main Methods and Anonymous Main Classes (Preview) [v3]

2023-04-27 Thread Maurizio Cimadamore
On Thu, 27 Apr 2023 18:21:56 GMT, Jim Laskey wrote: >> Add flexible main methods and anonymous main classes to the Java language. > > Jim Laskey has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains 14 commits: > > - Merge branch

Re: RFR: JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails [v2]

2023-04-27 Thread Antonios Printezis
On Thu, 27 Apr 2023 20:37:11 GMT, Erik Joelsson wrote: >> Antonios Printezis has updated the pull request incrementally with one >> additional commit since the last revision: >> >> changes based on Erik's feedback > > make/autoconf/buildjdk-spec.gmk.in line 109: > >> 107: # hsdis is not

Re: RFR: JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails [v2]

2023-04-27 Thread Erik Joelsson
On Thu, 27 Apr 2023 20:08:29 GMT, Antonios Printezis wrote: >> Fix is to exclude hsdis when building the buildjdk. > > Antonios Printezis has updated the pull request incrementally with one > additional commit since the last revision: > > changes based on Erik's feedback

Re: RFR: JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails [v3]

2023-04-27 Thread Antonios Printezis
> Fix is to exclude hsdis when building the buildjdk. Antonios Printezis has updated the pull request incrementally with one additional commit since the last revision: updated - Changes: - all: https://git.openjdk.org/jdk/pull/13697/files - new:

Integrated: 8298993: (process) java/lang/ProcessBuilder/UnblockSignals.java fails

2023-04-27 Thread Roger Riggs
On Tue, 25 Apr 2023 21:43:54 GMT, Roger Riggs wrote: > It appears that -Xcomp causes the relative timing of the commands to be > disturbed enough to prevent the correct operation of the test. The test > should not be run with -Xcomp This pull request has now been integrated. Changeset:

Re: RFR: JDK-8306112 Implementation of JEP 445: Flexible Main Methods and Anonymous Main Classes (Preview) [v2]

2023-04-27 Thread Maurizio Cimadamore
On Thu, 27 Apr 2023 18:28:41 GMT, Jim Laskey wrote: >> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Enter.java line 432: >> >>> 430: >>> 431: // Restructure top level to be an top level anonymous class. >>> 432: public static void

Re: RFR: JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails [v2]

2023-04-27 Thread Antonios Printezis
> Fix is to exclude hsdis when building the buildjdk. Antonios Printezis has updated the pull request incrementally with one additional commit since the last revision: changes based on Erik's feedback - Changes: - all: https://git.openjdk.org/jdk/pull/13697/files - new:

Re: RFR: JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails [v2]

2023-04-27 Thread Antonios Printezis
On Thu, 27 Apr 2023 18:19:49 GMT, Erik Joelsson wrote: >> Antonios Printezis has updated the pull request incrementally with one >> additional commit since the last revision: >> >> changes based on Erik's feedback > > This looks like it should work, but I would like to avoid sprinkling any

Re: RFR: 8306697: Add method to obtain String for CONSTANT_Class_info in ClassDesc [v2]

2023-04-27 Thread Chen Liang
On Sat, 22 Apr 2023 18:40:45 GMT, Chen Liang wrote: >> Add a method `internalName` to `ClassDesc`, and unifies handling of string >> representation of a class constant in CONSTANT_Class_info via >> `ofInternalName` and `internalName` APIs, documented in `ClassDesc` itself. >> In particular,

Withdrawn: 8306697: Add method to obtain String for CONSTANT_Class_info in ClassDesc

2023-04-27 Thread Chen Liang
On Sat, 22 Apr 2023 15:12:48 GMT, Chen Liang wrote: > Add a method `internalName` to `ClassDesc`, and unifies handling of string > representation of a class constant in CONSTANT_Class_info via > `ofInternalName` and `internalName` APIs, documented in `ClassDesc` itself. > In particular,

Re: RFR: 8306729: Add nominal descriptors of modules and packages to Constants API [v15]

2023-04-27 Thread Mandy Chung
On Thu, 27 Apr 2023 07:42:29 GMT, Adam Sotona wrote: >> Constants API already provides models for all loadable constants to help >> programs manipulating class files and modelling bytecode instructions. >> However no models of module and package constants are provided by Constants >> API.

Re: RFR: 8306697: Add method to obtain String for CONSTANT_Class_info in ClassDesc [v2]

2023-04-27 Thread Mandy Chung
On Sat, 22 Apr 2023 18:40:45 GMT, Chen Liang wrote: >> Add a method `internalName` to `ClassDesc`, and unifies handling of string >> representation of a class constant in CONSTANT_Class_info via >> `ofInternalName` and `internalName` APIs, documented in `ClassDesc` itself. >> In particular,

Re: RFR: 8305093: Linker cache should not take layout names into account [v2]

2023-04-27 Thread ExE Boss
On Fri, 21 Apr 2023 01:03:57 GMT, Jorn Vernee wrote: >> Strip names from the function descriptors used in linkage requests. The >> names are not important for classification, and this will allow the cached >> MethodHandle/UpcallStubFactory to be shared across linkage request with the >> same

Re: RFR: 8306697: Add method to obtain String for CONSTANT_Class_info in ClassDesc [v2]

2023-04-27 Thread Brian Goetz
On Sat, 22 Apr 2023 18:40:45 GMT, Chen Liang wrote: >> Add a method `internalName` to `ClassDesc`, and unifies handling of string >> representation of a class constant in CONSTANT_Class_info via >> `ofInternalName` and `internalName` APIs, documented in `ClassDesc` itself. >> In particular,

Re: RFR: 8296935: Arrays.asList() can return a List that throws undocumented ArrayStoreException

2023-04-27 Thread Stuart Marks
On Thu, 27 Apr 2023 18:36:53 GMT, Stuart Marks wrote: > … Please review CSR [JDK-8307074](https://bugs.openjdk.org/browse/JDK-8307074). - PR Comment: https://git.openjdk.org/jdk/pull/13698#issuecomment-1526154278

RFR: 8296935: Arrays.asList() can return a List that throws undocumented ArrayStoreException

2023-04-27 Thread Stuart Marks
… - Commit messages: - 8296935: Arrays.asList() can return a List that throws undocumented ArrayStoreException Changes: https://git.openjdk.org/jdk/pull/13698/files Webrev: https://webrevs.openjdk.org/?repo=jdk=13698=00 Issue: https://bugs.openjdk.org/browse/JDK-8296935

Re: RFR: JDK-8306112 Implementation of JEP 445: Flexible Main Methods and Anonymous Main Classes (Preview) [v2]

2023-04-27 Thread Jim Laskey
On Thu, 27 Apr 2023 14:53:21 GMT, Maurizio Cimadamore wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> PreviewFeatures.isEnabled() > > src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Enter.java line 432: >

Re: RFR: JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails

2023-04-27 Thread Antonios Printezis
On Thu, 27 Apr 2023 18:19:49 GMT, Erik Joelsson wrote: > This looks like it should work, but I would like to avoid sprinkling any more > CREATING_BUILDJDK conditionals throughout the build than absolutely > necessary. I think it would be better to just override `HSDIS_BACKEND` and >

Re: RFR: JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails

2023-04-27 Thread Erik Joelsson
On Thu, 27 Apr 2023 17:57:05 GMT, Antonios Printezis wrote: > Fix is to exclude hsdis when building the buildjdk. This looks like it should work, but I would like to avoid sprinkling any more CREATING_BUILDJDK conditionals throughout the build than absolutely necessary. I think it would be

Integrated: 8306927: Collator treats "v" and "w" as the same letter for Swedish language locale.

2023-04-27 Thread Naoto Sato
On Wed, 26 Apr 2023 20:42:01 GMT, Naoto Sato wrote: > Updating the collation rules for Swedish to the modern one, which is aligned > with the CLDR's default collation rules. Since it is changing the existing > behavior, a release note has also been drafted: >

Re: RFR: 8298993: (process) java/lang/ProcessBuilder/UnblockSignals.java fails [v2]

2023-04-27 Thread Brent Christian
On Thu, 27 Apr 2023 13:54:53 GMT, Roger Riggs wrote: >> It appears that -Xcomp causes the relative timing of the commands to be >> disturbed enough to prevent the correct operation of the test. The test >> should not be run with -Xcomp > > Roger Riggs has updated the pull request incrementally

Re: RFR: JDK-8306112 Implementation of JEP 445: Flexible Main Methods and Anonymous Main Classes (Preview) [v2]

2023-04-27 Thread Jim Laskey
On Thu, 27 Apr 2023 14:55:01 GMT, Maurizio Cimadamore wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> PreviewFeatures.isEnabled() > > src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java line >

Re: RFR: JDK-8306112 Implementation of JEP 445: Flexible Main Methods and Anonymous Main Classes (Preview) [v2]

2023-04-27 Thread Jim Laskey
On Thu, 27 Apr 2023 13:39:37 GMT, Alan Bateman wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> PreviewFeatures.isEnabled() > > src/java.base/share/classes/sun/launcher/LauncherHelper.java line 45: > >> 43: import

Re: RFR: JDK-8306112 Implementation of JEP 445: Flexible Main Methods and Anonymous Main Classes (Preview) [v3]

2023-04-27 Thread Jim Laskey
> Add flexible main methods and anonymous main classes to the Java language. Jim Laskey has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 14 commits: - Merge branch 'master' into 8306112 - PreviewFeatures.isEnabled() - Clean up

RFR: JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails

2023-04-27 Thread Antonios Printezis
Fix is to exclude hsdis when building the buildjdk. - Commit messages: - JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails Changes: https://git.openjdk.org/jdk/pull/13697/files Webrev: https://webrevs.openjdk.org/?repo=jdk=13697=00 Issue:

Re: RFR: 8306697: Add method to obtain String for CONSTANT_Class_info in ClassDesc [v2]

2023-04-27 Thread Chen Liang
On Thu, 27 Apr 2023 17:58:02 GMT, Mandy Chung wrote: > `ClassDesc.ofClassDescString("I")` can't differentiate if it's a primitive or > an internal name of class `I`. It is always treated as an internal name when it is without a `[` prefix. if class `I` in the unnamed package is stored in a

Re: RFR: 8306697: Add method to obtain String for CONSTANT_Class_info in ClassDesc [v2]

2023-04-27 Thread Mandy Chung
On Sat, 22 Apr 2023 18:40:45 GMT, Chen Liang wrote: >> Add a method `internalName` to `ClassDesc`, and unifies handling of string >> representation of a class constant in CONSTANT_Class_info via >> `ofInternalName` and `internalName` APIs, documented in `ClassDesc` itself. >> In particular,

Re: RFR: 8306697: Add method to obtain String for CONSTANT_Class_info in ClassDesc [v2]

2023-04-27 Thread Chen Liang
On Thu, 27 Apr 2023 17:23:58 GMT, Mandy Chung wrote: > 4. Return a string representation of internal name for a class or interface > and a descriptor string for a primitive type and array. The method could be > called `classDescString`. The caller can test if this `ClassDesc` is not a >

Re: RFR: 8306697: Add method to obtain String for CONSTANT_Class_info in ClassDesc [v2]

2023-04-27 Thread Mandy Chung
On Sat, 22 Apr 2023 18:40:45 GMT, Chen Liang wrote: >> Add a method `internalName` to `ClassDesc`, and unifies handling of string >> representation of a class constant in CONSTANT_Class_info via >> `ofInternalName` and `internalName` APIs, documented in `ClassDesc` itself. >> In particular,

Re: RFR: 8306697: Add method to obtain String for CONSTANT_Class_info in ClassDesc [v2]

2023-04-27 Thread Chen Liang
On Sat, 22 Apr 2023 18:40:45 GMT, Chen Liang wrote: >> Add a method `internalName` to `ClassDesc`, and unifies handling of string >> representation of a class constant in CONSTANT_Class_info via >> `ofInternalName` and `internalName` APIs, documented in `ClassDesc` itself. >> In particular,

Re: RFR: 8306697: Add method to obtain String for CONSTANT_Class_info in ClassDesc [v2]

2023-04-27 Thread Mandy Chung
On Sat, 22 Apr 2023 18:40:45 GMT, Chen Liang wrote: >> Add a method `internalName` to `ClassDesc`, and unifies handling of string >> representation of a class constant in CONSTANT_Class_info via >> `ofInternalName` and `internalName` APIs, documented in `ClassDesc` itself. >> In particular,

Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v4]

2023-04-27 Thread Mahendra Chhipa
> Test is updated to create the binary files during test execution. Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Implemented the review comments. - Changes: - all: https://git.openjdk.org/jdk/pull/13537/files

Re: RFR: 8306946: jdk/test/lib/process/ProcessToolsStartProcessTest.java fails with "wrong number of lines in OutputAnalyzer output" [v3]

2023-04-27 Thread Leonid Mesnik
On Thu, 27 Apr 2023 16:35:59 GMT, Leonid Mesnik wrote: >> The ProcessTools.startProcess (...) has been updated to completely read >> streams after process has been completed. >> The test was updated to run 5 times with different number of lines and line >> sizes. > > Leonid Mesnik has updated

Integrated: 8205592: BigDecimal.doubleValue() is depressingly slow

2023-04-27 Thread Raffaello Giulietti
On Thu, 7 Jul 2022 15:20:32 GMT, Raffaello Giulietti wrote: > A reimplementation of `BigDecimal.[double|float]Value()` to enhance > performance, avoiding an intermediate string and its subsequent parsing on > the slow path. This pull request has now been integrated. Changeset: eb358619

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v65]

2023-04-27 Thread Jim Laskey
> Enhance the Java programming language with string templates, which are > similar to string literals but contain embedded expressions. A string > template is interpreted at run time by replacing each expression with the > result of evaluating that expression, possibly after further validation

Re: RFR: 8205592: BigDecimal.doubleValue() is depressingly slow [v2]

2023-04-27 Thread Raffaello Giulietti
> A reimplementation of `BigDecimal.[double|float]Value()` to enhance > performance, avoiding an intermediate string and its subsequent parsing on > the slow path. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Renamed

Re: RFR: 8306946: jdk/test/lib/process/ProcessToolsStartProcessTest.java fails with "wrong number of lines in OutputAnalyzer output" [v3]

2023-04-27 Thread Daniel D . Daugherty
On Thu, 27 Apr 2023 16:35:59 GMT, Leonid Mesnik wrote: >> The ProcessTools.startProcess (...) has been updated to completely read >> streams after process has been completed. >> The test was updated to run 5 times with different number of lines and line >> sizes. > > Leonid Mesnik has updated

Re: RFR: 8299748: java/util/zip/Deinflate.java failing on s390x [v6]

2023-04-27 Thread Amit Kumar
> DeInflate.java test fails on s390x platform because size for out1 array which > is responsible for storing the compressed data is insufficient. And being > unable to write whole compressed data on array, on s390 whole data can't be > recovered after compression. This PR updates the check

Re: RFR: 8299748: java/util/zip/Deinflate.java failing on s390x [v5]

2023-04-27 Thread Amit Kumar
On Thu, 27 Apr 2023 16:08:10 GMT, Andrey Turbanov wrote: >> Amit Kumar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> comment suggestion from @jaikiran > > test/jdk/java/util/zip/DeInflate.java line 146: > >> 144:

Re: RFR: 8306461: ObjectInputStream::readObject() should handle negative array sizes without throwing NegativeArraySizeExceptions [v3]

2023-04-27 Thread Volker Simonis
On Wed, 26 Apr 2023 12:47:47 GMT, Roger Riggs wrote: >> Volker Simonis has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >>

Re: RFR: 8205592: BigDecimal.doubleValue() is depressingly slow

2023-04-27 Thread Joe Darcy
On Wed, 26 Apr 2023 08:30:07 GMT, Raffaello Giulietti wrote: > No, that would not be correct. It would be subject to [double > rounding](https://en.wikipedia.org/wiki/Rounding#Double_rounding), against > the spec. > > For example, `BigDecimal` 1.00059604644775390626 should round to

Re: RFR: 8306946: jdk/test/lib/process/ProcessToolsStartProcessTest.java fails with "wrong number of lines in OutputAnalyzer output" [v3]

2023-04-27 Thread Leonid Mesnik
> The ProcessTools.startProcess (...) has been updated to completely read > streams after process has been completed. > The test was updated to run 5 times with different number of lines and line > sizes. Leonid Mesnik has updated the pull request incrementally with one additional commit since

RE: blocking peek for blocking queues

2023-04-27 Thread mark.yagnatinsky
Someone said this is the right list for this, so forwarding from jdk-dev with a small tweak I'd like to make a case for adding a blocking variant of peek() to BlockingQueue. This has apparently been suggested before: https://bugs.openjdk.org/browse/JDK-6653412 At the time, the verdict was that

Re: RFR: 8299748: java/util/zip/Deinflate.java failing on s390x [v5]

2023-04-27 Thread Andrey Turbanov
On Thu, 27 Apr 2023 07:24:24 GMT, Amit Kumar wrote: >> DeInflate.java test fails on s390x platform because size for out1 array >> which is responsible for storing the compressed data is insufficient. And >> being unable to write whole compressed data on array, on s390 whole data >> can't be

Re: RFR: JDK-8306112 Implementation of JEP 445: Flexible Main Methods and Anonymous Main Classes (Preview) [v2]

2023-04-27 Thread Joe Darcy
On Thu, 27 Apr 2023 13:17:58 GMT, Jim Laskey wrote: >> Add flexible main methods and anonymous main classes to the Java language. > > Jim Laskey has updated the pull request incrementally with one additional > commit since the last revision: > > PreviewFeatures.isEnabled() I assume future

Re: RFR: 8306927: Collator treats "v" and "w" as the same letter for Swedish language locale.

2023-04-27 Thread Joe Wang
On Wed, 26 Apr 2023 20:42:01 GMT, Naoto Sato wrote: > Updating the collation rules for Swedish to the modern one, which is aligned > with the CLDR's default collation rules. Since it is changing the existing > behavior, a release note has also been drafted: >

Re: RFR: JDK-8306112 Implementation of JEP 445: Flexible Main Methods and Anonymous Main Classes (Preview) [v2]

2023-04-27 Thread Maurizio Cimadamore
On Thu, 27 Apr 2023 13:17:58 GMT, Jim Laskey wrote: >> Add flexible main methods and anonymous main classes to the Java language. > > Jim Laskey has updated the pull request incrementally with one additional > commit since the last revision: > > PreviewFeatures.isEnabled()

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v64]

2023-04-27 Thread Jim Laskey
> Enhance the Java programming language with string templates, which are > similar to string literals but contain embedded expressions. A string > template is interpreted at run time by replacing each expression with the > result of evaluating that expression, possibly after further validation

Re: RFR: 8298993: (process) java/lang/ProcessBuilder/UnblockSignals.java fails [v2]

2023-04-27 Thread Roger Riggs
> It appears that -Xcomp causes the relative timing of the commands to be > disturbed enough to prevent the correct operation of the test. The test > should not be run with -Xcomp Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: JDK-8306112 Implementation of JEP 445: Flexible Main Methods and Anonymous Main Classes (Preview) [v2]

2023-04-27 Thread Alan Bateman
On Thu, 27 Apr 2023 13:17:58 GMT, Jim Laskey wrote: >> Add flexible main methods and anonymous main classes to the Java language. > > Jim Laskey has updated the pull request incrementally with one additional > commit since the last revision: > > PreviewFeatures.isEnabled()

Re: RFR: 8299748: java/util/zip/Deinflate.java failing on s390x [v3]

2023-04-27 Thread Jaikiran Pai
On Thu, 27 Apr 2023 06:43:00 GMT, Jaikiran Pai wrote: >> Thanks for pointing it out. Please take a look at the latest modifications. > > The latest code changes look OK to me. I've added a comment about the test > method comment. Tests continue to pass on mach5 with these latest changes.

Re: RFR: JDK-8306112 Implementation of JEP 445: Flexible Main Methods and Anonymous Main Classes (Preview) [v2]

2023-04-27 Thread Jim Laskey
> Add flexible main methods and anonymous main classes to the Java language. Jim Laskey has updated the pull request incrementally with one additional commit since the last revision: PreviewFeatures.isEnabled() - Changes: - all: https://git.openjdk.org/jdk/pull/13689/files -

Re: RFR: 8303040: linux PPC64le: Implementation of Foreign Function & Memory API (Preview) [v24]

2023-04-27 Thread Martin Doerr
On Thu, 27 Apr 2023 12:54:55 GMT, Martin Doerr wrote: >> Implementation of "Foreign Function & Memory API" for linux on Power (Little >> Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification". >> >> This PR does not include code for VaList support because it's supposed to

Re: RFR: 8303040: linux PPC64le: Implementation of Foreign Function & Memory API (Preview) [v24]

2023-04-27 Thread Martin Doerr
> Implementation of "Foreign Function & Memory API" for linux on Power (Little > Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification". > > This PR does not include code for VaList support because it's supposed to get > removed by

RFR: JDK-8306112 Implementation of JEP 445: Flexible Main Methods and Anonymous Main Classes (Preview)

2023-04-27 Thread Jim Laskey
Add flexible main methods and anonymous main classes to the Java language. - Commit messages: - Clean up isPreview - Missing exception - Corrections - Update VM.java - Clean up testing - Update TestJavacTaskScanner.java - Merge branch 'master' into 8306112 - Clean up -

Re: RFR: 8306927: Collator treats "v" and "w" as the same letter for Swedish language locale.

2023-04-27 Thread Naoto Sato
On Thu, 27 Apr 2023 04:37:08 GMT, Joe Wang wrote: > The rule was changed in 2006, the year Jave SE 6 was released. Though it > looks like very much a corner case, it goes all the way back. I wonder if a > CSR is needed? We don't file a CSR for such a locale data change. These sorts of changes

Re: RFR: 8305093: Linker cache should not take layout names into account [v2]

2023-04-27 Thread Andrey Turbanov
On Fri, 21 Apr 2023 01:03:57 GMT, Jorn Vernee wrote: >> Strip names from the function descriptors used in linkage requests. The >> names are not important for classification, and this will allow the cached >> MethodHandle/UpcallStubFactory to be shared across linkage request with the >> same

Re: RFR: 8305201: Improve error message for GroupLayouts that are too large on SysV [v2]

2023-04-27 Thread Andrey Turbanov
On Thu, 27 Apr 2023 09:28:23 GMT, Jorn Vernee wrote: >> Using for instance a struct layout that contains an unbounded array will >> produce the exception from the JBS issue. >> >> This patch checks for the case where a GroupLayout is too large more >> explicitly, and reports the issue using a

Re: RFR: 8303040: linux PPC64le: Implementation of Foreign Function & Memory API (Preview) [v23]

2023-04-27 Thread Martin Doerr
> Implementation of "Foreign Function & Memory API" for linux on Power (Little > Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification". > > This PR does not include code for VaList support because it's supposed to get > removed by

Re: RFR: 8305092: Improve Thread.sleep(millis, nanos) for sub-millisecond granularity [v12]

2023-04-27 Thread Aleksey Shipilev
On Wed, 26 Apr 2023 20:22:54 GMT, Aleksey Shipilev wrote: >> Java API has the `Thread.sleep(millis, nanos)` method exposed to users. The >> documentation for that method clearly says the precision and accuracy are >> dependent on the underlying system behavior. However, it always rounds up >>

Re: RFR: 8306697: Add method to obtain String for CONSTANT_Class_info in ClassDesc [v2]

2023-04-27 Thread Adam Sotona
On Sat, 22 Apr 2023 18:40:45 GMT, Chen Liang wrote: >> Add a method `internalName` to `ClassDesc`, and unifies handling of string >> representation of a class constant in CONSTANT_Class_info via >> `ofInternalName` and `internalName` APIs, documented in `ClassDesc` itself. >> In particular,

Re: RFR: 8305201: Improve error message for GroupLayouts that are too large on SysV [v2]

2023-04-27 Thread Jorn Vernee
> Using for instance a struct layout that contains an unbounded array will > produce the exception from the JBS issue. > > This patch checks for the case where a GroupLayout is too large more > explicitly, and reports the issue using a more informative exception. Jorn Vernee has updated the

Re: RFR: 8304888: Add dedicated VMProps for linker and fallback linker [v2]

2023-04-27 Thread Jorn Vernee
> This patch adds a dedicated jtreg property to check which CABI is being used > by the JDK, which can be used both to check whether the foreign linker is > supported, and whether the fallback linker is being used. (and, possibly it > can also be use to check for a particular ABI in case we

Re: RFR: 8306697: Add method to obtain String for CONSTANT_Class_info in ClassDesc [v2]

2023-04-27 Thread Adam Sotona
On Sat, 22 Apr 2023 18:40:45 GMT, Chen Liang wrote: >> Add a method `internalName` to `ClassDesc`, and unifies handling of string >> representation of a class constant in CONSTANT_Class_info via >> `ofInternalName` and `internalName` APIs, documented in `ClassDesc` itself. >> In particular,

Integrated: 8304265: Implementation of Foreign Function and Memory API (Third Preview)

2023-04-27 Thread Per Minborg
On Fri, 17 Mar 2023 15:42:56 GMT, Per Minborg wrote: > API changes for the FFM API (third preview) > > ### Specdiff > https://cr.openjdk.org/~pminborg/panama/21/v2/specdiff/overview-summary.html > > ### Javadoc >

Re: RFR: 8306697: Add method to obtain String for CONSTANT_Class_info in ClassDesc [v2]

2023-04-27 Thread Adam Sotona
On Sat, 22 Apr 2023 18:40:45 GMT, Chen Liang wrote: >> Add a method `internalName` to `ClassDesc`, and unifies handling of string >> representation of a class constant in CONSTANT_Class_info via >> `ofInternalName` and `internalName` APIs, documented in `ClassDesc` itself. >> In particular,

Re: RFR: 8306729: Add nominal descriptors of modules and packages to Constants API [v13]

2023-04-27 Thread Adam Sotona
On Wed, 26 Apr 2023 18:15:34 GMT, Alan Bateman wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> removed prefixes from name methods > > src/java.base/share/classes/java/lang/constant/ConstantUtils.java line 133: >

Re: RFR: 8306729: Add nominal descriptors of modules and packages to Constants API [v15]

2023-04-27 Thread Adam Sotona
> Constants API already provides models for all loadable constants to help > programs manipulating class files and modelling bytecode instructions. > However no models of module and package constants are provided by Constants > API. Every program manipulating class files must implement own

Re: RFR: 8299748: java/util/zip/Deinflate.java failing on s390x [v5]

2023-04-27 Thread Amit Kumar
> DeInflate.java test fails on s390x platform because size for out1 array which > is responsible for storing the compressed data is insufficient. And being > unable to write whole compressed data on array, on s390 whole data can't be > recovered after compression. This PR updates the check

Re: RFR: 8306946: jdk/test/lib/process/ProcessToolsStartProcessTest.java fails with "wrong number of lines in OutputAnalyzer output" [v2]

2023-04-27 Thread Leonid Mesnik
On Thu, 27 Apr 2023 04:59:00 GMT, David Holmes wrote: >> Leonid Mesnik has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix > > test/lib-test/jdk/test/lib/process/ProcessToolsStartProcessTest.java line 79: > >> 77:

Re: RFR: 8306946: jdk/test/lib/process/ProcessToolsStartProcessTest.java fails with "wrong number of lines in OutputAnalyzer output" [v2]

2023-04-27 Thread Leonid Mesnik
> The ProcessTools.startProcess (...) has been updated to completely read > streams after process has been completed. > The test was updated to run 5 times with different number of lines and line > sizes. Leonid Mesnik has updated the pull request incrementally with one additional commit since

Re: RFR: 8299748: java/util/zip/Deinflate.java failing on s390x [v4]

2023-04-27 Thread Amit Kumar
On Thu, 27 Apr 2023 06:42:08 GMT, Jaikiran Pai wrote: >> Amit Kumar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> comments from Lance > > test/jdk/java/util/zip/DeInflate.java line 124: > >> 122: * This method checks if a given

Re: RFR: 8299748: java/util/zip/Deinflate.java failing on s390x [v4]

2023-04-27 Thread Jaikiran Pai
On Thu, 27 Apr 2023 03:25:53 GMT, Amit Kumar wrote: >> DeInflate.java test fails on s390x platform because size for out1 array >> which is responsible for storing the compressed data is insufficient. And >> being unable to write whole compressed data on array, on s390 whole data >> can't be

Re: RFR: 8301492: Modernize equals() method of ResourceBundle.CacheKey and Bundles.CacheKey [v3]

2023-04-27 Thread Sergey Tsypanov
On Wed, 1 Feb 2023 10:36:12 GMT, Sergey Tsypanov wrote: >> `ResourceBundle.CacheKey.equals()` and `Bundles.CacheKey.equals()` are quire >> outdated. This simple clean-up modernizes them. > > Sergey Tsypanov has updated the pull request incrementally with one > additional commit since the last

Re: RFR: 8306729: Add nominal descriptors of modules and packages to Constants API [v14]

2023-04-27 Thread Adam Sotona
> Constants API already provides models for all loadable constants to help > programs manipulating class files and modelling bytecode instructions. > However no models of module and package constants are provided by Constants > API. Every program manipulating class files must implement own

Re: RFR: 8299748: java/util/zip/Deinflate.java failing on s390x [v4]

2023-04-27 Thread Jaikiran Pai
On Thu, 27 Apr 2023 03:25:53 GMT, Amit Kumar wrote: >> DeInflate.java test fails on s390x platform because size for out1 array >> which is responsible for storing the compressed data is insufficient. And >> being unable to write whole compressed data on array, on s390 whole data >> can't be

Re: RFR: 8299748: java/util/zip/Deinflate.java failing on s390x [v3]

2023-04-27 Thread Jaikiran Pai
On Thu, 27 Apr 2023 03:17:25 GMT, Amit Kumar wrote: >> test/jdk/java/util/zip/DeInflate.java line 129: >> >>> 127: int m = 0; >>> 128: >>> 129: ByteArrayOutputStream baos = new ByteArrayOutputStream(len); >> >> Is there a reason a try-with-resources is not being used? > >