On Tue, 2 May 2023 20:16:15 GMT, Joe Wang wrote:
>> Add a system property, jdk.xml.config.file, to return the path to a custom
>> JAXP configuration file. The current configuration file, jaxp.properties,
>> that the JDK supports will become the default configuration file.
>>
>> CSR:
On Tue, 9 May 2023 22:10:22 GMT, Archie Cobbs wrote:
> pingbot
Thanks for the reminder. Too late to sponsor today so tomorrow.
-
PR Comment: https://git.openjdk.org/jdk/pull/13379#issuecomment-1541124772
On Sat, 18 Feb 2023 18:22:49 GMT, Eirik Bjorsnos wrote:
> This PR continues the efforts from #12632 to speed up case-insensitive string
> matching.
>
> We now tackle case-insensitive comparison of mixed-coder strings, implemented
> in `StringLatin1.regionMatchesCI_UTF16`
>
> Key insights:
>
On Tue, 9 May 2023 22:14:04 GMT, Erik Joelsson wrote:
> I think you also need to make a change to `GraalBuilderImage.gmk` and the
> target in `Main.gmk` that calls it.
Good catch! Fixed `GraalBuilderImage.gmk`, thanks!
For the `graal-builder-image` target that uses `GraalBuilderImage.gmk`,
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/hotspot static libraries:
>
> - Introduce new make target(s) for creating image/bundle containing hotspot
> libjvm.a and JDK static libraries
>
>
On Tue, 9 May 2023 21:46:42 GMT, Jiangli Zhou wrote:
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling the JDK/hotspot static libraries:
>>
>> - Introduce new make target(s) for creating image/bundle
On Fri, 7 Apr 2023 18:24:42 GMT, Archie Cobbs wrote:
>> IO stream classes like `FileOutputStream` can have assocated NIO channels.
>>
>> When `close()` is invoked on one of these classes, it in turn invokes
>> `close()` on the associated channel (if any). But when the associated
>> channel's
On Mon, 8 May 2023 19:45:18 GMT, Jiangli Zhou wrote:
> > > All of that said, I think we can get away with a smaller subset of
> > > targets and deliverables. AFAIK, graal needs the combined
> > > `graal-builder-image` as input to their build anyway, so they should not
> > > have any
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/hotspot static libraries:
>
> - Introduce new make target(s) for creating image/bundle containing hotspot
> libjvm.a and JDK static libraries
>
>
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/hotspot static libraries:
>
> - Introduce new make target(s) for creating image/bundle containing hotspot
> libjvm.a and JDK static libraries
>
>
On Sun, 12 Mar 2023 21:28:59 GMT, iaroslavski wrote:
>> Sorting:
>>
>> - adopt radix sort for sequential and parallel sorts on
>> int/long/float/double arrays (almost random and length > 6K)
>> - fix tryMergeRuns() to better handle case when the last run is a single
>> element
>> - minor
On Tue, 9 May 2023 20:39:19 GMT, Justin Lu wrote:
> Please review this PR which adds an example snippet to
> `java.time.temporal.WeekFields.of(Locale locale)`
>
> The snippet demonstrates how to create a Locale that has English Locale
> qualities with an ISO-8601 first day of the week.
>
>
On Tue, 9 May 2023 20:39:19 GMT, Justin Lu wrote:
> Please review this PR which adds an example snippet to
> `java.time.temporal.WeekFields.of(Locale locale)`
>
> The snippet demonstrates how to create a Locale that has English Locale
> qualities with an ISO-8601 first day of the week.
>
>
On Tue, 9 May 2023 20:39:19 GMT, Justin Lu wrote:
> Please review this PR which adds an example snippet to
> `java.time.temporal.WeekFields.of(Locale locale)`
>
> The snippet demonstrates how to create a Locale that has English Locale
> qualities with an ISO-8601 first day of the week.
>
>
On Fri, 5 May 2023 21:28:25 GMT, Roger Riggs wrote:
> The implementation of java.time.Instant.until(I2, ChronoUnit) in some cases
> did not correctly borrow or carry from the nanos to the seconds when
> computing using ChronoUnit.MILLIS or ChronoUnit.MICROS.
> The errant computation was
Please review this PR which adds an example snippet to
`java.time.temporal.WeekFields.of(Locale locale)`
The snippet demonstrates how to create a Locale that has English Locale
qualities with an ISO-8601 first day of the week.
This snippet was added as there was a desire for an
> These micros were developed while investigating JDK-8305670 by myself and
> Sergey Kuksenko. The order of thread creation was important in that bug, so
> there are 2 JMH for creating sleepers before and after the worker threads.
Eric Caspole has updated the pull request incrementally with one
On Thu, 4 May 2023 15:52:36 GMT, Leonid Mesnik wrote:
> The ProcessTools has some support of jtreg thread factory functionality.
> It tries to run the new process using virtual thread to run `main()` method.
> This fix updates it to skip the java runs where no main class is involved and
> more
On Tue, 14 Mar 2023 14:51:34 GMT, Thiago Henrique Hüpner
wrote:
> 8304148: Remapping a class with Invokedynamic constant loses static bootstrap
> arguments
This pull request has now been integrated.
Changeset: dde557e3
Author:Thiago Henrique Hüpner
Committer: Adam Sotona
URL:
> These micros were developed while investigating JDK-8305670 by myself and
> Sergey Kuksenko. The order of thread creation was important in that bug, so
> there are 2 JMH for creating sleepers before and after the worker threads.
Eric Caspole has updated the pull request incrementally with one
On Tue, 9 May 2023 17:25:57 GMT, Leonid Mesnik wrote:
>> The ProcessTools has some support of jtreg thread factory functionality.
>> It tries to run the new process using virtual thread to run `main()` method.
>> This fix updates it to skip the java runs where no main class is involved
>> and
> 8304148: Remapping a class with Invokedynamic constant loses static bootstrap
> arguments
Thiago Henrique Hüpner has updated the pull request incrementally with one
additional commit since the last revision:
Update full name
-
Changes:
- all:
> The ProcessTools has some support of jtreg thread factory functionality.
> It tries to run the new process using virtual thread to run `main()` method.
> This fix updates it to skip the java runs where no main class is involved and
> more correctly process options which has 2nd argument.
> Also
On Wed, 26 Apr 2023 22:20:37 GMT, Justin Lu wrote:
> Please review this PR which adds the method `caseFoldLanguageTag(String
> languageTag)` to java.util.Locale.
>
> This method case folds a language tag to adhere to _[section 2.1.1.
> Formatting of Language Tags of
>
> Enhance the Java programming language with string templates, which are
> similar to string literals but contain embedded expressions. A string
> template is interpreted at run time by replacing each expression with the
> result of evaluating that expression, possibly after further validation
On Sun, 23 Apr 2023 23:44:41 GMT, Chen Liang wrote:
>> Please review this patch adding two new convenience methods that allows
>> easier access to MethodTypeDesc instances and its associated CSR as well.
>> This is a necessity to allow #13186 to reduce array copies in a few
>> scenarios; the
On Tue, 9 May 2023 16:27:21 GMT, Viktor Klang wrote:
>> Still relevant to address? /cc @PaulSandoz
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Using apiNote and rewording from method to operation
Marked as reviewed by
On Tue, 9 May 2023 16:24:24 GMT, Jim Laskey wrote:
>> Enhance the Java programming language with string templates, which are
>> similar to string literals but contain embedded expressions. A string
>> template is interpreted at run time by replacing each expression with the
>> result of
On Tue, 9 May 2023 16:06:12 GMT, Paul Sandoz wrote:
>> Viktor Klang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Using apiNote and rewording from method to operation
>
> I would recommend:
> - using `@apiNote` (might have to be
> Still relevant to address? /cc @PaulSandoz
Viktor Klang has updated the pull request incrementally with one additional
commit since the last revision:
Using apiNote and rewording from method to operation
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13890/files
- new:
On Tue, 9 May 2023 12:58:27 GMT, Jim Laskey wrote:
>> Enhance the Java programming language with string templates, which are
>> similar to string literals but contain embedded expressions. A string
>> template is interpreted at run time by replacing each expression with the
>> result of
> Enhance the Java programming language with string templates, which are
> similar to string literals but contain embedded expressions. A string
> template is interpreted at run time by replacing each expression with the
> result of evaluating that expression, possibly after further validation
On Tue, 9 May 2023 16:08:57 GMT, Chen Liang wrote:
>> To make this runnable without manually adding a bunch of `--add-opens` flags
>
> They are added in the `make/RunTests.gmk`:
>
On Thu, 27 Apr 2023 12:54:55 GMT, Martin Doerr wrote:
>> Implementation of "Foreign Function & Memory API" for linux on Power (Little
>> Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification".
>>
>> This PR does not include code for VaList support because it's supposed to
On Tue, 18 Apr 2023 10:44:03 GMT, Martin Doerr wrote:
>> Implementation of "Foreign Function & Memory API" for linux on Power (Little
>> Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification".
>>
>> This PR does not include code for VaList support because it's supposed to
On Thu, 16 Mar 2023 14:42:10 GMT, Martin Doerr wrote:
>> Implementation of "Foreign Function & Memory API" for linux on Power (Little
>> Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification".
>>
>> This PR does not include code for VaList support because it's supposed to
On Sat, 6 May 2023 19:38:36 GMT, Martin Doerr wrote:
>> Implementation of "Foreign Function & Memory API" for linux on Power (Little
>> Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification".
>>
>> This PR does not include code for VaList support because it's supposed to
>>
On Tue, 9 May 2023 16:09:14 GMT, Adam Sotona wrote:
>> Following improvements implemented:
>> - Switch over `String` replaced with switch single char
>> - Binary search for frames in `StackMapGenerator`
>> - `StackMapGenerator.rawHandlers` with pre-calculated offsets
>> - `ClassEntry` is caching
On Tue, 9 May 2023 15:50:13 GMT, Viktor Klang wrote:
> Still relevant to address? /cc @PaulSandoz
I would recommend:
- using `@apiNote` (might have to be placed at the end of the documentation);
and
- say "This operation is provided ..."
-
PR Review:
On Tue, 9 May 2023 15:57:44 GMT, Claes Redestad wrote:
>> test/micro/org/openjdk/bench/jdk/classfile/RebuildMethodBodies.java line 42:
>>
>>> 40: @BenchmarkMode(Mode.Throughput)
>>> 41: @State(Scope.Benchmark)
>>> 42: @Fork(value = 1, jvmArgsAppend = {"--enable-preview"})
>>
>> Suggestion:
>>
Still relevant to address? /cc @PaulSandoz
-
Commit messages:
- JDK-8151531: Add notes to BaseStream.spliterator/iterator docs regarding
them being escape hatches
Changes: https://git.openjdk.org/jdk/pull/13890/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=13890=00
Issue:
On Tue, 9 May 2023 15:50:30 GMT, Claes Redestad wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed StackMapGenerator
>
> test/micro/org/openjdk/bench/jdk/classfile/RebuildMethodBodies.java line 42:
>
>> 40:
On Tue, 9 May 2023 12:58:27 GMT, Jim Laskey wrote:
>> Enhance the Java programming language with string templates, which are
>> similar to string literals but contain embedded expressions. A string
>> template is interpreted at run time by replacing each expression with the
>> result of
> Following improvements implemented:
> - Switch over `String` replaced with switch single char
> - Binary search for frames in `StackMapGenerator`
> - `StackMapGenerator.rawHandlers` with pre-calculated offsets
> - `ClassEntry` is caching `ClassDesc` symbol
> - Caching of type symbols in
> Following improvements implemented:
> - Switch over `String` replaced with switch single char
> - Binary search for frames in `StackMapGenerator`
> - `StackMapGenerator.rawHandlers` with pre-calculated offsets
> - `ClassEntry` is caching `ClassDesc` symbol
> - Caching of type symbols in
On Mon, 8 May 2023 10:32:48 GMT, Viktor Klang wrote:
> Attempting to make the "at-most once" nature, of invoking the supplied action
> to tryAdvance, clearer in the JavaDoc.
This pull request has now been integrated.
Changeset: fdbfc8a7
Author:Viktor Klang
Committer: Roger Riggs
URL:
On Wed, 19 Apr 2023 14:31:36 GMT, Chen Liang wrote:
> Spotted the typo for BootstrapMethods, and another review over the API
> exposed the typo on PermittedSubclasses.
Withdrawing this patch in favor of removing `validSince` completely in another
patch.
-
PR Comment:
On Wed, 19 Apr 2023 14:31:36 GMT, Chen Liang wrote:
> Spotted the typo for BootstrapMethods, and another review over the API
> exposed the typo on PermittedSubclasses.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/13536
On Tue, 9 May 2023 15:09:54 GMT, Chen Liang wrote:
>> Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with
>> proper privileges, with tests.
>>
>> This addition is useful in case classes at runtime are not loaded from the
>> system class loader, such as Proxy. This is
On Wed, 26 Apr 2023 15:04:50 GMT, Adam Sotona wrote:
> Following improvements implemented:
> - Switch over `String` replaced with switch single char
> - Binary search for frames in `StackMapGenerator`
> - `StackMapGenerator.rawHandlers` with pre-calculated offsets
> - `ClassEntry` is caching
On Tue, 9 May 2023 14:22:39 GMT, Roger Riggs wrote:
>> @RogerRiggs "the" instead of "a" gives me the impression that the
>> Spliterator only has a single element left. The choice of colon instead of a
>> comma is because "If a remaining element exists" introduces a list of 2
>> elements (and
On Wed, 26 Apr 2023 09:47:58 GMT, Adam Sotona wrote:
> > @asotona Just curious, what's the current state of our new API model of
> > caching class hierarchy info in a Classfile context object as we've
> > discussed on the mailing list? Will you create a patch, or should I update
> > this
> javap uses proprietary com.sun.tools.classfile library to parse class files.
>
> This patch converts javap to use Classfile API.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains
> Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with
> proper privileges, with tests.
>
> This addition is useful in case classes at runtime are not loaded from the
> system class loader, such as Proxy. This is also useful to APIs that generate
> bytecode with a
> The ProcessTools has some support of jtreg thread factory functionality.
> It tries to run the new process using virtual thread to run `main()` method.
> This fix updates it to skip the java runs where no main class is involved and
> more correctly process options which has 2nd argument.
> Also
On Tue, 9 May 2023 09:21:08 GMT, Viktor Klang wrote:
>> src/java.base/share/classes/java/util/Spliterator.java line 298:
>>
>>> 296: public interface Spliterator {
>>> 297: /**
>>> 298: * If a remaining element exists: performs the given action on it,
>>
>> I'm not sure the ":" is an
On Mon, 8 May 2023 19:07:17 GMT, Viktor Klang wrote:
>> Attempting to make the "at-most once" nature, of invoking the supplied
>> action to tryAdvance, clearer in the JavaDoc.
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Wed, 26 Apr 2023 15:04:50 GMT, Adam Sotona wrote:
> Following improvements implemented:
> - Switch over `String` replaced with switch single char
> - Binary search for frames in `StackMapGenerator`
> - `StackMapGenerator.rawHandlers` with pre-calculated offsets
> - `ClassEntry` is caching
On Wed, 26 Apr 2023 15:04:50 GMT, Adam Sotona wrote:
> Following improvements implemented:
> - Switch over `String` replaced with switch single char
> - Binary search for frames in `StackMapGenerator`
> - `StackMapGenerator.rawHandlers` with pre-calculated offsets
> - `ClassEntry` is caching
On Wed, 26 Apr 2023 15:04:50 GMT, Adam Sotona wrote:
> Following improvements implemented:
> - Switch over `String` replaced with switch single char
> - Binary search for frames in `StackMapGenerator`
> - `StackMapGenerator.rawHandlers` with pre-calculated offsets
> - `ClassEntry` is caching
Following improvements implemented:
- Switch over `String` replaced with switch single char
- Binary search for frames in `StackMapGenerator`
- `StackMapGenerator.rawHandlers` with pre-calculated offsets
- `ClassEntry` is caching `ClassDesc` symbol
- Caching of type symbols in `NameAndTypeEntry`
On Wed, 26 Apr 2023 16:00:07 GMT, Chen Liang wrote:
> 1. CodeBuilder.invokeInstruction and CodeBuilder.fieldInstruction can pass
> their symbols to the NameAndTypeEntry as well, since it's almost always going
> to be used by stack map generation later.
Yes, they actually do. CodeBuilder
On Tue, 9 May 2023 09:03:09 GMT, Mandy Chung wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Correct Platform.is64Bit() to report address size of the architecture
>> enum, not the running system
>
>
On Tue, 9 May 2023 11:16:32 GMT, Glavo wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Correct Platform.is64Bit() to report address size of the architecture
>> enum, not the running system
>
>
> Refactor the Platform class of jlink to use jdk.internal.util OperatingSystem
> and Architecture instead of os.name and os.arch.
> They are direct replacements for the Platform enums except for UNKNOWN; its
> use is refactored to report errors via exceptions.
>
> Neither os.name nor os.arch
On Tue, 9 May 2023 13:20:28 GMT, Aleksei Efimov wrote:
>> JNDI `DnsClient` has a finalize method to close its internal datagram
>> channel selector.
>> The change proposed here replaces it with a cleaner to close the selector
>> once the `DnsClient`
>> instance becomes phantom reachable.
On Tue, 9 May 2023 13:20:28 GMT, Aleksei Efimov wrote:
>> JNDI `DnsClient` has a finalize method to close its internal datagram
>> channel selector.
>> The change proposed here replaces it with a cleaner to close the selector
>> once the `DnsClient`
>> instance becomes phantom reachable.
> JNDI `DnsClient` has a finalize method to close its internal datagram channel
> selector.
> The change proposed here replaces it with a cleaner to close the selector
> once the `DnsClient`
> instance becomes phantom reachable.
>
> The change was tested with `jdk-tier1` to `jdk-tier3` test
On Fri, 14 Apr 2023 14:02:46 GMT, Adam Sotona wrote:
> Classfile API didn't handle transformations of class files version 50 and
> below correctly.
>
> Proposed fix have two parts:
> 1. Inflation of branch targets does not depend on StackMapTable attribute
> presence for class file version
> Classfile API didn't handle transformations of class files version 50 and
> below correctly.
>
> Proposed fix have two parts:
> 1. Inflation of branch targets does not depend on StackMapTable attribute
> presence for class file version 50 and below. Alternative fallback
> implementation is
> Enhance the Java programming language with string templates, which are
> similar to string literals but contain embedded expressions. A string
> template is interpreted at run time by replacing each expression with the
> result of evaluating that expression, possibly after further validation
> Enhance the Java programming language with string templates, which are
> similar to string literals but contain embedded expressions. A string
> template is interpreted at run time by replacing each expression with the
> result of evaluating that expression, possibly after further validation
On Tue, 9 May 2023 11:59:08 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 16 additional
>>
On Tue, 9 May 2023 11:11:36 GMT, Adam Sotona wrote:
>> Classfile API didn't handle transformations of class files version 50 and
>> below correctly.
>>
>> Proposed fix have two parts:
>> 1. Inflation of branch targets does not depend on StackMapTable attribute
>> presence for class file
On Tue, 9 May 2023 11:11:36 GMT, Adam Sotona wrote:
>> Classfile API didn't handle transformations of class files version 50 and
>> below correctly.
>>
>> Proposed fix have two parts:
>> 1. Inflation of branch targets does not depend on StackMapTable attribute
>> presence for class file
On Tue, 9 May 2023 11:11:36 GMT, Adam Sotona wrote:
>> Classfile API didn't handle transformations of class files version 50 and
>> below correctly.
>>
>> Proposed fix have two parts:
>> 1. Inflation of branch targets does not depend on StackMapTable attribute
>> presence for class file
On Mon, 8 May 2023 13:46:55 GMT, Maurizio Cimadamore
wrote:
> This is a tricky intermittent failure on one of our async file channel test.
>
> While the logic of the test is a bit hard to follow, I believe the test is
> supposed to work as follows:
>
> * in the main thread, we submit an
On Mon, 8 May 2023 14:53:41 GMT, Roger Riggs wrote:
>> Refactor the Platform class of jlink to use jdk.internal.util
>> OperatingSystem and Architecture instead of os.name and os.arch.
>> They are direct replacements for the Platform enums except for UNKNOWN; its
>> use is refactored to
On Mon, 8 May 2023 16:10:37 GMT, Maurizio Cimadamore
wrote:
> This is a port of: https://git.openjdk.org/panama-foreign/pull/830
This pull request has now been integrated.
Changeset: 7a3bea1f
Author:Maurizio Cimadamore
URL:
> Classfile API didn't handle transformations of class files version 50 and
> below correctly.
>
> Proposed fix have two parts:
> 1. Inflation of branch targets does not depend on StackMapTable attribute
> presence for class file version 50 and below. Alternative fallback
> implementation is
On Mon, 13 Mar 2023 08:13:44 GMT, Chen Liang wrote:
> Without this patch, the Classfile API tries to encode PrimitiveClassDesc as
> CONSTANT_Class_info and error in `toInternalName`.
This pull request has now been integrated.
Changeset: cd5d0ff5
Author:Chen Liang
Committer: Adam Sotona
On Mon, 8 May 2023 21:00:32 GMT, Roger Riggs wrote:
>> Viktor Klang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update src/java.base/share/classes/java/util/Spliterator.java
>>
>> Co-authored-by: Paul Sandoz
>
>
On Mon, 8 May 2023 14:53:41 GMT, Roger Riggs wrote:
>> Refactor the Platform class of jlink to use jdk.internal.util
>> OperatingSystem and Architecture instead of os.name and os.arch.
>> They are direct replacements for the Platform enums except for UNKNOWN; its
>> use is refactored to
On Mon, 8 May 2023 13:14:34 GMT, Sean Coffey wrote:
> minor enhancement to have -XshowSettings launcher option display the version
> of tzdata installed in the JDK
>
> example output of the new tzdata info :
>
>
>
> Locale settings:
> default locale = English
> default display
84 matches
Mail list logo
